)]}'
{"id":"openstack%2Fglance-tempest-plugin~807366","triplet_id":"openstack%2Fglance-tempest-plugin~master~I01e0db7f0d79f072211ee63ea48a6558d008d285","project":"openstack/glance-tempest-plugin","branch":"master","hashtags":[],"change_id":"I01e0db7f0d79f072211ee63ea48a6558d008d285","subject":"Fix glance tempest plugin test to use the right tempest variables","status":"MERGED","created":"2021-09-03 17:02:15.000000000","updated":"2021-09-03 19:26:52.000000000","submitted":"2021-09-03 19:26:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"807366","meta_rev_id":"355eba968ae653730d98614f46bf92cee4c4bac9","_number":807366,"virtual_id_number":807366,"owner":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-03 19:26:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":2,"date":"2021-09-03 18:20:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2021-09-03 18:39:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2021-09-03 18:12:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":1,"date":"2021-09-03 18:39:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-03 17:04:50.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"CC"},{"updated":"2021-09-03 17:04:50.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2021-09-03 17:55:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-03 18:20:25.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2021-09-03 18:39:37.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"}],"messages":[{"id":"a6eabf16fc636f8a1dd34c61d31d534097200780","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-09-03 17:02:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8566b8be2f13b7a186cf6ae58ebdfda4b555d012","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-09-03 17:04:50.000000000","message":"Patch Set 1:\n\nI\u0027m confused/surprised that this moved from image-based grouping to scope-based with project names?","accounts_in_message":[],"_revision_number":1},{"id":"37db9ca2829ef0e3dd3db1e9f6d5a7820a07f5f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-09-03 17:21:00.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"afce7379e1d0c7c6bc495d5365b44e8728e01c17","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-03 17:55:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/38a761ebe02444bd9e98fe7ec680fdf2 : SUCCESS in 4m 00s\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/0394d0abd0d648888a6f59a9316f0806 : SUCCESS in 33m 07s (non-voting)\n- glance-legacy-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/731a28a9d27b40f8bc53b17119e0da57 : SUCCESS in 29m 30s","accounts_in_message":[],"_revision_number":2},{"id":"bba403b7a8f03d5fd195e969b720d936e99dae0d","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-09-03 18:05:08.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 1:\n\u003e \n\u003e I\u0027m confused/surprised that this moved from image-based grouping to scope-based with project names?\n\nIdea was to make enforce_scope configuration consistence and can be used in tempest in-tree glance test as well in glance plugin.","accounts_in_message":[],"_revision_number":2},{"id":"61ed6404170913878f7e9ede8288f3e34f1e97e6","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-09-03 18:05:43.000000000","message":"Patch Set 2:\n\ncan we remove or mark deprecation for removal this config https://github.com/openstack/glance-tempest-plugin/blob/master/glance_tempest_plugin/config.py\n\nThings went in parallel and end up having two config option one in tempest and one this","accounts_in_message":[],"_revision_number":2},{"id":"a64fa3005319054e03df337f9226d87449379525","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-09-03 18:12:27.000000000","message":"Patch Set 2: Code-Review+1\n\nbtw, this fix lgtm and config option can be removed/deprecated in separate one.","accounts_in_message":[],"_revision_number":2},{"id":"b546028111924b4bc87a8b5e2ee3a821957c22ed","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-09-03 18:20:25.000000000","message":"Patch Set 2: Code-Review+2\n\nSounds good to remove config option in a separate patch.","accounts_in_message":[],"_revision_number":2},{"id":"7a9194fafdcfd015f0809e3bed48b34d337e9928","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-09-03 18:39:37.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"382f169cd858ba8fc0b636484bce920bd9c717ee","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-03 18:40:02.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a5472e165cb5c811f03d43172c4e7b7e5d8f525d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-03 19:26:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0ab5c1e382c4406f980ca848159e1907 : SUCCESS in 3m 57s\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/d300428ba43f4f4c99870c8e1a26dec8 : SUCCESS in 37m 46s (non-voting)\n- glance-legacy-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/62674f6249094b088515a0808dcc9cff : SUCCESS in 38m 09s","accounts_in_message":[],"_revision_number":2},{"id":"355eba968ae653730d98614f46bf92cee4c4bac9","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-03 19:26:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"afb867b2ac355d3554a1da2ed826b85aef44d542","revisions":{"efcf65edfe43da84a28a951fd6fcb906570fc440":{"kind":"REWORK","_number":1,"created":"2021-09-03 17:02:15.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/66/807366/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance-tempest-plugin","ref":"refs/changes/66/807366/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance-tempest-plugin refs/changes/66/807366/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance-tempest-plugin refs/changes/66/807366/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance-tempest-plugin refs/changes/66/807366/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance-tempest-plugin refs/changes/66/807366/1"}}},"commit":{"parents":[{"commit":"fcc879217673ac55e409d2b6644077ddb895209e","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance-tempest-plugin/commit/fcc879217673ac55e409d2b6644077ddb895209e"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-09-03 17:00:36.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-09-03 17:00:36.000000000","tz":0},"subject":"Fix glance tempest plugin test to use the right tempest variables","message":"Fix glance tempest plugin test to use the right tempest variables\n\nA set of changes moved the glance specific bits to use the tempest\nconfiguration option for detecting if the secure RBAC tests should be\nrun. But, we didn\u0027t update the tests themselves to use the new option,\ncausing the tests to be skipped without our knowledge.\n\nThis commit updates the tests to use the new option and gets them\nrunning again.\n\nhttps: //review.opendev.org/c/openstack/glance/+/778952\nhttps: //review.opendev.org/c/openstack/devstack/+/778945\nChange-Id: I01e0db7f0d79f072211ee63ea48a6558d008d285\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance-tempest-plugin/commit/efcf65edfe43da84a28a951fd6fcb906570fc440"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance-tempest-plugin/commit/efcf65edfe43da84a28a951fd6fcb906570fc440"}]},"branch":"refs/heads/master"},"afb867b2ac355d3554a1da2ed826b85aef44d542":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-09-03 17:21:00.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/66/807366/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance-tempest-plugin","ref":"refs/changes/66/807366/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance-tempest-plugin refs/changes/66/807366/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance-tempest-plugin refs/changes/66/807366/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance-tempest-plugin refs/changes/66/807366/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance-tempest-plugin refs/changes/66/807366/2"}}},"commit":{"parents":[{"commit":"fcc879217673ac55e409d2b6644077ddb895209e","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance-tempest-plugin/commit/fcc879217673ac55e409d2b6644077ddb895209e"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-09-03 17:00:36.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-09-03 17:20:15.000000000","tz":0},"subject":"Fix glance tempest plugin test to use the right tempest variables","message":"Fix glance tempest plugin test to use the right tempest variables\n\nA set of changes moved the glance specific bits to use the tempest\nconfiguration option for detecting if the secure RBAC tests should be\nrun [0][1]. But, we didn\u0027t update the tests themselves to use the new option,\ncausing the tests to be skipped without our knowledge.\n\nThis commit updates the tests to use the new option and gets them\nrunning again.\n\n[0] https://review.opendev.org/c/openstack/glance/+/778952\n[1] https://review.opendev.org/c/openstack/devstack/+/778945\n\nChange-Id: I01e0db7f0d79f072211ee63ea48a6558d008d285\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance-tempest-plugin/commit/afb867b2ac355d3554a1da2ed826b85aef44d542"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance-tempest-plugin/commit/afb867b2ac355d3554a1da2ed826b85aef44d542"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}