)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"89025b631f32492b604659f4d35ba32fe4230927","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Pranali Deore \u003cpdeore@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-20 13:43:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Verify new manager persona supported for image apis"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the introduction of the base capability has been extended"},{"line_number":10,"context_line":"as a result of an OpenStack community goal to include a ``manager``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df687f12_a5bafb44","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"updated":"2021-12-20 14:17:51.000000000","message":"Add tests to support new manager role","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"08c10a6615df2fbaa6ce65ae33060652c130af2e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pranali Deore \u003cpdeore@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-20 13:43:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Verify new manager persona supported for image apis"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the introduction of the base capability has been extended"},{"line_number":10,"context_line":"as a result of an OpenStack community goal to include a ``manager``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"96435cd5_fc2925b2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"in_reply_to":"df687f12_a5bafb44","updated":"2021-12-21 10:45:25.000000000","message":"Done","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"89025b631f32492b604659f4d35ba32fe4230927","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Verify new manager persona supported for image apis"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the introduction of the base capability has been extended"},{"line_number":10,"context_line":"as a result of an OpenStack community goal to include a ``manager``"},{"line_number":11,"context_line":"role in the project scope."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit verifies whether all the image APIs tempest tests"},{"line_number":14,"context_line":"which are under ``member`` role are supported with \u0027manager\u0027"},{"line_number":15,"context_line":"role or not."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: Ida889aa30d462443b801c0f524c51f54b8b756d5"},{"line_number":18,"context_line":"Depends-On: I29a14118126efd3bfb168b25df36911433cad2d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6403c8a1_04cc7db4","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":12},"updated":"2021-12-20 14:17:51.000000000","message":"Refer the community goal specs which specifies inclusion of manager role.\n\nThe commit message should be;\n\nDuring Yoga PTG community has decided to add one more `manager` role/persona [1] which will have more privileges than `member` role and less than `admin` role.\n\nThis commit verifies that glance APIs support newly introduced `manager` role/persona.\n\n[1] Reference to community goal","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"08c10a6615df2fbaa6ce65ae33060652c130af2e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Verify new manager persona supported for image apis"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the introduction of the base capability has been extended"},{"line_number":10,"context_line":"as a result of an OpenStack community goal to include a ``manager``"},{"line_number":11,"context_line":"role in the project scope."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit verifies whether all the image APIs tempest tests"},{"line_number":14,"context_line":"which are under ``member`` role are supported with \u0027manager\u0027"},{"line_number":15,"context_line":"role or not."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: Ida889aa30d462443b801c0f524c51f54b8b756d5"},{"line_number":18,"context_line":"Depends-On: I29a14118126efd3bfb168b25df36911433cad2d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"846c3cdf_902ac1e1","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":12},"in_reply_to":"6403c8a1_04cc7db4","updated":"2021-12-21 10:45:25.000000000","message":"Done","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6f55adb412d4378e1bac8ad4e6da46987f40443b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"which are under ``member`` role are supported with \u0027manager\u0027"},{"line_number":15,"context_line":"role or not."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: Ida889aa30d462443b801c0f524c51f54b8b756d5"},{"line_number":18,"context_line":"Depends-On: I29a14118126efd3bfb168b25df36911433cad2d9"},{"line_number":19,"context_line":"Change-Id: I451e21795c79815d791530b70a3c4936f373be33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ce2d8de4_1ad657a1","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":53},"updated":"2021-12-20 14:19:18.000000000","message":"No need to add spec as depends-on, instead you can refer it in commit message as stated above.","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"08c10a6615df2fbaa6ce65ae33060652c130af2e","unresolved":true,"context_lines":[{"line_number":14,"context_line":"which are under ``member`` role are supported with \u0027manager\u0027"},{"line_number":15,"context_line":"role or not."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: Ida889aa30d462443b801c0f524c51f54b8b756d5"},{"line_number":18,"context_line":"Depends-On: I29a14118126efd3bfb168b25df36911433cad2d9"},{"line_number":19,"context_line":"Change-Id: I451e21795c79815d791530b70a3c4936f373be33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"05d70a7b_25e24e5e","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":53},"in_reply_to":"ce2d8de4_1ad657a1","updated":"2021-12-21 10:45:25.000000000","message":"oops sorry, I wanted to add the devstack change as depend-on here.","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"89025b631f32492b604659f4d35ba32fe4230927","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d63e7d5_fe06fdee","updated":"2021-12-20 14:17:51.000000000","message":"We also need to verify metadef APIs with manager role.","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"b49751ff10ffb1bf1d2a70a41f34df0ed9162826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b96269fa_6eba439c","updated":"2022-05-05 19:14:22.000000000","message":"Maybe it will be better to consider merging this one before .\nhttps://review.opendev.org/c/openstack/glance-tempest-plugin/+/839605","commit_id":"614d6bf88afe6e70853ec8b28fc7baffa7dd5556"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"30933e1e567340b85f0300c25181944b3d0d244b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"62403313_e3d29d8f","updated":"2022-04-28 06:15:53.000000000","message":"is it possible for you to rebase your patch on top of this and follow the structure?\nhttps://review.opendev.org/c/openstack/glance-tempest-plugin/+/839605\n\nIf not I think you can separate out image tests and add depends on this patch and create similar structure for metadef tests.","commit_id":"614d6bf88afe6e70853ec8b28fc7baffa7dd5556"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"4fa893ba2702bd409576b41fa23e71dfa13e5da3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f5942561_1aba32ca","updated":"2025-04-03 14:06:29.000000000","message":"I find it a bit weird that reader tests inherit from member tests that inherit from manager tests. Shouldn\u0027t all 3 of them inherit from some kind of base class?","commit_id":"6bb9172c64ecba2140acdebe5475946fa3619411"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"4d855ed3b44292501d62dab0e148a55e6856364c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a466ad4_ce33dc38","in_reply_to":"f5942561_1aba32ca","updated":"2025-04-07 10:13:39.000000000","message":"Yes.\nI think we need to create here parent base class to inherit from","commit_id":"6bb9172c64ecba2140acdebe5475946fa3619411"}],"glance_tempest_plugin/tests/rbac/v2/test_images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"89025b631f32492b604659f4d35ba32fe4230927","unresolved":true,"context_lines":[{"line_number":1583,"context_line":"class ProjectMemberTests(ProjectManagerTests, ImageV2RbacImageTest,"},{"line_number":1584,"context_line":"                         ImageV2RbacTemplate):"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027, \u0027system_admin\u0027,"},{"line_number":1587,"context_line":"                   \u0027project_alt_admin\u0027]"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"10ac8655_b39e5d21","line":1586,"updated":"2021-12-20 14:17:51.000000000","message":"This should include project_manager as well, right?","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"08c10a6615df2fbaa6ce65ae33060652c130af2e","unresolved":true,"context_lines":[{"line_number":1583,"context_line":"class ProjectMemberTests(ProjectManagerTests, ImageV2RbacImageTest,"},{"line_number":1584,"context_line":"                         ImageV2RbacTemplate):"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027, \u0027system_admin\u0027,"},{"line_number":1587,"context_line":"                   \u0027project_alt_admin\u0027]"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6da57131_d4b79414","line":1586,"in_reply_to":"10ac8655_b39e5d21","updated":"2021-12-21 10:45:25.000000000","message":"ohh yes right, I missed it.","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"89025b631f32492b604659f4d35ba32fe4230927","unresolved":true,"context_lines":[{"line_number":1589,"context_line":""},{"line_number":1590,"context_line":"class ProjectReaderTests(ProjectMemberTests):"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027, \u0027system_admin\u0027,"},{"line_number":1593,"context_line":"                   \u0027project_alt_admin\u0027]"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"    def test_create_image(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1d339f4_4cdb47a7","line":1592,"updated":"2021-12-20 14:17:51.000000000","message":"ditto?","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"08c10a6615df2fbaa6ce65ae33060652c130af2e","unresolved":false,"context_lines":[{"line_number":1589,"context_line":""},{"line_number":1590,"context_line":"class ProjectReaderTests(ProjectMemberTests):"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027, \u0027system_admin\u0027,"},{"line_number":1593,"context_line":"                   \u0027project_alt_admin\u0027]"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"    def test_create_image(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4371e77a_91d8fd45","line":1592,"in_reply_to":"c1d339f4_4cdb47a7","updated":"2021-12-21 10:45:25.000000000","message":"Ack","commit_id":"50506e3b7d8734647a05af29ad6c70b2b60e197d"}]}