)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aef3d7091c4c66fc437f604f65897e4fa4a6922b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove system_admin from tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since there is no system admin and system scope in SRBAC, removing"},{"line_number":10,"context_line":"related checks from the tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I95c5a8dae2b0970752dbc1db398d25485d942312"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"62f1b098_e1a12e3d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"updated":"2023-03-01 19:11:38.000000000","message":"we can still use system token for negative tests assert to make sure it does not have access to the things. \n\nAlso, key thing you are fixing here is to use the different project member to get the image created by another project. It will be good to mention that in commit message.","commit_id":"78ed9a67756cbea98e0268f4ccf61073a6c74f8f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aef3d7091c4c66fc437f604f65897e4fa4a6922b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee492cc9_d2bba6bc","updated":"2023-03-01 19:11:38.000000000","message":"I have few suggestion inline, though current code fixes the issue but we have better way to do that. If it is urgent to merge to unblock the gate I can +1 this and can propose the changes I am suggesting in followup. ","commit_id":"78ed9a67756cbea98e0268f4ccf61073a6c74f8f"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"12d05e069b0930f572857403d0c3f68c3cb3bb06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8aff2800_95291657","in_reply_to":"ee492cc9_d2bba6bc","updated":"2023-03-02 05:48:05.000000000","message":"I think it would be better to go ahead and merge this change to unblock the gate and have the suggested changes in followup patch.","commit_id":"78ed9a67756cbea98e0268f4ccf61073a6c74f8f"}],"glance_tempest_plugin/tests/rbac/v2/test_project_admin_tests.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aef3d7091c4c66fc437f604f65897e4fa4a6922b","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        image \u003d self.do_request(\u0027create_image\u0027, expected_status\u003d201,"},{"line_number":45,"context_line":"                                **self.image(visibility\u003d\u0027public\u0027))"},{"line_number":46,"context_line":"        self.addCleanup(self.admin_images_client.delete_image, image[\u0027id\u0027])"},{"line_number":47,"context_line":"        # Check that system user is not permitted to create image."},{"line_number":48,"context_line":"        self.do_request(\u0027create_image\u0027, expected_status\u003dexceptions.Forbidden,"},{"line_number":49,"context_line":"                        client\u003dself.os_system_admin.image_client_v2,"},{"line_number":50,"context_line":"                        **self.image(visibility\u003d\u0027public\u0027))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002761fd8b5e-8a0b-46ca-91c4-6c2c2d35039d\u0027)"},{"line_number":53,"context_line":"    def test_get_image(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6874d8d0_d8e3ba98","side":"PARENT","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":58},"updated":"2023-03-01 19:11:38.000000000","message":"I think this is good assert here. we can keep it. and all the below one too.","commit_id":"701b74b15459c0f4c229a92d834697ba527c4ed8"}],"glance_tempest_plugin/tests/rbac/v2/test_project_members_tests.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aef3d7091c4c66fc437f604f65897e4fa4a6922b","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self.addCleanup(self.admin_images_client.delete_image, image[\u0027id\u0027])"},{"line_number":73,"context_line":"        self.do_request(\u0027show_image\u0027, expected_status\u003dexceptions.NotFound,"},{"line_number":74,"context_line":"                        image_id\u003dimage[\u0027id\u0027],"},{"line_number":75,"context_line":"                        client\u003dself.setup_user_client().image_client_v2)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        image \u003d project_client.image_client_v2.create_image("},{"line_number":78,"context_line":"            **self.image(visibility\u003d\u0027shared\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"a39ac87f_dc10ef83","line":75,"range":{"start_line":75,"start_character":23,"end_line":75,"end_character":71},"updated":"2023-03-01 19:11:38.000000000","message":"this was the reason of failure. so with that Tempest change (871018) project_admin, project_member and project_reader will have the same project id[1] and that is why project_member was able to see the image created by project_admin.\n\nIt fixes the issue but instead of creating the new project at runtime by setup_user_client() we can check project_alt_reader is not able to GET it.\n\n[1] https://docs.openstack.org/tempest/latest/keystone_scopes_and_roles_support.html#project-scoped-personas","commit_id":"78ed9a67756cbea98e0268f4ccf61073a6c74f8f"}]}