)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37535,"name":"Florent Le Lain","display_name":"flelain","email":"florent.le-lain@ovhcloud.com","username":"flelain"},"change_message_id":"571151450dffd3d41b052204f1a3cc2939c09b56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a978e15d_c720b8cc","updated":"2026-11-18 09:14:06.000000000","message":"Thanks 🙂","commit_id":"89595ad674d09c213ec207bf577536402ef5152e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cf5b28eb488aee833adc490f31d1aba5fb06fdae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c6128ac_9c8596d0","updated":"2026-11-18 07:07:38.000000000","message":"We have couple of days to get this merged and release. Could you please post new PS if possible?","commit_id":"89595ad674d09c213ec207bf577536402ef5152e"}],"glance_store/_drivers/s3.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"23fe2319b7e6c5bded6ee28b7bdc44ebfba66784","unresolved":false,"context_lines":[{"line_number":746,"context_line":"                 s3_store_temp_url_enabled is False"},{"line_number":747,"context_line":"        \"\"\""},{"line_number":748,"context_line":"        loc \u003d location.store_location"},{"line_number":749,"context_line":"        # NOTE(mklejn): Without a region, botocore would presign with deprecated"},{"line_number":750,"context_line":"        # SigV2. That\u0027s true for at least 1.35.99 and 1.36.0"},{"line_number":751,"context_line":"        s3_client \u003d self._create_s3_client(signature_version\u003d\u0027s3v4\u0027)"},{"line_number":752,"context_line":"        bucket, key \u003d loc.bucket, loc.key"}],"source_content_type":"text/x-python","patch_set":1,"id":"25416dbe_b2b24104","line":749,"updated":"2026-11-10 19:12:43.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"dbf608df3ba509940341e10afd62fcf729c1c822"},{"author":{"_account_id":37535,"name":"Florent Le Lain","display_name":"flelain","email":"florent.le-lain@ovhcloud.com","username":"flelain"},"change_message_id":"0dc19110edf84038b936ba70c13df63ca1b19111","unresolved":true,"context_lines":[{"line_number":748,"context_line":"        loc \u003d location.store_location"},{"line_number":749,"context_line":"        # NOTE(mklejn): Without a region, botocore would presign with"},{"line_number":750,"context_line":"        # deprecated SigV2. That\u0027s true for at least 1.35.99 and 1.36.0"},{"line_number":751,"context_line":"        s3_client \u003d self._create_s3_client(signature_version\u003d\u0027s3v4\u0027)"},{"line_number":752,"context_line":"        bucket, key \u003d loc.bucket, loc.key"},{"line_number":753,"context_line":"        expires_at \u003d timeutils.utcnow(with_timezone\u003dTrue).replace("},{"line_number":754,"context_line":"            microsecond\u003d0) + datetime.timedelta(seconds\u003dself.temp_url_expiry)"}],"source_content_type":"text/x-python","patch_set":2,"id":"31b4333d_713ea72f","line":751,"updated":"2026-11-16 15:49:44.000000000","message":"May worth it caching 1 presign client per store - instead of creating a new client on any new calls (Claude/Opus5.5 estimates a gain of tens of ms).","commit_id":"89595ad674d09c213ec207bf577536402ef5152e"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"ea11cf959b209eb2f1943ab093476228839a5d38","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        loc \u003d location.store_location"},{"line_number":749,"context_line":"        # NOTE(mklejn): Without a region, botocore would presign with"},{"line_number":750,"context_line":"        # deprecated SigV2. That\u0027s true for at least 1.35.99 and 1.36.0"},{"line_number":751,"context_line":"        s3_client \u003d self._create_s3_client(signature_version\u003d\u0027s3v4\u0027)"},{"line_number":752,"context_line":"        bucket, key \u003d loc.bucket, loc.key"},{"line_number":753,"context_line":"        expires_at \u003d timeutils.utcnow(with_timezone\u003dTrue).replace("},{"line_number":754,"context_line":"            microsecond\u003d0) + datetime.timedelta(seconds\u003dself.temp_url_expiry)"}],"source_content_type":"text/x-python","patch_set":2,"id":"99a2c543_f3c48899","line":751,"in_reply_to":"31b4333d_713ea72f","updated":"2026-11-16 16:00:14.000000000","message":"perhaps, but it\u0027s out of scope. topic was already discussed in PTG and it\u0027s a separate piece of work\n\nhttps://etherpad.opendev.org/p/oct2026-ptg-glance\nhttps://etherpad.opendev.org/p/store-connection-session-reuse","commit_id":"89595ad674d09c213ec207bf577536402ef5152e"},{"author":{"_account_id":37535,"name":"Florent Le Lain","display_name":"flelain","email":"florent.le-lain@ovhcloud.com","username":"flelain"},"change_message_id":"571151450dffd3d41b052204f1a3cc2939c09b56","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        loc \u003d location.store_location"},{"line_number":749,"context_line":"        # NOTE(mklejn): Without a region, botocore would presign with"},{"line_number":750,"context_line":"        # deprecated SigV2. That\u0027s true for at least 1.35.99 and 1.36.0"},{"line_number":751,"context_line":"        s3_client \u003d self._create_s3_client(signature_version\u003d\u0027s3v4\u0027)"},{"line_number":752,"context_line":"        bucket, key \u003d loc.bucket, loc.key"},{"line_number":753,"context_line":"        expires_at \u003d timeutils.utcnow(with_timezone\u003dTrue).replace("},{"line_number":754,"context_line":"            microsecond\u003d0) + datetime.timedelta(seconds\u003dself.temp_url_expiry)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e39fad72_8c90c440","line":751,"in_reply_to":"99a2c543_f3c48899","updated":"2026-11-18 09:14:06.000000000","message":"Sounds good","commit_id":"89595ad674d09c213ec207bf577536402ef5152e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0528aae1847779e0ce86fcf83bb67fb1fbff408f","unresolved":true,"context_lines":[{"line_number":752,"context_line":"        bucket, key \u003d loc.bucket, loc.key"},{"line_number":753,"context_line":"        expires_at \u003d timeutils.utcnow(with_timezone\u003dTrue).replace("},{"line_number":754,"context_line":"            microsecond\u003d0) + datetime.timedelta(seconds\u003dself.temp_url_expiry)"},{"line_number":755,"context_line":"        url \u003d s3_client.generate_presigned_url("},{"line_number":756,"context_line":"            \u0027get_object\u0027, Params\u003d{\u0027Bucket\u0027: bucket, \u0027Key\u0027: key},"},{"line_number":757,"context_line":"            ExpiresIn\u003dself.temp_url_expiry, HttpMethod\u003d\u0027GET\u0027)"},{"line_number":758,"context_line":"        return url, expires_at"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    @capabilities.check"}],"source_content_type":"text/x-python","patch_set":2,"id":"854a52f8_f7e985d6","line":757,"range":{"start_line":755,"start_character":8,"end_line":757,"end_character":61},"updated":"2026-11-16 09:40:32.000000000","message":"This triggers botocore logging of the canonical request and final signature. With ordinary debug\u003dTrue, anyone with those logs and access to the storage endpoint could reuse the URL until expiry.\n\nEither we should document to use botocore.auth\u003dWARN in glance config for default_log_levels or else use filter to suppress sensitive signing DEBUG records during URL generation.","commit_id":"89595ad674d09c213ec207bf577536402ef5152e"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"e0da253ac98d91a912f69f4dc52a6f8eb19ffd20","unresolved":true,"context_lines":[{"line_number":752,"context_line":"        bucket, key \u003d loc.bucket, loc.key"},{"line_number":753,"context_line":"        expires_at \u003d timeutils.utcnow(with_timezone\u003dTrue).replace("},{"line_number":754,"context_line":"            microsecond\u003d0) + datetime.timedelta(seconds\u003dself.temp_url_expiry)"},{"line_number":755,"context_line":"        url \u003d s3_client.generate_presigned_url("},{"line_number":756,"context_line":"            \u0027get_object\u0027, Params\u003d{\u0027Bucket\u0027: bucket, \u0027Key\u0027: key},"},{"line_number":757,"context_line":"            ExpiresIn\u003dself.temp_url_expiry, HttpMethod\u003d\u0027GET\u0027)"},{"line_number":758,"context_line":"        return url, expires_at"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    @capabilities.check"}],"source_content_type":"text/x-python","patch_set":2,"id":"71e41573_788eead0","line":757,"range":{"start_line":755,"start_character":8,"end_line":757,"end_character":61},"in_reply_to":"854a52f8_f7e985d6","updated":"2026-11-16 10:22:38.000000000","message":"it\u0027s at least botocore.auth and urllib3.connectionpool. I\u0027ll set everything to debug in my dev and see what else pops up. Filter sounds better to me as it\u0027s not limiting debug capabilities of operators","commit_id":"89595ad674d09c213ec207bf577536402ef5152e"}],"glance_store/tests/unit/test_s3_store_base.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"23fe2319b7e6c5bded6ee28b7bdc44ebfba66784","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import hashlib"},{"line_number":18,"context_line":"import io"},{"line_number":19,"context_line":"from unittest import mock"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c7ed3f8_082f80e7","line":16,"updated":"2026-11-10 19:12:43.000000000","message":"pep8: F401 \u0027datetime\u0027 imported but unused","commit_id":"dbf608df3ba509940341e10afd62fcf729c1c822"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"23fe2319b7e6c5bded6ee28b7bdc44ebfba66784","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import botocore"},{"line_number":25,"context_line":"from botocore import exceptions as boto_exceptions"},{"line_number":26,"context_line":"from botocore import stub"},{"line_number":27,"context_line":"from oslo_utils import timeutils"},{"line_number":28,"context_line":"from oslo_utils import units"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from glance_store._drivers import s3"}],"source_content_type":"text/x-python","patch_set":1,"id":"239c31c7_2e885f9d","line":27,"updated":"2026-11-10 19:12:43.000000000","message":"pep8: F401 \u0027oslo_utils.timeutils\u0027 imported but unused","commit_id":"dbf608df3ba509940341e10afd62fcf729c1c822"}]}
