)]}'
{"glance_store/_drivers/rbd.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"865be7d1d3d1417422f22842ca81883af91cbfc4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class ImageDeleteFlag(object):"},{"line_number":154,"context_line":"    \"\"\"Flag Object used to determine whether an object requires deletion after"},{"line_number":155,"context_line":"    it\u0027s reference has been deleted from Glance."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_da095b2e","line":153,"updated":"2016-10-05 12:41:54.000000000","message":"There should be unit tests for this class, imho.","commit_id":"ed570d5358794c382bc626c3f822448230b57901"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"865be7d1d3d1417422f22842ca81883af91cbfc4","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class ImageDeleteFlag(object):"},{"line_number":154,"context_line":"    \"\"\"Flag Object used to determine whether an object requires deletion after"},{"line_number":155,"context_line":"    it\u0027s reference has been deleted from Glance."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    This is primarily used when rbd images are shared between services e.g."},{"line_number":158,"context_line":"    glance \u003c-\u003e cinder and the image is protected thus removing our ability to"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_74d94021","line":155,"updated":"2016-10-05 12:41:54.000000000","message":"its*","commit_id":"ed570d5358794c382bc626c3f822448230b57901"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"865be7d1d3d1417422f22842ca81883af91cbfc4","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            msg \u003d _(\"Unable to decode async delete catalog\")"},{"line_number":214,"context_line":"            raise exceptions.RBDScrubberError(msg)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # names must not be str() for librbd"},{"line_number":217,"context_line":"        d \u003d {}"},{"line_number":218,"context_line":"        for k, v in data.iteritems():"},{"line_number":219,"context_line":"            d[str(k): str(v)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_ba09ef97","line":216,"updated":"2016-10-05 12:41:54.000000000","message":"I don\u0027t get this comment. \"must not be str()\", and then you apply \"str()\" to everything... What do you mean?","commit_id":"ed570d5358794c382bc626c3f822448230b57901"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"865be7d1d3d1417422f22842ca81883af91cbfc4","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # names must not be str() for librbd"},{"line_number":217,"context_line":"        d \u003d {}"},{"line_number":218,"context_line":"        for k, v in data.iteritems():"},{"line_number":219,"context_line":"            d[str(k): str(v)]"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return d"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_f75c7227","line":218,"updated":"2016-10-05 12:41:54.000000000","message":"dict.iteritems() does not exist in Python 3, please juste use \".items()\".","commit_id":"ed570d5358794c382bc626c3f822448230b57901"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"865be7d1d3d1417422f22842ca81883af91cbfc4","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            raise exceptions.RBDScrubberError(msg)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if image:"},{"line_number":235,"context_line":"            return data.get(image, None)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        return data"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_9a1273b3","line":235,"updated":"2016-10-05 12:41:54.000000000","message":"None is the default value anyway, so this could just be \"data.get(image)\".","commit_id":"ed570d5358794c382bc626c3f822448230b57901"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"865be7d1d3d1417422f22842ca81883af91cbfc4","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        \"\"\""},{"line_number":535,"context_line":"        with rados.Rados(conffile\u003dself.conf_file, rados_id\u003dself.user) as conn:"},{"line_number":536,"context_line":"            with conn.open_ioctx(self.pool) as ioctx:"},{"line_number":537,"context_line":"                images \u003d ImageDeleteFlag.get_all(ioctx).iteritems()"},{"line_number":538,"context_line":"                for image, snap in images:"},{"line_number":539,"context_line":"                    deleted \u003d False"},{"line_number":540,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_b7874a60","line":537,"updated":"2016-10-05 12:41:54.000000000","message":"ditto :)","commit_id":"ed570d5358794c382bc626c3f822448230b57901"}]}
