)]}'
{"glance_store/tests/utils.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"296802caee86474deb9143a33ef509b44f1cf68d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    path \u003d parsed.path"},{"line_number":31,"context_line":"    query \u003d parsed.query"},{"line_number":32,"context_line":"    if not query:"},{"line_number":33,"context_line":"        path, query \u003d parsed.path.split(\u0027?\u0027)"},{"line_number":34,"context_line":"    queries \u003d urlparse.parse_qsl(query, True)"},{"line_number":35,"context_line":"    sorted_query \u003d sorted(queries, key\u003dlambda x: x[0])"},{"line_number":36,"context_line":"    encoded_sorted_query \u003d urllib.urlencode(sorted_query, True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_51586b56","line":33,"updated":"2015-01-21 21:05:28.000000000","message":"This should be \n\n    parsed.path.split(\u0027?\u0027, 1)\n\nIt is *plausible* for a path segment to have more than one ? in it. If it does, the tests here will give you a ValueError. It\u0027s better to be safe than sorry. :)","commit_id":"e67f12349594487eb8272751e2d2239d43101224"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"fbca94ea379e312ae0e38d285995019a99f2c4e1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    path \u003d parsed.path"},{"line_number":31,"context_line":"    query \u003d parsed.query"},{"line_number":32,"context_line":"    if not query:"},{"line_number":33,"context_line":"        path, query \u003d parsed.path.split(\u0027?\u0027)"},{"line_number":34,"context_line":"    queries \u003d urlparse.parse_qsl(query, True)"},{"line_number":35,"context_line":"    sorted_query \u003d sorted(queries, key\u003dlambda x: x[0])"},{"line_number":36,"context_line":"    encoded_sorted_query \u003d urllib.urlencode(sorted_query, True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_c1f2c899","line":33,"in_reply_to":"1a930d6b_51586b56","updated":"2015-01-22 00:14:29.000000000","message":"Thanks, that makes sense :).","commit_id":"e67f12349594487eb8272751e2d2239d43101224"}],"tests/unit/test_vmware_store.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b1e14bdd22652e7628b27501feea3ab58004b45d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    the component pieces."},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    scheme \u003d \u0027vsphere\u0027"},{"line_number":60,"context_line":"    return (\"%s://%s/folder%s/%s?dcPath\u003d%s\u0026dsName\u003d%s\""},{"line_number":61,"context_line":"            % (scheme, host_ip, folder_name,"},{"line_number":62,"context_line":"               image_id, datacenter_path, datastore_name))"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2fd6e4c5","line":60,"updated":"2015-02-03 14:54:03.000000000","message":"since we fixed the code to prevent bad things to happen when there are multiple `?` in the query. Would you mind adding a test for that?","commit_id":"a39d3558c86b37a35c815af2a2b3c709ae30e0d7"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f83df0c4998e0b771fa9d4ba95794774fe8a6a10","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    the component pieces."},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    scheme \u003d \u0027vsphere\u0027"},{"line_number":60,"context_line":"    return (\"%s://%s/folder%s/%s?dcPath\u003d%s\u0026dsName\u003d%s\""},{"line_number":61,"context_line":"            % (scheme, host_ip, folder_name,"},{"line_number":62,"context_line":"               image_id, datacenter_path, datastore_name))"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_24dc3de4","line":60,"in_reply_to":"da86d52c_2fd6e4c5","updated":"2015-02-03 18:13:02.000000000","message":"I should have seen this coming :). Sure Flavio, I will add a test.","commit_id":"a39d3558c86b37a35c815af2a2b3c709ae30e0d7"}]}
