)]}'
{"glance_store/_drivers/filesystem.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"21dd68cfa310f0200fcc44916ce843a01ce1d239","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    _CAPABILITIES \u003d (capabilities.BitMasks.READ_RANDOM |"},{"line_number":138,"context_line":"                     capabilities.BitMasks.WRITE_ACCESS |"},{"line_number":139,"context_line":"                     capabilities.BitMasks.DRIVER_REUSABLE)"},{"line_number":140,"context_line":"    OPTIONS \u003d _FILESYSTEM_CONFIGS"},{"line_number":141,"context_line":"    READ_CHUNKSIZE \u003d 64 * units.Ki"},{"line_number":142,"context_line":"    WRITE_CHUNKSIZE \u003d READ_CHUNKSIZE"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_584d8c3d","line":139,"updated":"2015-01-24 03:14:36.000000000","message":"So, this secondary prefix is my concern, all references in the \u0027client\u0027 code will need to add \u0027BitMasks\u0027 prefix instead of capabilities.CAP directly (In practice we import module), I think it\u0027s redundant (I mentioned in previous comment).","commit_id":"1a1bf595db8a2364bd6dee6cf9c221a5865c6742"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"2aafdce397c4e4becec12f82afa613eaee2d9a57","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    _CAPABILITIES \u003d (capabilities.BitMasks.READ_RANDOM |"},{"line_number":138,"context_line":"                     capabilities.BitMasks.WRITE_ACCESS |"},{"line_number":139,"context_line":"                     capabilities.BitMasks.DRIVER_REUSABLE)"},{"line_number":140,"context_line":"    OPTIONS \u003d _FILESYSTEM_CONFIGS"},{"line_number":141,"context_line":"    READ_CHUNKSIZE \u003d 64 * units.Ki"},{"line_number":142,"context_line":"    WRITE_CHUNKSIZE \u003d READ_CHUNKSIZE"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_f31496a1","line":139,"in_reply_to":"1a930d6b_584d8c3d","updated":"2015-01-24 20:16:13.000000000","message":"I don\u0027t think BitMasks is \"redundant\". If it were capabilities.Capabilities, I\u0027d agree. Further, I mentioned on IRC after submitting this that we could still reap the immutability benefit by doing (in the capabilities module):\n\n    READ_RANDOM \u003d BitMasks.READ_RANDOM\n    # etc.\n\nBut that seems a bit redundant for a few less characters in practice. I really don\u0027t feel strongly about either way, I do feel strongly that we should be using an enum regardless of how we choose to present this to the user.","commit_id":"1a1bf595db8a2364bd6dee6cf9c221a5865c6742"}]}
