)]}'
{"glance_store/_drivers/vmware_datastore.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"e1226a54b2de4dc101ad97f941338287a4af4f95","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.vmware import api"},{"line_number":25,"context_line":"from oslo.vmware import constants"},{"line_number":26,"context_line":"import oslo.vmware.exceptions as vmwareexceptions"},{"line_number":27,"context_line":"from oslo_config import cfg"},{"line_number":28,"context_line":"from oslo_utils import excutils"},{"line_number":29,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_b01f155a","line":26,"updated":"2015-02-06 08:14:23.000000000","message":"Since we are adding a new import we can use oslo_vmware instead of the deprecated oslo.vmware.\n\nfrom oslo_vmware import exceptions as vexc","commit_id":"5625a9edaeb8ecf51e477ad50c947f6c227c52e5"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"eb371c9f35a0eb53bf0f2504d23f2f08926bd3b4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.vmware import api"},{"line_number":25,"context_line":"from oslo.vmware import constants"},{"line_number":26,"context_line":"import oslo.vmware.exceptions as vmwareexceptions"},{"line_number":27,"context_line":"from oslo_config import cfg"},{"line_number":28,"context_line":"from oslo_utils import excutils"},{"line_number":29,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_9945a7b5","line":26,"in_reply_to":"da86d52c_0e116bac","updated":"2015-02-09 05:13:24.000000000","message":"oslo_vmware is now supported following https://review.openstack.org/#/c/145924/2. I only meant for new imports its better to use oslo_vmware.","commit_id":"5625a9edaeb8ecf51e477ad50c947f6c227c52e5"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"dae07e13f1497fa7c6a2236f50cd098b6521275c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.vmware import api"},{"line_number":25,"context_line":"from oslo.vmware import constants"},{"line_number":26,"context_line":"import oslo.vmware.exceptions as vmwareexceptions"},{"line_number":27,"context_line":"from oslo_config import cfg"},{"line_number":28,"context_line":"from oslo_utils import excutils"},{"line_number":29,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_0e116bac","line":26,"in_reply_to":"da86d52c_b01f155a","updated":"2015-02-09 04:05:10.000000000","message":"Looks the oslo_vmware is only in ideal phase, there is no code avaialble. \nhttps://github.com/openstack-packages/python-oslo-vmware\n\nmay still require using oslo.vmware until the project is ready and having glance and nova moving to it.","commit_id":"5625a9edaeb8ecf51e477ad50c947f6c227c52e5"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"e1226a54b2de4dc101ad97f941338287a4af4f95","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        try:"},{"line_number":418,"context_line":"            self.session.wait_for_task(delete_task)"},{"line_number":419,"context_line":"        except vmwareexceptions.FileNotFoundException:"},{"line_number":420,"context_line":"            raise exceptions.NotFound(image\u003dfile_path)"},{"line_number":421,"context_line":"        except Exception:"},{"line_number":422,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":423,"context_line":"                LOG.exception(_LE(\u0027Failed to delete image %(image)s \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_956923fb","line":420,"updated":"2015-02-06 08:14:23.000000000","message":"Nit:  Since the image file is not found it is better to provide a more meaningful message like msg \u003d _(\u0027Image file %s not found\u0027) % file_path\n\nrather than the default msg in NotFound which is \"Image %(image)s not found\"","commit_id":"5625a9edaeb8ecf51e477ad50c947f6c227c52e5"}],"tests/unit/test_vmware_store.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"e1226a54b2de4dc101ad97f941338287a4af4f95","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            HttpConn.return_value \u003d FakeHTTPConnection(status\u003d404)"},{"line_number":202,"context_line":"            self.assertRaises(exceptions.NotFound, self.store.get, loc)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_delete_none_existing(self):"},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        Test that trying to delete an image that doesn\u0027t exist"},{"line_number":207,"context_line":"        raises an error"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_304a4555","line":204,"updated":"2015-02-06 08:14:23.000000000","message":"Nit: test_delete_non_existing ?","commit_id":"5625a9edaeb8ecf51e477ad50c947f6c227c52e5"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"e1226a54b2de4dc101ad97f941338287a4af4f95","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            def fake_error(task):"},{"line_number":215,"context_line":"                from oslo_vmware.exceptions import FileNotFoundException"},{"line_number":216,"context_line":"                raise FileNotFoundException()"},{"line_number":217,"context_line":"            mock_task.side_effect \u003d fake_error"},{"line_number":218,"context_line":"            self.assertRaises(exceptions.NotFound, self.store.delete, loc)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_get_size(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_b07b9579","line":217,"updated":"2015-02-06 08:14:23.000000000","message":"You could avoid the fake_error method since the side_effect can also be an exception :-\n\nmock_task.side_effect \u003d FileNotFoundException","commit_id":"5625a9edaeb8ecf51e477ad50c947f6c227c52e5"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0a887ee03e820e7068d210e219d5d326a6f52f03","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_delete_non_existing(self):"},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        Test that trying to delete an image that doesn\u0027t exist"},{"line_number":207,"context_line":"        raises an error"},{"line_number":208,"context_line":"        \"\"\""},{"line_number":209,"context_line":"        loc \u003d location.get_location_from_uri("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_8652f432","line":206,"updated":"2015-02-25 23:14:39.000000000","message":"NIT:First sentence of docstring should fit on one line and/or multiline docstring should not start with empty line.","commit_id":"ea09a05f822f12e9e93e7bb1fda17c9465eddcc5"},{"author":{"_account_id":12196,"name":"Jun Hong Li","email":"junhongl@cn.ibm.com","username":"Junhongl"},"change_message_id":"323295de1b1348cf9b2ebc466aaa76450155ca82","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_delete_non_existing(self):"},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        Test that trying to delete an image that doesn\u0027t exist"},{"line_number":207,"context_line":"        raises an error"},{"line_number":208,"context_line":"        \"\"\""},{"line_number":209,"context_line":"        loc \u003d location.get_location_from_uri("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_bfc3f688","line":206,"in_reply_to":"ba7be1f8_8652f432","updated":"2015-03-02 03:40:21.000000000","message":"Done","commit_id":"ea09a05f822f12e9e93e7bb1fda17c9465eddcc5"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"8a41172caecce8fd920bae32f596199b2b2916aa","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            \"dsName\u003dds1\u0026dcPath\u003ddc1\" % FAKE_UUID, conf\u003dself.conf)"},{"line_number":212,"context_line":"        with mock.patch.object(self.store.session,"},{"line_number":213,"context_line":"                               \u0027wait_for_task\u0027) as mock_task:"},{"line_number":214,"context_line":"            from oslo_vmware.exceptions import FileNotFoundException"},{"line_number":215,"context_line":"            mock_task.side_effect \u003d FileNotFoundException"},{"line_number":216,"context_line":"            self.assertRaises(exceptions.NotFound, self.store.delete, loc)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_4ff878c4","line":214,"updated":"2015-02-17 10:13:53.000000000","message":"Nit: I\u0027d move the import to other imports at the beginning of the module.","commit_id":"ea09a05f822f12e9e93e7bb1fda17c9465eddcc5"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"d9509ddfbdefe6dc0de1273a69063619e7e566ef","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            \"dsName\u003dds1\u0026dcPath\u003ddc1\" % FAKE_UUID, conf\u003dself.conf)"},{"line_number":212,"context_line":"        with mock.patch.object(self.store.session,"},{"line_number":213,"context_line":"                               \u0027wait_for_task\u0027) as mock_task:"},{"line_number":214,"context_line":"            from oslo_vmware.exceptions import FileNotFoundException"},{"line_number":215,"context_line":"            mock_task.side_effect \u003d FileNotFoundException"},{"line_number":216,"context_line":"            self.assertRaises(exceptions.NotFound, self.store.delete, loc)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_fb5c301b","line":214,"in_reply_to":"da86d52c_4ff878c4","updated":"2015-02-25 19:23:39.000000000","message":"+1","commit_id":"ea09a05f822f12e9e93e7bb1fda17c9465eddcc5"},{"author":{"_account_id":12196,"name":"Jun Hong Li","email":"junhongl@cn.ibm.com","username":"Junhongl"},"change_message_id":"323295de1b1348cf9b2ebc466aaa76450155ca82","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            \"dsName\u003dds1\u0026dcPath\u003ddc1\" % FAKE_UUID, conf\u003dself.conf)"},{"line_number":212,"context_line":"        with mock.patch.object(self.store.session,"},{"line_number":213,"context_line":"                               \u0027wait_for_task\u0027) as mock_task:"},{"line_number":214,"context_line":"            from oslo_vmware.exceptions import FileNotFoundException"},{"line_number":215,"context_line":"            mock_task.side_effect \u003d FileNotFoundException"},{"line_number":216,"context_line":"            self.assertRaises(exceptions.NotFound, self.store.delete, loc)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_dfbeeaff","line":214,"in_reply_to":"da86d52c_4ff878c4","updated":"2015-03-02 03:40:21.000000000","message":"Done","commit_id":"ea09a05f822f12e9e93e7bb1fda17c9465eddcc5"}]}
