)]}'
{"glance_store/_drivers/rbd.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"58c15fe690077dd1facd5e9251e6b99a56e30ec9","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                    # Then delete image."},{"line_number":305,"context_line":"                    rbd.RBD().remove(ioctx, image_name)"},{"line_number":306,"context_line":"                except rbd.ImageNotFound:"},{"line_number":307,"context_line":"                    msg \u003d _(\"RBD image %s does not exist\") % image_name"},{"line_number":308,"context_line":"                    raise exceptions.NotFound(message\u003dmsg)"},{"line_number":309,"context_line":"                except rbd.ImageBusy:"},{"line_number":310,"context_line":"                    log_msg \u003d _(\"image %s could not be removed \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e3a8d721","line":307,"updated":"2015-02-06 15:44:58.000000000","message":"If I\u0027m not completely wrong, delegating the string formatting to translators is supposed to fetch better performance. So, instead of \n    msg \u003d _(\u0027foo %s\u0027) % \u0027bar\u0027 \nyou would do \n    msg \u003d _(\u0027foo %s\u0027, \u0027bar\u0027)","commit_id":"692686a55bd0b2c306e21adb0d2e391b8009368e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"71408f21981ef27f31dc8260272020b3e345154c","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                    # Then delete image."},{"line_number":305,"context_line":"                    rbd.RBD().remove(ioctx, image_name)"},{"line_number":306,"context_line":"                except rbd.ImageNotFound:"},{"line_number":307,"context_line":"                    msg \u003d _(\"RBD image %s does not exist\") % image_name"},{"line_number":308,"context_line":"                    raise exceptions.NotFound(message\u003dmsg)"},{"line_number":309,"context_line":"                except rbd.ImageBusy:"},{"line_number":310,"context_line":"                    log_msg \u003d _(\"image %s could not be removed \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_b2c5463f","line":307,"in_reply_to":"da86d52c_09fee905","updated":"2015-02-06 18:19:50.000000000","message":"Yeah, makes sense. Looks like there is another MP which is doing that refactoring. https://review.openstack.org/#/c/137852/\n\nSorry, I\u0027ll take my -1 back :)\nAnd, thanks for the work!","commit_id":"692686a55bd0b2c306e21adb0d2e391b8009368e"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"ef2c8512c5b45516d6de458dd0ed3b117fec5e6d","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                    # Then delete image."},{"line_number":305,"context_line":"                    rbd.RBD().remove(ioctx, image_name)"},{"line_number":306,"context_line":"                except rbd.ImageNotFound:"},{"line_number":307,"context_line":"                    msg \u003d _(\"RBD image %s does not exist\") % image_name"},{"line_number":308,"context_line":"                    raise exceptions.NotFound(message\u003dmsg)"},{"line_number":309,"context_line":"                except rbd.ImageBusy:"},{"line_number":310,"context_line":"                    log_msg \u003d _(\"image %s could not be removed \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_f2e09e98","line":307,"in_reply_to":"da86d52c_b2c5463f","updated":"2015-02-06 18:27:43.000000000","message":"Yeah, I\u0027d say leave off nitting on where the formatting happens until that patch is revisited and closer to being merged.","commit_id":"692686a55bd0b2c306e21adb0d2e391b8009368e"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"6465840cb7ade87269b72047f32edbfa4e46e0b0","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                    # Then delete image."},{"line_number":305,"context_line":"                    rbd.RBD().remove(ioctx, image_name)"},{"line_number":306,"context_line":"                except rbd.ImageNotFound:"},{"line_number":307,"context_line":"                    msg \u003d _(\"RBD image %s does not exist\") % image_name"},{"line_number":308,"context_line":"                    raise exceptions.NotFound(message\u003dmsg)"},{"line_number":309,"context_line":"                except rbd.ImageBusy:"},{"line_number":310,"context_line":"                    log_msg \u003d _(\"image %s could not be removed \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_09fee905","line":307,"in_reply_to":"da86d52c_de180a20","updated":"2015-02-06 16:33:09.000000000","message":"I think that this method is valid and Jordan is right. More over everywhere in the code msg \u003d _(\u0027foo %s\u0027) % \u0027bar\u0027 is used. For example, look at 172 line in this file.","commit_id":"692686a55bd0b2c306e21adb0d2e391b8009368e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a59d1160e1225bec10b62efaa44d5f0c73ccea73","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                    # Then delete image."},{"line_number":305,"context_line":"                    rbd.RBD().remove(ioctx, image_name)"},{"line_number":306,"context_line":"                except rbd.ImageNotFound:"},{"line_number":307,"context_line":"                    msg \u003d _(\"RBD image %s does not exist\") % image_name"},{"line_number":308,"context_line":"                    raise exceptions.NotFound(message\u003dmsg)"},{"line_number":309,"context_line":"                except rbd.ImageBusy:"},{"line_number":310,"context_line":"                    log_msg \u003d _(\"image %s could not be removed \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_de180a20","line":307,"in_reply_to":"da86d52c_e3a8d721","updated":"2015-02-06 15:53:19.000000000","message":"Hey, I think you are right. But the intent of this patch it to use hacking 0.10 and the original code uses \"_(\u0027foo %s\u0027) % \u0027bar\u0027\". I don\u0027t want to introduce unrelated change for better performance in this patch.\n\nPlus, if we are going this way (replacing \u0027%\u0027 by \u0027,\u0027) we should do it everywhere for consistency.\n\nOverall, not sure if I deserve a -1 for this :)","commit_id":"692686a55bd0b2c306e21adb0d2e391b8009368e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"58c15fe690077dd1facd5e9251e6b99a56e30ec9","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                                             image_size, order)"},{"line_number":348,"context_line":"                except rbd.ImageExists:"},{"line_number":349,"context_line":"                    msg \u003d _(\u0027RBD image %s already exists\u0027) % image_id"},{"line_number":350,"context_line":"                    raise exceptions.Duplicate(message\u003dmsg)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"                try:"},{"line_number":353,"context_line":"                    with rbd.Image(ioctx, image_name) as image:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_836f1bfb","line":350,"updated":"2015-02-06 15:44:58.000000000","message":"same here","commit_id":"692686a55bd0b2c306e21adb0d2e391b8009368e"}],"tox.ini":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b14cb4d0165c30302bfb8f144da40d83f295c675","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# TODO(dmllr): Analyze or fix the warnings blacklisted below"},{"line_number":30,"context_line":"# H301  one import per line"},{"line_number":31,"context_line":"# H404  multi line docstring should start with a summary"},{"line_number":32,"context_line":"# H405  multi line docstring summary not separated with an empty line"},{"line_number":33,"context_line":"ignore \u003d H301,H404,H405"},{"line_number":34,"context_line":"builtins \u003d _"},{"line_number":35,"context_line":"exclude \u003d .venv,.git,.tox,dist,doc,etc,*glance_store/locale*,*openstack/common*,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"da86d52c_fd097484","line":32,"updated":"2015-02-19 17:15:55.000000000","message":"Why was H405 added? It should not be needed for this patch.","commit_id":"692686a55bd0b2c306e21adb0d2e391b8009368e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1d15bd0a92d02b37994e57719e08dff96d07207e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# TODO(dmllr): Analyze or fix the warnings blacklisted below"},{"line_number":30,"context_line":"# H301  one import per line"},{"line_number":31,"context_line":"# H404  multi line docstring should start with a summary"},{"line_number":32,"context_line":"# H405  multi line docstring summary not separated with an empty line"},{"line_number":33,"context_line":"ignore \u003d H301,H404,H405"},{"line_number":34,"context_line":"builtins \u003d _"},{"line_number":35,"context_line":"exclude \u003d .venv,.git,.tox,dist,doc,etc,*glance_store/locale*,*openstack/common*,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ba7be1f8_c68eac2d","line":32,"in_reply_to":"da86d52c_fd097484","updated":"2015-02-25 23:05:47.000000000","message":"I don\u0027t think we comply with H405 so excluding it would be needed to bring it in.","commit_id":"692686a55bd0b2c306e21adb0d2e391b8009368e"}]}
