)]}'
{"glance_store/_drivers/rbd.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"129ec63f08a00858b2eb4d45e7fdf6bbcedf0d44","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        itself, it should raise `exceptions.BadStoreConfiguration`"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            chunk \u003d self.conf.glance_store.rbd_store_chunk_size"},{"line_number":197,"context_line":"            self.chunk_size \u003d chunk * (1024 ** 2)"},{"line_number":198,"context_line":"            self.READ_CHUNKSIZE \u003d self.chunk_size"},{"line_number":199,"context_line":"            self.WRITE_CHUNKSIZE \u003d self.READ_CHUNKSIZE"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_37195b22","line":196,"updated":"2015-02-26 12:24:35.000000000","message":"I think you missed this one.","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0266030e172c5a2d7ca545fc20ad013ddada86df","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        itself, it should raise `exceptions.BadStoreConfiguration`"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            chunk \u003d self.conf.glance_store.rbd_store_chunk_size"},{"line_number":197,"context_line":"            self.chunk_size \u003d chunk * (1024 ** 2)"},{"line_number":198,"context_line":"            self.READ_CHUNKSIZE \u003d self.chunk_size"},{"line_number":199,"context_line":"            self.WRITE_CHUNKSIZE \u003d self.READ_CHUNKSIZE"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_64c951ab","line":196,"updated":"2015-02-26 17:55:06.000000000","message":"No, I didn\u0027t  :)\nThis one is being changed on related patch. See commit message for the Id.","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8529d0d278e56e04224ac03a440d21e19ec9e468","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import math"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":"from oslo_utils import excutils"},{"line_number":25,"context_line":"from oslo_utils import units"},{"line_number":26,"context_line":"import six.moves.urllib.parse as urlparse"},{"line_number":27,"context_line":"import swiftclient"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_c62cec9b","line":24,"updated":"2015-02-25 22:52:43.000000000","message":"Unrelated change","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0266030e172c5a2d7ca545fc20ad013ddada86df","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import math"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":"from oslo_utils import excutils"},{"line_number":25,"context_line":"from oslo_utils import units"},{"line_number":26,"context_line":"import six.moves.urllib.parse as urlparse"},{"line_number":27,"context_line":"import swiftclient"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_a4c6e997","line":24,"updated":"2015-02-26 17:55:06.000000000","message":"You are right, I just got carried away. ;)","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0266030e172c5a2d7ca545fc20ad013ddada86df","unresolved":false,"context_lines":[{"line_number":43,"context_line":"_LI \u003d i18n._LI"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"DEFAULT_CONTAINER \u003d \u0027glance\u0027"},{"line_number":46,"context_line":"DEFAULT_LARGE_OBJECT_SIZE \u003d 5 * units.Ki  # 5GB"},{"line_number":47,"context_line":"DEFAULT_LARGE_OBJECT_CHUNK_SIZE \u003d 200  # 200M"},{"line_number":48,"context_line":"ONE_MB \u003d units.k * units.Ki  # Here we used the mixed meaning of MB"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_c4c11d81","line":46,"updated":"2015-02-26 17:55:06.000000000","message":"My reasoning for doing so was that number 1024 here relates to Ki and not an arbitrary number, even if it means 5Ki times Mi.","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8529d0d278e56e04224ac03a440d21e19ec9e468","unresolved":false,"context_lines":[{"line_number":43,"context_line":"_LI \u003d i18n._LI"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"DEFAULT_CONTAINER \u003d \u0027glance\u0027"},{"line_number":46,"context_line":"DEFAULT_LARGE_OBJECT_SIZE \u003d 5 * units.Ki  # 5GB"},{"line_number":47,"context_line":"DEFAULT_LARGE_OBJECT_CHUNK_SIZE \u003d 200  # 200M"},{"line_number":48,"context_line":"ONE_MB \u003d units.k * units.Ki  # Here we used the mixed meaning of MB"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_3b8c01da","line":46,"updated":"2015-02-25 22:52:43.000000000","message":"Why not use 5120 here instead as we\u0027re not really talking about Kis? We don\u0027t use units.Ki/5.12 below either.","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a4b04005b9bd98ee39c52d974b2c9e9ab66c6f37","unresolved":false,"context_lines":[{"line_number":43,"context_line":"_LI \u003d i18n._LI"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"DEFAULT_CONTAINER \u003d \u0027glance\u0027"},{"line_number":46,"context_line":"DEFAULT_LARGE_OBJECT_SIZE \u003d 5 * units.Ki  # 5GB"},{"line_number":47,"context_line":"DEFAULT_LARGE_OBJECT_CHUNK_SIZE \u003d 200  # 200M"},{"line_number":48,"context_line":"ONE_MB \u003d units.k * units.Ki  # Here we used the mixed meaning of MB"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_03c33238","line":46,"in_reply_to":"ba7be1f8_3b8c01da","updated":"2015-02-26 16:14:40.000000000","message":"this one I don\u0027t mind.","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0266030e172c5a2d7ca545fc20ad013ddada86df","unresolved":false,"context_lines":[{"line_number":45,"context_line":"DEFAULT_CONTAINER \u003d \u0027glance\u0027"},{"line_number":46,"context_line":"DEFAULT_LARGE_OBJECT_SIZE \u003d 5 * units.Ki  # 5GB"},{"line_number":47,"context_line":"DEFAULT_LARGE_OBJECT_CHUNK_SIZE \u003d 200  # 200M"},{"line_number":48,"context_line":"ONE_MB \u003d units.k * units.Ki  # Here we used the mixed meaning of MB"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"_SWIFT_OPTS \u003d ["},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027swift_store_auth_version\u0027, default\u003d\u00272\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e4bc6108","line":48,"updated":"2015-02-26 17:55:06.000000000","message":"Here again it\u0027s a matter of perspective, if we leave it as 1000 (and we didn\u0027t read the name of the variable of course) we wouldn\u0027t know if this is an arbitrary number.\nIn this case we try to get a mixed unit MB which comes from multiplying decimal K by binary K, resulting in k * Ki.\nI believe this is more clarifying, otherwise you could wonder why is it not 1000 * 1000 or 1024 * 1024","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8529d0d278e56e04224ac03a440d21e19ec9e468","unresolved":false,"context_lines":[{"line_number":45,"context_line":"DEFAULT_CONTAINER \u003d \u0027glance\u0027"},{"line_number":46,"context_line":"DEFAULT_LARGE_OBJECT_SIZE \u003d 5 * units.Ki  # 5GB"},{"line_number":47,"context_line":"DEFAULT_LARGE_OBJECT_CHUNK_SIZE \u003d 200  # 200M"},{"line_number":48,"context_line":"ONE_MB \u003d units.k * units.Ki  # Here we used the mixed meaning of MB"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"_SWIFT_OPTS \u003d ["},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027swift_store_auth_version\u0027, default\u003d\u00272\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_fb434969","line":48,"updated":"2015-02-25 22:52:43.000000000","message":"This really does not improve readability.\n\nI\u0027d prefer it either as it is or 1000 * units.Ki, but even that does not make it gteat.","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a4b04005b9bd98ee39c52d974b2c9e9ab66c6f37","unresolved":false,"context_lines":[{"line_number":45,"context_line":"DEFAULT_CONTAINER \u003d \u0027glance\u0027"},{"line_number":46,"context_line":"DEFAULT_LARGE_OBJECT_SIZE \u003d 5 * units.Ki  # 5GB"},{"line_number":47,"context_line":"DEFAULT_LARGE_OBJECT_CHUNK_SIZE \u003d 200  # 200M"},{"line_number":48,"context_line":"ONE_MB \u003d units.k * units.Ki  # Here we used the mixed meaning of MB"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"_SWIFT_OPTS \u003d ["},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027swift_store_auth_version\u0027, default\u003d\u00272\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_a384260b","line":48,"in_reply_to":"ba7be1f8_fb434969","updated":"2015-02-26 16:14:40.000000000","message":"+1 to Erno\u0027s suggestion.\n\nAlso, iiiuuuuuugghhhhhh, do we still have this around?","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"}],"glance_store/driver.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0266030e172c5a2d7ca545fc20ad013ddada86df","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"from oslo_utils import importutils"},{"line_number":23,"context_line":"from oslo_utils import units"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from glance_store import capabilities"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_84cc85bc","line":22,"updated":"2015-02-26 17:55:06.000000000","message":"I really did get carried away that day. XD","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8529d0d278e56e04224ac03a440d21e19ec9e468","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"from oslo_utils import importutils"},{"line_number":23,"context_line":"from oslo_utils import units"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from glance_store import capabilities"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_fb11895d","line":22,"updated":"2015-02-25 22:52:43.000000000","message":"Unrelated change, please keep separate.","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8529d0d278e56e04224ac03a440d21e19ec9e468","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class Store(capabilities.StoreCapability):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    OPTIONS \u003d None"},{"line_number":37,"context_line":"    READ_CHUNKSIZE \u003d 16 * units.Mi  # 16M"},{"line_number":38,"context_line":"    WRITE_CHUNKSIZE \u003d READ_CHUNKSIZE"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self, conf):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_3b288199","line":37,"updated":"2015-02-25 22:52:43.000000000","message":"This for example makes perfectly sense.","commit_id":"12dd4dc08ce7f0ebdc5933ac642a9cde66d52380"}],"tests/unit/test_cinder_store.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"16234139835b74d63ff3a49fbf63e80e817b6ca7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            loc \u003d location.get_location_from_uri(uri, conf\u003dself.conf)"},{"line_number":73,"context_line":"            image_size \u003d self.store.get_size(loc, context\u003dfake_context)"},{"line_number":74,"context_line":"            self.assertEqual(image_size,"},{"line_number":75,"context_line":"                             fake_volumes.values()[0].size * (units.Ki ** 3))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_cinder_delete_raise_error(self):"},{"line_number":78,"context_line":"        uri \u003d \u0027cinder://12345678-9012-3455-6789-012345678901\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_3681abfb","line":75,"updated":"2015-02-24 23:04:22.000000000","message":"This could be units.Gi","commit_id":"98cfe7aaefb395a9b51048804306caca2126bfba"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f6aadcfa030a5e967c4d77c7d41157302bb15b6b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            loc \u003d location.get_location_from_uri(uri, conf\u003dself.conf)"},{"line_number":73,"context_line":"            image_size \u003d self.store.get_size(loc, context\u003dfake_context)"},{"line_number":74,"context_line":"            self.assertEqual(image_size,"},{"line_number":75,"context_line":"                             fake_volumes.values()[0].size * (units.Ki ** 3))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_cinder_delete_raise_error(self):"},{"line_number":78,"context_line":"        uri \u003d \u0027cinder://12345678-9012-3455-6789-012345678901\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_c656d0cd","line":75,"updated":"2015-02-25 09:56:39.000000000","message":"Yes, it should be units.Gi, thanks Sabari for the catch","commit_id":"98cfe7aaefb395a9b51048804306caca2126bfba"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"84042215c3a9cf092630679bd6447e46697c0649","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            loc \u003d location.get_location_from_uri(uri, conf\u003dself.conf)"},{"line_number":73,"context_line":"            image_size \u003d self.store.get_size(loc, context\u003dfake_context)"},{"line_number":74,"context_line":"            self.assertEqual(image_size,"},{"line_number":75,"context_line":"                             fake_volumes.values()[0].size * (units.Ki ** 3))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_cinder_delete_raise_error(self):"},{"line_number":78,"context_line":"        uri \u003d \u0027cinder://12345678-9012-3455-6789-012345678901\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_fdee0fec","line":75,"in_reply_to":"ba7be1f8_3681abfb","updated":"2015-02-25 01:08:44.000000000","message":"Good point Sabari. I think this is Okay as is, but this can be changed if Gorka decides to. They\u0027ll only lose 2 +1s, one of which they\u0027ll get back immediately.","commit_id":"98cfe7aaefb395a9b51048804306caca2126bfba"}],"tests/unit/test_rbd_store.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"b5c8715a0e8f9fe45e09ce5b54de819317cfb1a0","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import StringIO"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from glance_store._drivers import rbd as rbd_store"},{"line_number":21,"context_line":"from glance_store import exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_cac103e6","side":"PARENT","line":18,"updated":"2015-02-20 17:00:36.000000000","message":"This is still a third party library, why did you move it above StringIO (which is a standard library)?","commit_id":"138875b7c3051a4f92616df56bffb8c91e669d88"}]}