)]}'
{"glance_store/_drivers/http.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"5760227dce8716ef2f4b2cf07e31e17fbf1d01a6","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \"\"\"An implementation of the HTTP(S) Backend Adapter\"\"\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    _CAPABILITIES \u003d (capabilities.BitMasks.READ_RANDOM |"},{"line_number":116,"context_line":"                     capabilities.BitMasks.DRIVER_REUSABLE)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @capabilities.check"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_4588931f","line":115,"updated":"2015-03-23 22:28:52.000000000","message":"Should it be a static capability ? Can we check ACCEPT_RANGES with a HEAD request and update this dynamically. I see your NOTE below, but is that the plan to remove the static capability later ?","commit_id":"c0a4ab3496657d65746c55ee7e16a96d89eeca8c"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"e02737bc95a5e9dc449935dda2bf6a14ba3e98a3","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    \"\"\"An implementation of the HTTP(S) Backend Adapter\"\"\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    _CAPABILITIES \u003d (capabilities.BitMasks.READ_RANDOM |"},{"line_number":116,"context_line":"                     capabilities.BitMasks.DRIVER_REUSABLE)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @capabilities.check"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_45d7b3c1","line":115,"in_reply_to":"1a6ced46_4588931f","updated":"2015-03-23 22:40:29.000000000","message":"I think I jumped the gun. I got this self-clarified :). Since it really depends on the external source we query for a particular image to support partial download, it\u0027s ok to set the capability statically.","commit_id":"c0a4ab3496657d65746c55ee7e16a96d89eeca8c"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a8fc0847999a74e5e3a9c3609647c5e4231a99df","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            return 0"},{"line_number":181,"context_line":"        return size"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def _query(self, location, verb, depth\u003d0, headers\u003d{}):"},{"line_number":184,"context_line":"        if depth \u003e MAX_REDIRECTS:"},{"line_number":185,"context_line":"            reason \u003d (_(\"The HTTP URL exceeded %s maximum \""},{"line_number":186,"context_line":"                        \"redirects.\") % MAX_REDIRECTS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_46976748","line":183,"updated":"2015-03-25 16:28:07.000000000","message":"{} is a dangerous default value. If you truly intend to use the wacky side-effects of passing a mutable object as a default here, then please document that in a comment or docstring.","commit_id":"369858bf1e7492c9f3308c05168ff3e102184150"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"4200ebe238b3f9422c8fcd920ccd8b2ec61e07c2","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            return 0"},{"line_number":181,"context_line":"        return size"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def _query(self, location, verb, depth\u003d0, headers\u003d{}):"},{"line_number":184,"context_line":"        if depth \u003e MAX_REDIRECTS:"},{"line_number":185,"context_line":"            reason \u003d (_(\"The HTTP URL exceeded %s maximum \""},{"line_number":186,"context_line":"                        \"redirects.\") % MAX_REDIRECTS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_c3a985e1","line":183,"in_reply_to":"1a6ced46_46976748","updated":"2015-04-17 00:42:50.000000000","message":"Done","commit_id":"369858bf1e7492c9f3308c05168ff3e102184150"}],"glance_store/tests/utils.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"81af1d6572d9434fcfa2ab4a87bd9557ae5d0011","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def read(self, amt):"},{"line_number":63,"context_line":"        self.data.read(amt)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def partialize(self, data, range):"},{"line_number":66,"context_line":"        self.headers[\u0027Accept-Ranges\u0027] \u003d \u0027bytes\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        ret \u003d range.strip(\u0027bytes\u003d\u0027).split(\u0027-\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_df350cdc","line":65,"updated":"2015-03-24 15:52:48.000000000","message":"Can we use an existing range header parser instead of implementing one here? For example, https://github.com/dmeranda/httpheader","commit_id":"c0a4ab3496657d65746c55ee7e16a96d89eeca8c"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"917f1c67824f90e6405c9e12b74d27cf678c2dae","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def read(self, amt):"},{"line_number":63,"context_line":"        self.data.read(amt)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def partialize(self, data, range):"},{"line_number":66,"context_line":"        self.headers[\u0027Accept-Ranges\u0027] \u003d \u0027bytes\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        ret \u003d range.strip(\u0027bytes\u003d\u0027).split(\u0027-\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_ce302ba1","line":65,"in_reply_to":"1a6ced46_df350cdc","updated":"2015-04-03 22:48:18.000000000","message":"I agreed and would like to leverage such lib/util to easy this stuff if we have @Sabari.","commit_id":"c0a4ab3496657d65746c55ee7e16a96d89eeca8c"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"c06a7e49be87a11596a7c9e3a22b46150a57fcea","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def read(self, amt):"},{"line_number":63,"context_line":"        self.data.read(amt)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def partialize(self, data, range):"},{"line_number":66,"context_line":"        self.headers[\u0027Accept-Ranges\u0027] \u003d \u0027bytes\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        ret \u003d range.strip(\u0027bytes\u003d\u0027).split(\u0027-\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ab451fb_03ee4d22","line":65,"in_reply_to":"baa041b7_ce302ba1","updated":"2015-04-17 00:43:31.000000000","message":"I updated the code to use werkzeug.","commit_id":"c0a4ab3496657d65746c55ee7e16a96d89eeca8c"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"5760227dce8716ef2f4b2cf07e31e17fbf1d01a6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            self.status \u003d 200"},{"line_number":74,"context_line":"            return data"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        start, end \u003d ret"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if start:"},{"line_number":79,"context_line":"            if start.isdigit():"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_e22b35e9","line":76,"updated":"2015-03-23 22:28:52.000000000","message":"Would it be worthwhile adding webob for test-requirements ? In that case, it\u0027s easy to parse valid range values. \n\n webob.byterange.Range.parse(range)","commit_id":"c0a4ab3496657d65746c55ee7e16a96d89eeca8c"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"917f1c67824f90e6405c9e12b74d27cf678c2dae","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            self.status \u003d 200"},{"line_number":74,"context_line":"            return data"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        start, end \u003d ret"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if start:"},{"line_number":79,"context_line":"            if start.isdigit():"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_ae272763","line":76,"in_reply_to":"1a6ced46_e22b35e9","updated":"2015-04-03 22:48:18.000000000","message":"Ditto","commit_id":"c0a4ab3496657d65746c55ee7e16a96d89eeca8c"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a8fc0847999a74e5e3a9c3609647c5e4231a99df","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                                             (len(data) + end, len(data) - 1,"},{"line_number":121,"context_line":"                                              len(data)))"},{"line_number":122,"context_line":"            return data[end:]"},{"line_number":123,"context_line":"        else:  # Shouldn\u0027t reach here"},{"line_number":124,"context_line":"            self.status \u003d 200"},{"line_number":125,"context_line":"            return data"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_c6335712","line":123,"updated":"2015-03-25 16:28:07.000000000","message":"Won\u0027t we reach this clause if only start is set, and it\u0027s set to 0? I.e., \u0027bytes\u003d0-\u0027 And this is the intended behavior in that case AIUI.","commit_id":"369858bf1e7492c9f3308c05168ff3e102184150"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"4200ebe238b3f9422c8fcd920ccd8b2ec61e07c2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                                             (len(data) + end, len(data) - 1,"},{"line_number":121,"context_line":"                                              len(data)))"},{"line_number":122,"context_line":"            return data[end:]"},{"line_number":123,"context_line":"        else:  # Shouldn\u0027t reach here"},{"line_number":124,"context_line":"            self.status \u003d 200"},{"line_number":125,"context_line":"            return data"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_43b6953e","line":123,"in_reply_to":"1a6ced46_c6335712","updated":"2015-04-17 00:42:50.000000000","message":"We are now using werkzeug to parse header.","commit_id":"369858bf1e7492c9f3308c05168ff3e102184150"}],"tests/unit/test_http_store.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a8fc0847999a74e5e3a9c3609647c5e4231a99df","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(image_size, chunk_size)"},{"line_number":130,"context_line":"        self.assertEqual(image_size, len(\u0027\u0027.join(expected_returns)))"},{"line_number":131,"context_line":"        chunks \u003d [c for c in image_file]"},{"line_number":132,"context_line":"        self.assertEqual(expected_returns, chunks)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_http_get_redirect(self):"},{"line_number":135,"context_line":"        # Add two layers of redirects to the response stack, which will"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_6167ede9","line":132,"updated":"2015-03-25 16:28:07.000000000","message":"We should add tests for the various 416 conditions that can be triggered as well.","commit_id":"369858bf1e7492c9f3308c05168ff3e102184150"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"4f9ff0520d34a585b4391525982b12692cecdcaa","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(image_size, chunk_size)"},{"line_number":130,"context_line":"        self.assertEqual(image_size, len(\u0027\u0027.join(expected_returns)))"},{"line_number":131,"context_line":"        chunks \u003d [c for c in image_file]"},{"line_number":132,"context_line":"        self.assertEqual(expected_returns, chunks)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_http_get_redirect(self):"},{"line_number":135,"context_line":"        # Add two layers of redirects to the response stack, which will"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_0e1733ee","line":132,"in_reply_to":"1a6ced46_6167ede9","updated":"2015-04-03 22:51:15.000000000","message":"I agreed, seems worth to have. @Sabari","commit_id":"369858bf1e7492c9f3308c05168ff3e102184150"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"4200ebe238b3f9422c8fcd920ccd8b2ec61e07c2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertEqual(image_size, chunk_size)"},{"line_number":130,"context_line":"        self.assertEqual(image_size, len(\u0027\u0027.join(expected_returns)))"},{"line_number":131,"context_line":"        chunks \u003d [c for c in image_file]"},{"line_number":132,"context_line":"        self.assertEqual(expected_returns, chunks)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_http_get_redirect(self):"},{"line_number":135,"context_line":"        # Add two layers of redirects to the response stack, which will"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_03876d62","line":132,"in_reply_to":"baa041b7_0e1733ee","updated":"2015-04-17 00:42:50.000000000","message":"Added a test for the same.","commit_id":"369858bf1e7492c9f3308c05168ff3e102184150"}],"tests/unit/test_utils.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e0b7c93282d8f21837519ae36dd1959c65bbfa7d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                   \u0027bytes\u003d-100\u0027]"},{"line_number":45,"context_line":"        for i, input_str in enumerate(input_offset_chunk):"},{"line_number":46,"context_line":"            ret \u003d utils.get_bytes_range_str(*input_str)"},{"line_number":47,"context_line":"            self.assertEqual(exp_str[i], ret)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_aa906ced","line":47,"updated":"2015-04-17 18:05:58.000000000","message":"This should also include a test where offset is None, and one where neither keyword argument is given.","commit_id":"613b6cd05fadc6c23e42c691c25a25e2b6ac1c93"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"fb65e3bc26059c5a057aa8bb75d97746b8ed5bc8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                   \u0027bytes\u003d-100\u0027]"},{"line_number":45,"context_line":"        for i, input_str in enumerate(input_offset_chunk):"},{"line_number":46,"context_line":"            ret \u003d utils.get_bytes_range_str(*input_str)"},{"line_number":47,"context_line":"            self.assertEqual(exp_str[i], ret)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_537b7e8c","line":47,"in_reply_to":"3ab451fb_aa906ced","updated":"2015-05-04 22:14:02.000000000","message":"Ok. Added.","commit_id":"613b6cd05fadc6c23e42c691c25a25e2b6ac1c93"}]}
