)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7c6acbb6c038acad02a93607d95517ff6e1125de","unresolved":false,"context_lines":[{"line_number":17,"context_line":"3. Help handling redirects"},{"line_number":18,"context_line":"4. Help with Chunked Encoding"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partial-bug: 1436082"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-authored-by: Sabari Kumar Murugesan \u003csmurugesan@vmware.com\u003e"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a710552_60b4aad0","line":20,"updated":"2015-12-16 12:29:52.000000000","message":"Should this be `Closes` ?","commit_id":"77b6f969136ae93ccbd014e03619829d1d494e8b"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"cece8c0d29e545f64fe2bde5855bede61cee8e76","unresolved":false,"context_lines":[{"line_number":17,"context_line":"3. Help handling redirects"},{"line_number":18,"context_line":"4. Help with Chunked Encoding"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partial-bug: 1436082"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-authored-by: Sabari Kumar Murugesan \u003csmurugesan@vmware.com\u003e"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa69d971_8c3dce2c","line":20,"in_reply_to":"5a710552_60b4aad0","updated":"2016-01-07 08:12:38.000000000","message":"The bug also needs the HTTP store to switch to requests. I will work on restoring that.","commit_id":"77b6f969136ae93ccbd014e03619829d1d494e8b"}],"glance_store/_drivers/vmware_datastore.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7c6acbb6c038acad02a93607d95517ff6e1125de","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":57,"context_line":"MAX_REDIRECTS \u003d 5"},{"line_number":58,"context_line":"DEFAULT_STORE_IMAGE_DIR \u003d \u0027/openstack_glance\u0027"},{"line_number":59,"context_line":"DS_URL_PREFIX \u003d \u0027/folder\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_e0bada09","line":56,"updated":"2015-12-16 12:29:52.000000000","message":"Not opposed to this but, this patch is changing the default chunk size. Just want to make  sure you\u0027re aware of this.","commit_id":"77b6f969136ae93ccbd014e03619829d1d494e8b"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"cece8c0d29e545f64fe2bde5855bede61cee8e76","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":57,"context_line":"MAX_REDIRECTS \u003d 5"},{"line_number":58,"context_line":"DEFAULT_STORE_IMAGE_DIR \u003d \u0027/openstack_glance\u0027"},{"line_number":59,"context_line":"DS_URL_PREFIX \u003d \u0027/folder\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_e76023a7","line":56,"in_reply_to":"5a710552_e0bada09","updated":"2016-01-07 08:12:38.000000000","message":"Yup :) - the previous 8KB was to match httplib\u0027s default read size.","commit_id":"77b6f969136ae93ccbd014e03619829d1d494e8b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7c6acbb6c038acad02a93607d95517ff6e1125de","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                                  \u0027content.\u0027) % {\u0027image\u0027: location.image_id})"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    def _query(self, location, method):"},{"line_number":589,"context_line":"        # session \u003d new_session(total_retries\u003dself.api_retry_count)"},{"line_number":590,"context_line":"        session \u003d new_session(self.api_insecure)"},{"line_number":591,"context_line":"        loc \u003d location.store_location"},{"line_number":592,"context_line":"        redirects_followed \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_e0517ad9","line":589,"updated":"2015-12-16 12:29:52.000000000","message":"Perhaps we can remove this comment","commit_id":"77b6f969136ae93ccbd014e03619829d1d494e8b"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"cece8c0d29e545f64fe2bde5855bede61cee8e76","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                                  \u0027content.\u0027) % {\u0027image\u0027: location.image_id})"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    def _query(self, location, method):"},{"line_number":589,"context_line":"        # session \u003d new_session(total_retries\u003dself.api_retry_count)"},{"line_number":590,"context_line":"        session \u003d new_session(self.api_insecure)"},{"line_number":591,"context_line":"        loc \u003d location.store_location"},{"line_number":592,"context_line":"        redirects_followed \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_c7595ffe","line":589,"in_reply_to":"5a710552_e0517ad9","updated":"2016-01-07 08:12:38.000000000","message":"Done","commit_id":"77b6f969136ae93ccbd014e03619829d1d494e8b"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"739808694d708740bc1e2e53de7a7cf43652c268","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":57,"context_line":"MAX_REDIRECTS \u003d 5"},{"line_number":58,"context_line":"DEFAULT_STORE_IMAGE_DIR \u003d \u0027/openstack_glance\u0027"},{"line_number":59,"context_line":"DS_URL_PREFIX \u003d \u0027/folder\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_e86e8295","line":56,"updated":"2016-02-09 14:35:34.000000000","message":"I am wondering if this should be a config option.\nCan it be changed by store users to increase download speed?","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"7b91d438c9ab36d0f97038a608f7173c76c4064c","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":57,"context_line":"MAX_REDIRECTS \u003d 5"},{"line_number":58,"context_line":"DEFAULT_STORE_IMAGE_DIR \u003d \u0027/openstack_glance\u0027"},{"line_number":59,"context_line":"DS_URL_PREFIX \u003d \u0027/folder\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_ec1ae016","line":56,"in_reply_to":"3a57f1b5_03e89a0f","updated":"2016-02-15 10:16:01.000000000","message":"Thanks Kairat. But agree with Flavio, let\u0027s cutover first.","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"6837b4c4060e22f1ca207bbde7601a7af4a5c22c","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":57,"context_line":"MAX_REDIRECTS \u003d 5"},{"line_number":58,"context_line":"DEFAULT_STORE_IMAGE_DIR \u003d \u0027/openstack_glance\u0027"},{"line_number":59,"context_line":"DS_URL_PREFIX \u003d \u0027/folder\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_03e89a0f","line":56,"in_reply_to":"5a5ae5dd_e86e8295","updated":"2016-02-10 14:29:14.000000000","message":"I\u0027d rather not add other config options, tbh. We might need it in the future but let\u0027s wait for this to land and see what the feedback is.","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"739808694d708740bc1e2e53de7a7cf43652c268","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \u0027selected.\u0027))]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"def http_response_iterator(conn, response, size):"},{"line_number":127,"context_line":"    \"\"\"Return an iterator for a file-like object."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param conn: HTTP(S) Connection"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_a8540a21","line":126,"updated":"2016-02-09 14:35:34.000000000","message":"Not related to the change but it looks like full copy of iterator for http driver.","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"7b91d438c9ab36d0f97038a608f7173c76c4064c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \u0027selected.\u0027))]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"def http_response_iterator(conn, response, size):"},{"line_number":127,"context_line":"    \"\"\"Return an iterator for a file-like object."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param conn: HTTP(S) Connection"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_e49be8c7","line":126,"in_reply_to":"5a5ae5dd_a8540a21","updated":"2016-02-15 10:16:01.000000000","message":"Yup, in fact a lot of these things are common for both stores. I even considered extending the HTTP store for VMware but it will involve a lot of code changes.","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"739808694d708740bc1e2e53de7a7cf43652c268","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        vmware store."},{"line_number":244,"context_line":"        \"\"\""},{"line_number":245,"context_line":"        parsed_url \u003d urlparse.urlparse(self.get_uri())"},{"line_number":246,"context_line":"        https_url \u003d parsed_url._replace(scheme\u003d\u0027https\u0027)"},{"line_number":247,"context_line":"        return urlparse.urlunparse(https_url)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_48879612","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":17},"updated":"2016-02-09 14:35:34.000000000","message":"usually it is not good idea to have variables with the same name as function\u003d). Could you please rename it?","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"82d28eaeb3b4bd31ace7d7280a9a47955366bdab","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        vmware store."},{"line_number":244,"context_line":"        \"\"\""},{"line_number":245,"context_line":"        parsed_url \u003d urlparse.urlparse(self.get_uri())"},{"line_number":246,"context_line":"        https_url \u003d parsed_url._replace(scheme\u003d\u0027https\u0027)"},{"line_number":247,"context_line":"        return urlparse.urlunparse(https_url)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_2e7d7d1c","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":17},"in_reply_to":"3a57f1b5_236a7681","updated":"2016-02-10 14:44:03.000000000","message":"Yep, it is just not easy to read sometimes. So it is just nice to have\u003d).","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"7b91d438c9ab36d0f97038a608f7173c76c4064c","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        vmware store."},{"line_number":244,"context_line":"        \"\"\""},{"line_number":245,"context_line":"        parsed_url \u003d urlparse.urlparse(self.get_uri())"},{"line_number":246,"context_line":"        https_url \u003d parsed_url._replace(scheme\u003d\u0027https\u0027)"},{"line_number":247,"context_line":"        return urlparse.urlunparse(https_url)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_0f2d1146","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":17},"in_reply_to":"3a57f1b5_2e7d7d1c","updated":"2016-02-15 10:16:01.000000000","message":"Thanks guys, at some point I think I renamed the method without looking through :).","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"7b91d438c9ab36d0f97038a608f7173c76c4064c","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        vmware store."},{"line_number":244,"context_line":"        \"\"\""},{"line_number":245,"context_line":"        parsed_url \u003d urlparse.urlparse(self.get_uri())"},{"line_number":246,"context_line":"        https_url \u003d parsed_url._replace(scheme\u003d\u0027https\u0027)"},{"line_number":247,"context_line":"        return urlparse.urlunparse(https_url)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_cce27c9f","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":17},"in_reply_to":"5a5ae5dd_48879612","updated":"2016-02-15 10:16:01.000000000","message":"Done","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"6837b4c4060e22f1ca207bbde7601a7af4a5c22c","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        vmware store."},{"line_number":244,"context_line":"        \"\"\""},{"line_number":245,"context_line":"        parsed_url \u003d urlparse.urlparse(self.get_uri())"},{"line_number":246,"context_line":"        https_url \u003d parsed_url._replace(scheme\u003d\u0027https\u0027)"},{"line_number":247,"context_line":"        return urlparse.urlunparse(https_url)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_236a7681","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":17},"in_reply_to":"5a5ae5dd_48879612","updated":"2016-02-10 14:29:14.000000000","message":"to be fair, it\u0027s a method and this variable won\u0027t overload it. :P","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"739808694d708740bc1e2e53de7a7cf43652c268","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        :param location: `glance_store.location.Location` object, supplied"},{"line_number":559,"context_line":"                        from glance_store.location.get_location_from_uri()"},{"line_number":560,"context_line":"        \"\"\""},{"line_number":561,"context_line":"        return self._query(location, \u0027HEAD\u0027)[2]"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    @capabilities.check"},{"line_number":564,"context_line":"    def delete(self, location, context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_6b036c0e","line":561,"range":{"start_line":561,"start_character":22,"end_line":561,"end_character":23},"updated":"2016-02-09 14:35:34.000000000","message":"Looks like HEAD requests won\u0027t be closed because of stream\u003dTrue.","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"7b91d438c9ab36d0f97038a608f7173c76c4064c","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        :param location: `glance_store.location.Location` object, supplied"},{"line_number":559,"context_line":"                        from glance_store.location.get_location_from_uri()"},{"line_number":560,"context_line":"        \"\"\""},{"line_number":561,"context_line":"        return self._query(location, \u0027HEAD\u0027)[2]"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    @capabilities.check"},{"line_number":564,"context_line":"    def delete(self, location, context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_cc1d5cbf","line":561,"range":{"start_line":561,"start_character":22,"end_line":561,"end_character":23},"in_reply_to":"5a5ae5dd_6b036c0e","updated":"2016-02-15 10:16:01.000000000","message":"Done","commit_id":"b5641e10ca3171e5b336acf10790d53be120eeb6"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"eb34c7ee6d0328223f3876e2962ecdc2e7d55052","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from oslo_utils import excutils"},{"line_number":24,"context_line":"from oslo_utils import netutils"},{"line_number":25,"context_line":"from oslo_utils import units"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    from oslo_vmware import api"},{"line_number":29,"context_line":"    import oslo_vmware.exceptions as vexc"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_a63a0797","line":26,"updated":"2016-02-18 08:12:39.000000000","message":"Is it related to change?\u003d) Not reason for -1.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"6f80d1ba4dc001e4dae62d891b1f6e531a44de38","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from oslo_utils import excutils"},{"line_number":24,"context_line":"from oslo_utils import netutils"},{"line_number":25,"context_line":"from oslo_utils import units"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    from oslo_vmware import api"},{"line_number":29,"context_line":"    import oslo_vmware.exceptions as vexc"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_aac73063","line":26,"in_reply_to":"dae33548_a63a0797","updated":"2016-02-25 07:09:08.000000000","message":"creeped in somehow :D. I removed it.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"eb34c7ee6d0328223f3876e2962ecdc2e7d55052","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    while chunk:"},{"line_number":166,"context_line":"        chunk \u003d data.read(CHUNKSIZE)"},{"line_number":167,"context_line":"        if chunk \u003d\u003d \u0027\u0027:"},{"line_number":168,"context_line":"            break"},{"line_number":169,"context_line":"        yield chunk"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_468e9bd0","line":168,"updated":"2016-02-18 08:12:39.000000000","message":"Not reason for -1, but it can be a bit simplified.\nif chunk !\u003d \u0027\u0027:\n   yield chunk\nor\nif chunk:\n   yield chunk","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"6f80d1ba4dc001e4dae62d891b1f6e531a44de38","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    while chunk:"},{"line_number":166,"context_line":"        chunk \u003d data.read(CHUNKSIZE)"},{"line_number":167,"context_line":"        if chunk \u003d\u003d \u0027\u0027:"},{"line_number":168,"context_line":"            break"},{"line_number":169,"context_line":"        yield chunk"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_261070a8","line":168,"in_reply_to":"dae33548_468e9bd0","updated":"2016-02-25 07:09:08.000000000","message":"I used glance.common.utils.chunkiter() instead :)","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"eb34c7ee6d0328223f3876e2962ecdc2e7d55052","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        param_list \u003d {\u0027dsName\u0027: self.datstore_name}"},{"line_number":193,"context_line":"        if self.datacenter_path:"},{"line_number":194,"context_line":"            param_list[\u0027dcPath\u0027] \u003d self.datacenter_path"},{"line_number":195,"context_line":"        self.query \u003d urllib.parse.urlencode(param_list)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def get_uri(self):"},{"line_number":198,"context_line":"        if netutils.is_valid_ipv6(self.server_host):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_46bfbba9","line":195,"updated":"2016-02-18 08:12:39.000000000","message":"It would be perfect to change this to urlparse instead of urllib.parse but nevermind\u003d). It is quite optional and perhaps it just my bikesheding","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"6f80d1ba4dc001e4dae62d891b1f6e531a44de38","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        param_list \u003d {\u0027dsName\u0027: self.datstore_name}"},{"line_number":193,"context_line":"        if self.datacenter_path:"},{"line_number":194,"context_line":"            param_list[\u0027dcPath\u0027] \u003d self.datacenter_path"},{"line_number":195,"context_line":"        self.query \u003d urllib.parse.urlencode(param_list)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def get_uri(self):"},{"line_number":198,"context_line":"        if netutils.is_valid_ipv6(self.server_host):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_e6f1686c","line":195,"in_reply_to":"bae84128_9f456844","updated":"2016-02-25 07:09:08.000000000","message":"Thanks!","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"0ca115205379544bb572b148a8d785656ab7f020","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        param_list \u003d {\u0027dsName\u0027: self.datstore_name}"},{"line_number":193,"context_line":"        if self.datacenter_path:"},{"line_number":194,"context_line":"            param_list[\u0027dcPath\u0027] \u003d self.datacenter_path"},{"line_number":195,"context_line":"        self.query \u003d urllib.parse.urlencode(param_list)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def get_uri(self):"},{"line_number":198,"context_line":"        if netutils.is_valid_ipv6(self.server_host):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_9f456844","line":195,"in_reply_to":"bae84128_b9a87a21","updated":"2016-02-24 13:19:07.000000000","message":"Yep, definitely we can re-factor it later.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e4d0c46385b8758e026d5ead31bcb8ca521db493","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        param_list \u003d {\u0027dsName\u0027: self.datstore_name}"},{"line_number":193,"context_line":"        if self.datacenter_path:"},{"line_number":194,"context_line":"            param_list[\u0027dcPath\u0027] \u003d self.datacenter_path"},{"line_number":195,"context_line":"        self.query \u003d urllib.parse.urlencode(param_list)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def get_uri(self):"},{"line_number":198,"context_line":"        if netutils.is_valid_ipv6(self.server_host):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_b9a87a21","line":195,"in_reply_to":"dae33548_46bfbba9","updated":"2016-02-23 19:14:25.000000000","message":"Sounds like a good candidate for a follow-up patch.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"eb34c7ee6d0328223f3876e2962ecdc2e7d55052","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        ds \u003d self.select_datastore(image_size)"},{"line_number":470,"context_line":"        image_file \u003d _Reader(image_file, verifier)"},{"line_number":471,"context_line":"        headers \u003d {}"},{"line_number":472,"context_line":"        if image_size \u003e 0:"},{"line_number":473,"context_line":"            headers \u003d {\u0027Content-Length\u0027: image_size}"},{"line_number":474,"context_line":"            data \u003d image_file"},{"line_number":475,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_01947d40","line":472,"updated":"2016-02-18 08:12:39.000000000","message":"Looks like uploading 100 Gb images will take one big chunk. Is it ok for VMware. It is not related to change I know, perhaps we need a bug about that. \nI am personally prefer to fix it here.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"0ca115205379544bb572b148a8d785656ab7f020","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        ds \u003d self.select_datastore(image_size)"},{"line_number":470,"context_line":"        image_file \u003d _Reader(image_file, verifier)"},{"line_number":471,"context_line":"        headers \u003d {}"},{"line_number":472,"context_line":"        if image_size \u003e 0:"},{"line_number":473,"context_line":"            headers \u003d {\u0027Content-Length\u0027: image_size}"},{"line_number":474,"context_line":"            data \u003d image_file"},{"line_number":475,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_1f7038a3","line":472,"in_reply_to":"bae84128_792712ca","updated":"2016-02-24 13:19:07.000000000","message":"Agree","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"a8981cd15c1248e8860845cfdc21190b2ba7eb84","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        ds \u003d self.select_datastore(image_size)"},{"line_number":470,"context_line":"        image_file \u003d _Reader(image_file, verifier)"},{"line_number":471,"context_line":"        headers \u003d {}"},{"line_number":472,"context_line":"        if image_size \u003e 0:"},{"line_number":473,"context_line":"            headers \u003d {\u0027Content-Length\u0027: image_size}"},{"line_number":474,"context_line":"            data \u003d image_file"},{"line_number":475,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_029c2a68","line":472,"in_reply_to":"bae84128_9d76f404","updated":"2016-02-25 07:23:39.000000000","message":"Ok, thanks.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"6f80d1ba4dc001e4dae62d891b1f6e531a44de38","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        ds \u003d self.select_datastore(image_size)"},{"line_number":470,"context_line":"        image_file \u003d _Reader(image_file, verifier)"},{"line_number":471,"context_line":"        headers \u003d {}"},{"line_number":472,"context_line":"        if image_size \u003e 0:"},{"line_number":473,"context_line":"            headers \u003d {\u0027Content-Length\u0027: image_size}"},{"line_number":474,"context_line":"            data \u003d image_file"},{"line_number":475,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_9d76f404","line":472,"in_reply_to":"dae33548_01947d40","updated":"2016-02-25 07:09:08.000000000","message":"@Kairat: Not really, we are providing a file-like obj to requests which is then passed over to urllib3/httplib. httplib makes requests with blocksizes of 8192 bytes. So definitely not done in one chunk.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e4d0c46385b8758e026d5ead31bcb8ca521db493","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        ds \u003d self.select_datastore(image_size)"},{"line_number":470,"context_line":"        image_file \u003d _Reader(image_file, verifier)"},{"line_number":471,"context_line":"        headers \u003d {}"},{"line_number":472,"context_line":"        if image_size \u003e 0:"},{"line_number":473,"context_line":"            headers \u003d {\u0027Content-Length\u0027: image_size}"},{"line_number":474,"context_line":"            data \u003d image_file"},{"line_number":475,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_792712ca","line":472,"in_reply_to":"dae33548_01947d40","updated":"2016-02-23 19:14:25.000000000","message":"Let\u0027s do it in a follow-up patch. We\u0027re too close to FF","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"eb34c7ee6d0328223f3876e2962ecdc2e7d55052","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        image_file \u003d _Reader(image_file, verifier)"},{"line_number":471,"context_line":"        headers \u003d {}"},{"line_number":472,"context_line":"        if image_size \u003e 0:"},{"line_number":473,"context_line":"            headers \u003d {\u0027Content-Length\u0027: image_size}"},{"line_number":474,"context_line":"            data \u003d image_file"},{"line_number":475,"context_line":"        else:"},{"line_number":476,"context_line":"            data \u003d _chunk_data(image_file)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_e198796c","line":473,"updated":"2016-02-18 08:12:39.000000000","message":"headers.update would be a bit safer here in case if somebody will change dictionary name or initialize it with some value.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"6f80d1ba4dc001e4dae62d891b1f6e531a44de38","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        image_file \u003d _Reader(image_file, verifier)"},{"line_number":471,"context_line":"        headers \u003d {}"},{"line_number":472,"context_line":"        if image_size \u003e 0:"},{"line_number":473,"context_line":"            headers \u003d {\u0027Content-Length\u0027: image_size}"},{"line_number":474,"context_line":"            data \u003d image_file"},{"line_number":475,"context_line":"        else:"},{"line_number":476,"context_line":"            data \u003d _chunk_data(image_file)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_06bbac76","line":473,"in_reply_to":"dae33548_e198796c","updated":"2016-02-25 07:09:08.000000000","message":"Done","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"eb34c7ee6d0328223f3876e2962ecdc2e7d55052","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                                              \u0027url\u0027: url,"},{"line_number":505,"context_line":"                                              \u0027e\u0027: e}"},{"line_number":506,"context_line":"            LOG.error(msg)"},{"line_number":507,"context_line":"            raise exceptions.BackendException(msg)"},{"line_number":508,"context_line":"        except Exception:"},{"line_number":509,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":510,"context_line":"                LOG.exception(_LE(\u0027Failed to upload content of image \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_61774902","line":507,"updated":"2016-02-18 08:12:39.000000000","message":"So we are generating common Backend exception in any case. Can errors like StoreFull exception or WriteDenied be raised by VMware store?","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"6f80d1ba4dc001e4dae62d891b1f6e531a44de38","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                                              \u0027url\u0027: url,"},{"line_number":505,"context_line":"                                              \u0027e\u0027: e}"},{"line_number":506,"context_line":"            LOG.error(msg)"},{"line_number":507,"context_line":"            raise exceptions.BackendException(msg)"},{"line_number":508,"context_line":"        except Exception:"},{"line_number":509,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":510,"context_line":"                LOG.exception(_LE(\u0027Failed to upload content of image \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_2aa4c006","line":507,"in_reply_to":"dae33548_61774902","updated":"2016-02-25 07:09:08.000000000","message":"We do check before storing the image in select_datastore (L414). Of course, if this happens while the write is in-progress, the backend just terminates the connection, so can\u0027t raise a more specific exception.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"eb34c7ee6d0328223f3876e2962ecdc2e7d55052","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                              % {\u0027path\u0027: loc.path, \u0027status\u0027: resp.status})"},{"line_number":622,"context_line":"                    LOG.info(reason)"},{"line_number":623,"context_line":"                    raise exceptions.BadStoreUri(message\u003dreason)"},{"line_number":624,"context_line":"                conn.close()"},{"line_number":625,"context_line":"                location \u003d self._new_location(location, location_header)"},{"line_number":626,"context_line":"        else:"},{"line_number":627,"context_line":"            # NOTE(sigmavirus24): We exceeded the maximum number of redirects"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_7c6410b8","line":624,"updated":"2016-02-18 08:12:39.000000000","message":"Just curious, is conn.close() idempotent.\nWhat if you have 5 redirects on HEAD or GET request? Can we call conn.close() twice?","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"6f80d1ba4dc001e4dae62d891b1f6e531a44de38","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                              % {\u0027path\u0027: loc.path, \u0027status\u0027: resp.status})"},{"line_number":622,"context_line":"                    LOG.info(reason)"},{"line_number":623,"context_line":"                    raise exceptions.BadStoreUri(message\u003dreason)"},{"line_number":624,"context_line":"                conn.close()"},{"line_number":625,"context_line":"                location \u003d self._new_location(location, location_header)"},{"line_number":626,"context_line":"        else:"},{"line_number":627,"context_line":"            # NOTE(sigmavirus24): We exceeded the maximum number of redirects"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_4af5c4c9","line":624,"in_reply_to":"dae33548_7c6410b8","updated":"2016-02-25 07:09:08.000000000","message":"Yeah, it is. https://github.com/kennethreitz/requests/blob/046a0f215de3fac60326ea1c2c9dd30beb329f61/requests/packages/urllib3/response.py#L152","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"eb34c7ee6d0328223f3876e2962ecdc2e7d55052","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        store_class \u003d old_location.store_location.__class__"},{"line_number":665,"context_line":"        image_id \u003d old_location.image_id"},{"line_number":666,"context_line":"        store_specs \u003d old_location.store_specs"},{"line_number":667,"context_line":"        return glance_store.location.Location(store_name,"},{"line_number":668,"context_line":"                                              store_class,"},{"line_number":669,"context_line":"                                              uri\u003durl,"},{"line_number":670,"context_line":"                                              image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_7cbc10bb","line":667,"updated":"2016-02-18 08:12:39.000000000","message":"Why not vmware location?\u003d)\nWe would have redundant init call in case of common location.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"92a26841a41b22a48ad6525c246d1787c48fbe1e","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        store_class \u003d old_location.store_location.__class__"},{"line_number":665,"context_line":"        image_id \u003d old_location.image_id"},{"line_number":666,"context_line":"        store_specs \u003d old_location.store_specs"},{"line_number":667,"context_line":"        return glance_store.location.Location(store_name,"},{"line_number":668,"context_line":"                                              store_class,"},{"line_number":669,"context_line":"                                              uri\u003durl,"},{"line_number":670,"context_line":"                                              image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_622a56e9","line":667,"in_reply_to":"bae84128_62a096a6","updated":"2016-02-25 07:28:42.000000000","message":"am with you on the naming :). Lets remember that when we do the store API refactor.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"a8981cd15c1248e8860845cfdc21190b2ba7eb84","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        store_class \u003d old_location.store_location.__class__"},{"line_number":665,"context_line":"        image_id \u003d old_location.image_id"},{"line_number":666,"context_line":"        store_specs \u003d old_location.store_specs"},{"line_number":667,"context_line":"        return glance_store.location.Location(store_name,"},{"line_number":668,"context_line":"                                              store_class,"},{"line_number":669,"context_line":"                                              uri\u003durl,"},{"line_number":670,"context_line":"                                              image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_62a096a6","line":667,"in_reply_to":"bae84128_82f79af4","updated":"2016-02-25 07:23:39.000000000","message":"Oh, I am really sorry, I was thinking about StoreLocation here. Yes, you are right. Looks like it is not good idea to introduce entities with similar names in one module but nevermind. It is my fault.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"db8ab1804a7d11cdeb8ab25de158bf9ef87ae89c","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        store_class \u003d old_location.store_location.__class__"},{"line_number":665,"context_line":"        image_id \u003d old_location.image_id"},{"line_number":666,"context_line":"        store_specs \u003d old_location.store_specs"},{"line_number":667,"context_line":"        return glance_store.location.Location(store_name,"},{"line_number":668,"context_line":"                                              store_class,"},{"line_number":669,"context_line":"                                              uri\u003durl,"},{"line_number":670,"context_line":"                                              image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_82f79af4","line":667,"in_reply_to":"bae84128_b5a66851","updated":"2016-02-25 07:14:48.000000000","message":"+ Added some tests for the redirect logic as it was completely missing. \n\nI made a note above to remove the redirect logic as its not needed by the store. We should remove all this redirection handling in Newton.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"6f80d1ba4dc001e4dae62d891b1f6e531a44de38","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        store_class \u003d old_location.store_location.__class__"},{"line_number":665,"context_line":"        image_id \u003d old_location.image_id"},{"line_number":666,"context_line":"        store_specs \u003d old_location.store_specs"},{"line_number":667,"context_line":"        return glance_store.location.Location(store_name,"},{"line_number":668,"context_line":"                                              store_class,"},{"line_number":669,"context_line":"                                              uri\u003durl,"},{"line_number":670,"context_line":"                                              image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_b5a66851","line":667,"in_reply_to":"dae33548_7cbc10bb","updated":"2016-02-25 07:09:08.000000000","message":"I am not sure if I follow you 100% here. Let me try to reply based on my understanding.\n\nBut the reason for not returning a StoreLocation object is because a StoreLocation class can only be initialized with store specs and not with a uri.","commit_id":"a067ac21f82434b55231d726e5fcad41bd460922"}],"glance_store/tests/unit/test_vmware_store.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"383e557bbc496380566560e3760a29be39d61df3","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        self.assertEqual(expected_checksum, reader.checksum.hexdigest())"},{"line_number":321,"context_line":"        self.assertEqual(1, reader.size)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_reader_with_verifier(self):"},{"line_number":324,"context_line":"        content \u003d b\u0027XXX\u0027"},{"line_number":325,"context_line":"        image \u003d six.BytesIO(content)"},{"line_number":326,"context_line":"        verifier \u003d mock.MagicMock(name\u003d\u0027mock_verifier\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_e2cb3aa2","side":"PARENT","line":323,"range":{"start_line":323,"start_character":4,"end_line":323,"end_character":40},"updated":"2016-01-25 23:30:33.000000000","message":"Why is this verifier test case removed?","commit_id":"9683e3bedeb0c33842add19e2334104044426dfe"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"8a8e6a2f8bcb9099912d94e089ce46fc2ca1b271","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        self.assertEqual(expected_checksum, reader.checksum.hexdigest())"},{"line_number":321,"context_line":"        self.assertEqual(1, reader.size)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_reader_with_verifier(self):"},{"line_number":324,"context_line":"        content \u003d b\u0027XXX\u0027"},{"line_number":325,"context_line":"        image \u003d six.BytesIO(content)"},{"line_number":326,"context_line":"        verifier \u003d mock.MagicMock(name\u003d\u0027mock_verifier\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_b607c316","side":"PARENT","line":323,"range":{"start_line":323,"start_character":4,"end_line":323,"end_character":40},"in_reply_to":"9a68dd71_e2cb3aa2","updated":"2016-01-25 23:41:43.000000000","message":"Thanks, good catch!!\n\nI was just removing the ChunkReader tests :)","commit_id":"9683e3bedeb0c33842add19e2334104044426dfe"}]}
