)]}'
{"glance_store/_drivers/rbd.py":[{"author":{"_account_id":1107,"name":"Josh Durgin","email":"jdurgin@redhat.com","username":"jdurgin"},"change_message_id":"d11363fe5d068358feb868f6a656daa908a88eb8","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            features \u003d conn.conf_get(\u0027rbd_default_features\u0027)"},{"line_number":259,"context_line":"            if ((features is None) or (int(features) \u003d\u003d 0)):"},{"line_number":260,"context_line":"                features \u003d rbd.RBD_FEATURE_LAYERING"},{"line_number":261,"context_line":"            return int(features)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def _create_image(self, fsid, ioctx, image_name,"},{"line_number":264,"context_line":"                      size, order, context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_aa96b93c","line":261,"updated":"2015-05-19 17:43:53.000000000","message":"Since this is just used in one place, I\u0027d suggest putting it inline in _create_image(), and using the existing rados connection (you\u0027ll need to pass it in from the caller) as well.","commit_id":"c4224bb96377a213f0442ee2ebebe50aeea05f73"},{"author":{"_account_id":1107,"name":"Josh Durgin","email":"jdurgin@redhat.com","username":"jdurgin"},"change_message_id":"d11363fe5d068358feb868f6a656daa908a88eb8","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        :retval `glance_store.rbd.StoreLocation` object"},{"line_number":273,"context_line":"        \"\"\""},{"line_number":274,"context_line":"        librbd \u003d rbd.RBD()"},{"line_number":275,"context_line":"        if hasattr(rbd, \u0027features\u0027):"},{"line_number":276,"context_line":"            librbd.create(ioctx, image_name, size, order, old_format\u003dFalse,"},{"line_number":277,"context_line":"                          features\u003dself.features)"},{"line_number":278,"context_line":"            return StoreLocation({"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_6ab321ea","line":275,"updated":"2015-05-19 17:43:53.000000000","message":"Layering has been supported since ceph\u0027s bobtail release, which is too old for anyone to run anymore. So we can get rid of this conditional and the else block.","commit_id":"c4224bb96377a213f0442ee2ebebe50aeea05f73"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"651b6b344c3c696d0ae58a0cc449b16bbb34a161","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright 2010-2011 Josh Durgin"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_277ab7bd","line":1,"updated":"2015-06-01 14:03:03.000000000","message":"addition not needed","commit_id":"8aaab768c638e115da362e65b6d7dc312167a849"},{"author":{"_account_id":16412,"name":"Vikhyat Umrao","email":"vumrao@redhat.com","username":"vikhyat"},"change_message_id":"cca022afbcfb4b0d6daf963ea1f11aa000d6f132","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright 2010-2011 Josh Durgin"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_82e279d3","line":1,"in_reply_to":"7a016987_277ab7bd","updated":"2015-06-01 14:16:22.000000000","message":"Sorry , sure I will remove this.","commit_id":"8aaab768c638e115da362e65b6d7dc312167a849"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"651b6b344c3c696d0ae58a0cc449b16bbb34a161","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        features \u003d conn.conf_get(\u0027rbd_default_features\u0027)"},{"line_number":267,"context_line":"        if ((features is None) or (int(features) \u003d\u003d 0)):"},{"line_number":268,"context_line":"            features \u003d rbd.RBD_FEATURE_LAYERING"},{"line_number":269,"context_line":"        librbd.create(ioctx, image_name, size, order, old_format\u003dFalse,"},{"line_number":270,"context_line":"                      features\u003dfeatures)"},{"line_number":271,"context_line":"        return StoreLocation({"},{"line_number":272,"context_line":"            \u0027fsid\u0027: fsid,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_e756df28","line":269,"updated":"2015-06-01 14:03:03.000000000","message":"This change supports just `old_format\u003dFalse`. Does this break any compatibility with existing deployments?","commit_id":"8aaab768c638e115da362e65b6d7dc312167a849"},{"author":{"_account_id":16412,"name":"Vikhyat Umrao","email":"vumrao@redhat.com","username":"vikhyat"},"change_message_id":"91196fca35871f70bb2d26a4c0fdb402683803c8","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        features \u003d conn.conf_get(\u0027rbd_default_features\u0027)"},{"line_number":267,"context_line":"        if ((features is None) or (int(features) \u003d\u003d 0)):"},{"line_number":268,"context_line":"            features \u003d rbd.RBD_FEATURE_LAYERING"},{"line_number":269,"context_line":"        librbd.create(ioctx, image_name, size, order, old_format\u003dFalse,"},{"line_number":270,"context_line":"                      features\u003dfeatures)"},{"line_number":271,"context_line":"        return StoreLocation({"},{"line_number":272,"context_line":"            \u0027fsid\u0027: fsid,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_c213d1ff","line":269,"in_reply_to":"7a016987_e756df28","updated":"2015-06-01 14:11:21.000000000","message":"Hi Flavio,\n\nI and Josh discussed about this and the reason we removed the handling of old_format because it\u0027s no longer needed since no one runs pre-bobtail ceph releases and old_format is for pre-bobtail ceph releases.\nNow it is very very old that It is not listed here also : http://ceph.com/docs/master/releases/\n\nRegards,\nVikhyat","commit_id":"8aaab768c638e115da362e65b6d7dc312167a849"}]}