)]}'
{"glance_store/_drivers/s3.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f7ad9f5090640e306a83acf6302880983f1dc54c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        accesskey \u003d self.accesskey"},{"line_number":176,"context_line":"        secretkey \u003d self.secretkey"},{"line_number":177,"context_line":"        if six.PY3:"},{"line_number":178,"context_line":"            accesskey \u003d accesskey.decode(\u0027utf-8\u0027)"},{"line_number":179,"context_line":"            secretkey \u003d secretkey.decode(\u0027utf-8\u0027)"},{"line_number":180,"context_line":"        return \u0027%s:%s@\u0027 % (accesskey, secretkey)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c8f431f2","line":178,"updated":"2015-06-18 22:30:25.000000000","message":"My only concern is the path when accesskey/secretkey are already unicode. On Python 3.x strings don\u0027t have a decode method. Only str.encode exists.","commit_id":"967c34ad3aa3eedb5e602f20559ca8272b6e39e1"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"007891d34f6057d9ae8cd6cda3308ceb70ce7b7d","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        accesskey \u003d self.accesskey"},{"line_number":176,"context_line":"        secretkey \u003d self.secretkey"},{"line_number":177,"context_line":"        if six.PY3:"},{"line_number":178,"context_line":"            accesskey \u003d accesskey.decode(\u0027utf-8\u0027)"},{"line_number":179,"context_line":"            secretkey \u003d secretkey.decode(\u0027utf-8\u0027)"},{"line_number":180,"context_line":"        return \u0027%s:%s@\u0027 % (accesskey, secretkey)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_79017205","line":178,"in_reply_to":"fa32b979_c8f431f2","updated":"2015-07-02 15:39:06.000000000","message":"I\u0027m not proud of this change. For me, it\u0027s wrong to have to *decode* keys each time that we need to access them. I rewrote my patch to not *encode* keys when the attributes are set.\n\nThe test pass, so it\u0027s good for me. Maybe it\u0027s wrong, but I\u0027m sorry, I\u0027m unable to test the whole Glance application yet with S3. We may have to change some minor things in Glance and glance_store later, when we will be able to run Glance using a real S3 service, instead of unit test which mocks everything (the unit test does maybe not mock the right types on Python 3).","commit_id":"967c34ad3aa3eedb5e602f20559ca8272b6e39e1"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f7ad9f5090640e306a83acf6302880983f1dc54c","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        accesskey \u003d loc.accesskey"},{"line_number":429,"context_line":"        if six.PY3:"},{"line_number":430,"context_line":"            accesskey \u003d accesskey.decode(\u0027utf-8\u0027)"},{"line_number":431,"context_line":"        msg \u003d (\"Retrieved image object from S3 using (s3_host\u003d%(s3_host)s, \""},{"line_number":432,"context_line":"               \"access_key\u003d%(accesskey)s, bucket\u003d%(bucket)s, \""},{"line_number":433,"context_line":"               \"key\u003d%(obj_name)s)\" % ({\u0027s3_host\u0027: loc.s3serviceurl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_68e08529","line":430,"updated":"2015-06-18 22:30:25.000000000","message":"Same concern","commit_id":"967c34ad3aa3eedb5e602f20559ca8272b6e39e1"}]}
