)]}'
{"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4417f02bea68bbf9db24407a1aaae87caadae4b6","unresolved":false,"context_lines":[{"line_number":912,"context_line":"        service_project_name \u003d ("},{"line_number":913,"context_line":"            self.conf.glance_store.swift_store_service_project_name)"},{"line_number":914,"context_line":"        service_key \u003d self.conf.glance_store.swift_store_service_key"},{"line_number":915,"context_line":"        if service_username or service_project_name or service_key:"},{"line_number":916,"context_line":"            if (not service_username or not service_project_name"},{"line_number":917,"context_line":"                    or not service_key):"},{"line_number":918,"context_line":"                reason \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_3309e032","line":915,"updated":"2016-02-25 18:16:35.000000000","message":"I assume the double `if` here and L916 is to avoid conflicts with other work not requiring this configs.","commit_id":"fb2612792076b956da6b27dc83457587b89dd3d4"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4417f02bea68bbf9db24407a1aaae87caadae4b6","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"                os_options[\u0027region_name\u0027] \u003d self.region"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"        return swiftclient.Connection("},{"line_number":1082,"context_line":"            authurl, context.user, None,"},{"line_number":1083,"context_line":"            preauthurl\u003dstorage_url,"},{"line_number":1084,"context_line":"            preauthtoken\u003dcontext.auth_token,"},{"line_number":1085,"context_line":"            tenant_name\u003dcontext.tenant,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_ceed6b90","line":1082,"updated":"2016-02-25 18:16:35.000000000","message":"Can you confirm that passing `context.user` and `context.tenant` every time is harmless? Or better, confirm that it\u0027s not going to change the current behavior.","commit_id":"fb2612792076b956da6b27dc83457587b89dd3d4"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4417f02bea68bbf9db24407a1aaae87caadae4b6","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"            preauthtoken\u003dcontext.auth_token,"},{"line_number":1085,"context_line":"            tenant_name\u003dcontext.tenant,"},{"line_number":1086,"context_line":"            os_options\u003dos_options,"},{"line_number":1087,"context_line":"            auth_version\u003d\u00272\u0027, insecure\u003dself.insecure,"},{"line_number":1088,"context_line":"            ssl_compression\u003dself.ssl_compression,"},{"line_number":1089,"context_line":"            cacert\u003dself.cacert)"},{"line_number":1090,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_2effb735","line":1087,"updated":"2016-02-25 18:16:35.000000000","message":"What are the implications of hard-coding version 2? Could you expand on why this is required?","commit_id":"fb2612792076b956da6b27dc83457587b89dd3d4"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4417f02bea68bbf9db24407a1aaae87caadae4b6","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"            os_options\u003dos_options,"},{"line_number":1087,"context_line":"            auth_version\u003d\u00272\u0027, insecure\u003dself.insecure,"},{"line_number":1088,"context_line":"            ssl_compression\u003dself.ssl_compression,"},{"line_number":1089,"context_line":"            cacert\u003dself.cacert)"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":""},{"line_number":1092,"context_line":"class ChunkReader(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_4e5e7b46","line":1089,"updated":"2016-02-25 18:16:35.000000000","message":"Alternatively, we could pass the arguments you added as keyword arguments and set them just for the service token case to avoid changing the current call:\n\n    kwds \u003d {}\n    if self.service_auth:\n        # Set authurl, user, none, tenant_name, os_options an dauth_version here","commit_id":"fb2612792076b956da6b27dc83457587b89dd3d4"}]}