)]}'
{"glance_store/_drivers/cinder.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"b810fe1b570c447e9752ce8fadb0417d9bc90a6a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cinderclient \u003d None"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":"if cinderclient is None:"},{"line_number":39,"context_line":"    LOG.warn(_LW(\"Try to import cinderclient but failed\"))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_0cb971cb","line":38,"updated":"2015-07-17 22:11:00.000000000","message":"This seems unrelated.","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"fe93fe38d7645fd0e7b5a334555066915cbe405e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cinderclient \u003d None"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":"if cinderclient is None:"},{"line_number":39,"context_line":"    LOG.warn(_LW(\"Try to import cinderclient but failed\"))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_ce7c4173","line":38,"in_reply_to":"9a41bdd9_0cb971cb","updated":"2015-07-29 18:13:45.000000000","message":"Yes and no. It\u0027s fixing the same kind of issue in another location. Could either split it into a separate patch or could update the commit statement to cover fixing the same kind of issue for both cinder and swift store cases.","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"fe93fe38d7645fd0e7b5a334555066915cbe405e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":"if cinderclient is None:"},{"line_number":39,"context_line":"    LOG.warn(_LW(\"Try to import cinderclient but failed\"))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"_CINDER_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_aef0d5fd","line":39,"updated":"2015-07-29 18:13:45.000000000","message":"As someone else commented in one of the other files, this should be done when the store is configured, as the VMware case already appears to do.","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"fb5a39b4cf0436e3bb8f203669048176557d05b3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"_LW \u003d i18n._LW"},{"line_number":47,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":48,"context_line":"if swiftclient is None:"},{"line_number":49,"context_line":"    LOG.warn(_LW(\"Try to import swiftclient but failed\"))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"DEFAULT_CONTAINER \u003d \u0027glance\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_9ace7758","line":49,"updated":"2015-07-29 17:18:45.000000000","message":"Would it be better to warn when the store is configured ? Otherwise, it will unnecessarily show up on the logs :)","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"fe93fe38d7645fd0e7b5a334555066915cbe405e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"_LW \u003d i18n._LW"},{"line_number":47,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":48,"context_line":"if swiftclient is None:"},{"line_number":49,"context_line":"    LOG.warn(_LW(\"Try to import swiftclient but failed\"))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"DEFAULT_CONTAINER \u003d \u0027glance\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_4356ca2a","line":49,"in_reply_to":"3a50d1a3_9ace7758","updated":"2015-07-29 18:13:45.000000000","message":"+1","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"}],"glance_store/_drivers/vmware_datastore.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"b810fe1b570c447e9752ce8fadb0417d9bc90a6a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":51,"context_line":"if api is None:"},{"line_number":52,"context_line":"    LOG.warn(_LW(\"Try to import oslo.vmware but failed\"))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_ecb52dd0","line":51,"updated":"2015-07-17 22:11:00.000000000","message":"Again, unrelated.","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"b02721d1d13056423728ab61bb0437306dc6a021","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":51,"context_line":"if api is None:"},{"line_number":52,"context_line":"    LOG.warn(_LW(\"Try to import oslo.vmware but failed\"))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_1a302755","line":51,"in_reply_to":"3a50d1a3_5abd4faf","updated":"2015-07-29 17:19:43.000000000","message":"@Ian: the comment was not a reply to yours. Sorry :) I meant to comment on the next line.","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6e1f73334cbe90c65f6f6f90fc1f6c9d4cca380b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":51,"context_line":"if api is None:"},{"line_number":52,"context_line":"    LOG.warn(_LW(\"Try to import oslo.vmware but failed\"))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_a08e6b77","line":51,"in_reply_to":"3a50d1a3_5abd4faf","updated":"2015-07-30 17:19:39.000000000","message":"I agree, it seems reduntant to list if stores are configured or not.","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"fb5a39b4cf0436e3bb8f203669048176557d05b3","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":51,"context_line":"if api is None:"},{"line_number":52,"context_line":"    LOG.warn(_LW(\"Try to import oslo.vmware but failed\"))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_5abd4faf","line":51,"in_reply_to":"9a41bdd9_ecb52dd0","updated":"2015-07-29 17:18:45.000000000","message":"check L322. We already warn when the store is configured.\n\nIMO, we do not need to warn when the store is not configured.","commit_id":"a397cf0365c318db861b6c1b9a3e83f5eec087bd"}]}
