)]}'
{"glance_store/_drivers/rbd.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"6699900869e2137961443c3d8057f15e308d937e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    \"\"\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def __init__(self, pool, name, snapshot, store, chunk_size\u003dNone,"},{"line_number":153,"context_line":"                 connect_timeout\u003d-1):"},{"line_number":154,"context_line":"        self.pool \u003d pool or store.pool"},{"line_number":155,"context_line":"        self.name \u003d name"},{"line_number":156,"context_line":"        self.snapshot \u003d snapshot"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_76f6f4fa","line":153,"updated":"2015-07-10 16:11:27.000000000","message":"connect_timeout\u003d0 looks more consistent","commit_id":"cd0e7fa3216a4580bd5f8849799b6faaec509cac"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f0777b68273d51425677b65766d98b368d6cbb02","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"@contextlib.contextmanager"},{"line_number":435,"context_line":"def get_connection(conffile, rados_id, connect_timeout\u003d0):"},{"line_number":436,"context_line":"    client \u003d rados.Rados(conffile\u003dconffile, rados_id\u003drados_id)"},{"line_number":437,"context_line":"    if connect_timeout \u003e 0:"},{"line_number":438,"context_line":"        client.connect(timeout\u003dconnect_timeout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_5e48ad87","line":435,"updated":"2015-07-17 04:11:50.000000000","message":"Minor feedback: This could have also been a method belonging to the store class to avoid passing the connect_timeout everywhere. We anyway pass the store instance to ImageIterator.","commit_id":"2030dfe70b550617d63e1d3f0d2b0fc64624f0cd"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"d52aed62bc41a3dd2dad3a73d77b46f4441d0a13","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"@contextlib.contextmanager"},{"line_number":435,"context_line":"def get_connection(conffile, rados_id, connect_timeout\u003d0):"},{"line_number":436,"context_line":"    client \u003d rados.Rados(conffile\u003dconffile, rados_id\u003drados_id)"},{"line_number":437,"context_line":"    if connect_timeout \u003e 0:"},{"line_number":438,"context_line":"        client.connect(timeout\u003dconnect_timeout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_d7c9e4ad","line":435,"in_reply_to":"9a41bdd9_5e48ad87","updated":"2015-07-17 15:26:43.000000000","message":"Done","commit_id":"2030dfe70b550617d63e1d3f0d2b0fc64624f0cd"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f0777b68273d51425677b65766d98b368d6cbb02","unresolved":false,"context_lines":[{"line_number":434,"context_line":"@contextlib.contextmanager"},{"line_number":435,"context_line":"def get_connection(conffile, rados_id, connect_timeout\u003d0):"},{"line_number":436,"context_line":"    client \u003d rados.Rados(conffile\u003dconffile, rados_id\u003drados_id)"},{"line_number":437,"context_line":"    if connect_timeout \u003e 0:"},{"line_number":438,"context_line":"        client.connect(timeout\u003dconnect_timeout)"},{"line_number":439,"context_line":"    else:"},{"line_number":440,"context_line":"        client.connect()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_befbf946","line":437,"updated":"2015-07-17 04:11:50.000000000","message":"Looks like connect_timeout\u003d0 is the default in librados (correct me if am wrong!). So can we just do :-\n\n client.connect(timeout\u003dconnect_timeout) ?","commit_id":"2030dfe70b550617d63e1d3f0d2b0fc64624f0cd"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"d52aed62bc41a3dd2dad3a73d77b46f4441d0a13","unresolved":false,"context_lines":[{"line_number":434,"context_line":"@contextlib.contextmanager"},{"line_number":435,"context_line":"def get_connection(conffile, rados_id, connect_timeout\u003d0):"},{"line_number":436,"context_line":"    client \u003d rados.Rados(conffile\u003dconffile, rados_id\u003drados_id)"},{"line_number":437,"context_line":"    if connect_timeout \u003e 0:"},{"line_number":438,"context_line":"        client.connect(timeout\u003dconnect_timeout)"},{"line_number":439,"context_line":"    else:"},{"line_number":440,"context_line":"        client.connect()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_ea19a423","line":437,"in_reply_to":"9a41bdd9_befbf946","updated":"2015-07-17 15:26:43.000000000","message":"Done","commit_id":"2030dfe70b550617d63e1d3f0d2b0fc64624f0cd"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"daa57bde0ebbbafc8d1c3623933ff46dbc54d88b","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @contextlib.contextmanager"},{"line_number":194,"context_line":"    def get_connection(self, conffile, rados_id):"},{"line_number":195,"context_line":"        client \u003d rados.Rados(conffile\u003dconffile, rados_id\u003drados_id)"},{"line_number":196,"context_line":"        client.connect(timeout\u003dself.connect_timeout)"},{"line_number":197,"context_line":"        try:"},{"line_number":198,"context_line":"            yield client"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_fa145ba0","line":195,"updated":"2015-07-23 14:59:24.000000000","message":"+1 on this context manager.","commit_id":"b7cc3f1e2483d0172c2a029d185f44b1302eba64"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ddefa314f7bbf6b7a78607be0238628332f3d073","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @contextlib.contextmanager"},{"line_number":194,"context_line":"    def get_connection(self, conffile, rados_id):"},{"line_number":195,"context_line":"        client \u003d rados.Rados(conffile\u003dconffile, rados_id\u003drados_id)"},{"line_number":196,"context_line":"        client.connect(timeout\u003dself.connect_timeout)"},{"line_number":197,"context_line":"        try:"},{"line_number":198,"context_line":"            yield client"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_95c928af","line":195,"in_reply_to":"3a50d1a3_fa145ba0","updated":"2015-07-24 16:28:02.000000000","message":"Why not +2? ;)","commit_id":"b7cc3f1e2483d0172c2a029d185f44b1302eba64"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"ea097533216f4b05cbd10c5e7a8ac677184e39d6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        try:"},{"line_number":198,"context_line":"            client.connect(timeout\u003dself.connect_timeout)"},{"line_number":199,"context_line":"        except rados.Error:"},{"line_number":200,"context_line":"            msg \u003d _(\"Error connecting to ceph cluster.\")"},{"line_number":201,"context_line":"            LOG.exception(msg)"},{"line_number":202,"context_line":"            raise exceptions.BackendException()"},{"line_number":203,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_4d95253e","line":200,"updated":"2015-07-31 19:34:47.000000000","message":"Nit: Please use _LE marker since this message is not user facing.","commit_id":"01a4e42d5e1203d374f78a9e8fa36ff7826fc978"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"cfc32e38122a769249b5a259089a813f7942fb9c","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        try:"},{"line_number":198,"context_line":"            client.connect(timeout\u003dself.connect_timeout)"},{"line_number":199,"context_line":"        except rados.Error:"},{"line_number":200,"context_line":"            msg \u003d _(\"Error connecting to ceph cluster.\")"},{"line_number":201,"context_line":"            LOG.exception(msg)"},{"line_number":202,"context_line":"            raise exceptions.BackendException()"},{"line_number":203,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_663da4ba","line":200,"in_reply_to":"3a50d1a3_4d95253e","updated":"2015-08-11 05:48:39.000000000","message":"Done. Thanks!","commit_id":"01a4e42d5e1203d374f78a9e8fa36ff7826fc978"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"59c3a6ee0f55f8d3c88fc1abc5838a7427538470","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Storage backend for RBD"},{"line_number":17,"context_line":"   (RADOS (Reliable Autonomic Distributed Object Store) Block Device)\"\"\""},{"line_number":18,"context_line":"from __future__ import absolute_import"},{"line_number":19,"context_line":"from __future__ import with_statement"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import hashlib"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_272c3401","side":"PARENT","line":18,"updated":"2015-09-04 20:20:36.000000000","message":"Why remove these?  I\u0027m pretty sure this introduced the gate blocking bug 1492432 in glance-store 0.9.0.\n\nAttempting a fix here: https://review.openstack.org/#/c/220646/","commit_id":"cd04b9217f4581f9d1d6840bc6c3c4c916b330e8"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c427643e90c5e4fdf27344631babaf188ef28ddd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      \u0027If using cephx authentication, this file should \u0027"},{"line_number":68,"context_line":"                      \u0027include a reference to the right keyring \u0027"},{"line_number":69,"context_line":"                      \u0027in a client.\u003cUSER\u003e section\u0027)),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027rados_connect_timeout\u0027, default\u003d0,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Timeout value (in seconds) used when connecting to \u0027"},{"line_number":72,"context_line":"                      \u0027ceph cluster. If value \u003c\u003d 0, no timeout is set and \u0027"},{"line_number":73,"context_line":"                      \u0027default librados value is used.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_3b48588a","line":70,"updated":"2015-08-14 07:01:58.000000000","message":"is this something that can be specified through the ceph.conf file? I\u0027d like to avoid adding new config options if we can rely on ceph\u0027s file","commit_id":"3f5a37cb6e27946da3a5943289d5996fa96a552a"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"f4e8bb3ec97232a2ae19d095bccfb551c759b74c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      \u0027If using cephx authentication, this file should \u0027"},{"line_number":68,"context_line":"                      \u0027include a reference to the right keyring \u0027"},{"line_number":69,"context_line":"                      \u0027in a client.\u003cUSER\u003e section\u0027)),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027rados_connect_timeout\u0027, default\u003d0,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Timeout value (in seconds) used when connecting to \u0027"},{"line_number":72,"context_line":"                      \u0027ceph cluster. If value \u003c\u003d 0, no timeout is set and \u0027"},{"line_number":73,"context_line":"                      \u0027default librados value is used.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_305ffee6","line":70,"in_reply_to":"1a4dcd0f_3b48588a","updated":"2015-08-27 17:25:58.000000000","message":"Flavio, unfortunately I found out that it cannot be configured in ceph.conf, it\u0027s just pybind feature: https://github.com/ceph/ceph/blob/master/src/pybind/rados.py#L189","commit_id":"3f5a37cb6e27946da3a5943289d5996fa96a552a"}]}
