)]}'
{"glance_store/exceptions.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1367b758448fa46563bcf1eaef0dd1bb0b715c7e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"},{"line_number":59,"context_line":"                raise"},{"line_number":60,"context_line":"            else:"},{"line_number":61,"context_line":"                LOG.info(\u0027There was an error while formatting exception \u0027"},{"line_number":62,"context_line":"                         \u0027message\u0027)"},{"line_number":63,"context_line":"        self.msg \u003d message"},{"line_number":64,"context_line":"        super(GlanceStoreException, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_b33910f5","line":61,"updated":"2015-07-16 15:32:26.000000000","message":"LOG.info(_LI( or perhaps LOG.debug","commit_id":"d315f7aaa1446f414c43d8fe30979d568a75eaa1"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"438a0559ff366e708d2760749a6dfec565e6b113","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"},{"line_number":59,"context_line":"                raise"},{"line_number":60,"context_line":"            else:"},{"line_number":61,"context_line":"                LOG.info(\u0027There was an error while formatting exception \u0027"},{"line_number":62,"context_line":"                         \u0027message\u0027)"},{"line_number":63,"context_line":"        self.msg \u003d message"},{"line_number":64,"context_line":"        super(GlanceStoreException, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_74c92e5a","line":61,"in_reply_to":"9a41bdd9_b33910f5","updated":"2015-07-16 16:37:39.000000000","message":"Done, thanks!","commit_id":"d315f7aaa1446f414c43d8fe30979d568a75eaa1"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"c0e2df5d1c306406c6cc3503fb4a69f5521d2773","unresolved":false,"context_lines":[{"line_number":23,"context_line":"_ \u003d i18n._"},{"line_number":24,"context_line":"_LI \u003d i18n._LI"},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":"_FATAL_EXCEPTION_FORMAT_ERRORS \u003d False"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class BackendException(Exception):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_cddaeb78","line":26,"updated":"2015-08-03 19:01:10.000000000","message":"Do we expect the user of the library to change _FATAL_EXCEPTION_FORMAT_ERRORS ? If so, why is it prefixed with _ ? If not, why do we need this ?","commit_id":"393670c8e7e0635e8d255dccf0aba2893bcdcf35"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"85aa6f4b73ae7a95f0308a2f94e6464eabe365e7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    message \u003d \"An unknown store exception occurred\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":53,"context_line":"        if not message:"},{"line_number":54,"context_line":"            message \u003d self.message"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            if kwargs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_4c71b943","line":53,"updated":"2015-07-17 22:10:10.000000000","message":"Do we anticipate anyone doing\n\n    raise SubclassofGlanceStoreException(message\u003d\u0027\u0027)\n\nIf not, could this be:\n\n    if message is not None\n\nTo be a bit more explicit about what we expect?","commit_id":"393670c8e7e0635e8d255dccf0aba2893bcdcf35"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"c0e2df5d1c306406c6cc3503fb4a69f5521d2773","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        if not message:"},{"line_number":54,"context_line":"            message \u003d self.message"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            if kwargs:"},{"line_number":57,"context_line":"                message \u003d message % kwargs"},{"line_number":58,"context_line":"        except Exception:"},{"line_number":59,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_90ef18b0","line":56,"updated":"2015-08-03 19:01:10.000000000","message":"If there is no message but some kwargs, this would run into formatting error. e.g. raise GlanceStoreException(msg\u003d\u0027Failed\u0027). IMO, we don\u0027t need to interpolate kwargs if there is no message.","commit_id":"393670c8e7e0635e8d255dccf0aba2893bcdcf35"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"3ced1ab082109dba2786741c138f189e691bb668","unresolved":false,"context_lines":[{"line_number":23,"context_line":"_ \u003d i18n._"},{"line_number":24,"context_line":"_LI \u003d i18n._LI"},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":"_FATAL_EXCEPTION_FORMAT_ERRORS \u003d False"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class BackendException(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_d5d0d055","line":26,"updated":"2015-10-05 08:16:35.000000000","message":"When is this True ? It\u0027s a private global, which is not changed here.","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"fdb8ee97fcc9632b6be069a414fa389ffa2294b9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"_ \u003d i18n._"},{"line_number":24,"context_line":"_LI \u003d i18n._LI"},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":"_FATAL_EXCEPTION_FORMAT_ERRORS \u003d False"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class BackendException(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_868d8b33","line":26,"in_reply_to":"9a1a9d01_d5d0d055","updated":"2015-10-06 13:07:34.000000000","message":"In \u0027glance\u0027 its used in the tests. It\u0027s not used in glance_store (yet).","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"60d650c3eac0f3a99104159f6140a61d4bcb7c7b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    a \u0027message\u0027 property. That message will get printf\u0027d"},{"line_number":48,"context_line":"    with the keyword arguments provided to the constructor."},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    message \u003d \"An unknown store exception occurred\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":53,"context_line":"        if not message:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_6194e1e7","line":50,"updated":"2015-10-02 10:34:46.000000000","message":"This need to be translated.","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"3ced1ab082109dba2786741c138f189e691bb668","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":53,"context_line":"        if not message:"},{"line_number":54,"context_line":"            message \u003d self.message"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            if kwargs:"},{"line_number":57,"context_line":"                message \u003d message % kwargs"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_f5d3945d","line":54,"updated":"2015-10-05 08:16:35.000000000","message":"Can we have an `else` clause here instead of doing a try/catch below ?","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"60d650c3eac0f3a99104159f6140a61d4bcb7c7b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            if kwargs:"},{"line_number":57,"context_line":"                message \u003d message % kwargs"},{"line_number":58,"context_line":"        except Exception:"},{"line_number":59,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"},{"line_number":60,"context_line":"                raise"},{"line_number":61,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_e188f1c8","line":58,"updated":"2015-10-02 10:34:46.000000000","message":"This confuses me a bit.\nCan we get something except KeyError here?","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"60d650c3eac0f3a99104159f6140a61d4bcb7c7b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"},{"line_number":60,"context_line":"                raise"},{"line_number":61,"context_line":"            else:"},{"line_number":62,"context_line":"                LOG.info(_LI(\u0027There was an error while formatting exception \u0027"},{"line_number":63,"context_line":"                             \u0027message\u0027))"},{"line_number":64,"context_line":"        self.msg \u003d message"},{"line_number":65,"context_line":"        super(GlanceStoreException, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_c1a60d53","line":62,"updated":"2015-10-02 10:34:46.000000000","message":"IMO, we need to post message and kwargs. It allows easily to understand what is problem root cause.","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"3ced1ab082109dba2786741c138f189e691bb668","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            else:"},{"line_number":62,"context_line":"                LOG.info(_LI(\u0027There was an error while formatting exception \u0027"},{"line_number":63,"context_line":"                             \u0027message\u0027))"},{"line_number":64,"context_line":"        self.msg \u003d message"},{"line_number":65,"context_line":"        super(GlanceStoreException, self).__init__(message)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_95ca58a0","line":64,"updated":"2015-10-05 08:16:35.000000000","message":"mmh, we probably don\u0027t need this attribute. do we? We\u0027re passing `message` to the parent class. I honestly don\u0027t know if the attribute is being used elsewhere.","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"fdb8ee97fcc9632b6be069a414fa389ffa2294b9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                LOG.info(_LI(\u0027There was an error while formatting exception \u0027"},{"line_number":63,"context_line":"                             \u0027message\u0027))"},{"line_number":64,"context_line":"        self.msg \u003d message"},{"line_number":65,"context_line":"        super(GlanceStoreException, self).__init__(message)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class MissingCredentialError(GlanceStoreException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_86658b46","line":65,"updated":"2015-10-06 13:07:34.000000000","message":"Here is the equivalent class in \u0027glance\u0027:\n\n class GlanceException(Exception):\n    \"\"\"\n    Base Glance Exception\n\n    To correctly use this class, inherit from it and define\n    a \u0027message\u0027 property. That message will get printf\u0027d\n    with the keyword arguments provided to the constructor.\n    \"\"\"\n    message \u003d _(\"An unknown exception occurred\")\n\n    def __init__(self, message\u003dNone, *args, **kwargs):\n        if not message:\n            message \u003d self.message\n        try:\n            if kwargs:\n                message \u003d message % kwargs\n        except Exception:\n            if _FATAL_EXCEPTION_FORMAT_ERRORS:\n                raise\n            else:\n                # at least get the core message out if something happened\n                pass\n        self.msg \u003d message\n        super(GlanceException, self).__init__(message)\n\nMike has copied this (including its quirks) fairly faithfully.\n\nI think what we have is as good as GlanceException.\n\nRemember, our exception handling is very broken without this. It would be great to get something in in the Liberty timeframe.","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"}],"glance_store/tests/unit/test_exceptions.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"3ced1ab082109dba2786741c138f189e691bb668","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_b5cd1cb9","line":1,"updated":"2015-10-05 08:16:35.000000000","message":"2015*","commit_id":"4985056275f9b988f37cbae0fe6b54b4dd3180e0"}]}
