)]}'
{"glance_store/_drivers/s3.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39f960f7b3e3548f98b374a5c336b2546faff005","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d_(\u0027The number of thread pools to perform a multipart \u0027"},{"line_number":80,"context_line":"                      \u0027upload in S3.\u0027)),"},{"line_number":81,"context_line":"    cfg.BoolOpt(\u0027s3_store_enable_proxy\u0027, default\u003dFalse,"},{"line_number":82,"context_line":"                help\u003d_(\u0027The name of the proxy host to use for connecting\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027s3_store_proxy_host\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Address or hostname for a proxy server.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_b9ed58f1","line":82,"updated":"2015-08-08 17:02:34.000000000","message":"Is this helptext correct? seems to me that this options just enables/disables the proxy","commit_id":"867ea66473cb8e157886c09540e8a8a0341bb6fb"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"67bc81077fcc0c2dc5e57ef73dafb40f985eb9c0","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        s3host, s3port \u003d netutils.parse_host_port(loc.s3serviceurl, 80)"},{"line_number":394,"context_line":"        uformat \u003d self.conf.glance_store.s3_store_bucket_url_format"},{"line_number":395,"context_line":"        calling_format \u003d get_calling_format(s3_store_bucket_url_format\u003duformat)"},{"line_number":396,"context_line":"        proxy \u003d self.conf.glance_store.s3_store_enable_proxy"},{"line_number":397,"context_line":"        proxy_name \u003d self.conf.glance_store.s3_store_proxy_name"},{"line_number":398,"context_line":"        proxy_user \u003d self.conf.glance_store.s3_store_proxy_user"},{"line_number":399,"context_line":"        proxy_pass \u003d self.conf.glance_store.s3_store_proxy_password"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_ffcdfb86","line":396,"updated":"2015-08-09 11:46:21.000000000","message":"use_proxy or enable_proxy will probably be better.","commit_id":"867ea66473cb8e157886c09540e8a8a0341bb6fb"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"67bc81077fcc0c2dc5e57ef73dafb40f985eb9c0","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        proxy_name \u003d self.conf.glance_store.s3_store_proxy_name"},{"line_number":398,"context_line":"        proxy_user \u003d self.conf.glance_store.s3_store_proxy_user"},{"line_number":399,"context_line":"        proxy_pass \u003d self.conf.glance_store.s3_store_proxy_password"},{"line_number":400,"context_line":"        proxy_port \u003d self.conf.glance_store.s3_store_proxy_port"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        if proxy:"},{"line_number":403,"context_line":"            return S3Connection(loc.access_key, loc.secret_key,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_7fa00ba6","line":400,"updated":"2015-08-09 11:46:21.000000000","message":"proxy parameters only relevant for the IF block, can we move them there?","commit_id":"867ea66473cb8e157886c09540e8a8a0341bb6fb"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"67bc81077fcc0c2dc5e57ef73dafb40f985eb9c0","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        proxy_port \u003d self.conf.glance_store.s3_store_proxy_port"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        if proxy:"},{"line_number":403,"context_line":"            return S3Connection(loc.access_key, loc.secret_key,"},{"line_number":404,"context_line":"                                proxy\u003dproxy_name,"},{"line_number":405,"context_line":"                                proxy_port\u003dproxy_port,"},{"line_number":406,"context_line":"                                proxy_user\u003dproxy_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_9fbe37d3","line":403,"updated":"2015-08-09 11:46:21.000000000","message":"I am not familiar with the Glance code base, but in the line 411 I see loc.secretkey and loc.accesskey (without the underscore). Do we have 2 sets of these parameters one with and one without the underscore?","commit_id":"867ea66473cb8e157886c09540e8a8a0341bb6fb"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cc1bde1c627e53744036315185b1bf24b3f65545","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        proxy_port \u003d self.conf.glance_store.s3_store_proxy_port"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        if proxy:"},{"line_number":403,"context_line":"            return S3Connection(loc.access_key, loc.secret_key,"},{"line_number":404,"context_line":"                                proxy\u003dproxy_name,"},{"line_number":405,"context_line":"                                proxy_port\u003dproxy_port,"},{"line_number":406,"context_line":"                                proxy_user\u003dproxy_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_6762a2da","line":403,"in_reply_to":"1a4dcd0f_9fbe37d3","updated":"2015-08-10 14:11:34.000000000","message":"Good catch, it should be without the underscore.","commit_id":"867ea66473cb8e157886c09540e8a8a0341bb6fb"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"a31a793692ca7f37205602fac5c144930f009b78","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        return S3Connection(loc.accesskey, loc.secretkey,"},{"line_number":409,"context_line":"                            host\u003ds3host, port\u003ds3port,"},{"line_number":410,"context_line":"                            is_secure\u003d(loc.scheme \u003d\u003d \u0027s3+https\u0027),"},{"line_number":411,"context_line":"                            calling_format\u003dcalling_format)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @capabilities.check"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_ef6a8480","line":410,"updated":"2015-08-12 17:24:18.000000000","message":"Style nit: I\u0027d rather this be done above, not a blocker though","commit_id":"e3b6d640a9b65f37f0ccd8fcc46022435afbb191"}]}