)]}'
{"glance_store/common/utils.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8f5f763b947f758e9165ca29d81871b0b021c388","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return cooperative_iter(self.fd.__iter__())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"exception_to_str \u003d encodeutils.exception_to_unicode"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_38fdfcb0","line":145,"range":{"start_line":145,"start_character":17,"end_line":145,"end_character":18},"updated":"2016-01-07 09:44:19.000000000","message":"Why couldn\u0027t we completely get rid of exception_to_str?","commit_id":"4e984860d369d9054ad633963cf4d86512996c2e"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a883016fe99e45cc4f5014688da2604a7cfacf9c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return cooperative_iter(self.fd.__iter__())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"exception_to_str \u003d encodeutils.exception_to_unicode"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_75a92124","line":145,"range":{"start_line":145,"start_character":17,"end_line":145,"end_character":18},"in_reply_to":"fa69d971_38fdfcb0","updated":"2016-01-07 19:37:56.000000000","message":"glance_store is a library, not an application. Maybe applications other than Glance use it?\n\nI don\u0027t know how glance_store is used, so I chose to not remove the function.\n\nMaybe we can deprecate it, but I don\u0027t know how functions are deprecated in glance_store...\n\nIt looks like glance_store is mainly used by Glance, and Glance doesn\u0027t use exception_to_str() (but exception_to_unicode). So maybe it\u0027s fine to remove it? What do you think?","commit_id":"4e984860d369d9054ad633963cf4d86512996c2e"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"81be8174289fe94d3f60b4f9ebebd734f6a304ca","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return cooperative_iter(self.fd.__iter__())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"exception_to_str \u003d encodeutils.exception_to_unicode"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_b888f0c7","line":145,"range":{"start_line":145,"start_character":17,"end_line":145,"end_character":18},"in_reply_to":"fa69d971_75a92124","updated":"2016-01-07 20:02:34.000000000","message":"I think it\u0027s safe to remove as glance_store is not used by anything other than glance. Also, the utils is not part of the store api. But I would put a release note just in case.","commit_id":"4e984860d369d9054ad633963cf4d86512996c2e"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"450fad40f6b70f65d617293cd05468cf42e5e929","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return cooperative_iter(self.fd.__iter__())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"exception_to_str \u003d encodeutils.exception_to_unicode"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_c5645b23","line":145,"range":{"start_line":145,"start_character":17,"end_line":145,"end_character":18},"in_reply_to":"fa69d971_b888f0c7","updated":"2016-01-11 08:51:45.000000000","message":"Thank you for your confirmation. I used your comment to justify the removal of the function in my new patch ;-)","commit_id":"4e984860d369d9054ad633963cf4d86512996c2e"}]}