)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"5141e22829c084533d5ca2b346be31a82a2b2a79","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sheepdog: fix upload failure when using API v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The image_size is always 0 since API version 2."},{"line_number":10,"context_line":"We cannot know actual image size until EOF."},{"line_number":11,"context_line":"On-demand resizing resolved this problem."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a68dd71_54929658","line":9,"updated":"2016-01-21 22:38:49.000000000","message":"image_size is not always zero in v2. It is zero when the client is doing a chunked http upload to glance-api e.g. in the case of instance snapshots.\n\nYou may want to change the commit msg saying that you want to fix upload failures during chunked upload.","commit_id":"6d480f7bf17182a1abb64deff93f5db2b9177d80"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"5141e22829c084533d5ca2b346be31a82a2b2a79","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The image_size is always 0 since API version 2."},{"line_number":10,"context_line":"We cannot know actual image size until EOF."},{"line_number":11,"context_line":"On-demand resizing resolved this problem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia8efa4383d0ff1c8701b3ee45aeded3fca8c4339"},{"line_number":14,"context_line":"Signed-off-by: YAMADA Hideki \u003cyamada.hideki@lab.ntt.co.jp\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a68dd71_54161bf2","line":11,"updated":"2016-01-21 22:38:49.000000000","message":"Can you file a bug and reference it here ?\n\nAlso, it would be great if you provide some exception traces or other info regarding the bug.","commit_id":"6d480f7bf17182a1abb64deff93f5db2b9177d80"}],"glance_store/_drivers/sheepdog.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"5141e22829c084533d5ca2b346be31a82a2b2a79","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        Sheepdog Usage: collie vdi write -a address -p port image offset len"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        new_offset \u003d offset + count"},{"line_number":104,"context_line":"        if self.get_size() \u003c new_offset:"},{"line_number":105,"context_line":"            self.resize(new_offset)"},{"line_number":106,"context_line":"        self._run_command(\"write\", data, str(offset), str(count))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_7f58d332","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":35},"updated":"2016-01-21 22:38:49.000000000","message":"Nit: new_size makes more sense than new_offset :D. But up to you.","commit_id":"6d480f7bf17182a1abb64deff93f5db2b9177d80"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"5141e22829c084533d5ca2b346be31a82a2b2a79","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        Sheepdog Usage: collie vdi write -a address -p port image offset len"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        new_offset \u003d offset + count"},{"line_number":104,"context_line":"        if self.get_size() \u003c new_offset:"},{"line_number":105,"context_line":"            self.resize(new_offset)"},{"line_number":106,"context_line":"        self._run_command(\"write\", data, str(offset), str(count))"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_1a48c55a","line":104,"updated":"2016-01-21 22:38:49.000000000","message":"This get_size() will be executed unnecessarily for images foe which we know the size. I suggest we do the resize the image in add() method before we write to it.","commit_id":"6d480f7bf17182a1abb64deff93f5db2b9177d80"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"15bdf783ec910651ebe5690c956319dea9f98b11","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Taobao Inc."},{"line_number":2,"context_line":"# Copyright (C) 2015 Nippon Telegraph and Telephone Corporation."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_8cea19ab","line":2,"updated":"2016-01-22 16:31:38.000000000","message":"2016","commit_id":"0e7e9be5fa16ec0b8564e015f144f50186acabf9"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"15bdf783ec910651ebe5690c956319dea9f98b11","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self._run_command(\"create\", None, str(size))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def resize(self, size):"},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":"        Resize this image in the Sheepdog cluster with size \u0027size\u0027."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        Sheepdog Usage: collie vdi create -a address -p port image size"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_ac2d9dff","line":114,"updated":"2016-01-22 16:31:38.000000000","message":"Docstring should not start with empty line: http://docs.openstack.org/developer/hacking/#docstrings","commit_id":"0e7e9be5fa16ec0b8564e015f144f50186acabf9"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"15bdf783ec910651ebe5690c956319dea9f98b11","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            while True:"},{"line_number":309,"context_line":"                data \u003d image_file.read(self.chunk_size)"},{"line_number":310,"context_line":"                length \u003d len(data)"},{"line_number":311,"context_line":"                if length \u003d\u003d 0:"},{"line_number":312,"context_line":"                    break"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"                new_offset \u003d offset + length"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_6c9d6509","line":311,"updated":"2016-01-22 16:31:38.000000000","message":"I\u0027m really not fond of having \u0027while True:\u0027 loops with exact condition escapes regardless how safe they seem.","commit_id":"0e7e9be5fa16ec0b8564e015f144f50186acabf9"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"a80b0053fb8dd99566c4f65857ecf6262fd4d2d0","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            checksum \u003d hashlib.md5()"},{"line_number":309,"context_line":"            data \u003d image_file.read(self.chunk_size)"},{"line_number":310,"context_line":"            length \u003d len(data)"},{"line_number":311,"context_line":"            while length \u003e 0:"},{"line_number":312,"context_line":"                new_offset \u003d offset + length"},{"line_number":313,"context_line":"                if image_size \u003c new_offset:"},{"line_number":314,"context_line":"                    image_size \u003d new_offset"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_b90a5477","line":311,"updated":"2016-01-26 00:58:04.000000000","message":"I think we can simplify this logic a bit similar to \nhttps://github.com/openstack/glance_store/blob/30ae6b020c9a903d50604d5b66a490dfe6de85b0/glance_store/_drivers/rbd.py#L397\n\n offset \u003d 0\n chunks \u003d utils.chunkreadable(image_file, self.chunk_size)\n for chunk in chunks: \n     chunk_length \u003d len(chunk)\n     if image_size \u003d\u003d 0:\n         #do resize\n     image.write(..)\n     offset +\u003d chunk_length\n\n return (location.get_uri(), offset, checksum.hexdigest(), {})\n\nPlease verify :)","commit_id":"a358269234ca6f14dca7ea7267137db258384c88"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0c0648793fb56e7c106cec44c76610b2271352c2","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                # be slower so setting a higher chunk size may"},{"line_number":316,"context_line":"                # speed things up a bit."},{"line_number":317,"context_line":"                if image_size \u003d\u003d 0:"},{"line_number":318,"context_line":"                    image.resize(offset + chunk_length)"},{"line_number":319,"context_line":"                image.write(chunk, offset, chunk_length)"},{"line_number":320,"context_line":"                offset +\u003d chunk_length"},{"line_number":321,"context_line":"                checksum.update(chunk)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_7e6af5ef","line":318,"updated":"2016-02-05 03:15:03.000000000","message":"This sounds super expensive resource/time wise","commit_id":"563536dc7ca1049d7afd1b0231f51b2ff8d1c98c"},{"author":{"_account_id":15101,"name":"YAMADA Hideki","email":"yamada.hideki@lab.ntt.co.jp","username":"yamada-h"},"change_message_id":"5762fa0d062cad7eb2d1568f25ce8089e9741028","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                # be slower so setting a higher chunk size may"},{"line_number":316,"context_line":"                # speed things up a bit."},{"line_number":317,"context_line":"                if image_size \u003d\u003d 0:"},{"line_number":318,"context_line":"                    image.resize(offset + chunk_length)"},{"line_number":319,"context_line":"                image.write(chunk, offset, chunk_length)"},{"line_number":320,"context_line":"                offset +\u003d chunk_length"},{"line_number":321,"context_line":"                checksum.update(chunk)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_89f53958","line":318,"in_reply_to":"5a5ae5dd_7e6af5ef","updated":"2016-02-05 03:52:41.000000000","message":"It is just a metadata change. So it is not expensive.","commit_id":"563536dc7ca1049d7afd1b0231f51b2ff8d1c98c"}]}
