)]}'
{"glance_store/_drivers/sheepdog.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f8c33f41197937e76cfc67181461f8954956b073","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \"\"\"Class describing an image stored in Sheepdog storage.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, addr, port, name, chunk_size):"},{"line_number":56,"context_line":"        self.addr \u003d str(addr)"},{"line_number":57,"context_line":"        self.port \u003d int(port)"},{"line_number":58,"context_line":"        self.name \u003d str(name)"},{"line_number":59,"context_line":"        self.chunk_size \u003d int(chunk_size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f2e63cb3","line":56,"updated":"2016-01-28 20:12:46.000000000","message":"why do you need this ?","commit_id":"bfc94d1f348852f319bcb398e6bd0be124521f84"},{"author":{"_account_id":15101,"name":"YAMADA Hideki","email":"yamada.hideki@lab.ntt.co.jp","username":"yamada-h"},"change_message_id":"14fec3d1f4b663a3b311aafddff296413854814a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \"\"\"Class describing an image stored in Sheepdog storage.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, addr, port, name, chunk_size):"},{"line_number":56,"context_line":"        self.addr \u003d str(addr)"},{"line_number":57,"context_line":"        self.port \u003d int(port)"},{"line_number":58,"context_line":"        self.name \u003d str(name)"},{"line_number":59,"context_line":"        self.chunk_size \u003d int(chunk_size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_43589232","line":56,"in_reply_to":"7a5de9d1_f2e63cb3","updated":"2016-01-29 05:53:31.000000000","message":"We don\u0027t need this. I\u0027ll remove it.","commit_id":"bfc94d1f348852f319bcb398e6bd0be124521f84"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f8c33f41197937e76cfc67181461f8954956b073","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, addr, port, name, chunk_size):"},{"line_number":56,"context_line":"        self.addr \u003d str(addr)"},{"line_number":57,"context_line":"        self.port \u003d int(port)"},{"line_number":58,"context_line":"        self.name \u003d str(name)"},{"line_number":59,"context_line":"        self.chunk_size \u003d int(chunk_size)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f2c5dc3b","line":57,"updated":"2016-01-28 20:12:46.000000000","message":"Pl fix the type in the location class. See below.","commit_id":"bfc94d1f348852f319bcb398e6bd0be124521f84"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f8c33f41197937e76cfc67181461f8954956b073","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            \u0027port\u0027: self.port,"},{"line_number":150,"context_line":"            \u0027image\u0027: self.image}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def parse_uri(self, uri):"},{"line_number":153,"context_line":"        valid_schema \u003d \u0027sheepdog://\u0027"},{"line_number":154,"context_line":"        if not uri.startswith(valid_schema):"},{"line_number":155,"context_line":"            reason \u003d _(\"URI must start with \u0027%s\u0027\") % valid_schema"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_12ee78ec","line":152,"updated":"2016-01-28 20:12:46.000000000","message":"You must set the right types in the location object.","commit_id":"bfc94d1f348852f319bcb398e6bd0be124521f84"},{"author":{"_account_id":15101,"name":"YAMADA Hideki","email":"yamada.hideki@lab.ntt.co.jp","username":"yamada-h"},"change_message_id":"14fec3d1f4b663a3b311aafddff296413854814a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            \u0027port\u0027: self.port,"},{"line_number":150,"context_line":"            \u0027image\u0027: self.image}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def parse_uri(self, uri):"},{"line_number":153,"context_line":"        valid_schema \u003d \u0027sheepdog://\u0027"},{"line_number":154,"context_line":"        if not uri.startswith(valid_schema):"},{"line_number":155,"context_line":"            reason \u003d _(\"URI must start with \u0027%s\u0027\") % valid_schema"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_233eb6b8","line":152,"in_reply_to":"7a5de9d1_12ee78ec","updated":"2016-01-29 05:53:31.000000000","message":"OK.","commit_id":"bfc94d1f348852f319bcb398e6bd0be124521f84"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"cc1316ab00db3c9ffe3666537f95141d97c11412","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        # This is used for backwards compatibility."},{"line_number":169,"context_line":"        else:"},{"line_number":170,"context_line":"            self.image \u003d pieces[0]"},{"line_number":171,"context_line":"            self.port \u003d self.conf.glance_store.sheepdog_store_port"},{"line_number":172,"context_line":"            self.addr \u003d self.conf.glance_store.sheepdog_store_address"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_bc76953c","line":171,"updated":"2016-02-10 09:59:40.000000000","message":"Thanks for patch. \nAs I can see that\u0027s the only place where we are initializing port for StoreLocation. So the question is:\nwhy do we need there setters and getters(and additional variable _port) if we can simply do\nself.port \u003d int(self.conf.glance_store.sheepdog_store_port)\nIt seems shorter and clearer IMO.","commit_id":"03fab63ae819ded2a1a4fff55684fc1150be7353"},{"author":{"_account_id":15101,"name":"YAMADA Hideki","email":"yamada.hideki@lab.ntt.co.jp","username":"yamada-h"},"change_message_id":"3da2a4ba92980ce5400c7f1a190db65212355635","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        # This is used for backwards compatibility."},{"line_number":169,"context_line":"        else:"},{"line_number":170,"context_line":"            self.image \u003d pieces[0]"},{"line_number":171,"context_line":"            self.port \u003d self.conf.glance_store.sheepdog_store_port"},{"line_number":172,"context_line":"            self.addr \u003d self.conf.glance_store.sheepdog_store_address"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_e9c62d99","line":171,"in_reply_to":"3a57f1b5_bc76953c","updated":"2016-02-11 18:33:51.000000000","message":"Thanks for review! I thought port might be set other place in future. Your suggestion is reasonable for now. I will fix it.","commit_id":"03fab63ae819ded2a1a4fff55684fc1150be7353"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"27c163d5a5f8cd6722336eb810d293e4169cde47","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # This is used for backwards compatibility."},{"line_number":163,"context_line":"        else:"},{"line_number":164,"context_line":"            self.image \u003d pieces[0]"},{"line_number":165,"context_line":"            self.port \u003d int(self.conf.glance_store.sheepdog_store_port)"},{"line_number":166,"context_line":"            self.addr \u003d self.conf.glance_store.sheepdog_store_address"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_a0da7f4a","line":165,"updated":"2016-02-11 22:12:01.000000000","message":"Shouldn\u0027t this be already an integer ? I guess we don\u0027t need this.\n\n cfg.IntOpt(\u0027sheepdog_store_port\u0027","commit_id":"2a5123d81c98128fc7cb33427e4a45376622f1c4"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"610430277eaf4da86ad36af083c840e39f18de40","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # This is used for backwards compatibility."},{"line_number":163,"context_line":"        else:"},{"line_number":164,"context_line":"            self.image \u003d pieces[0]"},{"line_number":165,"context_line":"            self.port \u003d int(self.conf.glance_store.sheepdog_store_port)"},{"line_number":166,"context_line":"            self.addr \u003d self.conf.glance_store.sheepdog_store_address"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_a0383ff0","line":165,"in_reply_to":"3a57f1b5_a0da7f4a","updated":"2016-02-11 22:23:52.000000000","message":"Ooops, I missed that. Nice catch!","commit_id":"2a5123d81c98128fc7cb33427e4a45376622f1c4"}],"glance_store/tests/unit/test_sheepdog_store.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f8c33f41197937e76cfc67181461f8954956b073","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.store.configure()"},{"line_number":65,"context_line":"        self.store_specs \u003d {\u0027image\u0027: \u00276bd59e6e-c410-11e5-ab67-0a73f1fda51b\u0027,"},{"line_number":66,"context_line":"                            \u0027addr\u0027: \u0027127.0.0.1\u0027,"},{"line_number":67,"context_line":"                            \u0027port\u0027: \u00277000\u0027}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_add_image(self):"},{"line_number":70,"context_line":"        called_commands \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_b290c444","line":67,"updated":"2016-01-28 20:12:46.000000000","message":"Nit: This should be int.","commit_id":"bfc94d1f348852f319bcb398e6bd0be124521f84"}]}