)]}'
{"glance_store/_drivers/vmware_datastore.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"3886a08bd62accebf8daf7b756f7d8ee64d67914","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            raise exceptions.BadStoreConfiguration("},{"line_number":300,"context_line":"                store_name\u003d\u0027vmware_datastore\u0027, reason\u003dmsg)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if not (self.conf.glance_store.vmware_datastore_name"},{"line_number":303,"context_line":"                or self.conf.glance_store.vmware_datastores):"},{"line_number":304,"context_line":"            msg \u003d (_(\"Specify at least \u0027vmware_datastore_name\u0027 or \""},{"line_number":305,"context_line":"                     \"\u0027vmware_datastores\u0027 option\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_2ae6dbe8","side":"PARENT","line":302,"updated":"2016-02-02 17:53:49.000000000","message":"can you raise BadStoreConfiguration if vmware_datastores is not defined ?\n\n  if not self.conf.glance_store.vmware_datastores:\n  ... \"Please specify the vmware_datastores option\"","commit_id":"82c8e777b47633dc86d013d626e95486a50e0386"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"14343c9344c41f560306a7b74d6c246095b6823e","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            raise exceptions.BadStoreConfiguration("},{"line_number":300,"context_line":"                store_name\u003d\u0027vmware_datastore\u0027, reason\u003dmsg)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if not (self.conf.glance_store.vmware_datastore_name"},{"line_number":303,"context_line":"                or self.conf.glance_store.vmware_datastores):"},{"line_number":304,"context_line":"            msg \u003d (_(\"Specify at least \u0027vmware_datastore_name\u0027 or \""},{"line_number":305,"context_line":"                     \"\u0027vmware_datastores\u0027 option\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_34e41e3a","side":"PARENT","line":302,"in_reply_to":"5a5ae5dd_ae9d1b5b","updated":"2016-02-03 01:55:12.000000000","message":"I\u0027ll just add to configure_add() then","commit_id":"82c8e777b47633dc86d013d626e95486a50e0386"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"adf31e1978715a4759fb50f5b96a0d05b95d8f67","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            raise exceptions.BadStoreConfiguration("},{"line_number":300,"context_line":"                store_name\u003d\u0027vmware_datastore\u0027, reason\u003dmsg)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if not (self.conf.glance_store.vmware_datastore_name"},{"line_number":303,"context_line":"                or self.conf.glance_store.vmware_datastores):"},{"line_number":304,"context_line":"            msg \u003d (_(\"Specify at least \u0027vmware_datastore_name\u0027 or \""},{"line_number":305,"context_line":"                     \"\u0027vmware_datastores\u0027 option\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_ae9d1b5b","side":"PARENT","line":302,"in_reply_to":"5a5ae5dd_c5edda8f","updated":"2016-02-03 00:58:54.000000000","message":"It;s done inside _option_get().","commit_id":"82c8e777b47633dc86d013d626e95486a50e0386"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"49b100fe15b443828cab8bd3529aedc17332d141","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            raise exceptions.BadStoreConfiguration("},{"line_number":300,"context_line":"                store_name\u003d\u0027vmware_datastore\u0027, reason\u003dmsg)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if not (self.conf.glance_store.vmware_datastore_name"},{"line_number":303,"context_line":"                or self.conf.glance_store.vmware_datastores):"},{"line_number":304,"context_line":"            msg \u003d (_(\"Specify at least \u0027vmware_datastore_name\u0027 or \""},{"line_number":305,"context_line":"                     \"\u0027vmware_datastores\u0027 option\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_c5edda8f","side":"PARENT","line":302,"in_reply_to":"7a5de9d1_2ae6dbe8","updated":"2016-02-02 23:28:09.000000000","message":"We don\u0027t do that for others that are not defined such as vmware_server_host, vmware_server_username, vmware_server_password","commit_id":"82c8e777b47633dc86d013d626e95486a50e0386"}]}