)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"516a302f5cc1cfae586f3ff172f50ff9faa9de7a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change plans to add some functional tests for swift."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Louis Taylor \u003clouis@kragniz.eu\u003e"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1a122d0e_7502770d","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":20},"updated":"2016-05-05 17:01:47.000000000","message":"From the logs it looks like this successfully adds swift tests (rather than plans to)?","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"}],"glance_store/tests/functional/hooks/gate_hook.sh":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4bd7ab2bd2a1ef6803e7bb1f6ba065429780f8de","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# This script is executed inside gate_hook function in devstack gate."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"#GLANCE_STORE_DRIVER\u003d$1"},{"line_number":18,"context_line":"GLANCE_STORE_DRIVER\u003dswift"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ENABLED_SERVICES+\u003d\",key,glance\""}],"source_content_type":"text/x-sh","patch_set":19,"id":"faac7902_9216dca5","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":23},"updated":"2016-05-05 20:21:08.000000000","message":"left over?","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"9d5ab7df15a18e43c7a4b5d56fb06f05c7449b57","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# This script is executed inside gate_hook function in devstack gate."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"#GLANCE_STORE_DRIVER\u003d$1"},{"line_number":18,"context_line":"GLANCE_STORE_DRIVER\u003dswift"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ENABLED_SERVICES+\u003d\",key,glance\""}],"source_content_type":"text/x-sh","patch_set":19,"id":"dab17558_16659944","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":23},"in_reply_to":"faac7902_9216dca5","updated":"2016-05-06 16:23:47.000000000","message":"Expanded on the note a bit more.","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"5ebbd9486930a71224ffcf73a4e05468e9e538dd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# NOTE(NiallBunting) In future these tests should be split up. This means"},{"line_number":18,"context_line":"# based on the store passed to this script in $1, particular services can"},{"line_number":19,"context_line":"# be enabled."},{"line_number":20,"context_line":"GLANCE_STORE_DRIVER\u003dswift"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ENABLED_SERVICES+\u003d\",key,glance\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":22,"id":"dab17558_61cf3d56","line":20,"updated":"2016-05-11 17:53:10.000000000","message":"This should probably be:\n\nGLANCE_STORE_DRIVER\u003d${GLANCE_STORE_DRIVER:-swift}","commit_id":"1e87dfdec82764ee93eda42489e77b47df103f8c"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"c9115afe53147ca147ef8b2298754f3bd92b5c72","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# NOTE(NiallBunting) In future these tests should be split up. This means"},{"line_number":18,"context_line":"# based on the store passed to this script in $1, particular services can"},{"line_number":19,"context_line":"# be enabled."},{"line_number":20,"context_line":"GLANCE_STORE_DRIVER\u003dswift"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ENABLED_SERVICES+\u003d\",key,glance\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":22,"id":"7aa08908_b3f73ef4","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":25},"updated":"2016-06-07 08:29:56.000000000","message":"base.py overrides \u0027default_store\u0027 to tested stores anyway, so it is not actually used.","commit_id":"1e87dfdec82764ee93eda42489e77b47df103f8c"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"15118123ec588ed4b9967955f259bd9837c489b6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# NOTE(NiallBunting) In future these tests should be split up. This means"},{"line_number":18,"context_line":"# based on the store passed to this script in $1, particular services can"},{"line_number":19,"context_line":"# be enabled."},{"line_number":20,"context_line":"GLANCE_STORE_DRIVER\u003dswift"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ENABLED_SERVICES+\u003d\",key,glance\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":22,"id":"dab17558_d035f5a8","line":20,"in_reply_to":"dab17558_61cf3d56","updated":"2016-05-12 09:54:49.000000000","message":"Currently because the way the infra settings are (using test gate-glance_store-dsvm-functional-filesystem), file gets passed in here which will cause swift not to be enabled and therefore cause the swift tests to fail.\n\nOnce this initial patch merges I will work on splitting the two tests part.","commit_id":"1e87dfdec82764ee93eda42489e77b47df103f8c"}],"glance_store/tests/functional/test_functional.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"516a302f5cc1cfae586f3ff172f50ff9faa9de7a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"logging.basicConfig()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SWIFT_CONTAINER \u003d \u0027glance_store_tests\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestFilesystem(base.BaseFunctionalTests):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a122d0e_99ddcd72","line":31,"range":{"start_line":31,"start_character":37,"end_line":31,"end_character":38},"updated":"2016-05-05 17:01:47.000000000","message":"possibly we should create a different container with a uuid each time to avoid collisions with existing containers. We should possibly delete it too, to completely clean up.","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"9d5ab7df15a18e43c7a4b5d56fb06f05c7449b57","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"logging.basicConfig()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SWIFT_CONTAINER \u003d \u0027glance_store_tests\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestFilesystem(base.BaseFunctionalTests):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dab17558_768345cd","line":31,"range":{"start_line":31,"start_character":37,"end_line":31,"end_character":38},"in_reply_to":"1a122d0e_99ddcd72","updated":"2016-05-06 16:23:47.000000000","message":"The container now gets deleted.","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"516a302f5cc1cfae586f3ff172f50ff9faa9de7a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        super(TestFilesystem, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class TestSwiftsystem(base.BaseFunctionalTests):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":54,"context_line":"        super(TestSwiftsystem, self).__init__(\u0027swift\u0027, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a122d0e_b5308f08","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":21},"updated":"2016-05-05 17:01:47.000000000","message":"TestSwiftsystem -\u003e TestSwift? (Filesystem is a store type, Swiftsystem isn\u0027t)","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4bd7ab2bd2a1ef6803e7bb1f6ba065429780f8de","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        super(TestFilesystem, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class TestSwiftsystem(base.BaseFunctionalTests):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":54,"context_line":"        super(TestSwiftsystem, self).__init__(\u0027swift\u0027, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":19,"id":"faac7902_729378fb","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":21},"in_reply_to":"1a122d0e_b5308f08","updated":"2016-05-05 20:21:08.000000000","message":"TestSimpleTenantSwift? \u0026 TestMultiTenantSwift? as two separate set of test classes like they are setup in swift driver.","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"a84eca62aa46caa2ae5dc0faf5f425b942c50997","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        super(TestFilesystem, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class TestSwiftsystem(base.BaseFunctionalTests):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":54,"context_line":"        super(TestSwiftsystem, self).__init__(\u0027swift\u0027, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":19,"id":"dab17558_6886d5ba","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":21},"in_reply_to":"faac7902_729378fb","updated":"2016-05-06 09:00:32.000000000","message":"FWIW I think it\u0027s fine to add a multi-tenant test in a separate patch. I think the goal of this one is mainly the plumbing.","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"516a302f5cc1cfae586f3ff172f50ff9faa9de7a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"#                          group\u003d\u0027glance_store\u0027)"},{"line_number":84,"context_line":"#        CONF.set_override(\u0027swift_store_config_file\u0027,"},{"line_number":85,"context_line":"#                          \u0027/home/nib/devstack/glance_store/functional_testing.conf\u0027,"},{"line_number":86,"context_line":"#                          group\u003d\u0027glance_store\u0027)"},{"line_number":87,"context_line":"        CONF.set_override(\u0027swift_store_create_container_on_put\u0027,"},{"line_number":88,"context_line":"                          True,"},{"line_number":89,"context_line":"                          group\u003d\u0027glance_store\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a122d0e_390ab920","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":2},"updated":"2016-05-05 17:01:47.000000000","message":"Not sure we need this comment.","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"516a302f5cc1cfae586f3ff172f50ff9faa9de7a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                for obj in objects:"},{"line_number":105,"context_line":"                    swift.delete_object(SWIFT_CONTAINER, obj.get(\u0027name\u0027))"},{"line_number":106,"context_line":"            except Exception:"},{"line_number":107,"context_line":"                if x \u003d\u003d 1:"},{"line_number":108,"context_line":"                    pass"},{"line_number":109,"context_line":"                else:"},{"line_number":110,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a122d0e_b9b24947","line":107,"range":{"start_line":107,"start_character":16,"end_line":107,"end_character":26},"updated":"2016-05-05 17:01:47.000000000","message":"Can you explain the retry logic here? Thanks.","commit_id":"163092ae5ab4021602a2a0af864df7721ea7db48"}]}