)]}'
{".zuul.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fd64d381b59cb21558cbaa33fbced4ebc251734d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      devstack_localrc:"},{"line_number":46,"context_line":"        ENABLE_IDENTITY_V2: true"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- job:"},{"line_number":49,"context_line":"    name: glance_store-dsvm-functional-cinder"},{"line_number":50,"context_line":"    parent: glance_store-dsvm-functional-base"},{"line_number":51,"context_line":"    required-projects:"},{"line_number":52,"context_line":"      - openstack/cinder"},{"line_number":53,"context_line":"    vars:"},{"line_number":54,"context_line":"      tox_envlist: functional-cinder"},{"line_number":55,"context_line":"      devstack_services:"},{"line_number":56,"context_line":"        c-api: true"},{"line_number":57,"context_line":"        c-sch: true"},{"line_number":58,"context_line":"        c-vol: true"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- job:"},{"line_number":61,"context_line":"    name: glance_store-tox-cinder-tips-base"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"df33271e_e40687ce","line":58,"range":{"start_line":48,"start_character":0,"end_line":58,"end_character":19},"updated":"2020-03-30 11:24:32.000000000","message":"we have defined the job but it isn\u0027t running anywhere.\nI think this should be run as an experimental job (see L#192) like other stores","commit_id":"914a629614ced1f4b5cae4b7fecce54475b07bb2"}],"glance_store/tests/functional/__init__.py":[{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"81b66fb0ce6387673b30dfada2e9a697e4bf736e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bacf61ea_c39a5a13","line":6,"updated":"2016-08-02 09:35:48.000000000","message":"I feel like adding logging is not related to adding cinder functional tests and probably be done in a separate patch.\n\nAlso would allow it to be implemented throughout the file/swift tests as well.","commit_id":"7af83e12705c6df449b9c211eaefde163fbd52ae"}],"glance_store/tests/functional/cinder/test_functional_cinder.py":[{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"caef4aab9d1a2df5865c8c92356302986bc56a09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_d17e7bad","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2016-07-04 12:46:45.000000000","message":"s/2015/2016/","commit_id":"a7d3b0f664c23e62125e4b03101dcd780cf6b8ba"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"70ac3819fb925f0589c80ea24cc227ea09081c2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_02909742","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"1aa78d24_d17e7bad","updated":"2016-07-05 03:47:55.000000000","message":"Done","commit_id":"a7d3b0f664c23e62125e4b03101dcd780cf6b8ba"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"caef4aab9d1a2df5865c8c92356302986bc56a09","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self._add_return_value \u003d None"},{"line_number":66,"context_line":"        self._add_orig \u003d self.store.add"},{"line_number":67,"context_line":"        self.mock_add \u003d mock.patch.object("},{"line_number":68,"context_line":"            self.store, \u0027add\u0027, side_effect\u003dself._add_wrap).start()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_a7d0cc54","line":67,"range":{"start_line":67,"start_character":24,"end_line":67,"end_character":28},"updated":"2016-07-04 12:46:45.000000000","message":"Testing this patch out. The mock seems to make this functional test pass when I don\u0027t have a devstack up. Is that the correct behaviour?","commit_id":"a7d3b0f664c23e62125e4b03101dcd780cf6b8ba"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"70ac3819fb925f0589c80ea24cc227ea09081c2e","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self._add_return_value \u003d None"},{"line_number":66,"context_line":"        self._add_orig \u003d self.store.add"},{"line_number":67,"context_line":"        self.mock_add \u003d mock.patch.object("},{"line_number":68,"context_line":"            self.store, \u0027add\u0027, side_effect\u003dself._add_wrap).start()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_a29b8371","line":67,"range":{"start_line":67,"start_character":24,"end_line":67,"end_character":28},"in_reply_to":"1aa78d24_a7d0cc54","updated":"2016-07-05 03:47:55.000000000","message":"No, this mock calls the actual cinderclient call. As commented above, it is just for memorizing the returned volume UUID from the add method, so that we can delete it after the test.\n\nActually, all the tests fail by requests.exceptions.ConnectionError when cinder is not running.","commit_id":"a7d3b0f664c23e62125e4b03101dcd780cf6b8ba"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"0b848faa2f680525b13ef6f7a8637c0ece8423ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_7c0378b8","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"updated":"2016-08-11 13:27:43.000000000","message":"s/2015/2016","commit_id":"dc329ffc84ce502d7e416a9ff25ecaccc36e12ed"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"e052b29af4bcf987007805c3a86345e6f27910fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_f61bb37e","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"in_reply_to":"9ad45d7e_7c0378b8","updated":"2016-08-19 04:08:04.000000000","message":"Done","commit_id":"dc329ffc84ce502d7e416a9ff25ecaccc36e12ed"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"0b848faa2f680525b13ef6f7a8637c0ece8423ee","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cinderclient import exceptions as cinder_exception"},{"line_number":20,"context_line":"from cinderclient.v2 import client as cinderclient"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_dc11c405","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":14},"updated":"2016-08-11 13:27:43.000000000","message":"Nothing is actually logged. Should we get rid of this?","commit_id":"dc329ffc84ce502d7e416a9ff25ecaccc36e12ed"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"e052b29af4bcf987007805c3a86345e6f27910fe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cinderclient import exceptions as cinder_exception"},{"line_number":20,"context_line":"from cinderclient.v2 import client as cinderclient"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_5611e75c","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":14},"in_reply_to":"9ad45d7e_dc11c405","updated":"2016-08-19 04:08:04.000000000","message":"Done","commit_id":"dc329ffc84ce502d7e416a9ff25ecaccc36e12ed"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fd64d381b59cb21558cbaa33fbced4ebc251734d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cinderclient import exceptions as cinder_exception"},{"line_number":20,"context_line":"from cinderclient.v2 import client as cinderclient"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"df33271e_4d9b53c8","line":20,"range":{"start_line":20,"start_character":18,"end_line":20,"end_character":20},"updated":"2020-03-30 11:24:32.000000000","message":"v2 is deprecated, use v3 here","commit_id":"914a629614ced1f4b5cae4b7fecce54475b07bb2"}],"glance_store/tests/functional/hooks/gate_hook.sh":[{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"caef4aab9d1a2df5865c8c92356302986bc56a09","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cinder)"},{"line_number":28,"context_line":"        ENABLED_SERVICES+\u003d\",c-api,c-sch,c-vol\""},{"line_number":29,"context_line":"        DEVSTACK_PROJECT_FROM_GIT+\u003d\",os-brick\""},{"line_number":30,"context_line":"\t;;"},{"line_number":31,"context_line":"esac"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"export GLANCE_STORE_DRIVER"}],"source_content_type":"text/x-sh","patch_set":11,"id":"1aa78d24_51ed6b8a","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":1},"updated":"2016-07-04 12:46:45.000000000","message":"nit: is this a tab when it meant to be spaces?","commit_id":"a7d3b0f664c23e62125e4b03101dcd780cf6b8ba"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"70ac3819fb925f0589c80ea24cc227ea09081c2e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cinder)"},{"line_number":28,"context_line":"        ENABLED_SERVICES+\u003d\",c-api,c-sch,c-vol\""},{"line_number":29,"context_line":"        DEVSTACK_PROJECT_FROM_GIT+\u003d\",os-brick\""},{"line_number":30,"context_line":"\t;;"},{"line_number":31,"context_line":"esac"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"export GLANCE_STORE_DRIVER"}],"source_content_type":"text/x-sh","patch_set":11,"id":"1aa78d24_e292ab4a","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":1},"in_reply_to":"1aa78d24_51ed6b8a","updated":"2016-07-05 03:47:55.000000000","message":"Done","commit_id":"a7d3b0f664c23e62125e4b03101dcd780cf6b8ba"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"a97ce63d0dd72240d066f30067a49b40861a789b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"export GLANCE_STORE_DRIVER"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"export ENABLED_SERVICES"},{"line_number":36,"context_line":"export DEVSTACK_PROJECT_FROM_GIT"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"$BASE/new/devstack-gate/devstack-vm-gate.sh"}],"source_content_type":"text/x-sh","patch_set":17,"id":"fa7ab95a_f570a242","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":32},"updated":"2016-09-01 16:36:00.000000000","message":"What does this do?","commit_id":"f87ca46f1bd006427dbef77153292afc41709712"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"d41aac3298ad46f11903a5b84bf4abf18989b271","unresolved":false,"context_lines":[{"line_number":33,"context_line":"export GLANCE_STORE_DRIVER"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"export ENABLED_SERVICES"},{"line_number":36,"context_line":"export DEVSTACK_PROJECT_FROM_GIT"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"$BASE/new/devstack-gate/devstack-vm-gate.sh"}],"source_content_type":"text/x-sh","patch_set":17,"id":"fa7ab95a_afb87376","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":32},"in_reply_to":"fa7ab95a_f570a242","updated":"2016-09-02 01:29:55.000000000","message":"This requests devstack to use os-brick library (set in line 29) from git repo, instead of using installing it from pip.\n\nBoth glance_store cinder driver and cinder service depend on os-brick, so it would be better to test the newest code.","commit_id":"f87ca46f1bd006427dbef77153292afc41709712"}]}