)]}'
{"glance_store/_drivers/vmware_datastore.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36379a12d66985463c64599243ac5f1ada341cb0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"port."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Possible Values:"},{"line_number":74,"context_line":"    * Any valid string that contains a valid IP, IP and port, DNS or"},{"line_number":75,"context_line":"      DNS and port."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_8c4c5043","line":74,"updated":"2016-07-26 21:58:19.000000000","message":"maybe you can list them separately as points?","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"3ce8645a6d645ad80d99c08141ab962ed37772d2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"port."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Possible Values:"},{"line_number":74,"context_line":"    * Any valid string that contains a valid IP, IP and port, DNS or"},{"line_number":75,"context_line":"      DNS and port."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_2d6b90b8","line":74,"in_reply_to":"dada55a8_8c4c5043","updated":"2016-07-27 08:18:08.000000000","message":"Done","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36379a12d66985463c64599243ac5f1ada341cb0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"\"\"\"),"},{"line_number":114,"context_line":"               secret\u003dTrue),"},{"line_number":115,"context_line":"    cfg.IntOpt(\u0027vmware_api_retry_count\u0027,"},{"line_number":116,"context_line":"               default\u003d10,"},{"line_number":117,"context_line":"               help\u003d_(\"\"\""},{"line_number":118,"context_line":"The number of VMware API retries."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_ec634caf","line":116,"updated":"2016-07-26 21:58:19.000000000","message":"We can add min value here.","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"3ce8645a6d645ad80d99c08141ab962ed37772d2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"\"\"\"),"},{"line_number":114,"context_line":"               secret\u003dTrue),"},{"line_number":115,"context_line":"    cfg.IntOpt(\u0027vmware_api_retry_count\u0027,"},{"line_number":116,"context_line":"               default\u003d10,"},{"line_number":117,"context_line":"               help\u003d_(\"\"\""},{"line_number":118,"context_line":"The number of VMware API retries."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_4d5c0419","line":116,"in_reply_to":"dada55a8_ec634caf","updated":"2016-07-27 08:18:08.000000000","message":"Done","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36379a12d66985463c64599243ac5f1ada341cb0","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"\"\"\")),"},{"line_number":131,"context_line":"    cfg.IntOpt(\u0027vmware_task_poll_interval\u0027,"},{"line_number":132,"context_line":"               default\u003d5,"},{"line_number":133,"context_line":"               help\u003d_(\"\"\""},{"line_number":134,"context_line":"Interval in seconds used for polling remote tasks invoked on VMware"},{"line_number":135,"context_line":"ESX/VC server."}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_4c0c18ec","line":132,"updated":"2016-07-26 21:58:19.000000000","message":"We can add a min value here","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"3ce8645a6d645ad80d99c08141ab962ed37772d2","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"\"\"\")),"},{"line_number":131,"context_line":"    cfg.IntOpt(\u0027vmware_task_poll_interval\u0027,"},{"line_number":132,"context_line":"               default\u003d5,"},{"line_number":133,"context_line":"               help\u003d_(\"\"\""},{"line_number":134,"context_line":"Interval in seconds used for polling remote tasks invoked on VMware"},{"line_number":135,"context_line":"ESX/VC server."}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_cda6340e","line":132,"in_reply_to":"dada55a8_4c0c18ec","updated":"2016-07-27 08:18:08.000000000","message":"Done","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36379a12d66985463c64599243ac5f1ada341cb0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"               help\u003d_(\"\"\""},{"line_number":150,"context_line":"The directory where the glance images will be stored in the datastore."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"This configuration option takes in the relative path to the directory"},{"line_number":153,"context_line":"where the glance images will be stored in the VMware datastore. If"},{"line_number":154,"context_line":"this option is not set,  the default directory where the glance images"},{"line_number":155,"context_line":"are stored is openstack_glance."}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_ec318ca3","line":152,"updated":"2016-07-26 21:58:19.000000000","message":"I guess this takes the name of the directory and not the path.","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"3ce8645a6d645ad80d99c08141ab962ed37772d2","unresolved":false,"context_lines":[{"line_number":149,"context_line":"               help\u003d_(\"\"\""},{"line_number":150,"context_line":"The directory where the glance images will be stored in the datastore."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"This configuration option takes in the relative path to the directory"},{"line_number":153,"context_line":"where the glance images will be stored in the VMware datastore. If"},{"line_number":154,"context_line":"this option is not set,  the default directory where the glance images"},{"line_number":155,"context_line":"are stored is openstack_glance."}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_adeb0012","line":152,"in_reply_to":"dada55a8_ec318ca3","updated":"2016-07-27 08:18:08.000000000","message":"I think it actually takes the path to the directory, not just the name. But please do correct me if I am wrong :)","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36379a12d66985463c64599243ac5f1ada341cb0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"are stored is openstack_glance."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Possible Values:"},{"line_number":158,"context_line":"    * Any string that is a valid relative path to a directory."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Related options:"},{"line_number":161,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_ac14b4e8","line":158,"updated":"2016-07-26 21:58:19.000000000","message":"A valid string value representing the name of the directory","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36379a12d66985463c64599243ac5f1ada341cb0","unresolved":false,"context_lines":[{"line_number":163,"context_line":"\"\"\")),"},{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":165,"context_line":"                default\u003dFalse,"},{"line_number":166,"context_line":"                help\u003d_(\"\"\""},{"line_number":167,"context_line":"Set verification of the ESX/vCenter server certificate."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"This configuration option takes in a boolean value to determine"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_ccee48ec","line":166,"updated":"2016-07-26 21:58:19.000000000","message":"We could add \"choices\" here for True and False","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"3ce8645a6d645ad80d99c08141ab962ed37772d2","unresolved":false,"context_lines":[{"line_number":163,"context_line":"\"\"\")),"},{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":165,"context_line":"                default\u003dFalse,"},{"line_number":166,"context_line":"                help\u003d_(\"\"\""},{"line_number":167,"context_line":"Set verification of the ESX/vCenter server certificate."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"This configuration option takes in a boolean value to determine"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_0dadece8","line":166,"in_reply_to":"dada55a8_ccee48ec","updated":"2016-07-27 08:18:08.000000000","message":"Done","commit_id":"b2a421c45a990e00cc795bd2d4cc77284d97719f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e47faf26b3d8cde2ba87e099de99ef6bb27908cd","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"_VMWARE_OPTS \u003d ["},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027vmware_server_host\u0027,"},{"line_number":64,"context_line":"               help\u003d_(\"\"\""},{"line_number":65,"context_line":"Address of the ESX/ESXi or vCenter Server target system."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This configuration option sets the address of the ESX/ESXi or vCenter"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_a208f292","line":64,"updated":"2016-07-27 15:39:16.000000000","message":"sample_default\u003d\u0027127.0.0.1\u0027","commit_id":"2bdacd1324a1a169115f09f99274a7665c834905"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e47faf26b3d8cde2ba87e099de99ef6bb27908cd","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"\"\"\")),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027vmware_server_username\u0027,"},{"line_number":85,"context_line":"               help\u003d_(\"\"\""},{"line_number":86,"context_line":"Server admin username."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This configuration option takes in the username for authenticating"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_82496ed3","line":85,"updated":"2016-07-27 15:39:16.000000000","message":"sample_default\u003d\u0027administrator\u0027","commit_id":"2bdacd1324a1a169115f09f99274a7665c834905"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e47faf26b3d8cde2ba87e099de99ef6bb27908cd","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"\"\"\")),"},{"line_number":100,"context_line":"    cfg.StrOpt(\u0027vmware_server_password\u0027,"},{"line_number":101,"context_line":"               help\u003d_(\"\"\""},{"line_number":102,"context_line":"Server admin password."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"This configuration option takes in the password for authenticating"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_e25e6a75","line":101,"updated":"2016-07-27 15:39:16.000000000","message":"Can add a sample_default here too maybe.","commit_id":"2bdacd1324a1a169115f09f99274a7665c834905"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e47faf26b3d8cde2ba87e099de99ef6bb27908cd","unresolved":false,"context_lines":[{"line_number":120,"context_line":"               help\u003d_(\"\"\""},{"line_number":121,"context_line":"The number of VMware API retries."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"This configuration option takes in the number of times the VMware"},{"line_number":124,"context_line":"ESX/VC server API must be retried upon session/connection related"},{"line_number":125,"context_line":"issues."},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_a2f2b26d","line":123,"updated":"2016-07-27 15:39:16.000000000","message":"maybe we can explain in a line about when and why a retry is required. ie, what happens when there is a session/connection related issue.","commit_id":"2bdacd1324a1a169115f09f99274a7665c834905"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e47faf26b3d8cde2ba87e099de99ef6bb27908cd","unresolved":false,"context_lines":[{"line_number":190,"context_line":"\"\"\"),"},{"line_number":191,"context_line":"                deprecated_name\u003d\u0027vmware_api_insecure\u0027),"},{"line_number":192,"context_line":"    cfg.StrOpt(\u0027vmware_ca_file\u0027,"},{"line_number":193,"context_line":"               help\u003d_(\"\"\""},{"line_number":194,"context_line":"Relative path to the CA bundle file."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"This configuration option enables the operator to use a custom"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_82584e58","line":193,"updated":"2016-07-27 15:39:16.000000000","message":"sample_default can be added here too","commit_id":"2bdacd1324a1a169115f09f99274a7665c834905"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"e47faf26b3d8cde2ba87e099de99ef6bb27908cd","unresolved":false,"context_lines":[{"line_number":228,"context_line":"the most free space available is selected."},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"Possible Values:"},{"line_number":231,"context_line":"    * Any string of the format"},{"line_number":232,"context_line":"      \u003cdatacenter_path\u003e:\u003cdatastore_name\u003e:\u003coptional_weight\u003e."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_02129e62","line":231,"updated":"2016-07-27 15:39:16.000000000","message":"add a colon. \n\"Any string of the format: \n\u003cdatacenter_path\u003e:\u003cdatastore_name\u003e:\u003coptional_weight\u003e\"","commit_id":"2bdacd1324a1a169115f09f99274a7665c834905"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a1454819d91167b825ad733d9a076857978df1c8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"\"\"\")),"},{"line_number":174,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":175,"context_line":"                default\u003dFalse,"},{"line_number":176,"context_line":"                choices\u003d(\u0027True\u0027, \u0027False\u0027),"},{"line_number":177,"context_line":"                help\u003d_(\"\"\""},{"line_number":178,"context_line":"Set verification of the ESX/vCenter server certificate."},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_d216ca4a","line":176,"range":{"start_line":176,"start_character":16,"end_line":176,"end_character":41},"updated":"2016-08-01 15:27:06.000000000","message":"BoolOpt doesn\u0027t have the \u0027choices\u0027 argument.\nhttp://docs.openstack.org/developer/oslo.config/types.html#oslo_config.types.Boolean","commit_id":"1fb2be00a8445eb450ac21b7b576738283f6d3e6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"This configuration option sets the address of the ESX/ESXi or vCenter"},{"line_number":69,"context_line":"Server target system. This option is required when using the VMware"},{"line_number":70,"context_line":"storage backend. The address can contain an IP (127.0.0.1), an IP"},{"line_number":71,"context_line":"and port (127.0.0.1:443), a DNS name (www.my-domain.com) or DNS and"},{"line_number":72,"context_line":"port."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible Values:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_6477ea3b","line":71,"range":{"start_line":71,"start_character":60,"end_line":71,"end_character":63},"updated":"2016-08-03 13:51:33.000000000","message":"s/DNS/DNS name/","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"This configuration option sets the address of the ESX/ESXi or vCenter"},{"line_number":69,"context_line":"Server target system. This option is required when using the VMware"},{"line_number":70,"context_line":"storage backend. The address can contain an IP (127.0.0.1), an IP"},{"line_number":71,"context_line":"and port (127.0.0.1:443), a DNS name (www.my-domain.com) or DNS and"},{"line_number":72,"context_line":"port."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible Values:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_911a0c7b","line":71,"range":{"start_line":71,"start_character":60,"end_line":71,"end_character":63},"in_reply_to":"bacf61ea_6477ea3b","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"port."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible Values:"},{"line_number":75,"context_line":"    * A valid IP."},{"line_number":76,"context_line":"    * A valid IP and port."},{"line_number":77,"context_line":"    * A valid DNS name."},{"line_number":78,"context_line":"    * A valid DNS name and port."}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_440c6694","line":75,"range":{"start_line":75,"start_character":6,"end_line":75,"end_character":17},"updated":"2016-08-03 13:51:33.000000000","message":"The example you give above is IPv4 ... can this also take IPv6 (assuming the underlying network supports it?)","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"port."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible Values:"},{"line_number":75,"context_line":"    * A valid IP."},{"line_number":76,"context_line":"    * A valid IP and port."},{"line_number":77,"context_line":"    * A valid DNS name."},{"line_number":78,"context_line":"    * A valid DNS name and port."}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_d743d411","line":75,"range":{"start_line":75,"start_character":6,"end_line":75,"end_character":17},"in_reply_to":"bacf61ea_440c6694","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    * A valid IP."},{"line_number":76,"context_line":"    * A valid IP and port."},{"line_number":77,"context_line":"    * A valid DNS name."},{"line_number":78,"context_line":"    * A valid DNS name and port."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Related options:"},{"line_number":81,"context_line":"    * vmware_server_username"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_c4db361a","line":78,"updated":"2016-08-03 13:51:33.000000000","message":"I\u0027d suggest dropping the period at the end of each list item to be consistent with the other lists","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    * A valid IP."},{"line_number":76,"context_line":"    * A valid IP and port."},{"line_number":77,"context_line":"    * A valid DNS name."},{"line_number":78,"context_line":"    * A valid DNS name and port."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Related options:"},{"line_number":81,"context_line":"    * vmware_server_username"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_5101b405","line":78,"in_reply_to":"bacf61ea_c4db361a","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"               help\u003d_(\"\"\""},{"line_number":88,"context_line":"Server admin username."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"This configuration option takes in the username for authenticating"},{"line_number":91,"context_line":"with the VMware ESX/ESXi or vCenter Server. This option is required"},{"line_number":92,"context_line":"when using the VMware storage backend."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_84dbfeec","line":90,"range":{"start_line":90,"start_character":32,"end_line":90,"end_character":34},"updated":"2016-08-03 13:51:33.000000000","message":"Probably don\u0027t need \u0027in\u0027 here.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"               help\u003d_(\"\"\""},{"line_number":88,"context_line":"Server admin username."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"This configuration option takes in the username for authenticating"},{"line_number":91,"context_line":"with the VMware ESX/ESXi or vCenter Server. This option is required"},{"line_number":92,"context_line":"when using the VMware storage backend."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_dc22dba2","line":90,"range":{"start_line":90,"start_character":32,"end_line":90,"end_character":34},"in_reply_to":"bacf61ea_84dbfeec","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"when using the VMware storage backend."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Possible Values:"},{"line_number":95,"context_line":"    * Any valid string that is a username to an admin account."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Related options:"},{"line_number":98,"context_line":"    * vmware_server_host"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_64d6cac4","line":95,"range":{"start_line":95,"start_character":61,"end_line":95,"end_character":62},"updated":"2016-08-03 13:51:33.000000000","message":"Probably don\u0027t need the period.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"when using the VMware storage backend."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Possible Values:"},{"line_number":95,"context_line":"    * Any valid string that is a username to an admin account."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Related options:"},{"line_number":98,"context_line":"    * vmware_server_host"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9c4fc369","line":95,"range":{"start_line":95,"start_character":61,"end_line":95,"end_character":62},"in_reply_to":"bacf61ea_64d6cac4","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"               help\u003d_(\"\"\""},{"line_number":105,"context_line":"Server admin password."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"This configuration option takes in the password for authenticating"},{"line_number":108,"context_line":"with the VMware ESX/ESXi or vCenter Server. This option is required"},{"line_number":109,"context_line":"when using the VMware storage backend."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_8402de3c","line":107,"range":{"start_line":107,"start_character":32,"end_line":107,"end_character":34},"updated":"2016-08-03 13:51:33.000000000","message":"Probably don\u0027t need \u0027in\u0027 here.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"               help\u003d_(\"\"\""},{"line_number":105,"context_line":"Server admin password."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"This configuration option takes in the password for authenticating"},{"line_number":108,"context_line":"with the VMware ESX/ESXi or vCenter Server. This option is required"},{"line_number":109,"context_line":"when using the VMware storage backend."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_5c46eb4f","line":107,"range":{"start_line":107,"start_character":32,"end_line":107,"end_character":34},"in_reply_to":"bacf61ea_8402de3c","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"when using the VMware storage backend."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible Values:"},{"line_number":112,"context_line":"    * Any valid string that is a password to an admin account."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Related options:"},{"line_number":115,"context_line":"    * vmware_server_host"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_04eeee8a","line":112,"range":{"start_line":112,"start_character":61,"end_line":112,"end_character":62},"updated":"2016-08-03 13:51:33.000000000","message":"Probably don\u0027t need the period.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"when using the VMware storage backend."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible Values:"},{"line_number":112,"context_line":"    * Any valid string that is a password to an admin account."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Related options:"},{"line_number":115,"context_line":"    * vmware_server_host"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9c76a3a1","line":112,"range":{"start_line":112,"start_character":61,"end_line":112,"end_character":62},"in_reply_to":"bacf61ea_04eeee8a","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"               help\u003d_(\"\"\""},{"line_number":124,"context_line":"The number of VMware API retries."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"This configuration option takes in the number of times the VMware"},{"line_number":127,"context_line":"ESX/VC server API must be retried upon session/connection related"},{"line_number":128,"context_line":"issues."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_24b9727a","line":126,"range":{"start_line":126,"start_character":26,"end_line":126,"end_character":34},"updated":"2016-08-03 13:51:33.000000000","message":"Maybe \"specifies\" instead of \"takes in\"?","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"               help\u003d_(\"\"\""},{"line_number":124,"context_line":"The number of VMware API retries."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"This configuration option takes in the number of times the VMware"},{"line_number":127,"context_line":"ESX/VC server API must be retried upon session/connection related"},{"line_number":128,"context_line":"issues."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_3cafb7e4","line":126,"range":{"start_line":126,"start_character":26,"end_line":126,"end_character":34},"in_reply_to":"bacf61ea_24b9727a","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"This configuration option takes in the number of times the VMware"},{"line_number":127,"context_line":"ESX/VC server API must be retried upon session/connection related"},{"line_number":128,"context_line":"issues."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The VMWare ESX/VC server API invocation is retried in case of any"},{"line_number":131,"context_line":"connection problems or server API call overload."}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_6459aa5b","line":128,"updated":"2016-08-03 13:51:33.000000000","message":"Looks like there\u0027s no way of specifying \"retry forever\", might be worth pointing that out.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"This configuration option takes in the number of times the VMware"},{"line_number":127,"context_line":"ESX/VC server API must be retried upon session/connection related"},{"line_number":128,"context_line":"issues."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The VMWare ESX/VC server API invocation is retried in case of any"},{"line_number":131,"context_line":"connection problems or server API call overload."}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_dc149b4e","line":128,"in_reply_to":"bacf61ea_6459aa5b","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"               help\u003d_(\"\"\""},{"line_number":160,"context_line":"The directory where the glance images will be stored in the datastore."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"This configuration option takes in the path to the directory where the"},{"line_number":163,"context_line":"glance images will be stored in the VMware datastore. If this option"},{"line_number":164,"context_line":"is not set,  the default directory where the glance images are stored"},{"line_number":165,"context_line":"is openstack_glance."}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_a401e208","line":162,"range":{"start_line":162,"start_character":26,"end_line":162,"end_character":34},"updated":"2016-08-03 13:51:33.000000000","message":"Maybe \"specifies\" instead of \"takes in\"?","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":159,"context_line":"               help\u003d_(\"\"\""},{"line_number":160,"context_line":"The directory where the glance images will be stored in the datastore."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"This configuration option takes in the path to the directory where the"},{"line_number":163,"context_line":"glance images will be stored in the VMware datastore. If this option"},{"line_number":164,"context_line":"is not set,  the default directory where the glance images are stored"},{"line_number":165,"context_line":"is openstack_glance."}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_7c900f96","line":162,"range":{"start_line":162,"start_character":26,"end_line":162,"end_character":34},"in_reply_to":"bacf61ea_a401e208","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                help\u003d_(\"\"\""},{"line_number":177,"context_line":"Set verification of the ESX/vCenter server certificate."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"This configuration option takes in a boolean value to determine"},{"line_number":180,"context_line":"whether or not to verify the ESX/vCenter server certificate. If this"},{"line_number":181,"context_line":"option is set to true, the ESX/vCenter server certificate is not"},{"line_number":182,"context_line":"verified. If this option is set to false, then the default CA"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9f186777","line":179,"range":{"start_line":179,"start_character":32,"end_line":179,"end_character":34},"updated":"2016-08-03 13:51:33.000000000","message":"Probably don\u0027t need the \"in\" here.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                help\u003d_(\"\"\""},{"line_number":177,"context_line":"Set verification of the ESX/vCenter server certificate."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"This configuration option takes in a boolean value to determine"},{"line_number":180,"context_line":"whether or not to verify the ESX/vCenter server certificate. If this"},{"line_number":181,"context_line":"option is set to true, the ESX/vCenter server certificate is not"},{"line_number":182,"context_line":"verified. If this option is set to false, then the default CA"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_5ce26b30","line":179,"range":{"start_line":179,"start_character":32,"end_line":179,"end_character":34},"in_reply_to":"bacf61ea_9f186777","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":179,"context_line":"This configuration option takes in a boolean value to determine"},{"line_number":180,"context_line":"whether or not to verify the ESX/vCenter server certificate. If this"},{"line_number":181,"context_line":"option is set to true, the ESX/vCenter server certificate is not"},{"line_number":182,"context_line":"verified. If this option is set to false, then the default CA"},{"line_number":183,"context_line":"truststore is used for verification. This option is ignored if"},{"line_number":184,"context_line":"\"vmware_ca_file\" is set i.e. the ESX/vCenter server certificate will"},{"line_number":185,"context_line":"then be verified using the file specified using the \"vmware_ca_file\""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9f46a74d","line":182,"range":{"start_line":182,"start_character":35,"end_line":182,"end_character":36},"updated":"2016-08-03 13:51:33.000000000","message":"\u0027F\u0027","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":179,"context_line":"This configuration option takes in a boolean value to determine"},{"line_number":180,"context_line":"whether or not to verify the ESX/vCenter server certificate. If this"},{"line_number":181,"context_line":"option is set to true, the ESX/vCenter server certificate is not"},{"line_number":182,"context_line":"verified. If this option is set to false, then the default CA"},{"line_number":183,"context_line":"truststore is used for verification. This option is ignored if"},{"line_number":184,"context_line":"\"vmware_ca_file\" is set i.e. the ESX/vCenter server certificate will"},{"line_number":185,"context_line":"then be verified using the file specified using the \"vmware_ca_file\""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_1cbf53fd","line":182,"range":{"start_line":182,"start_character":35,"end_line":182,"end_character":36},"in_reply_to":"bacf61ea_9f46a74d","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"whether or not to verify the ESX/vCenter server certificate. If this"},{"line_number":181,"context_line":"option is set to true, the ESX/vCenter server certificate is not"},{"line_number":182,"context_line":"verified. If this option is set to false, then the default CA"},{"line_number":183,"context_line":"truststore is used for verification. This option is ignored if"},{"line_number":184,"context_line":"\"vmware_ca_file\" is set i.e. the ESX/vCenter server certificate will"},{"line_number":185,"context_line":"then be verified using the file specified using the \"vmware_ca_file\""},{"line_number":186,"context_line":"option ."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Possible Values:"},{"line_number":189,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_3fca1ba2","line":186,"range":{"start_line":183,"start_character":37,"end_line":186,"end_character":8},"updated":"2016-08-03 13:51:33.000000000","message":"I suggest making this sentence a new paragraph.\n\nAlso, OpenStack house style is to write out \"i.e.\" as \"that is\" and \"e.g.\" as \"for example\".\n\nIn this case, though, I\u0027d suggest in addition to making this sentence into its own paragraph, splitting it into two sentences.  I suggest replacing \"set i.e. the\" with \"set.  In that case, the\".","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"whether or not to verify the ESX/vCenter server certificate. If this"},{"line_number":181,"context_line":"option is set to true, the ESX/vCenter server certificate is not"},{"line_number":182,"context_line":"verified. If this option is set to false, then the default CA"},{"line_number":183,"context_line":"truststore is used for verification. This option is ignored if"},{"line_number":184,"context_line":"\"vmware_ca_file\" is set i.e. the ESX/vCenter server certificate will"},{"line_number":185,"context_line":"then be verified using the file specified using the \"vmware_ca_file\""},{"line_number":186,"context_line":"option ."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Possible Values:"},{"line_number":189,"context_line":"    * True"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9c6063a6","line":186,"range":{"start_line":183,"start_character":37,"end_line":186,"end_character":8},"in_reply_to":"bacf61ea_3fca1ba2","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    * vmware_ca_file"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"\"\"\"),"},{"line_number":196,"context_line":"                deprecated_name\u003d\u0027vmware_api_insecure\u0027),"},{"line_number":197,"context_line":"    cfg.StrOpt(\u0027vmware_ca_file\u0027,"},{"line_number":198,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":199,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_ff0403c7","line":196,"range":{"start_line":196,"start_character":16,"end_line":196,"end_character":55},"updated":"2016-08-03 13:51:33.000000000","message":"This is a nit, but I think this should be above the help text so that it\u0027s obvious to people reading the code -- it\u0027s kind of lost down here.  (But feel free to ignore if there\u0027s a style reason for ordering the arguments in this way.)","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    * vmware_ca_file"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"\"\"\"),"},{"line_number":196,"context_line":"                deprecated_name\u003d\u0027vmware_api_insecure\u0027),"},{"line_number":197,"context_line":"    cfg.StrOpt(\u0027vmware_ca_file\u0027,"},{"line_number":198,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":199,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_dcb81b78","line":196,"range":{"start_line":196,"start_character":16,"end_line":196,"end_character":55},"in_reply_to":"bacf61ea_ff0403c7","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"Relative path to the CA bundle file."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"This configuration option enables the operator to use a custom"},{"line_number":203,"context_line":"Cerificate Authority File to verify the ESX/vCenter certificate. If"},{"line_number":204,"context_line":"this option is set, the \"vmware_insecure\" option will be ignored and"},{"line_number":205,"context_line":"the CA file specified will be used to authenticate the ESX/vCenter"},{"line_number":206,"context_line":"server certificate and establish a secure connection to the server."}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_ffd24333","line":203,"range":{"start_line":203,"start_character":64,"end_line":203,"end_character":65},"updated":"2016-08-03 13:51:33.000000000","message":"It might be worth splitting the paragraph here.  That way the warning about this option overriding the vmware_insecure option will stand out more.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":200,"context_line":"Relative path to the CA bundle file."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"This configuration option enables the operator to use a custom"},{"line_number":203,"context_line":"Cerificate Authority File to verify the ESX/vCenter certificate. If"},{"line_number":204,"context_line":"this option is set, the \"vmware_insecure\" option will be ignored and"},{"line_number":205,"context_line":"the CA file specified will be used to authenticate the ESX/vCenter"},{"line_number":206,"context_line":"server certificate and establish a secure connection to the server."}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_5cfeebae","line":203,"range":{"start_line":203,"start_character":64,"end_line":203,"end_character":65},"in_reply_to":"bacf61ea_ffd24333","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"server certificate and establish a secure connection to the server."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Possible Values:"},{"line_number":209,"context_line":"    * Any string that is a valid relative path to a CA file."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Related options:"},{"line_number":212,"context_line":"    * vmware_insecure"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9ffea7ac","line":209,"range":{"start_line":209,"start_character":59,"end_line":209,"end_character":60},"updated":"2016-08-03 13:51:33.000000000","message":"I suggest dropping the period.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":206,"context_line":"server certificate and establish a secure connection to the server."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Possible Values:"},{"line_number":209,"context_line":"    * Any string that is a valid relative path to a CA file."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Related options:"},{"line_number":212,"context_line":"    * vmware_insecure"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9c07c3c8","line":209,"range":{"start_line":209,"start_character":59,"end_line":209,"end_character":60},"in_reply_to":"bacf61ea_9ffea7ac","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        help\u003d_(\"\"\""},{"line_number":218,"context_line":"A list of datastores where the image can be stored."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"This configuration option takes in a list of datastores where the"},{"line_number":221,"context_line":"image can be stored in the VMWare store backend. This option may be"},{"line_number":222,"context_line":"specified multiple times for specifying multiple datastores. The"},{"line_number":223,"context_line":"datastore name should be specified after its datacenter path,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_bff1ebcf","line":220,"range":{"start_line":220,"start_character":26,"end_line":220,"end_character":34},"updated":"2016-08-03 13:51:33.000000000","message":"s/takes in/specifies/\n\nMay also be worth saying comma-separated list.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        help\u003d_(\"\"\""},{"line_number":218,"context_line":"A list of datastores where the image can be stored."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"This configuration option takes in a list of datastores where the"},{"line_number":221,"context_line":"image can be stored in the VMWare store backend. This option may be"},{"line_number":222,"context_line":"specified multiple times for specifying multiple datastores. The"},{"line_number":223,"context_line":"datastore name should be specified after its datacenter path,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_97d5dc1c","line":220,"range":{"start_line":220,"start_character":26,"end_line":220,"end_character":34},"in_reply_to":"bacf61ea_bff1ebcf","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":218,"context_line":"A list of datastores where the image can be stored."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"This configuration option takes in a list of datastores where the"},{"line_number":221,"context_line":"image can be stored in the VMWare store backend. This option may be"},{"line_number":222,"context_line":"specified multiple times for specifying multiple datastores. The"},{"line_number":223,"context_line":"datastore name should be specified after its datacenter path,"},{"line_number":224,"context_line":"separated by \":\". An optional weight may be given after the datastore"},{"line_number":225,"context_line":"name, separated again by \":\" to specify the priority. Thus, the"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_7f265317","line":222,"range":{"start_line":221,"start_character":49,"end_line":222,"end_character":60},"updated":"2016-08-03 13:51:33.000000000","message":"This is a little confusing.  You say it takes a list *and* it can be specified multiple times.  Please verify that both are true.  In other words, if I have\n\nvm_datastore\u003dmy:store:22\nvm_datastore\u003dmy:otherstore:11\n\nis this the same as specifying\n\nvm_datastore\u003dmy:store:22,my:otherstore:11\n\nor does the last one declared in the file win?  We need to be clear about this, because a lot of config options are \"last one wins\".","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":218,"context_line":"A list of datastores where the image can be stored."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"This configuration option takes in a list of datastores where the"},{"line_number":221,"context_line":"image can be stored in the VMWare store backend. This option may be"},{"line_number":222,"context_line":"specified multiple times for specifying multiple datastores. The"},{"line_number":223,"context_line":"datastore name should be specified after its datacenter path,"},{"line_number":224,"context_line":"separated by \":\". An optional weight may be given after the datastore"},{"line_number":225,"context_line":"name, separated again by \":\" to specify the priority. Thus, the"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_1f262268","line":222,"range":{"start_line":221,"start_character":49,"end_line":222,"end_character":60},"in_reply_to":"bacf61ea_7f265317","updated":"2016-08-03 20:06:44.000000000","message":"As far as I understand, I think we can specify multiple datastores and they would all be considered, as in it would be the same as specifying it as a list. But please do correct me if I am wrong :)","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3eaa606eac1771a1eee425d66d0641ae43deb56f","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Possible Values:"},{"line_number":237,"context_line":"    * Any string of the format:"},{"line_number":238,"context_line":"      \u003cdatacenter_path\u003e:\u003cdatastore_name\u003e:\u003coptional_weight\u003e."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"Related options:"},{"line_number":241,"context_line":"   * None"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_bffc4b3f","line":238,"range":{"start_line":238,"start_character":58,"end_line":238,"end_character":59},"updated":"2016-08-03 13:51:33.000000000","message":"I suggest no period here.","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"57d09525840916af2aa5e39147241f9fb85966f3","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Possible Values:"},{"line_number":237,"context_line":"    * Any string of the format:"},{"line_number":238,"context_line":"      \u003cdatacenter_path\u003e:\u003cdatastore_name\u003e:\u003coptional_weight\u003e."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"Related options:"},{"line_number":241,"context_line":"   * None"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_1c2113fd","line":238,"range":{"start_line":238,"start_character":58,"end_line":238,"end_character":59},"in_reply_to":"bacf61ea_bffc4b3f","updated":"2016-08-03 20:06:44.000000000","message":"Done","commit_id":"523f6d41890c94c34d32ee8931f65b71ca9452e1"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":68,"context_line":"This configuration option sets the address of the ESX/ESXi or vCenter"},{"line_number":69,"context_line":"Server target system. This option is required when using the VMware"},{"line_number":70,"context_line":"storage backend. The address can contain an IP (127.0.0.1), an IP"},{"line_number":71,"context_line":"and port (127.0.0.1:443), a DNS name (www.my-domain.com) or DNS name"},{"line_number":72,"context_line":"and port."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible Values:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_62a4d3b8","line":71,"updated":"2016-08-04 07:03:51.000000000","message":"The config option is only for the vCenter/ESX host. We can\u0027t specify the port, it is always 443.","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible Values:"},{"line_number":75,"context_line":"    * A valid IPv4 or IPv6 address"},{"line_number":76,"context_line":"    * A valid IPv4 or IPv6 address and port"},{"line_number":77,"context_line":"    * A valid DNS name"},{"line_number":78,"context_line":"    * A valid DNS name and port"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_42c54f3a","line":76,"updated":"2016-08-04 07:03:51.000000000","message":"cannot contain the port.","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    * A valid IPv4 or IPv6 address"},{"line_number":76,"context_line":"    * A valid IPv4 or IPv6 address and port"},{"line_number":77,"context_line":"    * A valid DNS name"},{"line_number":78,"context_line":"    * A valid DNS name and port"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Related options:"},{"line_number":81,"context_line":"    * vmware_server_username"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_a20feb86","line":78,"updated":"2016-08-04 07:03:51.000000000","message":"cannot contain the port","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"\"\"\")),"},{"line_number":85,"context_line":"    cfg.StrOpt(\u0027vmware_server_username\u0027,"},{"line_number":86,"context_line":"               sample_default\u003d\u0027admin\u0027,"},{"line_number":87,"context_line":"               help\u003d_(\"\"\""},{"line_number":88,"context_line":"Server admin username."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_827907ff","line":86,"updated":"2016-08-04 07:03:51.000000000","message":"sample_default can be \u0027root\u0027","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    cfg.StrOpt(\u0027vmware_server_username\u0027,"},{"line_number":86,"context_line":"               sample_default\u003d\u0027admin\u0027,"},{"line_number":87,"context_line":"               help\u003d_(\"\"\""},{"line_number":88,"context_line":"Server admin username."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"This configuration option takes the username for authenticating with"},{"line_number":91,"context_line":"the VMware ESX/ESXi or vCenter Server. This option is required when"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_42fd4f39","line":88,"updated":"2016-08-04 07:03:51.000000000","message":"Can be any user with appropriate privileges, not necessarily the admin.","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":92,"context_line":"using the VMware storage backend."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Possible Values:"},{"line_number":95,"context_line":"    * Any valid string that is a username to an admin account"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Related options:"},{"line_number":98,"context_line":"    * vmware_server_host"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_028a37bf","line":95,"updated":"2016-08-04 07:03:51.000000000","message":"again, need not be the admin account.","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":127,"context_line":"ESX/VC server API must be retried upon session/connection related"},{"line_number":128,"context_line":"issues. It is not possible to specify \u0027retry forever\u0027."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The VMWare ESX/VC server API invocation is retried in case of any"},{"line_number":131,"context_line":"connection problems or server API call overload."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Possible Values:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_a247eb75","line":130,"updated":"2016-08-04 07:03:51.000000000","message":"This is redundant as we have specified it in the above paragraph.","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"\"\"\")),"},{"line_number":198,"context_line":"    cfg.StrOpt(\u0027vmware_ca_file\u0027,"},{"line_number":199,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":200,"context_line":"               help\u003d_(\"\"\""},{"line_number":201,"context_line":"Relative path to the CA bundle file."},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_9d5b28f6","line":199,"updated":"2016-08-04 07:03:51.000000000","message":"a better default could be \u0027/etc/ssl/certs/ca-certificates.crt\u0027 which is the case in ubuntu/debian distros.","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    cfg.StrOpt(\u0027vmware_ca_file\u0027,"},{"line_number":199,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":200,"context_line":"               help\u003d_(\"\"\""},{"line_number":201,"context_line":"Relative path to the CA bundle file."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This configuration option enables the operator to use a custom"},{"line_number":204,"context_line":"Cerificate Authority File to verify the ESX/vCenter certificate."}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_ddf480d0","line":201,"updated":"2016-08-04 07:03:51.000000000","message":"the store passes this value to requests library. According to its documentation, this must be the absolute path.","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1f70b7332f498fe9cdf1353b4dc55532a3c02753","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        help\u003d_(\"\"\""},{"line_number":220,"context_line":"A list of datastores where the image can be stored."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"This configuration option specifies a comma-separated list of"},{"line_number":223,"context_line":"datastores where the image can be stored in the VMWare store backend."},{"line_number":224,"context_line":"This option may be specified multiple times for specifying multiple"},{"line_number":225,"context_line":"datastores. The datastore name should be specified after its"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_5da410b8","line":222,"updated":"2016-08-04 07:03:51.000000000","message":"This config option can be specified multiple times for specifying multiple datastores. It doesn\u0027t accept a comma-separated list of datastores.","commit_id":"cea6f21c6a7a38538666e079eeb81ad3b6bc107f"}]}