)]}'
{"glance_store/_drivers/rbd.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a53e4a16e3365ed7264bfe5c3647108bd4658516","unresolved":false,"context_lines":[{"line_number":56,"context_line":"_RBD_OPTS \u003d ["},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027rbd_store_chunk_size\u0027, default\u003dDEFAULT_CHUNKSIZE,"},{"line_number":58,"context_line":"               help\u003d_(\u0027RADOS images will be chunked into objects of this size \u0027"},{"line_number":59,"context_line":"                      \u0027(in megabytes). For best performance, this should be \u0027"},{"line_number":60,"context_line":"                      \u0027a power of two.\u0027)),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027rbd_store_pool\u0027, default\u003dDEFAULT_POOL,"},{"line_number":62,"context_line":"               help\u003d_(\u0027RADOS pool in which images are stored.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_fcdf4a0a","side":"PARENT","line":59,"range":{"start_line":59,"start_character":24,"end_line":59,"end_character":36},"updated":"2016-08-02 03:11:26.000000000","message":"Why do you remove the \u0027(in megabytes)\u0027? I think it\u0027s good to keep.","commit_id":"79532ea599cd0226e7176c6c7d59e04ee3b1a8ff"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"66ffaff901bc6c356bdde81bb3bd7cc751e82ea7","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"\"\"\")),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027rbd_store_pool\u0027, default\u003dDEFAULT_POOL,"},{"line_number":73,"context_line":"               help\u003d_(\u0027RADOS pool in which images are stored.\u0027)),"},{"line_number":74,"context_line":"    cfg.StrOpt(\u0027rbd_store_user\u0027, default\u003dDEFAULT_USER,"},{"line_number":75,"context_line":"               help\u003d_(\"\"\""},{"line_number":76,"context_line":"RADOS user to authenticate as."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_4ca88477","line":73,"range":{"start_line":73,"start_character":22,"end_line":73,"end_character":62},"updated":"2016-08-01 15:19:32.000000000","message":"Are you still working on this or did you miss it by any chance?","commit_id":"3b6658a061e071747e8042ac9fc272a90fe92095"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a53e4a16e3365ed7264bfe5c3647108bd4658516","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"\"\"\")),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027rbd_store_pool\u0027, default\u003dDEFAULT_POOL,"},{"line_number":73,"context_line":"               help\u003d_(\u0027RADOS pool in which images are stored.\u0027)),"},{"line_number":74,"context_line":"    cfg.StrOpt(\u0027rbd_store_user\u0027, default\u003dDEFAULT_USER,"},{"line_number":75,"context_line":"               help\u003d_(\"\"\""},{"line_number":76,"context_line":"RADOS user to authenticate as."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3c81e2fb","line":73,"range":{"start_line":73,"start_character":22,"end_line":73,"end_character":62},"in_reply_to":"bacf61ea_4ca88477","updated":"2016-08-02 03:11:26.000000000","message":"I think it\u0027s missed.","commit_id":"3b6658a061e071747e8042ac9fc272a90fe92095"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a53e4a16e3365ed7264bfe5c3647108bd4658516","unresolved":false,"context_lines":[{"line_number":93,"context_line":"               help\u003d_(\"\"\""},{"line_number":94,"context_line":"Ceph configuration file path."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"This configuration option takes in the relative path to the Ceph"},{"line_number":97,"context_line":"configuration file to be used. If the value for this option is not set"},{"line_number":98,"context_line":"by the user or is set to None, librados will locate the default"},{"line_number":99,"context_line":"configuration. If using Cephx authentication, this file should include"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9cbe0eac","line":96,"range":{"start_line":96,"start_character":39,"end_line":96,"end_character":52},"updated":"2016-08-02 03:11:26.000000000","message":"Why do you say it\u0027s a \u0027relative path\u0027? IMHO, it\u0027s an absolute path.","commit_id":"3b6658a061e071747e8042ac9fc272a90fe92095"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f855a5ef7bb627b7ac84d5b043056591c7d5bc1b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"_LE \u003d i18n._LE"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"_RBD_OPTS \u003d ["},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027rbd_store_chunk_size\u0027, default\u003dDEFAULT_CHUNKSIZE,"},{"line_number":58,"context_line":"               help\u003d_(\"\"\""},{"line_number":59,"context_line":"Size, in megabytes, to chunk RADOS images into."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_9c3a2acc","line":57,"updated":"2016-08-03 16:12:53.000000000","message":"Can we add a \"min\" here?","commit_id":"46ec76add62e3619b5edbf285f844badbf5c105b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f855a5ef7bb627b7ac84d5b043056591c7d5bc1b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"_RBD_OPTS \u003d ["},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027rbd_store_chunk_size\u0027, default\u003dDEFAULT_CHUNKSIZE,"},{"line_number":58,"context_line":"               help\u003d_(\"\"\""},{"line_number":59,"context_line":"Size, in megabytes, to chunk RADOS images into."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The images will be chunked into objects of the size set in megabytes"},{"line_number":62,"context_line":"using this configuration option. For optimal performance, the value"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_41156d47","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":19},"updated":"2016-08-03 16:12:53.000000000","message":"Good addition!","commit_id":"46ec76add62e3619b5edbf285f844badbf5c105b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"5a6997bb32139851f342a0efcec6fa4baf2d7610","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"_RBD_OPTS \u003d ["},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027rbd_store_chunk_size\u0027, default\u003dDEFAULT_CHUNKSIZE,"},{"line_number":58,"context_line":"               min\u003d1,"},{"line_number":59,"context_line":"               help\u003d_(\"\"\""},{"line_number":60,"context_line":"Size, in megabytes, to chunk RADOS images into."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_3bfbc87a","line":58,"range":{"start_line":58,"start_character":15,"end_line":58,"end_character":20},"updated":"2016-08-05 17:16:46.000000000","message":"@Fei Long,\nI asked Itisha to add this. Hope it makes sense. Please let us know what you think. Thanks.","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"3a254f215562c681cf2b7c2941ae7e978095d654","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"_RBD_OPTS \u003d ["},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027rbd_store_chunk_size\u0027, default\u003dDEFAULT_CHUNKSIZE,"},{"line_number":58,"context_line":"               min\u003d1,"},{"line_number":59,"context_line":"               help\u003d_(\"\"\""},{"line_number":60,"context_line":"Size, in megabytes, to chunk RADOS images into."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_3d7435cd","line":58,"range":{"start_line":58,"start_character":15,"end_line":58,"end_character":20},"in_reply_to":"bacf61ea_3bfbc87a","updated":"2016-08-08 04:07:59.000000000","message":"I\u0027m OK with this, given we\u0027re claiming rbd_store_chunk_size is integer. Actually, given we\u0027re using 8MB as default value, so all good.","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5fc6a6fa1fdc4f2a66bee2dd5dd67ef86555ba53","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d_(\"\"\""},{"line_number":60,"context_line":"Size, in megabytes, to chunk RADOS images into."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The images will be chunked into objects of the size set in megabytes"},{"line_number":63,"context_line":"using this configuration option. For optimal performance, the value"},{"line_number":64,"context_line":"should be a power of two."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_ac22d9b6","line":62,"updated":"2016-08-05 21:50:59.000000000","message":"\"Provide an integer value representing the size in megabytes to\nchunk Glance images. The default chunk size is 8 megabytes.\n\nWhen Ceph\u0027s RBD object storage system is used as the storage\nbackend for storing Glance images, the images are chunked into\nobjects of this size set using ``rbd_store_chunk_size``.\nThese chunked objects are then stored across the distributed\nblock data store to use for Glance.\"\n\nmaybe something like this?","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"ee0a43c308dd238936d4916a18382720698abcdc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d_(\"\"\""},{"line_number":60,"context_line":"Size, in megabytes, to chunk RADOS images into."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The images will be chunked into objects of the size set in megabytes"},{"line_number":63,"context_line":"using this configuration option. For optimal performance, the value"},{"line_number":64,"context_line":"should be a power of two."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_6d7618a5","line":62,"in_reply_to":"bacf61ea_ac22d9b6","updated":"2016-08-06 16:16:22.000000000","message":"Done","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"5a6997bb32139851f342a0efcec6fa4baf2d7610","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt(\u0027rbd_store_pool\u0027, default\u003dDEFAULT_POOL,"},{"line_number":74,"context_line":"               help\u003d_(\"\"\""},{"line_number":75,"context_line":"RADOS pool in which images are stored."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible Values:"},{"line_number":78,"context_line":"    * Any valid string that refers to an existing pool."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_dbb1cce1","line":76,"updated":"2016-08-05 17:16:46.000000000","message":"Can we elaborate this a bit more? Or is it too obvious to elaborate any more? \n\nIf you are not too sure, we can request Fei Long to help with this.","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"ee0a43c308dd238936d4916a18382720698abcdc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt(\u0027rbd_store_pool\u0027, default\u003dDEFAULT_POOL,"},{"line_number":74,"context_line":"               help\u003d_(\"\"\""},{"line_number":75,"context_line":"RADOS pool in which images are stored."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible Values:"},{"line_number":78,"context_line":"    * Any valid string that refers to an existing pool."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_cd1d8410","line":76,"in_reply_to":"bacf61ea_87c88ea9","updated":"2016-08-06 16:16:22.000000000","message":"Done","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5fc6a6fa1fdc4f2a66bee2dd5dd67ef86555ba53","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt(\u0027rbd_store_pool\u0027, default\u003dDEFAULT_POOL,"},{"line_number":74,"context_line":"               help\u003d_(\"\"\""},{"line_number":75,"context_line":"RADOS pool in which images are stored."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible Values:"},{"line_number":78,"context_line":"    * Any valid string that refers to an existing pool."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_87c88ea9","line":76,"in_reply_to":"bacf61ea_dbb1cce1","updated":"2016-08-05 21:50:59.000000000","message":"\"Provide a string value representing the RBD store pool to use for storing Glance images.\"\n\nThen maybe you can explain something like:\n\n\"When RBD is used as the storage backend for storing Glance images, the images are broken into chunks of object before storage in the cluster. The storage occurs by means of logical grouping of the objects (chunks of images) into a ``pool``. Each pool is defined with the number of placement groups it can contain.\"\n\nAnd then you can talk a little about the pool that is the default here. \n\nAnd also include a link to the Ceph docs page: http://ceph.com/planet/how-data-is-stored-in-ceph-cluster/","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5fc6a6fa1fdc4f2a66bee2dd5dd67ef86555ba53","unresolved":false,"context_lines":[{"line_number":93,"context_line":"section in rbd_store_ceph_conf."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Possible Values:"},{"line_number":96,"context_line":"    * Any string that is a valid RADOS user."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Related options:"},{"line_number":99,"context_line":"    * rbd_store_ceph_conf"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_473976a3","line":96,"range":{"start_line":96,"start_character":17,"end_line":96,"end_character":24},"updated":"2016-08-05 21:50:59.000000000","message":"representing","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"ee0a43c308dd238936d4916a18382720698abcdc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"section in rbd_store_ceph_conf."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Possible Values:"},{"line_number":96,"context_line":"    * Any string that is a valid RADOS user."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Related options:"},{"line_number":99,"context_line":"    * rbd_store_ceph_conf"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_ed9848c2","line":96,"range":{"start_line":96,"start_character":17,"end_line":96,"end_character":24},"in_reply_to":"bacf61ea_473976a3","updated":"2016-08-06 16:16:22.000000000","message":"Done","commit_id":"ae27131ce58a9b779a131a756fe383bb4f92b143"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a7db90bfd041f17b45a33b9dc598e7285b48b04","unresolved":false,"context_lines":[{"line_number":69,"context_line":"across the distributed block data store to use for Glance."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible Values:"},{"line_number":72,"context_line":"    * Any positive integer value (preferably a power of two)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Related options:"},{"line_number":75,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_8716a6a5","line":72,"range":{"start_line":72,"start_character":33,"end_line":72,"end_character":60},"updated":"2016-08-08 09:02:50.000000000","message":"Redundant, this should become clear from the text above as it\u0027s not hard constraint of the value.","commit_id":"25f9cca08e1dc272c5bccb07a1c80c366421868e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a7db90bfd041f17b45a33b9dc598e7285b48b04","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"RADOS pool in which images are stored."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"When RBD is used as the storage backend for storing Glance images, the"},{"line_number":83,"context_line":"images are broken into chunks of object before storage in the cluster."},{"line_number":84,"context_line":"The storage occurs by means of logical grouping of the objects (chunks"},{"line_number":85,"context_line":"of images) into a ``pool``. Each pool is defined with the number of"},{"line_number":86,"context_line":"placement groups it can contain. The default pool that is used is"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_c7eb7eaf","line":83,"range":{"start_line":82,"start_character":0,"end_line":83,"end_character":70},"updated":"2016-08-08 09:02:50.000000000","message":"While correct This has nothing to do with the rbd_store_pool option. All images and respectively their chunks will be stored by Glance into this one pool.","commit_id":"25f9cca08e1dc272c5bccb07a1c80c366421868e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a7db90bfd041f17b45a33b9dc598e7285b48b04","unresolved":false,"context_lines":[{"line_number":90,"context_line":"http://ceph.com/planet/how-data-is-stored-in-ceph-cluster/"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Possible Values:"},{"line_number":93,"context_line":"    * Any valid string that refers to an existing pool"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Related options:"},{"line_number":96,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_47ef8eb0","line":93,"range":{"start_line":93,"start_character":6,"end_line":93,"end_character":54},"updated":"2016-08-08 09:02:50.000000000","message":"How about \"Valid pool name\" \"Any valid string\" + constraints sounds really counterintuitive.","commit_id":"25f9cca08e1dc272c5bccb07a1c80c366421868e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a7db90bfd041f17b45a33b9dc598e7285b48b04","unresolved":false,"context_lines":[{"line_number":108,"context_line":"section in rbd_store_ceph_conf."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Possible Values:"},{"line_number":111,"context_line":"    * Any string representing a valid RADOS user"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Related options:"},{"line_number":114,"context_line":"    * rbd_store_ceph_conf"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_c75ede75","line":111,"range":{"start_line":111,"start_character":7,"end_line":111,"end_character":32},"updated":"2016-08-08 09:02:50.000000000","message":"Again how about removing this","commit_id":"25f9cca08e1dc272c5bccb07a1c80c366421868e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a7db90bfd041f17b45a33b9dc598e7285b48b04","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"This configuration option takes in the path to the Ceph configuration"},{"line_number":122,"context_line":"file to be used. If the value for this option is not set by the user"},{"line_number":123,"context_line":"or is set to None, librados will locate the default configuration. If"},{"line_number":124,"context_line":"using Cephx authentication, this file should include a reference to"},{"line_number":125,"context_line":"the right keyring in a client.\u003cUSER\u003e section"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_2789bacb","line":123,"range":{"start_line":123,"start_character":40,"end_line":123,"end_character":65},"updated":"2016-08-08 09:02:50.000000000","message":"From where?","commit_id":"25f9cca08e1dc272c5bccb07a1c80c366421868e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a7db90bfd041f17b45a33b9dc598e7285b48b04","unresolved":false,"context_lines":[{"line_number":125,"context_line":"the right keyring in a client.\u003cUSER\u003e section"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Possible Values:"},{"line_number":128,"context_line":"    * Any string that is a valid path to a configuration file"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Related options:"},{"line_number":131,"context_line":"    * rbd_store_user"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_c7d53eba","line":128,"range":{"start_line":128,"start_character":6,"end_line":128,"end_character":25},"updated":"2016-08-08 09:02:50.000000000","message":"ditto","commit_id":"25f9cca08e1dc272c5bccb07a1c80c366421868e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a7db90bfd041f17b45a33b9dc598e7285b48b04","unresolved":false,"context_lines":[{"line_number":135,"context_line":"               help\u003d_(\"\"\""},{"line_number":136,"context_line":"Timeout value for connecting to Ceph cluster."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"This configuration option takes in the timeout value (in seconds) used"},{"line_number":139,"context_line":"when connecting to the Ceph cluster i.e. it sets the time to wait for"},{"line_number":140,"context_line":"glance-api before closing the connection. This prevents glance-api"},{"line_number":141,"context_line":"hangups during the connection to RBD. If the value for this option"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_a7492a91","line":138,"range":{"start_line":138,"start_character":53,"end_line":138,"end_character":65},"updated":"2016-08-08 09:02:50.000000000","message":"The parentheses are redundant here.","commit_id":"25f9cca08e1dc272c5bccb07a1c80c366421868e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a7db90bfd041f17b45a33b9dc598e7285b48b04","unresolved":false,"context_lines":[{"line_number":139,"context_line":"when connecting to the Ceph cluster i.e. it sets the time to wait for"},{"line_number":140,"context_line":"glance-api before closing the connection. This prevents glance-api"},{"line_number":141,"context_line":"hangups during the connection to RBD. If the value for this option"},{"line_number":142,"context_line":"is set to \u003c\u003d 0, no timeout is set and the default librados value is"},{"line_number":143,"context_line":"used."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Possible Values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_871ce678","line":142,"range":{"start_line":142,"start_character":10,"end_line":142,"end_character":12},"updated":"2016-08-08 09:02:50.000000000","message":"I\u0027d prefer writing these out if we are providing a novel for each option anyways.","commit_id":"25f9cca08e1dc272c5bccb07a1c80c366421868e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d20449bdc8867cf136d6210e5c600b18988acac0","unresolved":false,"context_lines":[{"line_number":139,"context_line":"when connecting to the Ceph cluster i.e. it sets the time to wait for"},{"line_number":140,"context_line":"glance-api before closing the connection. This prevents glance-api"},{"line_number":141,"context_line":"hangups during the connection to RBD. If the value for this option"},{"line_number":142,"context_line":"is set to \u003c\u003d 0, no timeout is set and the default librados value is"},{"line_number":143,"context_line":"used."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Possible Values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_a3657ee2","line":142,"range":{"start_line":142,"start_character":10,"end_line":142,"end_character":12},"updated":"2016-08-08 18:37:40.000000000","message":"Think Erno wants you to expand this and mention \"less than or equal to\" explicitly.","commit_id":"f773c95c7a72e739501b092a357eb83a385b2fdd"}]}
