)]}'
{"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"700cfeb9cbd5903d8f931eecec7af24629a3da3e","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\"\"\")),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027swift_store_cacert\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This configuration option enables the operator to use a custom"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_48c58d8c","line":79,"updated":"2016-07-28 19:34:34.000000000","message":"Do we need to mark this opt as  \"required\"?\nAlso, you can include a \"sample_default\" here.","commit_id":"0d0a50d1a7f5dc1c5dbc98824b8e589f32ed618e"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"ba65ffcfece7804303e47adc1879a7695391a87d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\"\"\")),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027swift_store_cacert\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This configuration option enables the operator to use a custom"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_66e7ceb0","line":79,"in_reply_to":"bacf61ea_48c58d8c","updated":"2016-07-29 12:42:15.000000000","message":"No, I don\u0027t think it needs to be marked as \u0027required\u0027 since this option needs to be used only in the case the operator wants to specify a custom CA file, otherwise the default CA truststore is used (both of these in the case that the swift_store_auth_insecure option is set to False). In the case the swift_store_auth_insecure option is set to True, this option would not be required in any case as no SSL certificate verification will be done.","commit_id":"0d0a50d1a7f5dc1c5dbc98824b8e589f32ed618e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"f6784eb0fdf31698753674ce919542fa7d9ad0e1","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\"\"\")),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027swift_store_cacert\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This configuration option enables the operator to use a custom"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_87dc0e47","line":79,"in_reply_to":"bacf61ea_66e7ceb0","updated":"2016-08-01 17:25:41.000000000","message":"+1","commit_id":"0d0a50d1a7f5dc1c5dbc98824b8e589f32ed618e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"700cfeb9cbd5903d8f931eecec7af24629a3da3e","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"This configuration option takes in a string giving the endpoint type"},{"line_number":106,"context_line":"of the Swift service endpoint to use. This setting is only used if"},{"line_number":107,"context_line":"swift_store_auth_version is 2."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Possible values:"},{"line_number":110,"context_line":"    * publicURL"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c8ba1de1","line":107,"updated":"2016-07-28 19:34:34.000000000","message":"Maybe we can add a brief line explaining why this is to be done. \nAnd what about other versions? Do we not set an endpoint? Maybe we can explain that in brief too.","commit_id":"0d0a50d1a7f5dc1c5dbc98824b8e589f32ed618e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"700cfeb9cbd5903d8f931eecec7af24629a3da3e","unresolved":false,"context_lines":[{"line_number":292,"context_line":"This configuration option takes in a list of tenants that will be"},{"line_number":293,"context_line":"granted read/write access on all Swift containers created by Glance in"},{"line_number":294,"context_line":"multi-tenant mode."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Possible values:"},{"line_number":297,"context_line":"    * A comma separated list of strings of one of the forms:"},{"line_number":298,"context_line":"      \u003ctenant_id\u003e:\u003cusername\u003e, \u003ctenant_name\u003e:\u003cusername\u003e and"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_68c4d15e","line":295,"updated":"2016-07-28 19:34:34.000000000","message":"\"The default value is an empty list.\"","commit_id":"0d0a50d1a7f5dc1c5dbc98824b8e589f32ed618e"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d64527fa4c50ff152abeaa866c4df7f33c98b432","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                help\u003d_(\"\"\""},{"line_number":62,"context_line":"Set verification of the server certificate."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"This configuration option takes in a boolean value to determine"},{"line_number":65,"context_line":"whether or not to verify the server certificate. If this option is set"},{"line_number":66,"context_line":"to True, swiftclient won\u0027t check for a valid SSL certificate when"},{"line_number":67,"context_line":"authenticating. If the option is set to False, then the default CA"},{"line_number":68,"context_line":"truststore is used for verification."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_cc7f4d13","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":47},"updated":"2016-08-01 17:25:57.000000000","message":"How about something like this \"This boolean determines whether or not to verify the server certificate.\"\n\nJust trying to make the help text a little more crisp.","commit_id":"00e86f6a43ff93263b355bcb2dc3fc41ab28609c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d64527fa4c50ff152abeaa866c4df7f33c98b432","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"This configuration option enables the operator to use a custom"},{"line_number":84,"context_line":"Certificate Authority file for SSL verification when connecting to"},{"line_number":85,"context_line":"Swift."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Possible values:"},{"line_number":88,"context_line":"    * Any string that is a valid relative path to a CA file."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8caf157c","line":85,"updated":"2016-08-01 17:25:57.000000000","message":"Let\u0027s mention this should be a path to the file.","commit_id":"00e86f6a43ff93263b355bcb2dc3fc41ab28609c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d64527fa4c50ff152abeaa866c4df7f33c98b432","unresolved":false,"context_lines":[{"line_number":103,"context_line":"               help\u003d_(\"\"\""},{"line_number":104,"context_line":"Endpoint Type of Swift service."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"This configuration option takes in a string giving the endpoint type"},{"line_number":107,"context_line":"of the Swift service endpoint to use. The endpoint type determines the"},{"line_number":108,"context_line":"permissions related to the Swift service endpoint. This setting is"},{"line_number":109,"context_line":"only used if swift_store_auth_version is 2."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_6c37414d","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":37},"updated":"2016-08-01 17:25:57.000000000","message":"How about \"This string value indicates the endpoint type to use to fetch the Swift endpoint\"?","commit_id":"00e86f6a43ff93263b355bcb2dc3fc41ab28609c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d64527fa4c50ff152abeaa866c4df7f33c98b432","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Endpoint Type of Swift service."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"This configuration option takes in a string giving the endpoint type"},{"line_number":107,"context_line":"of the Swift service endpoint to use. The endpoint type determines the"},{"line_number":108,"context_line":"permissions related to the Swift service endpoint. This setting is"},{"line_number":109,"context_line":"only used if swift_store_auth_version is 2."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_c7b2864b","line":108,"range":{"start_line":107,"start_character":38,"end_line":108,"end_character":50},"updated":"2016-08-01 17:25:57.000000000","message":"This doesn\u0027t determine the permissions necessarily. But, whatever the endpoint this fetches must allow the store user to perform appropriate actions like reading and writing to the store.","commit_id":"00e86f6a43ff93263b355bcb2dc3fc41ab28609c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d64527fa4c50ff152abeaa866c4df7f33c98b432","unresolved":false,"context_lines":[{"line_number":106,"context_line":"This configuration option takes in a string giving the endpoint type"},{"line_number":107,"context_line":"of the Swift service endpoint to use. The endpoint type determines the"},{"line_number":108,"context_line":"permissions related to the Swift service endpoint. This setting is"},{"line_number":109,"context_line":"only used if swift_store_auth_version is 2."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":"    * publicURL"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a16662ea","line":109,"range":{"start_line":109,"start_character":41,"end_line":109,"end_character":42},"updated":"2016-08-01 17:25:57.000000000","message":"This can be 3 as well. \nIf we mention the explicit versions here, we may have to keep amending this whenever a version is added. How about we say anything that is not 1?\n\nhttps://github.com/openstack/python-swiftclient/blob/master/swiftclient/client.py#L630-L655","commit_id":"00e86f6a43ff93263b355bcb2dc3fc41ab28609c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d64527fa4c50ff152abeaa866c4df7f33c98b432","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                help\u003d_(\"\"\""},{"line_number":292,"context_line":"List of tenants that will be granted admin access."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"This configuration option takes in a list of tenants that will be"},{"line_number":295,"context_line":"granted read/write access on all Swift containers created by Glance in"},{"line_number":296,"context_line":"multi-tenant mode. The default value is an empty list."},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_476176a8","line":294,"range":{"start_line":294,"start_character":0,"end_line":294,"end_character":52},"updated":"2016-08-01 17:25:57.000000000","message":"How about \"This is a list of tenants ....\"?","commit_id":"00e86f6a43ff93263b355bcb2dc3fc41ab28609c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"5f7f59cbca04cc79246ddb9af4bd41180e3b1787","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This configuration option enables the operator to specify the relative"},{"line_number":83,"context_line":"path to a custom Certificate Authority file for SSL verification when"},{"line_number":84,"context_line":"connecting to Swift."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d8ca154f","line":83,"range":{"start_line":82,"start_character":62,"end_line":83,"end_character":4},"updated":"2016-08-08 21:27:50.000000000","message":"Is this always a relative path?","commit_id":"53313218aef7a99ca90abcb5ff0f298f5f4f13e8"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"193b35d98177d931c79409b9043881ad78da1c70","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This configuration option enables the operator to specify the relative"},{"line_number":83,"context_line":"path to a custom Certificate Authority file for SSL verification when"},{"line_number":84,"context_line":"connecting to Swift."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f855591d","line":83,"range":{"start_line":82,"start_character":62,"end_line":83,"end_character":4},"in_reply_to":"9ad45d7e_d8ca154f","updated":"2016-08-08 21:42:30.000000000","message":"Done","commit_id":"53313218aef7a99ca90abcb5ff0f298f5f4f13e8"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"5f7f59cbca04cc79246ddb9af4bd41180e3b1787","unresolved":false,"context_lines":[{"line_number":98,"context_line":"               help\u003d_(\u0027If set, the configured endpoint will be used. If \u0027"},{"line_number":99,"context_line":"                      \u0027None, the storage url from the auth response will be \u0027"},{"line_number":100,"context_line":"                      \u0027used.\u0027)),"},{"line_number":101,"context_line":"    cfg.StrOpt(\u0027swift_store_endpoint_type\u0027, default\u003d\u0027publicURL\u0027,"},{"line_number":102,"context_line":"               help\u003d_(\"\"\""},{"line_number":103,"context_line":"Endpoint Type of Swift service."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_b8ce4158","line":101,"updated":"2016-08-08 21:27:50.000000000","message":"If this takes only one of the three possible value listed below, can we add the \u0027choices\u0027 parameter here?","commit_id":"53313218aef7a99ca90abcb5ff0f298f5f4f13e8"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"193b35d98177d931c79409b9043881ad78da1c70","unresolved":false,"context_lines":[{"line_number":98,"context_line":"               help\u003d_(\u0027If set, the configured endpoint will be used. If \u0027"},{"line_number":99,"context_line":"                      \u0027None, the storage url from the auth response will be \u0027"},{"line_number":100,"context_line":"                      \u0027used.\u0027)),"},{"line_number":101,"context_line":"    cfg.StrOpt(\u0027swift_store_endpoint_type\u0027, default\u003d\u0027publicURL\u0027,"},{"line_number":102,"context_line":"               help\u003d_(\"\"\""},{"line_number":103,"context_line":"Endpoint Type of Swift service."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_18594d5b","line":101,"in_reply_to":"9ad45d7e_b8ce4158","updated":"2016-08-08 21:42:30.000000000","message":"Done","commit_id":"53313218aef7a99ca90abcb5ff0f298f5f4f13e8"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2f28de1ac0bc48f3f8a19582967abc09280d20ed","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"\"\"\")),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027swift_store_cacert\u0027,"},{"line_number":78,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_32de7fdd","line":78,"updated":"2016-08-10 16:22:05.000000000","message":"Can we possibly add \"secret\u003dTrue\" here?","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ee11a0c2fadeb2786378cfa9264d8244a06396af","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"\"\"\")),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027swift_store_cacert\u0027,"},{"line_number":78,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_ff771506","line":78,"in_reply_to":"9ad45d7e_32de7fdd","updated":"2016-08-12 15:56:52.000000000","message":"I\u0027m trying to understand here, why do we need to mark the certificate file as secret?","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b713059decab400e240058477efb92954fd7f0f3","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"\"\"\")),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027swift_store_cacert\u0027,"},{"line_number":78,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_a60f4c2d","line":78,"in_reply_to":"9ad45d7e_c3951289","updated":"2016-08-12 17:13:50.000000000","message":"@Brian, thanks a lot for helping me understand. It is clear now.","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebba53f790e1df488fd87eec180df31af8b98603","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"\"\"\")),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027swift_store_cacert\u0027,"},{"line_number":78,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_c3951289","line":78,"in_reply_to":"9ad45d7e_d16b1d84","updated":"2016-08-12 17:08:01.000000000","message":"@Dharini: the \u0027secret\u0027 option should have been named \u0027obscure_in_logs\u0027.  So if the value of an option is an actual private key, then you want secret\u003dTrue, but if the value is the name of a file containing the private key, probably not. In fact, it would be bad to make this secret\u003dTrue, because if my bundle file is at /my/ca/bundle.crt and I set this value to /my/ca_bundle.crt , it will be very helpful to have the path printed in the log message saying the bundle can\u0027t be found so I can troubleshoot.  \"File ************ not found\" isn\u0027t a very helpful message!","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"42efb9aab7a4c9196edc68c273077055c201523c","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"\"\"\")),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027swift_store_cacert\u0027,"},{"line_number":78,"context_line":"               sample_default\u003d\u0027/ca-bundle.crt\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\"\"\""},{"line_number":80,"context_line":"Path to the CA bundle file."},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_d16b1d84","line":78,"in_reply_to":"9ad45d7e_ff771506","updated":"2016-08-12 16:16:53.000000000","message":"I guess we can skip marking this as secret as it contains the server information, public key and the signature from the CA file (which I guess should be marked as secret)","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"258b5cc20d80dac42587618321933b2ade33a02d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"connecting to Swift."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Possible values:"},{"line_number":87,"context_line":"    * A valid relative path to a CA file"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Related options:"},{"line_number":90,"context_line":"    * swift_store_auth_insecure"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_8fe4d40d","line":87,"range":{"start_line":87,"start_character":14,"end_line":87,"end_character":22},"updated":"2016-08-08 22:46:50.000000000","message":"Relative to what?  Do we know what the working directory is for the process that\u0027s going to use this option?","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"258b5cc20d80dac42587618321933b2ade33a02d","unresolved":false,"context_lines":[{"line_number":297,"context_line":"default value is an empty list."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Possible values:"},{"line_number":300,"context_line":"    * A comma separated list of strings of one of the forms:"},{"line_number":301,"context_line":"      \u003ctenant_id\u003e:\u003cusername\u003e, \u003ctenant_name\u003e:\u003cusername\u003e and"},{"line_number":302,"context_line":"      *:\u003cusername\u003e."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Related options:"},{"line_number":305,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_a2c44f92","line":302,"range":{"start_line":300,"start_character":6,"end_line":302,"end_character":19},"updated":"2016-08-08 22:46:50.000000000","message":"Can you research this some more? The description seems a bit inaccurate since it contains a username as well as a tenant {id, name}.  Is glance_store just passing this directly to swift as an ACL for the containers, or do we do some parsing first?","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"87d73fde318822ae1ddd9684031663b14f501a14","unresolved":false,"context_lines":[{"line_number":297,"context_line":"default value is an empty list."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Possible values:"},{"line_number":300,"context_line":"    * A comma separated list of strings of one of the forms:"},{"line_number":301,"context_line":"      \u003ctenant_id\u003e:\u003cusername\u003e, \u003ctenant_name\u003e:\u003cusername\u003e and"},{"line_number":302,"context_line":"      *:\u003cusername\u003e."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Related options:"},{"line_number":305,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_180868d9","line":302,"range":{"start_line":300,"start_character":6,"end_line":302,"end_character":19},"in_reply_to":"9ad45d7e_07b7b2f5","updated":"2016-08-11 22:40:37.000000000","message":"I am not exactly sure about this. We need to setup the environment to test it and check if it actually works.","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"848d461302af4f5130e7679ac999f837d9d2509a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"default value is an empty list."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Possible values:"},{"line_number":300,"context_line":"    * A comma separated list of strings of one of the forms:"},{"line_number":301,"context_line":"      \u003ctenant_id\u003e:\u003cusername\u003e, \u003ctenant_name\u003e:\u003cusername\u003e and"},{"line_number":302,"context_line":"      *:\u003cusername\u003e."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Related options:"},{"line_number":305,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_d5a8addd","line":302,"range":{"start_line":300,"start_character":6,"end_line":302,"end_character":19},"in_reply_to":"9ad45d7e_5a925d9f","updated":"2016-08-10 16:28:28.000000000","message":"Yeah, on the swift side.\nIf one is using the tenant/user ids, it should work well I think.\nWe should probably get someone from swift to review this part.","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"84fae3816abd6242c3a0384f0d78f2f221136644","unresolved":false,"context_lines":[{"line_number":297,"context_line":"default value is an empty list."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Possible values:"},{"line_number":300,"context_line":"    * A comma separated list of strings of one of the forms:"},{"line_number":301,"context_line":"      \u003ctenant_id\u003e:\u003cusername\u003e, \u003ctenant_name\u003e:\u003cusername\u003e and"},{"line_number":302,"context_line":"      *:\u003cusername\u003e."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Related options:"},{"line_number":305,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_5a925d9f","line":302,"range":{"start_line":300,"start_character":6,"end_line":302,"end_character":19},"in_reply_to":"9ad45d7e_7f7d93e6","updated":"2016-08-09 20:44:33.000000000","message":"I wonder if the name of this option is leftover from the old days where there was just 1 user in a tenant?  Because this seems to specify a list of *users*, not a list of tenants.  Also, I still can\u0027t make any sense of the *:\u003cusername\u003e value.\n\nOne other thing ... when you say \"using names isn\u0027t allowed by default\", you mean on the swift side?  So it looks like this option can\u0027t be used at all in a default swift setup.","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"87dfed941c357a4fc632498dfe0c277d5b6b358b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"default value is an empty list."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Possible values:"},{"line_number":300,"context_line":"    * A comma separated list of strings of one of the forms:"},{"line_number":301,"context_line":"      \u003ctenant_id\u003e:\u003cusername\u003e, \u003ctenant_name\u003e:\u003cusername\u003e and"},{"line_number":302,"context_line":"      *:\u003cusername\u003e."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Related options:"},{"line_number":305,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_7f7d93e6","line":302,"range":{"start_line":300,"start_character":6,"end_line":302,"end_character":19},"in_reply_to":"9ad45d7e_a2c44f92","updated":"2016-08-09 20:29:13.000000000","message":"It does look like ACLs can be specified in either of those forms. However, using names isn\u0027t allowed by default. Names are allowed only when a certain configuration option is set. So, it should be of the form TENANT:USER where TENANT \u003d tenant id or \u0027*\u0027 or tenant name (if names are allowed) and USER \u003d user id or \u0027*\u0027 or user name (if names are allowed).\n\nhttps://github.com/openstack/swift/blob/master/swift/common/middleware/keystoneauth.py#L361-L391\nhttp://docs.openstack.org/developer/swift/overview_auth.html#access-control-using-keystoneauth","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"306043eeb88118349c0a199d4f0dea5bd04ec906","unresolved":false,"context_lines":[{"line_number":297,"context_line":"default value is an empty list."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Possible values:"},{"line_number":300,"context_line":"    * A comma separated list of strings of one of the forms:"},{"line_number":301,"context_line":"      \u003ctenant_id\u003e:\u003cusername\u003e, \u003ctenant_name\u003e:\u003cusername\u003e and"},{"line_number":302,"context_line":"      *:\u003cusername\u003e."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Related options:"},{"line_number":305,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_07b7b2f5","line":302,"range":{"start_line":300,"start_character":6,"end_line":302,"end_character":19},"in_reply_to":"9ad45d7e_d5a8addd","updated":"2016-08-10 20:57:14.000000000","message":"On a second look, this should accept only tenants.\nGlance adds ACLs in the form of \u003ctenant\u003e:* \nSo, this opt is appropriately named from what I see. We should re-do the help text to reflect this. But, whether a tenant name can be specified is still a dilemma.\n\nhttps://github.com/openstack/glance_store/blob/master/glance_store/_drivers/swift/store.py#L1137-L1150","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"fd2d2dd317cec4cf17decfbeae6ff1caed2919ef","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    * A comma separated list of strings of one of the forms:"},{"line_number":301,"context_line":"      \u003ctenant_id\u003e:\u003cusername\u003e, \u003ctenant_name\u003e:\u003cusername\u003e and"},{"line_number":302,"context_line":"      *:\u003cusername\u003e."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Related options:"},{"line_number":305,"context_line":"    * None"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_41dc9674","line":303,"updated":"2016-08-12 10:10:49.000000000","message":"Surprisingly, while the Swift API documentation\n(http://developer.openstack.org/api-ref-objectstorage-v1.html) has a\nsection \u0027Create, update, or delete container metadata\u0027, it doesn\u0027t\ngive as clear details of using ACLs with keystone style syntax as it could.\n\nIt also partially covers it here:\n\nhttp://docs.openstack.org/developer/swift/overview_auth.html\n\n(\u0027Access control using keystoneauth\u0027)\n\nbut there does seem to be gaps in the docs. (I\u0027ve mentioned this to a\nlocal Swift dev).\n\n \u003e which is adding a \u0027:*\u0027 suffix to each value in the\n \u003e swift_store_admin_tenants list.  That makes me think that if I had\n \u003e 12345:fred as a value in the config option, what\u0027s going to get passed to\n \u003e swift is X-Container-Write: 12345:fred:* ... and would swift barf on that,\n \u003e or just ignore the \u0027:*\u0027 part? (I am beyond my swift knowledge here.)\n\nSo from http://docs.openstack.org/developer/swift/overview_auth.html I think what is expected is\n\n  other_project_id:other_user_id\n\n  where other_project_id is the UUID of a Keystone project and\n  other_user_id is the UUID of a Keystone user.\n\nSince we deal mainly in projects (aka tenants), I think other_user_id \nis \u0027*\u0027, so the config should just be \u002712345\u0027, which will give 12345:*\nas the ACL.\n\n\n \u003e So it looks like this option should take a list of tenantIds for sure, but\n \u003e I\u0027m not sure what else could work.\n\nI think a list of project (ie tenant) ids is what is expected. Anything else is probably unexpected (it may or may not work, but it\u0027s not what we want).\n\nSo I think the original (current) glance doc is ok, but it might be worth\ntweaking it to explicitly say tenant *id* (rather than the implied name).","commit_id":"4fe302b02cb8db3213a0720e6fbb6bedb9e4202b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8f97dddc88c3bc67c08d0d3eb6077df8c8af1d64","unresolved":false,"context_lines":[{"line_number":298,"context_line":"default value is an empty list."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Possible values:"},{"line_number":301,"context_line":"    * A comma separated list of strings representing tenant_ids"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"Related options:"},{"line_number":304,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_3f59ad8f","line":301,"range":{"start_line":301,"start_character":59,"end_line":301,"end_character":60},"updated":"2016-08-12 13:49:24.000000000","message":"Let\u0027s drop this.\nHow about this instead \"UUID of Keystone projects/tenants\"?","commit_id":"8e96edfa698ad63b723cb0bd85cfc0fc56fe0438"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b28bc865540b44aa12ddf9a35eb3b73faf48fab1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Possible values:"},{"line_number":113,"context_line":"    * publicURL"},{"line_number":114,"context_line":"    * adminURL"},{"line_number":115,"context_line":"    * internalURL"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Related options:"},{"line_number":118,"context_line":"    * swift_store_endpoint"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_4f2adc2d","line":115,"range":{"start_line":115,"start_character":6,"end_line":115,"end_character":17},"updated":"2016-08-12 19:52:52.000000000","message":"I believe as a further enhancement we will have a brief description of what these values mean for operators to help configure this value properly in a specific deployment model.","commit_id":"fe58b4b0495241d06e4fddac28e2d41cdf8e6097"}]}
