)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d3fa837f8c4d002df6fd335d8e7a8e31269a9d8e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Disable verification for Keystone session in Swift"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The swift backend did not make use of the insecure option in"},{"line_number":10,"context_line":"the config when creating a Keystone session, enable or disable"},{"line_number":11,"context_line":"verification based on it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Steve Kowalik \u003csteven@wedontsleep.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a30ddce_9713eb65","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":51},"updated":"2017-03-08 22:06:55.000000000","message":"The verification is enabled by default as per keystoneauth1 [1].\nIt is an optional parameter and we are not required to enable it.\nIf conf.insecure is True, we can disable it.\n\n[1] https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L233","commit_id":"54b7ccbb9b3cc53dacb368c9953fc2677690d878"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b4f01ccac07603e3a60cd3751b150d12265d29e7","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"                                  user_domain_name\u003duser_domain_name,"},{"line_number":1221,"context_line":"                                  project_domain_id\u003dproject_domain_id,"},{"line_number":1222,"context_line":"                                  project_domain_name\u003dproject_domain_name)"},{"line_number":1223,"context_line":"        trustee_sess \u003d ks_session.Session(auth\u003dpassword)"},{"line_number":1224,"context_line":"        trustee_client \u003d ks_client.Client(session\u003dtrustee_sess)"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"        # request glance user id - we will use it as trustee user"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_efd1ccfc","line":1223,"updated":"2016-07-25 17:19:35.000000000","message":"This should be updated as well, no?","commit_id":"717c3129672826bd7ed5092240e8726d2f9bf69e"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"6378520a505221edb60c27aeef3ead63bfc5abb6","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"                                  user_domain_name\u003duser_domain_name,"},{"line_number":1221,"context_line":"                                  project_domain_id\u003dproject_domain_id,"},{"line_number":1222,"context_line":"                                  project_domain_name\u003dproject_domain_name)"},{"line_number":1223,"context_line":"        trustee_sess \u003d ks_session.Session(auth\u003dpassword)"},{"line_number":1224,"context_line":"        trustee_client \u003d ks_client.Client(session\u003dtrustee_sess)"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"        # request glance user id - we will use it as trustee user"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_0ac9a578","line":1223,"in_reply_to":"dada55a8_efd1ccfc","updated":"2016-07-25 20:46:43.000000000","message":"Done","commit_id":"717c3129672826bd7ed5092240e8726d2f9bf69e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b4f01ccac07603e3a60cd3751b150d12265d29e7","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"        )"},{"line_number":1247,"context_line":"        # now we can authenticate against KS"},{"line_number":1248,"context_line":"        # as trustee of user who provided token"},{"line_number":1249,"context_line":"        client_sess \u003d ks_session.Session(auth\u003dclient_password)"},{"line_number":1250,"context_line":"        return ks_client.Client(session\u003dclient_sess)"},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_0fd700ee","line":1249,"updated":"2016-07-25 17:19:35.000000000","message":"And here?","commit_id":"717c3129672826bd7ed5092240e8726d2f9bf69e"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"6378520a505221edb60c27aeef3ead63bfc5abb6","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"        )"},{"line_number":1247,"context_line":"        # now we can authenticate against KS"},{"line_number":1248,"context_line":"        # as trustee of user who provided token"},{"line_number":1249,"context_line":"        client_sess \u003d ks_session.Session(auth\u003dclient_password)"},{"line_number":1250,"context_line":"        return ks_client.Client(session\u003dclient_sess)"},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_4aa1dda8","line":1249,"in_reply_to":"dada55a8_0fd700ee","updated":"2016-07-25 20:46:43.000000000","message":"Done","commit_id":"717c3129672826bd7ed5092240e8726d2f9bf69e"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"12e44da63d8b1d12b00c672003612c96af1daf71","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"                                  user_domain_name\u003dself.user_domain_name,"},{"line_number":1083,"context_line":"                                  project_domain_id\u003dself.project_domain_id,"},{"line_number":1084,"context_line":"                                  project_domain_name\u003dself.project_domain_name)"},{"line_number":1085,"context_line":"        sess \u003d ks_session.Session(auth\u003dpassword, verify\u003dnot self.insecure)"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"        return ks_client.Client(session\u003dsess)"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_0a715476","line":1085,"updated":"2016-08-01 13:36:36.000000000","message":"Don\u0027t we need self.cacert also here?","commit_id":"d3c1544e9ecf0fc9f5d1bbd39b0b430a6cb3bd97"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2a69646c7a99ab7f7a55be415212f783e0571a9d","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"                                  project_domain_id\u003dself.project_domain_id,"},{"line_number":1278,"context_line":"                                  project_domain_name\u003dself.project_domain_name)"},{"line_number":1279,"context_line":"        sess \u003d ks_session.Session(auth\u003dpassword, verify\u003dnot self.insecure,"},{"line_number":1280,"context_line":"                                  cert\u003dself.cacert)"},{"line_number":1281,"context_line":""},{"line_number":1282,"context_line":"        return ks_client.Client(session\u003dsess)"},{"line_number":1283,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_d87cdbed","line":1280,"updated":"2016-10-24 15:21:47.000000000","message":"Unfortunately, that isn\u0027t how ksa\u0027s cert keyword arg works; that\u0027s for the *client* certificate, rather than a CA bundle:\n\n\u003e A client certificate to pass to requests. These are of the same form as requests expects. Either a single filename containing both the certificate and key or a tuple containing the path to the certificate then a path to the key.\n\nReally, we\u0027ll want it as part of the verify kwarg:\n\n\u003e The verification arguments to pass to requests. These are of the same form as requests expects, so True or False to verify (or not) against system certificates or a path to a bundle or CA certs to check against or None for requests to attempt to locate and use certificates.\n\nBut I\u0027m not sure how to deal with situations like insecure\u003dTrue and cacert\u003dsome_path; what does that even mean? Which half should we be honoring? Again, it might be left as future work.","commit_id":"3a68ff6fc9105e0ffebe189a761201637b45db09"}]}
