)]}'
{"glance_store/backend.py":[{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"80561501fe6a0aba93a92438dc65e2de638bf926","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * http"},{"line_number":50,"context_line":"        * swift"},{"line_number":51,"context_line":"        * s3"},{"line_number":52,"context_line":"        * rbd"},{"line_number":53,"context_line":"        * sheepdog"},{"line_number":54,"context_line":"        * cinder"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d5c87eaa","line":51,"range":{"start_line":51,"start_character":10,"end_line":51,"end_character":12},"updated":"2016-08-05 15:39:20.000000000","message":"This should to be removed as support for the S3 driver has been removed: https://review.openstack.org/#/c/347620/","commit_id":"a749cc5ba609a1039fafb195c06bf94e46dc8e1f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d01ec9e2ae793176d0352ba87803fb9231cdc599","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * http"},{"line_number":50,"context_line":"        * swift"},{"line_number":51,"context_line":"        * s3"},{"line_number":52,"context_line":"        * rbd"},{"line_number":53,"context_line":"        * sheepdog"},{"line_number":54,"context_line":"        * cinder"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_9565661f","line":51,"range":{"start_line":51,"start_character":10,"end_line":51,"end_character":12},"in_reply_to":"bacf61ea_d5c87eaa","updated":"2016-08-05 15:48:38.000000000","message":"Done","commit_id":"a749cc5ba609a1039fafb195c06bf94e46dc8e1f"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"80561501fe6a0aba93a92438dc65e2de638bf926","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        * file"},{"line_number":76,"context_line":"        * http"},{"line_number":77,"context_line":"        * swift"},{"line_number":78,"context_line":"        * s3"},{"line_number":79,"context_line":"        * rbd"},{"line_number":80,"context_line":"        * sheepdog"},{"line_number":81,"context_line":"        * cinder"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_15c7b696","line":78,"range":{"start_line":78,"start_character":10,"end_line":78,"end_character":12},"updated":"2016-08-05 15:39:20.000000000","message":"same here","commit_id":"a749cc5ba609a1039fafb195c06bf94e46dc8e1f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d01ec9e2ae793176d0352ba87803fb9231cdc599","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        * file"},{"line_number":76,"context_line":"        * http"},{"line_number":77,"context_line":"        * swift"},{"line_number":78,"context_line":"        * s3"},{"line_number":79,"context_line":"        * rbd"},{"line_number":80,"context_line":"        * sheepdog"},{"line_number":81,"context_line":"        * cinder"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d56b5eef","line":78,"range":{"start_line":78,"start_character":10,"end_line":78,"end_character":12},"in_reply_to":"bacf61ea_15c7b696","updated":"2016-08-05 15:48:38.000000000","message":"Done","commit_id":"a749cc5ba609a1039fafb195c06bf94e46dc8e1f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"List of enabled Glance stores."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Register the storage backends to use for storing disk images"},{"line_number":40,"context_line":"as a comma separated list with this configuration option. The"},{"line_number":41,"context_line":"default stores enabled for storing disk images with Glance are"},{"line_number":42,"context_line":"``file`` and ``http``. Including additional store names to the"},{"line_number":43,"context_line":"comma separated list for ``stores``, enables them to be used by"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_72886ae8","line":40,"range":{"start_line":40,"start_character":25,"end_line":40,"end_character":56},"updated":"2016-08-08 21:19:57.000000000","message":"This can be dropped.","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":37,"context_line":"List of enabled Glance stores."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Register the storage backends to use for storing disk images"},{"line_number":40,"context_line":"as a comma separated list with this configuration option. The"},{"line_number":41,"context_line":"default stores enabled for storing disk images with Glance are"},{"line_number":42,"context_line":"``file`` and ``http``. Including additional store names to the"},{"line_number":43,"context_line":"comma separated list for ``stores``, enables them to be used by"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_1b6e3996","line":40,"range":{"start_line":40,"start_character":25,"end_line":40,"end_character":56},"in_reply_to":"9ad45d7e_72886ae8","updated":"2016-08-09 15:37:56.000000000","message":"Done","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"\"\"\")),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027default_store\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027file\u0027,"},{"line_number":62,"context_line":"               help\u003d_(\"\"\""},{"line_number":63,"context_line":"The default storage backend to use for storing images."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_b28662b7","line":61,"updated":"2016-08-08 21:19:57.000000000","message":"Since there is a fixed set of values this can take, can we add the \"choices\" argument here?","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"\"\"\")),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027default_store\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027file\u0027,"},{"line_number":62,"context_line":"               help\u003d_(\"\"\""},{"line_number":63,"context_line":"The default storage backend to use for storing images."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_db5b01f5","line":61,"in_reply_to":"9ad45d7e_b28662b7","updated":"2016-08-09 15:37:56.000000000","message":"Done","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               help\u003d_(\"\"\""},{"line_number":63,"context_line":"The default storage backend to use for storing images."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Provide a string value representing the storage backend to be"},{"line_number":66,"context_line":"used by Glance as a default for storing images. If not set,"},{"line_number":67,"context_line":"Glance uses ``file`` as the default scheme for image storage."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The value given to this configuration option must be registered"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_12300e01","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":46},"updated":"2016-08-08 21:19:57.000000000","message":"How about\n\"Provide a string value representing the default storage backend to be used for storing images\"","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               help\u003d_(\"\"\""},{"line_number":63,"context_line":"The default storage backend to use for storing images."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Provide a string value representing the storage backend to be"},{"line_number":66,"context_line":"used by Glance as a default for storing images. If not set,"},{"line_number":67,"context_line":"Glance uses ``file`` as the default scheme for image storage."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The value given to this configuration option must be registered"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_9b6189ab","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":46},"in_reply_to":"9ad45d7e_12300e01","updated":"2016-08-09 15:37:56.000000000","message":"Done","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Provide a string value representing the storage backend to be"},{"line_number":66,"context_line":"used by Glance as a default for storing images. If not set,"},{"line_number":67,"context_line":"Glance uses ``file`` as the default scheme for image storage."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The value given to this configuration option must be registered"},{"line_number":70,"context_line":"as a valid store with the ``stores`` configuration option."}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_fd31cbed","line":67,"range":{"start_line":67,"start_character":36,"end_line":67,"end_character":42},"updated":"2016-08-08 21:19:57.000000000","message":"storage/backend?","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Provide a string value representing the storage backend to be"},{"line_number":66,"context_line":"used by Glance as a default for storing images. If not set,"},{"line_number":67,"context_line":"Glance uses ``file`` as the default scheme for image storage."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The value given to this configuration option must be registered"},{"line_number":70,"context_line":"as a valid store with the ``stores`` configuration option."}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_bb5e0de7","line":67,"range":{"start_line":67,"start_character":36,"end_line":67,"end_character":42},"in_reply_to":"9ad45d7e_fd31cbed","updated":"2016-08-09 15:37:56.000000000","message":"Done","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"as a valid store with the ``stores`` configuration option."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Possible values:"},{"line_number":73,"context_line":"    * A string value representing a registered store that can include:"},{"line_number":74,"context_line":"        * file"},{"line_number":75,"context_line":"        * http"},{"line_number":76,"context_line":"        * swift"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_4931410b","line":73,"range":{"start_line":73,"start_character":6,"end_line":73,"end_character":70},"updated":"2016-08-08 21:19:57.000000000","message":"\"One of the following\"?\nOr we can even get rid of this. Just list the seven possible values should be fine (like how we list \"True\" and \"Fasel\" for a BoolOpt)","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":70,"context_line":"as a valid store with the ``stores`` configuration option."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Possible values:"},{"line_number":73,"context_line":"    * A string value representing a registered store that can include:"},{"line_number":74,"context_line":"        * file"},{"line_number":75,"context_line":"        * http"},{"line_number":76,"context_line":"        * swift"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_7b5655d3","line":73,"range":{"start_line":73,"start_character":6,"end_line":73,"end_character":70},"in_reply_to":"9ad45d7e_4931410b","updated":"2016-08-09 15:37:56.000000000","message":"Done","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"               default\u003d0,"},{"line_number":88,"context_line":"               min\u003d0,"},{"line_number":89,"context_line":"               help\u003d_(\"\"\""},{"line_number":90,"context_line":"Minimum interval of wait before attempting an update of store"},{"line_number":91,"context_line":"capabilities."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Provide an integer value representing time in seconds to set the"},{"line_number":94,"context_line":"minimum interval before an update of dynamic storage capabilities"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_5d9bb7c9","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":13},"updated":"2016-08-08 21:19:57.000000000","message":"How about \"Minimum interval to wait before attempting to update store capabilities.\"?","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":87,"context_line":"               default\u003d0,"},{"line_number":88,"context_line":"               min\u003d0,"},{"line_number":89,"context_line":"               help\u003d_(\"\"\""},{"line_number":90,"context_line":"Minimum interval of wait before attempting an update of store"},{"line_number":91,"context_line":"capabilities."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Provide an integer value representing time in seconds to set the"},{"line_number":94,"context_line":"minimum interval before an update of dynamic storage capabilities"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_7007941c","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":13},"in_reply_to":"9ad45d7e_5d9bb7c9","updated":"2016-08-09 15:37:56.000000000","message":"Done","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"integer value greater than zero to enable this option."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"NOTE: Setting ``store_capabilities_update_min_interval`` does not"},{"line_number":101,"context_line":"cause updates to occur periodically based on the set interval. The"},{"line_number":102,"context_line":"update is performed based on the results of a check on the driver"},{"line_number":103,"context_line":"configuration and status of the storage backend at the elapse of"},{"line_number":104,"context_line":"the interval set."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_383c1193","line":104,"range":{"start_line":101,"start_character":63,"end_line":104,"end_character":17},"updated":"2016-08-08 21:19:57.000000000","message":"What does it mean for the operator? How does an operator know the capabilities have been updated? This sounds a bit non-deterministic at the moment. As an operator, what do I set this value to and why?","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":98,"context_line":"integer value greater than zero to enable this option."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"NOTE: Setting ``store_capabilities_update_min_interval`` does not"},{"line_number":101,"context_line":"cause updates to occur periodically based on the set interval. The"},{"line_number":102,"context_line":"update is performed based on the results of a check on the driver"},{"line_number":103,"context_line":"configuration and status of the storage backend at the elapse of"},{"line_number":104,"context_line":"the interval set."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_300d1c3f","line":104,"range":{"start_line":101,"start_character":63,"end_line":104,"end_character":17},"in_reply_to":"9ad45d7e_383c1193","updated":"2016-08-09 15:37:56.000000000","message":"Added a better explanation from an operators point of view.","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"update is performed based on the results of a check on the driver"},{"line_number":103,"context_line":"configuration and status of the storage backend at the elapse of"},{"line_number":104,"context_line":"the interval set."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * 0"},{"line_number":108,"context_line":"    * Positive integer"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_9d352f48","line":105,"updated":"2016-08-08 21:19:57.000000000","message":"Let\u0027s include this link for more info on store capabilities\nhttps://specs.openstack.org/openstack/glance-specs/specs/kilo/store-capabilities.html","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":102,"context_line":"update is performed based on the results of a check on the driver"},{"line_number":103,"context_line":"configuration and status of the storage backend at the elapse of"},{"line_number":104,"context_line":"the interval set."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * 0"},{"line_number":108,"context_line":"    * Positive integer"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_1008d82c","line":105,"in_reply_to":"9ad45d7e_9d352f48","updated":"2016-08-09 15:37:56.000000000","message":"Done","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"745a043dbe2aeae52bc73e322e29c1304a3fd30d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"the interval set."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * 0"},{"line_number":108,"context_line":"    * Positive integer"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Related Options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_2c521b14","line":107,"range":{"start_line":107,"start_character":6,"end_line":107,"end_character":7},"updated":"2016-08-08 21:19:57.000000000","message":"Let\u0027s spell this.","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d70b04b113b0449f3913e74250bb86e72cd85bde","unresolved":false,"context_lines":[{"line_number":104,"context_line":"the interval set."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Possible values:"},{"line_number":107,"context_line":"    * 0"},{"line_number":108,"context_line":"    * Positive integer"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Related Options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_db44a11c","line":107,"range":{"start_line":107,"start_character":6,"end_line":107,"end_character":7},"in_reply_to":"9ad45d7e_2c521b14","updated":"2016-08-09 15:37:56.000000000","message":"Done","commit_id":"1bd4dfd7a6f6ae9728dfe5607cb9d9b523242760"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5d991670b876ea1fe10e1e13a08757c14c9dd4b7","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    * stores"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"\"\"\")),"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027store_capabilities_update_min_interval\u0027,"},{"line_number":88,"context_line":"               default\u003d0,"},{"line_number":89,"context_line":"               min\u003d0,"},{"line_number":90,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_8aedb4f1","line":87,"updated":"2016-08-09 16:12:30.000000000","message":"This config options works for some storage backends that provide advanced capabilities.","commit_id":"b8df1409b2cb2666f06810bcb194cc2eca52959b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"84ef7e281da3c307421c3d990fded013ff62e969","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    * stores"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"\"\"\")),"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027store_capabilities_update_min_interval\u0027,"},{"line_number":88,"context_line":"               default\u003d0,"},{"line_number":89,"context_line":"               min\u003d0,"},{"line_number":90,"context_line":"               help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_60034143","line":87,"in_reply_to":"9ad45d7e_8aedb4f1","updated":"2016-08-09 16:45:48.000000000","message":"Done","commit_id":"b8df1409b2cb2666f06810bcb194cc2eca52959b"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5d991670b876ea1fe10e1e13a08757c14c9dd4b7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               default\u003d0,"},{"line_number":89,"context_line":"               min\u003d0,"},{"line_number":90,"context_line":"               help\u003d_(\"\"\""},{"line_number":91,"context_line":"Minimum interval to wait before attempting to update store"},{"line_number":92,"context_line":"capabilities."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_6a732081","line":91,"updated":"2016-08-09 16:12:30.000000000","message":"dynamic store capab.\n\nIn fact, you should copy over the first line from older description.","commit_id":"b8df1409b2cb2666f06810bcb194cc2eca52959b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"84ef7e281da3c307421c3d990fded013ff62e969","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               default\u003d0,"},{"line_number":89,"context_line":"               min\u003d0,"},{"line_number":90,"context_line":"               help\u003d_(\"\"\""},{"line_number":91,"context_line":"Minimum interval to wait before attempting to update store"},{"line_number":92,"context_line":"capabilities."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_00ec058e","line":91,"in_reply_to":"9ad45d7e_6a732081","updated":"2016-08-09 16:45:48.000000000","message":"Done","commit_id":"b8df1409b2cb2666f06810bcb194cc2eca52959b"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5d991670b876ea1fe10e1e13a08757c14c9dd4b7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"For more information on store capabilities and their updates, please"},{"line_number":108,"context_line":"visit: https://specs.openstack.org/openstack/glance-specs/specs/ \\"},{"line_number":109,"context_line":"kilo/store-capabilities.html"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":"    * Zero"},{"line_number":113,"context_line":"    * Positive integer"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_2a0da890","line":110,"updated":"2016-08-09 16:12:30.000000000","message":"The current spec doesn\u0027t give any examples of such capabilities when this is needed. Also, Glance team isn\u0027t maintaining any driver that supports this capability. So, this description is okay for a first pass for me (besides the above suggestions).\n\nWe should let a note out to driver maint. to ensure they are aware of this help text change and  can add examples for their deployments.\n\nOn second thought, you can add a link to the individual maint. http://docs.openstack.org/developer/glance_store/drivers/index.html  and indicate that for more information to setup a particular store in your deployment, you should contact these personnel.","commit_id":"b8df1409b2cb2666f06810bcb194cc2eca52959b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"84ef7e281da3c307421c3d990fded013ff62e969","unresolved":false,"context_lines":[{"line_number":107,"context_line":"For more information on store capabilities and their updates, please"},{"line_number":108,"context_line":"visit: https://specs.openstack.org/openstack/glance-specs/specs/ \\"},{"line_number":109,"context_line":"kilo/store-capabilities.html"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":"    * Zero"},{"line_number":113,"context_line":"    * Positive integer"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_20e94981","line":110,"in_reply_to":"9ad45d7e_2a0da890","updated":"2016-08-09 16:45:48.000000000","message":"Thanks for the clarification Nikhil. \nIncorporated the suggested changes.","commit_id":"b8df1409b2cb2666f06810bcb194cc2eca52959b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"db4ffc3e99f48c173c8b57721f539f6ea8414fb3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               default\u003d0,"},{"line_number":89,"context_line":"               min\u003d0,"},{"line_number":90,"context_line":"               help\u003d_(\"\"\""},{"line_number":91,"context_line":"Minimum interval seconds to execute updating dynamic storage"},{"line_number":92,"context_line":"capabilities based on backend status then."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_9e4cd271","line":91,"updated":"2016-08-09 17:11:53.000000000","message":"in?","commit_id":"cc040a6359877e2db81dc8f3a796bbd4b2031e04"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9f689890a31c88a0c5306a4b1ab6a97739af8dc9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               default\u003d0,"},{"line_number":89,"context_line":"               min\u003d0,"},{"line_number":90,"context_line":"               help\u003d_(\"\"\""},{"line_number":91,"context_line":"Minimum interval seconds to execute updating dynamic storage"},{"line_number":92,"context_line":"capabilities based on backend status then."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_feea2eab","line":91,"in_reply_to":"9ad45d7e_9e4cd271","updated":"2016-08-09 17:17:00.000000000","message":"Done","commit_id":"cc040a6359877e2db81dc8f3a796bbd4b2031e04"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"db4ffc3e99f48c173c8b57721f539f6ea8414fb3","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"For more information on setting up a particular store in your"},{"line_number":110,"context_line":"deplyment and help with the usage of this feature, please contact"},{"line_number":111,"context_line":"personnel form the store maintenance. Contact information can be"},{"line_number":112,"context_line":"found at: http://docs.openstack.org/developer/glance_store/drivers/ \\"},{"line_number":113,"context_line":"index.html"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_fe5a2e29","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":5},"updated":"2016-08-09 17:11:53.000000000","message":"the storage driver maintainers listed","commit_id":"cc040a6359877e2db81dc8f3a796bbd4b2031e04"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9f689890a31c88a0c5306a4b1ab6a97739af8dc9","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"For more information on setting up a particular store in your"},{"line_number":110,"context_line":"deplyment and help with the usage of this feature, please contact"},{"line_number":111,"context_line":"personnel form the store maintenance. Contact information can be"},{"line_number":112,"context_line":"found at: http://docs.openstack.org/developer/glance_store/drivers/ \\"},{"line_number":113,"context_line":"index.html"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_bee0b6cd","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":5},"in_reply_to":"9ad45d7e_fe5a2e29","updated":"2016-08-09 17:17:00.000000000","message":"Done","commit_id":"cc040a6359877e2db81dc8f3a796bbd4b2031e04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9066aef99aaa696a9e9f5feae0dde593d10e66f1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"as a comma separated list. The default stores enabled for"},{"line_number":41,"context_line":"storing disk images with Glance are ``file`` and ``http``."},{"line_number":42,"context_line":"Including additional store names to the comma separated list"},{"line_number":43,"context_line":"for ``stores``, enables them to be used by Glance as storage"},{"line_number":44,"context_line":"backends for image storage."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_2861f005","line":43,"range":{"start_line":43,"start_character":14,"end_line":43,"end_character":15},"updated":"2016-08-10 17:45:38.000000000","message":"Don\u0027t need this comma.","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9066aef99aaa696a9e9f5feae0dde593d10e66f1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"backends for image storage."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Possible values:"},{"line_number":47,"context_line":"    * A comma separated list that could include:"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * http"},{"line_number":50,"context_line":"        * swift"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_26fbe17a","line":47,"updated":"2016-08-10 17:45:38.000000000","message":"See my comment about the next option before reading this one.\n\nOK, so I wonder whether these are supposed to be *schemes* and not datastore names? The vmware store, for example, seems to identify itself as \u0027vmware_datastore\u0027: see https://github.com/openstack/glance_store/blob/197c39415b0f20375a8cbe9294dfca8c708fd7b5/glance_store/_drivers/vmware_datastore.py#L408 as well as other places in that file.","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a7b0e4150022cb0e5c0cba39277f623595be0aaa","unresolved":false,"context_lines":[{"line_number":44,"context_line":"backends for image storage."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Possible values:"},{"line_number":47,"context_line":"    * A comma separated list that could include:"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * http"},{"line_number":50,"context_line":"        * swift"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_bcd99959","line":47,"in_reply_to":"9ad45d7e_26fbe17a","updated":"2016-08-10 20:36:32.000000000","message":"I was able to verify on devstack that these values should be store names. Specifying scheme here fails glance-api start up.","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"4eaafabef0546152fe1d04c3cd1133fccf56f5e4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"backends for image storage."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Possible values:"},{"line_number":47,"context_line":"    * A comma separated list that could include:"},{"line_number":48,"context_line":"        * file"},{"line_number":49,"context_line":"        * http"},{"line_number":50,"context_line":"        * swift"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_1c0a6579","line":47,"in_reply_to":"9ad45d7e_bcd99959","updated":"2016-08-10 20:40:29.000000000","message":"Thanks Hemanth. In that case it makes sense to say that these are the store names that have schemes. And, the value for ``default_store`` must be a scheme which is registered with one of the stores that is in turn registered with the ``stores`` opt. Right?","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9066aef99aaa696a9e9f5feae0dde593d10e66f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        \u0027vmware\u0027),"},{"line_number":64,"context_line":"               help\u003d_(\"\"\""},{"line_number":65,"context_line":"The default storage backend to use for storing images."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Provide a string value representing the default storage backend"},{"line_number":68,"context_line":"to be used for storing images. If not set, Glance uses ``file``"},{"line_number":69,"context_line":"as the default storage backend for image storage."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_26c76197","line":66,"updated":"2016-08-10 17:45:38.000000000","message":"I\u0027m a bit worried about this one -- it\u0027s a big change from the old description, and my reading of the code is that what\u0027s supposed to be here is a scheme, not a store name: see https://github.com/openstack/glance_store/blob/197c39415b0f20375a8cbe9294dfca8c708fd7b5/glance_store/backend.py#L213 where it uses the value of this option to do a reverse lookup in a table and find the store.  If I am right, this is a horribly named option, but I guess that\u0027s a different bug.\n\nIt does make sense that this would be a scheme, not a store, though, because some stores can handle multiple schemes, and there might be some advantage to using a particular one.  On the other hand, this doesn\u0027t make a lot of sense because how do you avoid clashes in the table?  So someone other than me needs to look at this to verify my claim that this value should really be a scheme.\n\nIf I\u0027m correct, some of these values need to change.  For example, the vmware store uses \u0027vsphere\u0027 as its scheme: https://github.com/openstack/glance_store/blob/197c39415b0f20375a8cbe9294dfca8c708fd7b5/glance_store/_drivers/vmware_datastore.py#L60","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"3429ebc1b443d2983d100a50f2bb7b90653cf87a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        \u0027vmware\u0027),"},{"line_number":64,"context_line":"               help\u003d_(\"\"\""},{"line_number":65,"context_line":"The default storage backend to use for storing images."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Provide a string value representing the default storage backend"},{"line_number":68,"context_line":"to be used for storing images. If not set, Glance uses ``file``"},{"line_number":69,"context_line":"as the default storage backend for image storage."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_379b0974","line":66,"in_reply_to":"9ad45d7e_26c76197","updated":"2016-08-10 18:48:02.000000000","message":"I am a little confused with the usage of the term \"scheme\". \nAccording to the old help text description, if this were the scheme and not a store name, why would the \"scheme\" need to be registered as a store with the ``stores`` config option?\nhttp://docs.openstack.org/developer/glance/configuring.html#configuring-glance-storage-backends\nBut at the same time as you pointed out, the store for vmware is referred as vamware_datastore and the file scheme as `filesystem`.\nHoping to get a better understanding on this..","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"481f970f6adf54269183b08106d2640819277e50","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        \u0027vmware\u0027),"},{"line_number":64,"context_line":"               help\u003d_(\"\"\""},{"line_number":65,"context_line":"The default storage backend to use for storing images."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Provide a string value representing the default storage backend"},{"line_number":68,"context_line":"to be used for storing images. If not set, Glance uses ``file``"},{"line_number":69,"context_line":"as the default storage backend for image storage."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_56b15e46","line":66,"in_reply_to":"9ad45d7e_379b0974","updated":"2016-08-10 19:37:29.000000000","message":"At least from the code, it looks like default_store takes a scheme like Brian pointed out. But, the stores option takes store names. This should be easy to verify on devstack.","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"bd5bf5b60a506a5287706c78ce79f213c7bc3b81","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        \u0027vmware\u0027),"},{"line_number":64,"context_line":"               help\u003d_(\"\"\""},{"line_number":65,"context_line":"The default storage backend to use for storing images."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Provide a string value representing the default storage backend"},{"line_number":68,"context_line":"to be used for storing images. If not set, Glance uses ``file``"},{"line_number":69,"context_line":"as the default storage backend for image storage."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e2640c23","line":66,"in_reply_to":"9ad45d7e_56b15e46","updated":"2016-08-10 21:30:17.000000000","message":"Brian is right, this must be a scheme. And, I verified this on devstack. It\u0027s misleading though. \n\nWe should probably mention this explicitly and also mention all the schemes associated with a store.","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9066aef99aaa696a9e9f5feae0dde593d10e66f1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"               min\u003d0,"},{"line_number":90,"context_line":"               help\u003d_(\"\"\""},{"line_number":91,"context_line":"Minimum interval in seconds to execute updating dynamic storage"},{"line_number":92,"context_line":"capabilities based on backend status then."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Provide an integer value representing time in seconds to set the"},{"line_number":95,"context_line":"minimum interval before an update of dynamic storage capabilities"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_6b1f62b7","line":92,"range":{"start_line":92,"start_character":13,"end_line":92,"end_character":41},"updated":"2016-08-10 17:45:38.000000000","message":"I think this would be more clear as \"based on current backend status\".","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9066aef99aaa696a9e9f5feae0dde593d10e66f1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"integer value greater than zero to enable this option."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"NOTE: For more information on store capabilities and their updates,"},{"line_number":106,"context_line":"please visit: https://specs.openstack.org/openstack/glance-specs/ \\"},{"line_number":107,"context_line":"specs/kilo/store-capabilities.html"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"For more information on setting up a particular store in your"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_eba99291","line":106,"range":{"start_line":106,"start_character":65,"end_line":106,"end_character":66},"updated":"2016-08-10 17:45:38.000000000","message":"I think you need to remove this space or it will be included in the URL (that\u0027s what happens in the interpreter, anyway).","commit_id":"90907980f02144a81d939e6ecbc591c9454e0ece"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"7a9d6dd9e326e4aa3708e09999f6bd4b1027faeb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    * rbd"},{"line_number":85,"context_line":"    * sheepdog"},{"line_number":86,"context_line":"    * cinder"},{"line_number":87,"context_line":"    * vmsphere"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Related Options:"},{"line_number":90,"context_line":"    * stores"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_d8050215","line":87,"range":{"start_line":87,"start_character":6,"end_line":87,"end_character":14},"updated":"2016-08-12 15:44:06.000000000","message":"vsphere","commit_id":"cd995f546f41536a317abccda86446634af16740"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e76dd17aa3fec03b2903491d9f2512f4d5729a73","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\"\"\")),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027default_store\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027file\u0027,"},{"line_number":62,"context_line":"               choices\u003d(\u0027file\u0027, \u0027http\u0027, \u0027swift\u0027, \u0027rbd\u0027, \u0027sheepdog\u0027, \u0027cinder\u0027,"},{"line_number":63,"context_line":"                        \u0027vmware\u0027),"},{"line_number":64,"context_line":"               help\u003d_(\"\"\""},{"line_number":65,"context_line":"The default scheme to use for storing images."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_3bba586f","line":63,"range":{"start_line":62,"start_character":23,"end_line":63,"end_character":33},"updated":"2016-08-12 15:55:16.000000000","message":"These need to be changed as well to schemes.","commit_id":"a46e1fee1d9c659b2b550a7bf9d87a7876c4346f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"42018087ca9c43f85a057d31ffe50588ec49bb7b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\"\"\")),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027default_store\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027file\u0027,"},{"line_number":62,"context_line":"               choices\u003d(\u0027file\u0027, \u0027http\u0027, \u0027swift\u0027, \u0027rbd\u0027, \u0027sheepdog\u0027, \u0027cinder\u0027,"},{"line_number":63,"context_line":"                        \u0027vmware\u0027),"},{"line_number":64,"context_line":"               help\u003d_(\"\"\""},{"line_number":65,"context_line":"The default scheme to use for storing images."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_56b3a30a","line":63,"range":{"start_line":62,"start_character":23,"end_line":63,"end_character":33},"in_reply_to":"9ad45d7e_3bba586f","updated":"2016-08-12 16:02:37.000000000","message":"Done.\nApologies for carelessly skipping the change of this.","commit_id":"a46e1fee1d9c659b2b550a7bf9d87a7876c4346f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3c34a6710c34f7f40ef280e0f1235005bfdee500","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Register the storage backends to use for storing disk images"},{"line_number":40,"context_line":"as a comma separated list. The default stores enabled for"},{"line_number":41,"context_line":"storing disk images with Glance are ``file`` and ``http``."},{"line_number":42,"context_line":"Including additional store names to the comma separated list"},{"line_number":43,"context_line":"for ``stores`` enables them to be used by Glance as storage"},{"line_number":44,"context_line":"backends for image storage."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_36026f70","line":42,"range":{"start_line":42,"start_character":21,"end_line":42,"end_character":32},"updated":"2016-08-12 16:08:56.000000000","message":"Since there is confusion around whether these are store names or not, I\u0027m thinking if we should just call them stores instead.\nNot sure, just a thought.","commit_id":"d200c48edc6f2eb7016dc3cff7c5c0d172db3b4f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"22f33cdcdb28b55a4e00293c7987801ac4f22920","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Register the storage backends to use for storing disk images"},{"line_number":40,"context_line":"as a comma separated list. The default stores enabled for"},{"line_number":41,"context_line":"storing disk images with Glance are ``file`` and ``http``."},{"line_number":42,"context_line":"Including additional store names to the comma separated list"},{"line_number":43,"context_line":"for ``stores`` enables them to be used by Glance as storage"},{"line_number":44,"context_line":"backends for image storage."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_4f865c14","line":42,"range":{"start_line":42,"start_character":21,"end_line":42,"end_character":32},"in_reply_to":"9ad45d7e_36026f70","updated":"2016-08-12 19:54:57.000000000","message":"Done","commit_id":"d200c48edc6f2eb7016dc3cff7c5c0d172db3b4f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"14f34788b5498a635e396509b52d1637f4730c97","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Register the storage backends to use for storing disk images"},{"line_number":40,"context_line":"as a comma separated list. The default stores enabled for"},{"line_number":41,"context_line":"storing disk images with Glance are ``file`` and ``http``."},{"line_number":42,"context_line":"Include additional stores to the comma separated list to"},{"line_number":43,"context_line":"enables them to be used by Glance as storage backends for"},{"line_number":44,"context_line":"image storage."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Possible values:"},{"line_number":47,"context_line":"    * A comma separated list that could include:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_bd5f4571","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":14},"updated":"2016-08-15 16:38:48.000000000","message":"Sorry I didn\u0027t catch this earlier, but this makes it sound like you have to add the other stores to the default list, whereas in fact, you could completely replace it with different values.  On re-reading, I think you can simple delete this sentence--I think everything you want to say is already there in the first 2 sentences.","commit_id":"c5ac848ddb0dd656b563ca53187f8586c2407e95"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"deeb31ded241bc3cb12c32ec7cb18e8caf24e58d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Register the storage backends to use for storing disk images"},{"line_number":40,"context_line":"as a comma separated list. The default stores enabled for"},{"line_number":41,"context_line":"storing disk images with Glance are ``file`` and ``http``."},{"line_number":42,"context_line":"Include additional stores to the comma separated list to"},{"line_number":43,"context_line":"enables them to be used by Glance as storage backends for"},{"line_number":44,"context_line":"image storage."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Possible values:"},{"line_number":47,"context_line":"    * A comma separated list that could include:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_e05ab482","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":14},"in_reply_to":"3ac371cc_bd5f4571","updated":"2016-08-15 16:50:12.000000000","message":"Done","commit_id":"c5ac848ddb0dd656b563ca53187f8586c2407e95"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"14f34788b5498a635e396509b52d1637f4730c97","unresolved":false,"context_lines":[{"line_number":110,"context_line":"integer value greater than zero to enable this option."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"NOTE: For more information on store capabilities and their updates,"},{"line_number":113,"context_line":"please visit: https://specs.openstack.org/openstack/glance-specs/"},{"line_number":114,"context_line":"specs/kilo/store-capabilities.html"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"For more information on setting up a particular store in your"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_5d59f159","line":113,"updated":"2016-08-15 16:38:48.000000000","message":"I think you need the backslash here to get the url all on one line (my comment on PS5 was that you needed to eliminate the space in front of the \\).\n\nI think you need to have\n\n    ...glance-specs/\\\n    specs/kilo/...","commit_id":"c5ac848ddb0dd656b563ca53187f8586c2407e95"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"deeb31ded241bc3cb12c32ec7cb18e8caf24e58d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"integer value greater than zero to enable this option."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"NOTE: For more information on store capabilities and their updates,"},{"line_number":113,"context_line":"please visit: https://specs.openstack.org/openstack/glance-specs/"},{"line_number":114,"context_line":"specs/kilo/store-capabilities.html"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"For more information on setting up a particular store in your"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_809ae012","line":113,"in_reply_to":"3ac371cc_5d59f159","updated":"2016-08-15 16:50:12.000000000","message":"Done","commit_id":"c5ac848ddb0dd656b563ca53187f8586c2407e95"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"0bc59317fe103ee4a2c1de6c178651cba20690b3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                help\u003d_(\"\"\""},{"line_number":37,"context_line":"List of enabled Glance stores."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Register the storage backends to use for storing disk images"},{"line_number":40,"context_line":"as a comma separated list. The default stores enabled for"},{"line_number":41,"context_line":"storing disk images with Glance are ``file`` and ``http``."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_fa3a58cc","line":39,"range":{"start_line":39,"start_character":49,"end_line":39,"end_character":60},"updated":"2016-08-15 19:54:29.000000000","message":"\"image data\"\n\nas we now store \u0027ova\u0027 packages too in backend stores","commit_id":"9b245541b18b055641fb7645f0b32147d0405efc"}]}
