)]}'
{"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2e22b32ac60d92766c0dd28bb1e2217bebfeb55b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Provide a string value representing the service type to use for"},{"line_number":124,"context_line":"storing images while using Swift backend storage. The default"},{"line_number":125,"context_line":"service type is set to ``object-store``."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"NOTE: This setting is only used if swift_store_auth_version is 2."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2fbd3802","line":126,"updated":"2016-08-05 23:24:55.000000000","message":"What are the other possible values this opt could have?","commit_id":"539670406f122e5fc65238328fa2fdebe7f2fd76"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"462c9f3700c37bd376c8c29637f875693668e5e7","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"NOTE: Setting the region with ``swift_store_region`` is"},{"line_number":79,"context_line":"tenant-specific and is necessary only if the tenant has"},{"line_number":80,"context_line":"multiple endpoints. This setting is only used if"},{"line_number":81,"context_line":"``swift_store_auth_version`` is 2"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Possible values:"},{"line_number":84,"context_line":"    * A string valure representing a valid Swift region."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_cb4285aa","line":81,"range":{"start_line":80,"start_character":20,"end_line":81,"end_character":33},"updated":"2016-08-06 16:11:43.000000000","message":"I think it can also be used when the auth version is 3.","commit_id":"abf55397f7fe3e2eb5e98184185e257724240fd6"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"462c9f3700c37bd376c8c29637f875693668e5e7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"``swift_store_auth_version`` is 2"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Possible values:"},{"line_number":84,"context_line":"    * A string valure representing a valid Swift region."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Related Options:"},{"line_number":87,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_4bacd59e","line":84,"range":{"start_line":84,"start_character":15,"end_line":84,"end_character":21},"updated":"2016-08-06 16:11:43.000000000","message":"Small typo: \u0027value\u0027","commit_id":"abf55397f7fe3e2eb5e98184185e257724240fd6"},{"author":{"_account_id":18117,"name":"Itisha Dewan","email":"ishadewan07@gmail.com","username":"itisha"},"change_message_id":"462c9f3700c37bd376c8c29637f875693668e5e7","unresolved":false,"context_lines":[{"line_number":124,"context_line":"storing images while using Swift backend storage. The default"},{"line_number":125,"context_line":"service type is set to ``object-store``."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"NOTE: This setting is only used if ``swift_store_auth_version``"},{"line_number":128,"context_line":"is 2."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Possible values:"},{"line_number":131,"context_line":"    * A string representing a valid service type for Swift storage."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_6b0a797a","line":128,"range":{"start_line":127,"start_character":6,"end_line":128,"end_character":5},"updated":"2016-08-06 16:11:43.000000000","message":"I think this can also be used when the auth version is 3.","commit_id":"abf55397f7fe3e2eb5e98184185e257724240fd6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ca5a24db29f6c934a0dffda299fab7b14d0d15cd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"can connect to for image storage. By default, there is no region"},{"line_number":71,"context_line":"set."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"When Glance uses Swift as the storage backend to store images"},{"line_number":74,"context_line":"for a specific tenant that has multiple endpoints, setting of"},{"line_number":75,"context_line":"a Swift region with ``swift_store_region`` allows Glance to"},{"line_number":76,"context_line":"connect to Swift in the specified region as opposed to a"},{"line_number":77,"context_line":"single region connectivity."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_7148712e","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":49},"updated":"2016-08-08 17:29:37.000000000","message":"The old help text implies that this is only used for single-tenant storage ... is that correct?  If so, that should be mentioned here.\n\n(You can configure the swift store for single tenant (one tenant owns all the image data for all images) or multi-tenant (the image data for an image is stored in the swift account of the tenant who owns the image).)","commit_id":"cf745cab222a30ece46b35c94e18a5a3ca672142"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"be179e6c92522c3949b5f7044983b1c7f05caa94","unresolved":false,"context_lines":[{"line_number":70,"context_line":"can connect to for image storage. By default, there is no region"},{"line_number":71,"context_line":"set."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"When Glance uses Swift as the storage backend to store images"},{"line_number":74,"context_line":"for a specific tenant that has multiple endpoints, setting of"},{"line_number":75,"context_line":"a Swift region with ``swift_store_region`` allows Glance to"},{"line_number":76,"context_line":"connect to Swift in the specified region as opposed to a"},{"line_number":77,"context_line":"single region connectivity."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_3fb67b3d","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":49},"in_reply_to":"9ad45d7e_343d07bc","updated":"2016-08-09 20:19:32.000000000","message":"Thanks Hemanth.\nLet me know if we still need to change the description, specifically mentioning that it  can be used for both single and multi tenant.","commit_id":"cf745cab222a30ece46b35c94e18a5a3ca672142"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b2c72c08d5dc9baad10b704a3ba4a580ba61f30f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"can connect to for image storage. By default, there is no region"},{"line_number":71,"context_line":"set."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"When Glance uses Swift as the storage backend to store images"},{"line_number":74,"context_line":"for a specific tenant that has multiple endpoints, setting of"},{"line_number":75,"context_line":"a Swift region with ``swift_store_region`` allows Glance to"},{"line_number":76,"context_line":"connect to Swift in the specified region as opposed to a"},{"line_number":77,"context_line":"single region connectivity."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_69eb65b1","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":49},"in_reply_to":"9ad45d7e_3fb67b3d","updated":"2016-08-12 17:45:12.000000000","message":"Added a line mentioning that this opt can be configured for both single and multi tenant storage","commit_id":"cf745cab222a30ece46b35c94e18a5a3ca672142"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"fe23ce541d05042cd66dffde88e60e0358356c1d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"can connect to for image storage. By default, there is no region"},{"line_number":71,"context_line":"set."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"When Glance uses Swift as the storage backend to store images"},{"line_number":74,"context_line":"for a specific tenant that has multiple endpoints, setting of"},{"line_number":75,"context_line":"a Swift region with ``swift_store_region`` allows Glance to"},{"line_number":76,"context_line":"connect to Swift in the specified region as opposed to a"},{"line_number":77,"context_line":"single region connectivity."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_a6658ce2","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":49},"in_reply_to":"9ad45d7e_7148712e","updated":"2016-08-08 18:58:25.000000000","message":"I think this option can be configured to work for both single-tenant and multi-tenant image storage. Either way, we specify the region for Glance to store the image data for an image. Also, regions are account specific right? Rather than tenant specific?\n\nCan you please clarify this for me?","commit_id":"cf745cab222a30ece46b35c94e18a5a3ca672142"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"dc220462e8ef0ce7bcc43df73a611c9c22b713e7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"can connect to for image storage. By default, there is no region"},{"line_number":71,"context_line":"set."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"When Glance uses Swift as the storage backend to store images"},{"line_number":74,"context_line":"for a specific tenant that has multiple endpoints, setting of"},{"line_number":75,"context_line":"a Swift region with ``swift_store_region`` allows Glance to"},{"line_number":76,"context_line":"connect to Swift in the specified region as opposed to a"},{"line_number":77,"context_line":"single region connectivity."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_343d07bc","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":49},"in_reply_to":"9ad45d7e_a6658ce2","updated":"2016-08-09 17:57:47.000000000","message":"https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/swift/store.py#L1108\n\nWe would need it for multi-tenant store as well. Specifically to retrieve the swift endpoint.","commit_id":"cf745cab222a30ece46b35c94e18a5a3ca672142"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"48a7f00f7044046dd3c7ec83cd173a2dc80df776","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Setting an endpoint with ``swift_store_endpoint`` overrides the"},{"line_number":100,"context_line":"storage URL and is used for Glance image storage."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"NOTE: The URL should include the path up to, and excluding the"},{"line_number":103,"context_line":"container. The location of an object is obtained by appending"},{"line_number":104,"context_line":"the container and object to the configured URL."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_87d047f9","line":102,"range":{"start_line":102,"start_character":45,"end_line":102,"end_character":48},"updated":"2016-08-12 16:49:53.000000000","message":"nit: s/and/but","commit_id":"cf745cab222a30ece46b35c94e18a5a3ca672142"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b2c72c08d5dc9baad10b704a3ba4a580ba61f30f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Setting an endpoint with ``swift_store_endpoint`` overrides the"},{"line_number":100,"context_line":"storage URL and is used for Glance image storage."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"NOTE: The URL should include the path up to, and excluding the"},{"line_number":103,"context_line":"container. The location of an object is obtained by appending"},{"line_number":104,"context_line":"the container and object to the configured URL."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_890e99e3","line":102,"range":{"start_line":102,"start_character":45,"end_line":102,"end_character":48},"in_reply_to":"9ad45d7e_87d047f9","updated":"2016-08-12 17:45:12.000000000","message":"Done","commit_id":"cf745cab222a30ece46b35c94e18a5a3ca672142"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"07669d3eb8a648a2ca7fa1e9cbb6881ce11c5652","unresolved":false,"context_lines":[{"line_number":71,"context_line":"set."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"When Glance uses Swift as the storage backend to store images"},{"line_number":74,"context_line":"for a specific tenant (this option can be configured for both"},{"line_number":75,"context_line":"single-tenant and multi-tenant storage) that has multiple endpoints,"},{"line_number":76,"context_line":"setting of a Swift region with ``swift_store_region`` allows Glance"},{"line_number":77,"context_line":"to connect to Swift in the specified region as opposed to a single"},{"line_number":78,"context_line":"region connectivity."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_58d2a535","line":75,"range":{"start_line":74,"start_character":22,"end_line":75,"end_character":39},"updated":"2016-08-12 19:20:01.000000000","message":"Sorry to be picky, but this would read better if the parenthetical comment were a standalone sentence in its own paragraph.  I suggest putting it after this paragraph but before the NOTE below.","commit_id":"ed22ee55d31ab7a13769de09f41f477e8cf1de8e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"7869f9870fd5503b513cd137c4beedad0c62506b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"set."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"When Glance uses Swift as the storage backend to store images"},{"line_number":74,"context_line":"for a specific tenant (this option can be configured for both"},{"line_number":75,"context_line":"single-tenant and multi-tenant storage) that has multiple endpoints,"},{"line_number":76,"context_line":"setting of a Swift region with ``swift_store_region`` allows Glance"},{"line_number":77,"context_line":"to connect to Swift in the specified region as opposed to a single"},{"line_number":78,"context_line":"region connectivity."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_58dc6518","line":75,"range":{"start_line":74,"start_character":22,"end_line":75,"end_character":39},"in_reply_to":"9ad45d7e_58d2a535","updated":"2016-08-12 19:27:03.000000000","message":"Done","commit_id":"ed22ee55d31ab7a13769de09f41f477e8cf1de8e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"93261983efef5bfa0314f54f04cf481d21a438d2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"multi-tenant storage."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"NOTE: Setting the region with ``swift_store_region`` is"},{"line_number":83,"context_line":"tenant-specific and is necessary only if the tenant has"},{"line_number":84,"context_line":"multiple endpoints across different regions."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_7e578a02","line":83,"range":{"start_line":83,"start_character":33,"end_line":83,"end_character":40},"updated":"2016-08-15 15:33:32.000000000","message":"may be put this in bold in a follow up improvement.","commit_id":"eee8136a44a47b652997eaab0456c19314a49494"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"93261983efef5bfa0314f54f04cf481d21a438d2","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\"\"\")),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027swift_store_endpoint\u0027,"},{"line_number":94,"context_line":"               sample_default\u003d\u0027https://www.my-domain.com/v1/ \\"},{"line_number":95,"context_line":"                               path_up_to_container\u0027,"},{"line_number":96,"context_line":"               help\u003d_(\"\"\""},{"line_number":97,"context_line":"The URL endpoint to use for Swift backend storage."}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_be68e2bb","line":94,"range":{"start_line":94,"start_character":39,"end_line":94,"end_character":56},"updated":"2016-08-15 15:33:32.000000000","message":"may be use a example.com or glance.openstack.org or similar","commit_id":"eee8136a44a47b652997eaab0456c19314a49494"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d0050c9925f93bdfea5ca804a563572d6576d6a8","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\"\"\")),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027swift_store_endpoint\u0027,"},{"line_number":94,"context_line":"               sample_default\u003d\u0027https://www.my-domain.com/v1/ \\"},{"line_number":95,"context_line":"                               path_up_to_container\u0027,"},{"line_number":96,"context_line":"               help\u003d_(\"\"\""},{"line_number":97,"context_line":"The URL endpoint to use for Swift backend storage."}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_ded83e20","line":94,"range":{"start_line":94,"start_character":39,"end_line":94,"end_character":56},"in_reply_to":"3ac371cc_be68e2bb","updated":"2016-08-15 15:37:22.000000000","message":"+1 will have a follow up patch for this.","commit_id":"eee8136a44a47b652997eaab0456c19314a49494"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4c91e8765e72768ef3287e5a835c28e66db7f8c3","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"\"\"\")),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027swift_store_endpoint\u0027,"},{"line_number":94,"context_line":"               sample_default\u003d\u0027https://www.my-domain.com/v1/ \\"},{"line_number":95,"context_line":"                               path_up_to_container\u0027,"},{"line_number":96,"context_line":"               help\u003d_(\"\"\""},{"line_number":97,"context_line":"The URL endpoint to use for Swift backend storage."}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_99ad4034","line":94,"range":{"start_line":94,"start_character":39,"end_line":94,"end_character":56},"in_reply_to":"3ac371cc_ded83e20","updated":"2016-08-15 15:55:14.000000000","message":"I suggest \u0027swift.openstack.example.org\u0027 (it conforms with the new URL documentation convention)","commit_id":"eee8136a44a47b652997eaab0456c19314a49494"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"628eff955f4509067a77b79e09c192934ee5597a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"\"\"\")),"},{"line_number":120,"context_line":"    cfg.StrOpt(\u0027swift_store_endpoint\u0027,"},{"line_number":121,"context_line":"               sample_default\u003d\u0027https://swift.openstack.example.org/v1/\\"},{"line_number":122,"context_line":"                               path_up_to_container\u0027,"},{"line_number":123,"context_line":"               help\u003d_(\"\"\""},{"line_number":124,"context_line":"The URL endpoint to use for Swift backend storage."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_d3b76284","line":122,"updated":"2016-08-16 13:27:29.000000000","message":"I think this will include all the whitespace before the second line.  I think the thing to do here is use a \"\"\" string like you do for the help, and then it will be OK to start the URL in the first column.  Make sure you backslash so that you don\u0027t get newlines into the sample_default:\n\n    sample_default\u003d\"\"\"\\\n    https://swift.openstack.example.org/v1/path_not_including_container_name\\\n    \"\"\"\n\nAlso, I suggest changing the URL slightly as it\u0027s shown here.  The \"up_to_container\" is ambiguous (at least to me), could mean \"the path you need to get up to the container\", which arguably could include the container name.  You specifically point out what this means in the NOTE below, but as long as you\u0027re putting up a new PS, might as well change it here.  (But definitely leave the NOTE!)","commit_id":"d40be26241659f53f6ea57dfe789c32d22c71f9b"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d24b828742b4fc0a83e22e48e0bfdc056b87546f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"\"\"\")),"},{"line_number":120,"context_line":"    cfg.StrOpt(\u0027swift_store_endpoint\u0027,"},{"line_number":121,"context_line":"               sample_default\u003d\u0027https://swift.openstack.example.org/v1/\\"},{"line_number":122,"context_line":"                               path_up_to_container\u0027,"},{"line_number":123,"context_line":"               help\u003d_(\"\"\""},{"line_number":124,"context_line":"The URL endpoint to use for Swift backend storage."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_4bbbb227","line":122,"in_reply_to":"3ac371cc_d3b76284","updated":"2016-08-16 15:40:36.000000000","message":"Makes sense Brian. Thanks for the suggestion.","commit_id":"d40be26241659f53f6ea57dfe789c32d22c71f9b"}]}