)]}'
{"releasenotes/notes/improved-configuration-options-3635b56aba3072c9.yaml":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8b39004718670ae026eff7f4cc855763ca69d6b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - The glance_store configuration options have been"},{"line_number":4,"context_line":"    improved with more explanative help texts, sample"},{"line_number":5,"context_line":"    defaults, choices to easily pick from, and a well"},{"line_number":6,"context_line":"    defined range for the values with ``min`` and"},{"line_number":7,"context_line":"    ``max`` set."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_edc6af66","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":22},"updated":"2016-08-17 17:07:16.000000000","message":"can drop this or replace \"more explanative\" with detailed","commit_id":"a37f7f7c188f0b8b9aa072d173b30ea6b39dc434"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8b39004718670ae026eff7f4cc855763ca69d6b4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The glance_store configuration options have been"},{"line_number":4,"context_line":"    improved with more explanative help texts, sample"},{"line_number":5,"context_line":"    defaults, choices to easily pick from, and a well"},{"line_number":6,"context_line":"    defined range for the values with ``min`` and"},{"line_number":7,"context_line":"    ``max`` set."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    It is to be noted that the configuration options for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_0de4ebde","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":32},"updated":"2016-08-17 17:07:16.000000000","message":"set","commit_id":"a37f7f7c188f0b8b9aa072d173b30ea6b39dc434"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8b39004718670ae026eff7f4cc855763ca69d6b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - The glance_store configuration options have been"},{"line_number":4,"context_line":"    improved with more explanative help texts, sample"},{"line_number":5,"context_line":"    defaults, choices to easily pick from, and a well"},{"line_number":6,"context_line":"    defined range for the values with ``min`` and"},{"line_number":7,"context_line":"    ``max`` set."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    It is to be noted that the configuration options for"},{"line_number":10,"context_line":"    which a ``min`` value has been set to zero or greater,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_706c52d0","line":7,"range":{"start_line":3,"start_character":4,"end_line":7,"end_character":16},"updated":"2016-08-17 17:07:16.000000000","message":"Overall, how about something like this.\n\n\"The glance_store configuration options have been \nimproved with detailed help texts, defaults for sample\nconfiguration files, explicit choices to pick from and a strict range defined with ``min`` and ``max`` restrictions.\"","commit_id":"a37f7f7c188f0b8b9aa072d173b30ea6b39dc434"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8b39004718670ae026eff7f4cc855763ca69d6b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    improved with more explanative help texts, sample"},{"line_number":5,"context_line":"    defaults, choices to easily pick from, and a well"},{"line_number":6,"context_line":"    defined range for the values with ``min`` and"},{"line_number":7,"context_line":"    ``max`` set."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    It is to be noted that the configuration options for"},{"line_number":10,"context_line":"    which a ``min`` value has been set to zero or greater,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_edab4f73","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"updated":"2016-08-17 17:07:16.000000000","message":"restrictions","commit_id":"a37f7f7c188f0b8b9aa072d173b30ea6b39dc434"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8b39004718670ae026eff7f4cc855763ca69d6b4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    It is to be noted that the configuration options for"},{"line_number":10,"context_line":"    which a ``min`` value has been set to zero or greater,"},{"line_number":11,"context_line":"    eliminates the ability of it to accept negative"},{"line_number":12,"context_line":"    integer values. Operators need to verify that the values"},{"line_number":13,"context_line":"    provided to such configuration options comply with the"},{"line_number":14,"context_line":"    ``min`` value, while using of old configuration files"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_6d563fcf","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":29},"updated":"2016-08-17 17:07:16.000000000","message":"for","commit_id":"a37f7f7c188f0b8b9aa072d173b30ea6b39dc434"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8b39004718670ae026eff7f4cc855763ca69d6b4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    defined range for the values with ``min`` and"},{"line_number":7,"context_line":"    ``max`` set."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    It is to be noted that the configuration options for"},{"line_number":10,"context_line":"    which a ``min`` value has been set to zero or greater,"},{"line_number":11,"context_line":"    eliminates the ability of it to accept negative"},{"line_number":12,"context_line":"    integer values. Operators need to verify that the values"},{"line_number":13,"context_line":"    provided to such configuration options comply with the"},{"line_number":14,"context_line":"    ``min`` value, while using of old configuration files"},{"line_number":15,"context_line":"    that might have negative integer values for such"},{"line_number":16,"context_line":"    configuration options."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_50a2f64b","line":16,"range":{"start_line":9,"start_character":4,"end_line":16,"end_character":26},"updated":"2016-08-17 17:07:16.000000000","message":"How about \n\"Configuration options that take integer values have a strict\nrange defined with \"min\" and/or \"max\" restrictions. This renders the configuration options incapable of taking certain values that may have seemed valid before. For instance, a configuration with \"min\u003d0\" can\u0027t take negative values any more. Although a negative value may have appeared to work earlier, it would get discarded by the services silently. Enough care has been taken to ensure the new restrictions  are backwards compatible. \n\nGoing forward, operators need to verify that the values\nset for configuration options comply with the restrictions imposed. Otherwise, the services may fail to start\"","commit_id":"a37f7f7c188f0b8b9aa072d173b30ea6b39dc434"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"cea3554c5496e14a29d74d5170ea63c457161f59","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - The glance_store configuration options have been"},{"line_number":4,"context_line":"    improved with more explanative help texts, sample"},{"line_number":5,"context_line":"    defaults, choices to easily pick from, and a well"},{"line_number":6,"context_line":"    defined range for the values with ``min`` and"},{"line_number":7,"context_line":"    ``max`` set."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ac371cc_d0726610","line":5,"range":{"start_line":5,"start_character":14,"end_line":5,"end_character":41},"updated":"2016-08-17 17:06:08.000000000","message":"Small suggestion to reword this to something like this or similar: \"choices restricting to only valid values\"","commit_id":"ec4ce42a6004e664cbcd30ae49d343da381910ac"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"cea3554c5496e14a29d74d5170ea63c457161f59","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    improved with more explanative help texts, sample"},{"line_number":5,"context_line":"    defaults, choices to easily pick from, and a well"},{"line_number":6,"context_line":"    defined range for the values with ``min`` and"},{"line_number":7,"context_line":"    ``max`` set."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    It is to be noted that the configuration options for"},{"line_number":10,"context_line":"    which a ``min`` value has been set to zero or greater,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ac371cc_70cf3229","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"updated":"2016-08-17 17:06:08.000000000","message":"s/set/boundaries/","commit_id":"ec4ce42a6004e664cbcd30ae49d343da381910ac"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"457e62172deb9ab03f82e83e2310cf582dcc4714","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The glance_store configuration options have been"},{"line_number":4,"context_line":"    improved with detailed help texts, defaults for"},{"line_number":5,"context_line":"    sample configuration files, explicit choices"},{"line_number":6,"context_line":"    enabling the operator to provide only valid values,"},{"line_number":7,"context_line":"    and a strict range defined with ``min`` and ``max``"},{"line_number":8,"context_line":"    boundaries."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_597a2178","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":54},"updated":"2016-08-17 17:44:19.000000000","message":"\"of values for operators to choose from\"?","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c1db08d6e81d9e504a9e7c935db14764d19a51a6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    and a strict range defined with ``min`` and ``max``"},{"line_number":8,"context_line":"    boundaries."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    It is to be noted that the configuration options"},{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders"},{"line_number":13,"context_line":"    the configuration options incapable of taking certain"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_99b1394a","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":52},"updated":"2016-08-17 17:44:18.000000000","message":"Are all integer options now bound with min/max? If not, should say: \"some configuration\"","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"6de72608a28faeeeb2ff7e727f90662e4195eef1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    and a strict range defined with ``min`` and ``max``"},{"line_number":8,"context_line":"    boundaries."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    It is to be noted that the configuration options"},{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders"},{"line_number":13,"context_line":"    the configuration options incapable of taking certain"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_79c39d89","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":52},"in_reply_to":"3ac371cc_99b1394a","updated":"2016-08-17 17:55:18.000000000","message":"Alex, it says \"the conf opts that take integer values....\"\nDo you still suggest that we say \"some config opts that take int values...\"?","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c1db08d6e81d9e504a9e7c935db14764d19a51a6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    values that may have seemed valid before. For instance,"},{"line_number":15,"context_line":"    a configuration with \"min\u003d0\" can\u0027t take negative values"},{"line_number":16,"context_line":"    any more. Although a negative value may have appeared to"},{"line_number":17,"context_line":"    work earlier, it would now get discarded by the services."},{"line_number":18,"context_line":"    Enough care has been taken to ensure the new restrictions"},{"line_number":19,"context_line":"    are backward compatible."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_397f6567","line":17,"range":{"start_line":17,"start_character":18,"end_line":17,"end_character":60},"updated":"2016-08-17 17:44:18.000000000","message":"Isn\u0027t it the case (according to Brian\u0027s test) that Glance service would simply fail to start? If so, should say that instead of \"discarded by services\"","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"457e62172deb9ab03f82e83e2310cf582dcc4714","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    values that may have seemed valid before. For instance,"},{"line_number":15,"context_line":"    a configuration with \"min\u003d0\" can\u0027t take negative values"},{"line_number":16,"context_line":"    any more. Although a negative value may have appeared to"},{"line_number":17,"context_line":"    work earlier, it would now get discarded by the services."},{"line_number":18,"context_line":"    Enough care has been taken to ensure the new restrictions"},{"line_number":19,"context_line":"    are backward compatible."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_3eb90b7a","line":17,"range":{"start_line":17,"start_character":18,"end_line":17,"end_character":61},"updated":"2016-08-17 17:44:19.000000000","message":"This isn\u0027t accurate. Services would now fail to start. We either say that the earlier services just discarded the negative values or that the current services fail to start.\n\nSince we already mention about current services failing to start in the below paragraph, maybe we can mention that earlier services just discarded the negative values.","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"fe508912c518a88d5c9cc1a94d08f1812aef2a6e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    values that may have seemed valid before. For instance,"},{"line_number":15,"context_line":"    a configuration with \"min\u003d0\" can\u0027t take negative values"},{"line_number":16,"context_line":"    any more. Although a negative value may have appeared to"},{"line_number":17,"context_line":"    work earlier, it would now get discarded by the services."},{"line_number":18,"context_line":"    Enough care has been taken to ensure the new restrictions"},{"line_number":19,"context_line":"    are backward compatible."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_39cda5b7","line":17,"range":{"start_line":17,"start_character":18,"end_line":17,"end_character":61},"in_reply_to":"3ac371cc_3eb90b7a","updated":"2016-08-17 17:46:18.000000000","message":"+1 Hemanth suggestion.","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c1db08d6e81d9e504a9e7c935db14764d19a51a6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    a configuration with \"min\u003d0\" can\u0027t take negative values"},{"line_number":16,"context_line":"    any more. Although a negative value may have appeared to"},{"line_number":17,"context_line":"    work earlier, it would now get discarded by the services."},{"line_number":18,"context_line":"    Enough care has been taken to ensure the new restrictions"},{"line_number":19,"context_line":"    are backward compatible."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Going forward, operators need to verify that the values"},{"line_number":22,"context_line":"    set for configuration options comply with the restrictions"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_79955d85","line":19,"range":{"start_line":18,"start_character":3,"end_line":19,"end_character":27},"updated":"2016-08-17 17:44:18.000000000","message":"I think a slight re-wording is needed here. Something like: \"Enough care has been taken to ensure the new restrictions provide adequate support for reasonable values and thus should be backward compatible with most existing configurations\"","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"6de72608a28faeeeb2ff7e727f90662e4195eef1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    a configuration with \"min\u003d0\" can\u0027t take negative values"},{"line_number":16,"context_line":"    any more. Although a negative value may have appeared to"},{"line_number":17,"context_line":"    work earlier, it would now get discarded by the services."},{"line_number":18,"context_line":"    Enough care has been taken to ensure the new restrictions"},{"line_number":19,"context_line":"    are backward compatible."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Going forward, operators need to verify that the values"},{"line_number":22,"context_line":"    set for configuration options comply with the restrictions"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_f97f8ddd","line":19,"range":{"start_line":18,"start_character":3,"end_line":19,"end_character":27},"in_reply_to":"3ac371cc_79955d85","updated":"2016-08-17 17:55:18.000000000","message":"Should we necessarily say \"most existing configurations\"?\nDoesn\u0027t that mean it is not completely backward compatible?","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3b91c0fcbda5bac1259b09828f7e729db0555e2e","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    It is to be noted that the configuration options"},{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders"},{"line_number":13,"context_line":"    the configuration options incapable of taking certain"},{"line_number":14,"context_line":"    values that may have seemed valid before. For instance,"},{"line_number":15,"context_line":"    a configuration with \"min\u003d0\" can\u0027t take negative values"},{"line_number":16,"context_line":"    any more. Although a negative value may have appeared to"},{"line_number":17,"context_line":"    work earlier, it would now get discarded by the services."},{"line_number":18,"context_line":"    Enough care has been taken to ensure the new restrictions"},{"line_number":19,"context_line":"    are backward compatible."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Going forward, operators need to verify that the values"},{"line_number":22,"context_line":"    set for configuration options comply with the restrictions"},{"line_number":23,"context_line":"    imposed to prevent the services from failing to start."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_3901256b","line":23,"range":{"start_line":12,"start_character":40,"end_line":23,"end_character":58},"updated":"2016-08-17 17:54:37.000000000","message":"I suggest replacing the above with:\n\nThis renders the configuration options incapable of taking certain values that may have been accepted before, but were actually invalid. For example, configuration options specifying counts, where a negative value was undefined, no longer accept negative values.  Options where a negative value was previously defined (for example, -1 to mean unlimited) are of course unaffected by this change.\n\nInvalid values for configuration options will prevent the service from starting.  Check the logs for a message indicating the problematic configuration option and the reason why the supplied value has been rejected.","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"af3713330cc4c9591eaecba535f541c8d2f90374","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    It is to be noted that the configuration options"},{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders"},{"line_number":13,"context_line":"    the configuration options incapable of taking certain"},{"line_number":14,"context_line":"    values that may have seemed valid before. For instance,"},{"line_number":15,"context_line":"    a configuration with \"min\u003d0\" can\u0027t take negative values"},{"line_number":16,"context_line":"    any more. Although a negative value may have appeared to"},{"line_number":17,"context_line":"    work earlier, it would now get discarded by the services."},{"line_number":18,"context_line":"    Enough care has been taken to ensure the new restrictions"},{"line_number":19,"context_line":"    are backward compatible."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Going forward, operators need to verify that the values"},{"line_number":22,"context_line":"    set for configuration options comply with the restrictions"},{"line_number":23,"context_line":"    imposed to prevent the services from failing to start."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_f99b0d16","line":23,"range":{"start_line":12,"start_character":40,"end_line":23,"end_character":58},"in_reply_to":"3ac371cc_3901256b","updated":"2016-08-17 17:58:47.000000000","message":"Not sure it\u0027s clear anymore what I mean by \"replacing the above\".  The part to replace begins with the sentence beginning \"This renders\" and extends for the rest of the text.","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c4f828f2695921fef0c8de63bbc666c8358a3064","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    It is to be noted that the configuration options"},{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders"},{"line_number":13,"context_line":"    the configuration options incapable of taking certain"},{"line_number":14,"context_line":"    values that may have seemed valid before. For instance,"},{"line_number":15,"context_line":"    a configuration with \"min\u003d0\" can\u0027t take negative values"},{"line_number":16,"context_line":"    any more. Although a negative value may have appeared to"},{"line_number":17,"context_line":"    work earlier, it would now get discarded by the services."},{"line_number":18,"context_line":"    Enough care has been taken to ensure the new restrictions"},{"line_number":19,"context_line":"    are backward compatible."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Going forward, operators need to verify that the values"},{"line_number":22,"context_line":"    set for configuration options comply with the restrictions"},{"line_number":23,"context_line":"    imposed to prevent the services from failing to start."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_64f13401","line":23,"range":{"start_line":12,"start_character":40,"end_line":23,"end_character":58},"in_reply_to":"3ac371cc_f99b0d16","updated":"2016-08-17 18:26:51.000000000","message":"Thanks Brian. I have slightly edited the text you provided and added it to the new PS.\nLet me know if we have to further edit it.","commit_id":"8ca1b2a0ef45a48f2da244fa94cce3dffbe06045"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"58f23f763116e0cea2877e3dc0ac1f0fa789f1bc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    configuration options incapable of taking certain values"},{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"},{"line_number":16,"context_line":"    would have earlier simply discarded the supplied negative value."},{"line_number":17,"context_line":"    Such options would no longer discard negative values. Instead,"},{"line_number":18,"context_line":"    they will prevent the services from starting. However, options"},{"line_number":19,"context_line":"    where a negative value was previously defined (for example, -1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ac371cc_5f104159","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":67},"updated":"2016-08-17 18:47:36.000000000","message":"something like \"accept the negative value but discard it silently.\"","commit_id":"fa4734a901506c4b434e7f00e9758fb5332ce87a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a28e1e643243e66668378362497f2e9ef71d381","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders the"},{"line_number":13,"context_line":"    configuration options incapable of taking certain values"},{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"},{"line_number":16,"context_line":"    would have earlier simply discarded the supplied negative value."},{"line_number":17,"context_line":"    Such options would no longer discard negative values. Instead,"},{"line_number":18,"context_line":"    they will prevent the services from starting. However, options"},{"line_number":19,"context_line":"    where a negative value was previously defined (for example, -1"},{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ac371cc_f1bcc1bc","line":17,"range":{"start_line":14,"start_character":40,"end_line":17,"end_character":57},"updated":"2016-08-17 18:50:48.000000000","message":"I don\u0027t think this is correct.  The value wasn\u0027t discarded, it was used as equivalent to zero, because the code was looking for x \u003e 0.  So the value was accepted, it \"worked\", but it will no longer be accepted.","commit_id":"fa4734a901506c4b434e7f00e9758fb5332ce87a"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9df54b57619fad757953e04fbff0518577c0e38c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders the"},{"line_number":13,"context_line":"    configuration options incapable of taking certain values"},{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"},{"line_number":16,"context_line":"    would have earlier simply discarded the supplied negative value."},{"line_number":17,"context_line":"    Such options would no longer discard negative values. Instead,"},{"line_number":18,"context_line":"    they will prevent the services from starting. However, options"},{"line_number":19,"context_line":"    where a negative value was previously defined (for example, -1"},{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ac371cc_11bebd64","line":17,"range":{"start_line":14,"start_character":40,"end_line":17,"end_character":57},"in_reply_to":"3ac371cc_f1bcc1bc","updated":"2016-08-17 18:59:03.000000000","message":"Done","commit_id":"fa4734a901506c4b434e7f00e9758fb5332ce87a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"58f23f763116e0cea2877e3dc0ac1f0fa789f1bc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Thus, values that do not comply with the imposed restrictions will"},{"line_number":23,"context_line":"    prevent the service from starting. Operators are to check the"},{"line_number":24,"context_line":"    logs for a message indicating why the supplied value has been"},{"line_number":25,"context_line":"    rejected and the services failed to start."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ac371cc_91c62d98","line":23,"range":{"start_line":23,"start_character":49,"end_line":23,"end_character":55},"updated":"2016-08-17 18:47:36.000000000","message":"nit: must","commit_id":"fa4734a901506c4b434e7f00e9758fb5332ce87a"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9df54b57619fad757953e04fbff0518577c0e38c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Thus, values that do not comply with the imposed restrictions will"},{"line_number":23,"context_line":"    prevent the service from starting. Operators are to check the"},{"line_number":24,"context_line":"    logs for a message indicating why the supplied value has been"},{"line_number":25,"context_line":"    rejected and the services failed to start."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ac371cc_f1c201e8","line":23,"range":{"start_line":23,"start_character":49,"end_line":23,"end_character":55},"in_reply_to":"3ac371cc_91c62d98","updated":"2016-08-17 18:59:03.000000000","message":"Done","commit_id":"fa4734a901506c4b434e7f00e9758fb5332ce87a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"58f23f763116e0cea2877e3dc0ac1f0fa789f1bc","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Thus, values that do not comply with the imposed restrictions will"},{"line_number":23,"context_line":"    prevent the service from starting. Operators are to check the"},{"line_number":24,"context_line":"    logs for a message indicating why the supplied value has been"},{"line_number":25,"context_line":"    rejected and the services failed to start."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ac371cc_31293938","line":25,"range":{"start_line":24,"start_character":34,"end_line":25,"end_character":45},"updated":"2016-08-17 18:47:36.000000000","message":"Feel free to disregard this but I feel brian\u0027s suggestion sounds better here \"the problematic configuration option and the reason why the supplied value has been rejected.\"\n\nYour call.","commit_id":"fa4734a901506c4b434e7f00e9758fb5332ce87a"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"9df54b57619fad757953e04fbff0518577c0e38c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Thus, values that do not comply with the imposed restrictions will"},{"line_number":23,"context_line":"    prevent the service from starting. Operators are to check the"},{"line_number":24,"context_line":"    logs for a message indicating why the supplied value has been"},{"line_number":25,"context_line":"    rejected and the services failed to start."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ac371cc_51b4b580","line":25,"range":{"start_line":24,"start_character":34,"end_line":25,"end_character":45},"in_reply_to":"3ac371cc_31293938","updated":"2016-08-17 18:59:03.000000000","message":"Done","commit_id":"fa4734a901506c4b434e7f00e9758fb5332ce87a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d8c65d5656b8fae6d90d8efb86fdcb6b84545efc","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    It is to be noted that the configuration options"},{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders the"},{"line_number":13,"context_line":"    configuration options incapable of taking certain values"},{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_4a0d1ee7","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":39},"updated":"2016-08-17 20:10:24.000000000","message":"please add: \"where appropriate\" before the end of this sentence","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36e461e16341d2b0e67c1b9d1abfbe58cad85549","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    It is to be noted that the configuration options"},{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders the"},{"line_number":13,"context_line":"    configuration options incapable of taking certain values"},{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_e02ce99a","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":39},"in_reply_to":"3ac371cc_4a0d1ee7","updated":"2016-08-17 20:41:05.000000000","message":"Done","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d8c65d5656b8fae6d90d8efb86fdcb6b84545efc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders the"},{"line_number":13,"context_line":"    configuration options incapable of taking certain values"},{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"},{"line_number":16,"context_line":"    would have still accepted the supplied negative value."},{"line_number":17,"context_line":"    Such options will no longer accept negative values. Instead,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_4a24fe5e","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":39},"updated":"2016-08-17 20:10:24.000000000","message":"please add: \"but were actually invalid\" before the end of this sentence","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36e461e16341d2b0e67c1b9d1abfbe58cad85549","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    that take integer values now have a strict range defined"},{"line_number":12,"context_line":"    with \"min\" and/or \"max\" boundaries. This renders the"},{"line_number":13,"context_line":"    configuration options incapable of taking certain values"},{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"},{"line_number":16,"context_line":"    would have still accepted the supplied negative value."},{"line_number":17,"context_line":"    Such options will no longer accept negative values. Instead,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_00282585","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":39},"in_reply_to":"3ac371cc_4a24fe5e","updated":"2016-08-17 20:41:05.000000000","message":"Done","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d8c65d5656b8fae6d90d8efb86fdcb6b84545efc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"},{"line_number":16,"context_line":"    would have still accepted the supplied negative value."},{"line_number":17,"context_line":"    Such options will no longer accept negative values. Instead,"},{"line_number":18,"context_line":"    they will prevent the services from starting. However, options"},{"line_number":19,"context_line":"    where a negative value was previously defined (for example, -1"},{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_ca9d8e67","line":18,"range":{"start_line":17,"start_character":56,"end_line":18,"end_character":50},"updated":"2016-08-17 20:10:24.000000000","message":"I suggest deleting this sentence, you make this point below.  (This way the contrast between the options being changed and the ones left alone isn\u0027t interrupted.)","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36e461e16341d2b0e67c1b9d1abfbe58cad85549","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    that may have been accepted before. For example, configuration"},{"line_number":15,"context_line":"    options specifying counts, where a negative value was undefined,"},{"line_number":16,"context_line":"    would have still accepted the supplied negative value."},{"line_number":17,"context_line":"    Such options will no longer accept negative values. Instead,"},{"line_number":18,"context_line":"    they will prevent the services from starting. However, options"},{"line_number":19,"context_line":"    where a negative value was previously defined (for example, -1"},{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_a0183176","line":18,"range":{"start_line":17,"start_character":56,"end_line":18,"end_character":50},"in_reply_to":"3ac371cc_ca9d8e67","updated":"2016-08-17 20:41:05.000000000","message":"Done","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d8c65d5656b8fae6d90d8efb86fdcb6b84545efc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    where a negative value was previously defined (for example, -1"},{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Thus, values that do not comply with the imposed restrictions will"},{"line_number":23,"context_line":"    prevent the service from starting. Operators must check the"},{"line_number":24,"context_line":"    logs for a message indicating the problematic configuration option and"},{"line_number":25,"context_line":"    the reason why the supplied value has been rejected."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_6ac9fa58","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":11},"updated":"2016-08-17 20:10:24.000000000","message":"I suggest dropping the \"Thus\" and just beginning with \"Values\".\n\nAlso, instead of \"imposed restrictions\", I\u0027d suggest \"appropriate restrictions\".","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36e461e16341d2b0e67c1b9d1abfbe58cad85549","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    where a negative value was previously defined (for example, -1"},{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Thus, values that do not comply with the imposed restrictions will"},{"line_number":23,"context_line":"    prevent the service from starting. Operators must check the"},{"line_number":24,"context_line":"    logs for a message indicating the problematic configuration option and"},{"line_number":25,"context_line":"    the reason why the supplied value has been rejected."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_c01bad71","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":11},"in_reply_to":"3ac371cc_6ac9fa58","updated":"2016-08-17 20:41:05.000000000","message":"Done","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d8c65d5656b8fae6d90d8efb86fdcb6b84545efc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Thus, values that do not comply with the imposed restrictions will"},{"line_number":23,"context_line":"    prevent the service from starting. Operators must check the"},{"line_number":24,"context_line":"    logs for a message indicating the problematic configuration option and"},{"line_number":25,"context_line":"    the reason why the supplied value has been rejected."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_cad90e24","line":24,"range":{"start_line":23,"start_character":39,"end_line":24,"end_character":12},"updated":"2016-08-17 20:10:24.000000000","message":"I suggest changing this to: \"The logs will contain a message\".  (We want to be neutral, the ops will be pissed off as it is if a config option doesn\u0027t work any more, we don\u0027t want to be telling them what they \"must\" do on top of that!)","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"36e461e16341d2b0e67c1b9d1abfbe58cad85549","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    to mean unlimited) will remain unaffected by this change."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Thus, values that do not comply with the imposed restrictions will"},{"line_number":23,"context_line":"    prevent the service from starting. Operators must check the"},{"line_number":24,"context_line":"    logs for a message indicating the problematic configuration option and"},{"line_number":25,"context_line":"    the reason why the supplied value has been rejected."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_6012b958","line":24,"range":{"start_line":23,"start_character":39,"end_line":24,"end_character":12},"in_reply_to":"3ac371cc_cad90e24","updated":"2016-08-17 20:41:05.000000000","message":"Done","commit_id":"25bd645ee5a321d4a847fbc44046902f415c51f8"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"52d8c4831698c729b77ede169427930870d0b2f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - The glance_store configuration options have been"},{"line_number":4,"context_line":"    improved with detailed help texts, defaults for"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3ac371cc_c018cd20","line":1,"updated":"2016-08-17 20:48:51.000000000","message":"just a nit,\n\ncan you add a prelude indicating the config changes and hint to read more in other section (easy to miss section)?\n\nhttp://docs.openstack.org/developer/reno/usage.html","commit_id":"af3582a0288c643ec479062fba3e45441258e9da"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"dc2dbb39b6cc438b2e3c3610aa67505d94dde9a6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - The glance_store configuration options have been"},{"line_number":4,"context_line":"    improved with detailed help texts, defaults for"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3ac371cc_5b396ed6","line":1,"in_reply_to":"3ac371cc_c018cd20","updated":"2016-08-17 21:04:16.000000000","message":"Done","commit_id":"af3582a0288c643ec479062fba3e45441258e9da"}]}