)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e2105e12da876e465d3358592ed89062e47ea068","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Andrey Pavlov \u003candrey-mp@yandex.ru\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-24 20:13:14 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add volume_type to cinder store configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some cinder backend can have several volume types to optimize"},{"line_number":10,"context_line":"storage usage."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_958feb73","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"updated":"2016-10-10 15:25:42.000000000","message":"The actual option name is cinder_volume_type, so please correct it here.","commit_id":"b0bc55da2bea8f95095160f6bfb033db1a26b163"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e2105e12da876e465d3358592ed89062e47ea068","unresolved":false,"context_lines":[{"line_number":10,"context_line":"storage usage."},{"line_number":11,"context_line":"Adding this option allows to choose specific volume type in cinder"},{"line_number":12,"context_line":"that can be optimized for images."},{"line_number":13,"context_line":"Now default_volume_type is used for volume creation and this solution"},{"line_number":14,"context_line":"is not so suitable."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1616556"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_f5e2efd3","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":23},"updated":"2016-10-10 15:25:42.000000000","message":"I think you are referring to a cinder-side option? Please clarify.","commit_id":"b0bc55da2bea8f95095160f6bfb033db1a26b163"}],"glance_store/_drivers/cinder.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"09777d285b583cf6c4ecda6f4778a30cf94370a1","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        metadata \u003d {\u0027glance_image_id\u0027: image_id,"},{"line_number":644,"context_line":"                    \u0027image_size\u0027: str(image_size),"},{"line_number":645,"context_line":"                    \u0027image_owner\u0027: owner}"},{"line_number":646,"context_line":"        volume_type \u003d self.conf.glance_store.volume_type"},{"line_number":647,"context_line":"        LOG.debug(\u0027Creating a new volume: image_size\u003d%d size_gb\u003d%d type\u003d%s\u0027,"},{"line_number":648,"context_line":"                  image_size, size_gb, volume_type or \u0027None\u0027)"},{"line_number":649,"context_line":"        if image_size \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_92cecb81","line":646,"range":{"start_line":646,"start_character":45,"end_line":646,"end_character":56},"updated":"2016-08-19 16:36:16.000000000","message":"Oops, sorry that I didn\u0027t catch this earlier.\nGood catch, but this should be ``cinder_volume_type``.","commit_id":"f5b1666918fc551781b07948aa6e9f6011f5652a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e2105e12da876e465d3358592ed89062e47ea068","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    cfg.StrOpt(\u0027cinder_volume_type\u0027,"},{"line_number":287,"context_line":"               default\u003dNone,"},{"line_number":288,"context_line":"               help\u003d_(\"\"\""},{"line_number":289,"context_line":"Volume Type that will be used for volume creation in cinder."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"Possible values:"},{"line_number":292,"context_line":"    * A valid volume type from cinder"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_d59df3bc","line":289,"updated":"2016-10-10 15:25:42.000000000","message":"This is likely to be the only documentation for this option.  Please state what happens if it isn\u0027t set, and where an operator should look for the list of possible values.","commit_id":"b0bc55da2bea8f95095160f6bfb033db1a26b163"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"49312faaa8c6df4b3170e03de0ae42e285a4df25","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    cfg.StrOpt(\u0027cinder_volume_type\u0027,"},{"line_number":287,"context_line":"               default\u003dNone,"},{"line_number":288,"context_line":"               help\u003d_(\"\"\""},{"line_number":289,"context_line":"Volume Type that will be used for volume creation in cinder."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"Possible values:"},{"line_number":292,"context_line":"    * A valid volume type from cinder"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_558c83d9","line":289,"in_reply_to":"1a95cdbc_d59df3bc","updated":"2016-10-10 15:28:23.000000000","message":"+1","commit_id":"b0bc55da2bea8f95095160f6bfb033db1a26b163"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a56087546b1c99d792d6a7a98f421e5088df2f73","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    cfg.StrOpt(\u0027cinder_volume_type\u0027,"},{"line_number":287,"context_line":"               default\u003dNone,"},{"line_number":288,"context_line":"               help\u003d_(\"\"\""},{"line_number":289,"context_line":"Volume Type that will be used for volume creation in cinder."},{"line_number":290,"context_line":"Some cinder backend can have several volume types to optimize storage usage."},{"line_number":291,"context_line":"Adding this option allows to choose specific volume type in cinder"},{"line_number":292,"context_line":"that can be optimized for images."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_387897f2","line":289,"range":{"start_line":289,"start_character":7,"end_line":289,"end_character":8},"updated":"2016-10-11 19:28:06.000000000","message":"Maybe lowercase \u0027t\u0027 here?\n\nAlso, leave a blank line after the first sentence.","commit_id":"706f301289c4af55b8118cf1de2bbcdc3e90d2bb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a56087546b1c99d792d6a7a98f421e5088df2f73","unresolved":false,"context_lines":[{"line_number":287,"context_line":"               default\u003dNone,"},{"line_number":288,"context_line":"               help\u003d_(\"\"\""},{"line_number":289,"context_line":"Volume Type that will be used for volume creation in cinder."},{"line_number":290,"context_line":"Some cinder backend can have several volume types to optimize storage usage."},{"line_number":291,"context_line":"Adding this option allows to choose specific volume type in cinder"},{"line_number":292,"context_line":"that can be optimized for images."},{"line_number":293,"context_line":"If this is not set then default_volume_type from cinder configuration"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_584c6bc7","line":290,"range":{"start_line":290,"start_character":12,"end_line":290,"end_character":19},"updated":"2016-10-11 19:28:06.000000000","message":"s/backend/backends/","commit_id":"706f301289c4af55b8118cf1de2bbcdc3e90d2bb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a56087546b1c99d792d6a7a98f421e5088df2f73","unresolved":false,"context_lines":[{"line_number":288,"context_line":"               help\u003d_(\"\"\""},{"line_number":289,"context_line":"Volume Type that will be used for volume creation in cinder."},{"line_number":290,"context_line":"Some cinder backend can have several volume types to optimize storage usage."},{"line_number":291,"context_line":"Adding this option allows to choose specific volume type in cinder"},{"line_number":292,"context_line":"that can be optimized for images."},{"line_number":293,"context_line":"If this is not set then default_volume_type from cinder configuration"},{"line_number":294,"context_line":"will be used for volume creation."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_b8e8277e","line":291,"range":{"start_line":291,"start_character":19,"end_line":291,"end_character":44},"updated":"2016-10-11 19:28:06.000000000","message":"s/allows to choose specific/allows an operator to choose a specific/","commit_id":"706f301289c4af55b8118cf1de2bbcdc3e90d2bb"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"9bbf09fe6d0448b2ed18b255965fe24847f19c70","unresolved":false,"context_lines":[{"line_number":290,"context_line":"Some cinder backend can have several volume types to optimize storage usage."},{"line_number":291,"context_line":"Adding this option allows to choose specific volume type in cinder"},{"line_number":292,"context_line":"that can be optimized for images."},{"line_number":293,"context_line":"If this is not set then default_volume_type from cinder configuration"},{"line_number":294,"context_line":"will be used for volume creation."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_a74ba92a","line":293,"range":{"start_line":293,"start_character":24,"end_line":293,"end_character":43},"updated":"2016-10-11 16:41:04.000000000","message":"Nit.\nThis should be ``default_volume_type``.\nBut, let\u0027s not block this patch on this nit. We can have a follow up patch.","commit_id":"706f301289c4af55b8118cf1de2bbcdc3e90d2bb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a56087546b1c99d792d6a7a98f421e5088df2f73","unresolved":false,"context_lines":[{"line_number":290,"context_line":"Some cinder backend can have several volume types to optimize storage usage."},{"line_number":291,"context_line":"Adding this option allows to choose specific volume type in cinder"},{"line_number":292,"context_line":"that can be optimized for images."},{"line_number":293,"context_line":"If this is not set then default_volume_type from cinder configuration"},{"line_number":294,"context_line":"will be used for volume creation."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_3807b71d","line":293,"range":{"start_line":293,"start_character":24,"end_line":293,"end_character":43},"in_reply_to":"fa6399be_a74ba92a","updated":"2016-10-11 19:28:06.000000000","message":"I think put a blank line before this sentence (it will make this sentence about the default stand out better).\n\nInstead of ``default_volume_type``, I\u0027d suggest just saying it in plain words (if we write it so it looks like an option, people may think it\u0027s supposed to be set in this file).  Something like, \"If this is not set, then the default volume type specified in the cinder configuration will be used for volume creation.\"","commit_id":"706f301289c4af55b8118cf1de2bbcdc3e90d2bb"}]}