)]}'
{"glance_store/backend.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"9ed5e305f0f9ac12713b29aab8b68ab3847cba08","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    driver_opts \u003d []"},{"line_number":133,"context_line":"    mgr \u003d extension.ExtensionManager(\u0027glance_store.drivers\u0027)"},{"line_number":134,"context_line":"    # NOTE(zhiyan): Handle available drivers entry_points provided"},{"line_number":135,"context_line":"    # NOTE(nikhil): Return a sorted list of drivers so that the oslo config"},{"line_number":136,"context_line":"    # generator can use that order to keep generating configuration file in a"},{"line_number":137,"context_line":"    # consistent manner. If this order is not preserved, in some cases the"},{"line_number":138,"context_line":"    # downstream packagers may see a long diff of the changes though not"},{"line_number":139,"context_line":"    # relevant as only order has changed. See some more details at bug 1619487."},{"line_number":140,"context_line":"    drivers \u003d sorted([ext.name for ext in mgr])"},{"line_number":141,"context_line":"    handled_drivers \u003d []  # Used to handle backwards-compatible entries"},{"line_number":142,"context_line":"    for store_entry in drivers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_dfe7bbaa","line":139,"range":{"start_line":135,"start_character":4,"end_line":139,"end_character":79},"updated":"2016-09-02 19:25:11.000000000","message":"I don\u0027t insist but this is my suggestion:\n\"Return a sorted list of drivers to ensure that the sample configuration\nfiles generated by oslo config generator retain the order in which the\nconfig opts appear across different runs. If this order of config opts\nis not preserved, some downstream packagers may see a long diff of the\nchanges though not relevant as only order has changed. \nSee some more details at bug 1619487.\"","commit_id":"04ef385759e535881e01d439c93d5bfae4841940"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"26070de4b5bb6f97d9a09f8644cbcedc64c68dcf","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    driver_opts \u003d []"},{"line_number":133,"context_line":"    mgr \u003d extension.ExtensionManager(\u0027glance_store.drivers\u0027)"},{"line_number":134,"context_line":"    # NOTE(zhiyan): Handle available drivers entry_points provided"},{"line_number":135,"context_line":"    # NOTE(nikhil): Return a sorted list of drivers so that the oslo config"},{"line_number":136,"context_line":"    # generator can use that order to keep generating configuration file in a"},{"line_number":137,"context_line":"    # consistent manner. If this order is not preserved, in some cases the"},{"line_number":138,"context_line":"    # downstream packagers may see a long diff of the changes though not"},{"line_number":139,"context_line":"    # relevant as only order has changed. See some more details at bug 1619487."},{"line_number":140,"context_line":"    drivers \u003d sorted([ext.name for ext in mgr])"},{"line_number":141,"context_line":"    handled_drivers \u003d []  # Used to handle backwards-compatible entries"},{"line_number":142,"context_line":"    for store_entry in drivers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_24b745d9","line":139,"range":{"start_line":135,"start_character":4,"end_line":139,"end_character":79},"in_reply_to":"9a89bdaa_c4abf9d4","updated":"2016-09-06 18:48:01.000000000","message":"Done","commit_id":"04ef385759e535881e01d439c93d5bfae4841940"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6be394cad25e8b148193a444808c4ab15cbf79a6","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    driver_opts \u003d []"},{"line_number":133,"context_line":"    mgr \u003d extension.ExtensionManager(\u0027glance_store.drivers\u0027)"},{"line_number":134,"context_line":"    # NOTE(zhiyan): Handle available drivers entry_points provided"},{"line_number":135,"context_line":"    # NOTE(nikhil): Return a sorted list of drivers so that the oslo config"},{"line_number":136,"context_line":"    # generator can use that order to keep generating configuration file in a"},{"line_number":137,"context_line":"    # consistent manner. If this order is not preserved, in some cases the"},{"line_number":138,"context_line":"    # downstream packagers may see a long diff of the changes though not"},{"line_number":139,"context_line":"    # relevant as only order has changed. See some more details at bug 1619487."},{"line_number":140,"context_line":"    drivers \u003d sorted([ext.name for ext in mgr])"},{"line_number":141,"context_line":"    handled_drivers \u003d []  # Used to handle backwards-compatible entries"},{"line_number":142,"context_line":"    for store_entry in drivers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_c4abf9d4","line":139,"range":{"start_line":135,"start_character":4,"end_line":139,"end_character":79},"in_reply_to":"9a89bdaa_dfe7bbaa","updated":"2016-09-06 18:40:01.000000000","message":"+1 to Hemanth\u0027s suggestion","commit_id":"04ef385759e535881e01d439c93d5bfae4841940"}]}
