)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ea35d22da29a74b64a897da66b101329c5958be2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Darja Malyavkina \u003cdshakhray@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-10 18:11:35 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect debug msg when swift driver can\u0027t determine image size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1631995"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_15dcbb44","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":68},"updated":"2016-10-10 15:25:18.000000000","message":"Nit:\nThis line can\u0027t be more than 50 chars long.\nAlso, I wouldn\u0027t call the current message \"incorrect\".\nIt is just misleading.","commit_id":"7f2e5eedb5607cdb16c5a7796f35166eef7e7438"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"9994778b9041fb1b74a8d6e5a31781f70fab1174","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Darja Malyavkina \u003cdshakhray@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-10 18:30:10 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix debug msg when swift driver can\u0027t determine image size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1631995"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a95cdbc_f9f10902","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":58},"updated":"2016-10-10 15:36:58.000000000","message":"This is still longer than 50 chars\n\nHere is the extract from https://wiki.openstack.org/wiki/GitCommitMessages\n\"The first line should be limited to 50 characters and should not end with a period.\"","commit_id":"b3505a42ea4a086360e5723ef13150e7a11f21e8"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"19393084d6f0aa3ab324f696e02ea904bc6662e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Darja Malyavkina \u003cdshakhray@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-10 18:30:10 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix debug msg when swift driver can\u0027t determine image size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1631995"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a95cdbc_7ffb1947","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":58},"in_reply_to":"1a95cdbc_f9f10902","updated":"2016-10-10 16:33:23.000000000","message":"Suggestion:\nFix dbg msg when swift can\u0027t determine image size","commit_id":"b3505a42ea4a086360e5723ef13150e7a11f21e8"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ea35d22da29a74b64a897da66b101329c5958be2","unresolved":false,"context_lines":[{"line_number":866,"context_line":"                        # image_size \u003d\u003d 0 is when we don\u0027t know the size"},{"line_number":867,"context_line":"                        # of the image. This can occur with older clients"},{"line_number":868,"context_line":"                        # that don\u0027t inspect the payload size."},{"line_number":869,"context_line":"                        LOG.debug(\"Image is uploaded to Swift as a segmented \""},{"line_number":870,"context_line":"                                  \"object.\")"},{"line_number":871,"context_line":"                        total_chunks \u003d \u0027?\u0027"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"                    checksum \u003d hashlib.md5()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_75241f0c","line":870,"range":{"start_line":869,"start_character":34,"end_line":870,"end_character":43},"updated":"2016-10-10 15:25:18.000000000","message":"I don\u0027t insist but how about this\n\"Adding image as a segmented object to Swift\"\nJust trying to retain as much of the original debug message as possible. I believe in keeping log messages more or less intact as folks are used to seeing certain messages in the log.","commit_id":"7f2e5eedb5607cdb16c5a7796f35166eef7e7438"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"feb7ac37ed5ae599245706e59321a22700ba957f","unresolved":false,"context_lines":[{"line_number":868,"context_line":"                        # that don\u0027t inspect the payload size."},{"line_number":869,"context_line":"                        LOG.debug(\"The image size was not found for the image \""},{"line_number":870,"context_line":"                                  \"because it is either not provided in the \""},{"line_number":871,"context_line":"                                  \"request or chunked-transfer encoding used \""},{"line_number":872,"context_line":"                                  \"The image will be added as \""},{"line_number":873,"context_line":"                                  \"segmented object to Swift.\")"},{"line_number":874,"context_line":"                        total_chunks \u003d \u0027?\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_40b14546","line":871,"updated":"2016-10-14 12:26:12.000000000","message":"is","commit_id":"b1b99201007f9dee0ec3e4b3f6105bc8bcdd628a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"feb7ac37ed5ae599245706e59321a22700ba957f","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                    else:"},{"line_number":866,"context_line":"                        # image_size \u003d\u003d 0 is when we don\u0027t know the size"},{"line_number":867,"context_line":"                        # of the image. This can occur with older clients"},{"line_number":868,"context_line":"                        # that don\u0027t inspect the payload size."},{"line_number":869,"context_line":"                        LOG.debug(\"The image size was not found for the image \""},{"line_number":870,"context_line":"                                  \"because it is either not provided in the \""},{"line_number":871,"context_line":"                                  \"request or chunked-transfer encoding used \""},{"line_number":872,"context_line":"                                  \"The image will be added as \""},{"line_number":873,"context_line":"                                  \"segmented object to Swift.\")"},{"line_number":874,"context_line":"                        total_chunks \u003d \u0027?\u0027"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"                    checksum \u003d hashlib.md5()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_40fa2576","line":873,"range":{"start_line":868,"start_character":34,"end_line":873,"end_character":62},"updated":"2016-10-14 12:26:12.000000000","message":"Why can\u0027t we keep the current message intact mostly and just add more detail to it? Something like the following:\n\n\"Cannot determine image size because it is either not provided in the request or chunked-transfer encoding is used.\nAdding image as a segmented object to Swift.\"\n\nI suggest this because I think it helps to retain log messages as much as possible in their original form. We don\u0027t pay much attention to this today but hey, never too late, right? Having said that, it is probably not worth blocking this patch.","commit_id":"b1b99201007f9dee0ec3e4b3f6105bc8bcdd628a"}]}
