)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"44609377f32b7834bf1aba1f4b4735a89faa9198","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 22:15:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reverting to old multi-tenant behavior."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using swift multi-tenant store, using a user\u0027s service"},{"line_number":10,"context_line":"catalog to obtain the storage url for an object does not work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_02605900","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2016-10-20 17:09:35.000000000","message":"may be not call this reverting if it isn\u0027t a straightforward revert.\n\nhow about \"Using storage_url in DB for multi-tenant swift store\"\n\nthen describe in the CM that this commit also reverts a rather recent behavior, mention the glance_store releases that change exists, and provide a brief explanation on how this commit changes behavior compared to that one.","commit_id":"935afc3ea1c61a2850df7cd165342a0d444a85cd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f091767f1b11bb4537110d9451217094869a029f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"be looking at a location url formed with the wrong owner information"},{"line_number":14,"context_line":"result in an object GET failure (404)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch solves this issue by reverting to the old code logic where"},{"line_number":17,"context_line":"the storage_url for an image when using multi-tenant store was fetched"},{"line_number":18,"context_line":"from the database via ``location.swift_url``."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_2c4ad283","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":64},"updated":"2016-10-20 01:10:09.000000000","message":"Is this patch a straightforward revert of a particular commit? If so, which commit; if not, could you say something about why you couldn\u0027t just revert the commit.","commit_id":"935afc3ea1c61a2850df7cd165342a0d444a85cd"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"eab76989ce25670d194b6dd0ed5253815c0eac2f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"be looking at a location url formed with the wrong owner information"},{"line_number":14,"context_line":"result in an object GET failure (404)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch solves this issue by reverting to the old code logic where"},{"line_number":17,"context_line":"the storage_url for an image when using multi-tenant store was fetched"},{"line_number":18,"context_line":"from the database via ``location.swift_url``."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_8741de65","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":64},"in_reply_to":"fa6399be_2c4ad283","updated":"2016-10-20 16:43:17.000000000","message":"It isn\u0027t a straightforward revert like Brian is alluding to in his comment. It is a revert \"in principle\". Let\u0027s add more detail here. Maybe the change-id?","commit_id":"935afc3ea1c61a2850df7cd165342a0d444a85cd"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0d4928c9f2e423a7ba0bc448426d69ce83e3532b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"was fetched from the database via ``location.swift_url``. The commit"},{"line_number":19,"context_line":"that had introduced the fetch of storage_url from user\u0027s context is [1]."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://review.openstack.org/#/c/252370/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-Authored-By: Hemanth Makkapati \u003chemanth.makkapati@rackspace.com\u003e"},{"line_number":24,"context_line":"Co-Authored-By: Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a71b18c_d4eb66da","line":21,"updated":"2016-12-12 13:29:08.000000000","message":"I\u0027d prefer this be the change ID, that way someone can use the git CLI to search for that (searching for a URL won\u0027t work that way).","commit_id":"f148219d1a11c7c7fc4a8266bfd92c8356bb83da"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3651ca566ad2224fdb44654b00d3260723d330fe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"was fetched from the database via ``location.swift_url``. The commit"},{"line_number":19,"context_line":"that had introduced the fetch of storage_url from user\u0027s context is [1]."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://review.openstack.org/#/c/252370/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-Authored-By: Hemanth Makkapati \u003chemanth.makkapati@rackspace.com\u003e"},{"line_number":24,"context_line":"Co-Authored-By: Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_99d2bb33","line":21,"in_reply_to":"3a71b18c_d4eb66da","updated":"2016-12-12 15:41:26.000000000","message":"Use Change-Id: I7bc23dfc11900b55f45fe98144d14f883c381c9f","commit_id":"f148219d1a11c7c7fc4a8266bfd92c8356bb83da"}],"glance_store/_drivers/swift/connection_manager.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"0e7128038075575352395fb9eb486171bbb04410","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            LOG.info(_LI(\"Revoking trust %s\"), self.client.trust_id)"},{"line_number":187,"context_line":"            self.client.trusts.delete(self.client.trust_id)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _get_storage_url(self):"},{"line_number":190,"context_line":"        return self.location.swift_url"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def _init_connection(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6895a0_9baed883","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":31},"updated":"2016-10-24 19:30:56.000000000","message":"I wonder if we even need this method any more?\nCan we just use location.swift_url wherever we were invoking this method?","commit_id":"ecc9c7578c413b89ea5e4caafddf52d70cf61cdb"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"57c8fb66898d130bb79f583ee4644aae936fda3a","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            LOG.info(_LI(\"Revoking trust %s\"), self.client.trust_id)"},{"line_number":187,"context_line":"            self.client.trusts.delete(self.client.trust_id)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _get_storage_url(self):"},{"line_number":190,"context_line":"        return self.location.swift_url"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def _init_connection(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_38a4f7a4","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":31},"in_reply_to":"da6895a0_9baed883","updated":"2016-11-17 22:55:25.000000000","message":"Hemanth, both the SingleTenant and MultiTenant class\u0027 _get_storage_url method is used in the base class depending on the connection invoked. \nUnless we dont mind having a conditional check in the base class constructor, I think it is okay to have this method here.\nLet me know what you think.","commit_id":"ecc9c7578c413b89ea5e4caafddf52d70cf61cdb"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0d4928c9f2e423a7ba0bc448426d69ce83e3532b","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                # with client"},{"line_number":211,"context_line":"                self.allow_reauth \u003d False"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return self.store.get_store_connection("},{"line_number":214,"context_line":"            self.context.auth_token, self.storage_url)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_f4ba22e0","side":"PARENT","line":213,"updated":"2016-12-12 13:29:08.000000000","message":"This shouldn\u0027t have been updated. It\u0027s a stylistic change that has no bearing on the larger patch.","commit_id":"f8f11e761307e8e24b171ad8f8346baa8d65e614"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"8574bba84facaa014a9d3ba4d9125d88de2a70f4","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        # NOTE(Sridevi): Fix to map the account reference to the"},{"line_number":666,"context_line":"        # corresponding configuration value"},{"line_number":667,"context_line":"        if self.scheme \u003d\u003d \u0027swift+config\u0027:"},{"line_number":668,"context_line":"            if not self.conf.glance_store.swift_store_multi_tenant:"},{"line_number":669,"context_line":"                netloc \u003d self._get_conf_value_from_account_ref(netloc)"},{"line_number":670,"context_line":"            else:"},{"line_number":671,"context_line":"                # Multi-tenant store cannot work with swift+config"},{"line_number":672,"context_line":"                msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":673,"context_line":"                        \"work with swift+config scheme.\")"},{"line_number":674,"context_line":"                raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","},{"line_number":675,"context_line":"                                                       reason\u003dmsg)"},{"line_number":676,"context_line":"        else:"},{"line_number":677,"context_line":"            netloc, path \u003d self._form_uri_parts(netloc, path)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_1ef2a6d2","line":675,"range":{"start_line":668,"start_character":0,"end_line":675,"end_character":66},"updated":"2016-10-19 15:41:30.000000000","message":"I think  this validation should happen much higher up the stack. I\u0027m thinking that this should happen right when Glance comes up and registers the config. \n\nThe reason I say this is, if we leave this validation here, Glance is already up and running and it will probably fail on almost every image fetch (depending upon how many images were created using swift+config though). So, it is a tad too late and the operator has no choice but to take the services down, adjust the config and re-start services. To avoid all this, it is much better to do this validation high up in the stack and Glance should refuse to come up if it detects any misconfiguration.","commit_id":"05c07e6963b20f1903d74b47d1017f7ae9b40f2f"}],"glance_store/tests/unit/test_connection_manager.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c4cac6ee495940b00d39ed365648851d32f24b59","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            store_location\u003dself.location,"},{"line_number":72,"context_line":"            context\u003dself.context"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":"        store._get_endpoint.assert_called_once_with(self.context)"},{"line_number":75,"context_line":"        store.get_store_connection.assert_called_once_with("},{"line_number":76,"context_line":"            self.context.auth_token, manager.storage_url)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6895a0_fb0e42e4","side":"PARENT","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":65},"updated":"2016-10-21 00:57:09.000000000","message":"Can retain this test and also the removed lines 95, 100 with the additional arg. But not actually necessary if we are having separate tests.","commit_id":"9b63cb5d00b26b6d8bf105ae306094775cacd8dc"}],"glance_store/tests/unit/test_swift_store.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"eab76989ce25670d194b6dd0ed5253815c0eac2f","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"        self.assertEqual(\u0027https://example.com\u0027, connection.preauthurl)"},{"line_number":1527,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1528,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"    def test_connection_with_endpoint_from_catalog(self):"},{"line_number":1531,"context_line":"        self.store.configure()"},{"line_number":1532,"context_line":"        self.context.service_catalog \u003d ["},{"line_number":1533,"context_line":"            {"},{"line_number":1534,"context_line":"                \u0027endpoint_links\u0027: [],"},{"line_number":1535,"context_line":"                \u0027endpoints\u0027: ["},{"line_number":1536,"context_line":"                    {"},{"line_number":1537,"context_line":"                        \u0027region\u0027: \u0027RegionOne\u0027,"},{"line_number":1538,"context_line":"                        \u0027publicURL\u0027: \u0027https://scexample.com\u0027,"},{"line_number":1539,"context_line":"                    },"},{"line_number":1540,"context_line":"                ],"},{"line_number":1541,"context_line":"                \u0027type\u0027: \u0027object-store\u0027,"},{"line_number":1542,"context_line":"                \u0027name\u0027: \u0027Object Storage Service\u0027,"},{"line_number":1543,"context_line":"            }"},{"line_number":1544,"context_line":"        ]"},{"line_number":1545,"context_line":"        connection \u003d self.store.get_connection(self.location,"},{"line_number":1546,"context_line":"                                               context\u003dself.context)"},{"line_number":1547,"context_line":"        self.assertIsNone(connection.authurl)"},{"line_number":1548,"context_line":"        self.assertEqual(\u00271\u0027, connection.auth_version)"},{"line_number":1549,"context_line":"        self.assertIsNone(connection.user)"},{"line_number":1550,"context_line":"        self.assertIsNone(connection.tenant_name)"},{"line_number":1551,"context_line":"        self.assertIsNone(connection.key)"},{"line_number":1552,"context_line":"        self.assertEqual(\u0027https://scexample.com\u0027, connection.preauthurl)"},{"line_number":1553,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1554,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1555,"context_line":""},{"line_number":1556,"context_line":"    def test_connection_with_no_endpoint_found(self):"},{"line_number":1557,"context_line":"        self.store.configure()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_9f1e866e","side":"PARENT","line":1554,"range":{"start_line":1529,"start_character":0,"end_line":1554,"end_character":51},"updated":"2016-10-20 16:43:17.000000000","message":"Why are removing this test?","commit_id":"9b63cb5d00b26b6d8bf105ae306094775cacd8dc"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c5adb4e14036be8ffacd44796193a53897271d5f","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"        self.assertEqual(\u0027https://example.com\u0027, connection.preauthurl)"},{"line_number":1527,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1528,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"    def test_connection_with_endpoint_from_catalog(self):"},{"line_number":1531,"context_line":"        self.store.configure()"},{"line_number":1532,"context_line":"        self.context.service_catalog \u003d ["},{"line_number":1533,"context_line":"            {"},{"line_number":1534,"context_line":"                \u0027endpoint_links\u0027: [],"},{"line_number":1535,"context_line":"                \u0027endpoints\u0027: ["},{"line_number":1536,"context_line":"                    {"},{"line_number":1537,"context_line":"                        \u0027region\u0027: \u0027RegionOne\u0027,"},{"line_number":1538,"context_line":"                        \u0027publicURL\u0027: \u0027https://scexample.com\u0027,"},{"line_number":1539,"context_line":"                    },"},{"line_number":1540,"context_line":"                ],"},{"line_number":1541,"context_line":"                \u0027type\u0027: \u0027object-store\u0027,"},{"line_number":1542,"context_line":"                \u0027name\u0027: \u0027Object Storage Service\u0027,"},{"line_number":1543,"context_line":"            }"},{"line_number":1544,"context_line":"        ]"},{"line_number":1545,"context_line":"        connection \u003d self.store.get_connection(self.location,"},{"line_number":1546,"context_line":"                                               context\u003dself.context)"},{"line_number":1547,"context_line":"        self.assertIsNone(connection.authurl)"},{"line_number":1548,"context_line":"        self.assertEqual(\u00271\u0027, connection.auth_version)"},{"line_number":1549,"context_line":"        self.assertIsNone(connection.user)"},{"line_number":1550,"context_line":"        self.assertIsNone(connection.tenant_name)"},{"line_number":1551,"context_line":"        self.assertIsNone(connection.key)"},{"line_number":1552,"context_line":"        self.assertEqual(\u0027https://scexample.com\u0027, connection.preauthurl)"},{"line_number":1553,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1554,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1555,"context_line":""},{"line_number":1556,"context_line":"    def test_connection_with_no_endpoint_found(self):"},{"line_number":1557,"context_line":"        self.store.configure()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_9553c516","side":"PARENT","line":1554,"range":{"start_line":1529,"start_character":0,"end_line":1554,"end_character":51},"in_reply_to":"fa6399be_351bd974","updated":"2016-10-20 17:14:28.000000000","message":"Maybe we edit this test and can have this to show that the catalog will not be used for a fetch?","commit_id":"9b63cb5d00b26b6d8bf105ae306094775cacd8dc"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c0f5f886df3e5f4f2e0cf66a73e3a34aac6ea5a9","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"        self.assertEqual(\u0027https://example.com\u0027, connection.preauthurl)"},{"line_number":1527,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1528,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"    def test_connection_with_endpoint_from_catalog(self):"},{"line_number":1531,"context_line":"        self.store.configure()"},{"line_number":1532,"context_line":"        self.context.service_catalog \u003d ["},{"line_number":1533,"context_line":"            {"},{"line_number":1534,"context_line":"                \u0027endpoint_links\u0027: [],"},{"line_number":1535,"context_line":"                \u0027endpoints\u0027: ["},{"line_number":1536,"context_line":"                    {"},{"line_number":1537,"context_line":"                        \u0027region\u0027: \u0027RegionOne\u0027,"},{"line_number":1538,"context_line":"                        \u0027publicURL\u0027: \u0027https://scexample.com\u0027,"},{"line_number":1539,"context_line":"                    },"},{"line_number":1540,"context_line":"                ],"},{"line_number":1541,"context_line":"                \u0027type\u0027: \u0027object-store\u0027,"},{"line_number":1542,"context_line":"                \u0027name\u0027: \u0027Object Storage Service\u0027,"},{"line_number":1543,"context_line":"            }"},{"line_number":1544,"context_line":"        ]"},{"line_number":1545,"context_line":"        connection \u003d self.store.get_connection(self.location,"},{"line_number":1546,"context_line":"                                               context\u003dself.context)"},{"line_number":1547,"context_line":"        self.assertIsNone(connection.authurl)"},{"line_number":1548,"context_line":"        self.assertEqual(\u00271\u0027, connection.auth_version)"},{"line_number":1549,"context_line":"        self.assertIsNone(connection.user)"},{"line_number":1550,"context_line":"        self.assertIsNone(connection.tenant_name)"},{"line_number":1551,"context_line":"        self.assertIsNone(connection.key)"},{"line_number":1552,"context_line":"        self.assertEqual(\u0027https://scexample.com\u0027, connection.preauthurl)"},{"line_number":1553,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1554,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1555,"context_line":""},{"line_number":1556,"context_line":"    def test_connection_with_no_endpoint_found(self):"},{"line_number":1557,"context_line":"        self.store.configure()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_351bd974","side":"PARENT","line":1554,"range":{"start_line":1529,"start_character":0,"end_line":1554,"end_character":51},"in_reply_to":"fa6399be_9f1e866e","updated":"2016-10-20 17:13:06.000000000","message":"Hemanth, \nSince we reverted to fetching the url form the database via location.swift.url, this test doesnt test anything in the code. If included in the tests, it raises a mismatch error as this catalog is not gonna be referred. \nSo the connection.preauthurl in line 1552 here is gonna have \u0027https://example.com\u0027 and not \u0027https://scexample.com\u0027 from the user\u0027s catalog. (http://paste.openstack.org/show/586609/)\n\nCorrect me if I am wrong.","commit_id":"9b63cb5d00b26b6d8bf105ae306094775cacd8dc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f7930df8883775a95d46dace1b12b787eda06e50","unresolved":false,"context_lines":[{"line_number":1577,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1578,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1579,"context_line":""},{"line_number":1580,"context_line":"    def test_connection_with_endpoint_from_catalog(self):"},{"line_number":1581,"context_line":"        self.store.configure()"},{"line_number":1582,"context_line":"        self.context.service_catalog \u003d ["},{"line_number":1583,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_8164c6e5","line":1580,"updated":"2016-12-13 18:03:50.000000000","message":"Maybe you should rename this test? Your version checks to make sure the connection does NOT use the endpoint from the catalog.","commit_id":"9dbe040c2489b2876353e3cb4e16cc82ee6d348e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"db6206261fd3a1509efacb7b2952100bcba61a01","unresolved":false,"context_lines":[{"line_number":1577,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1578,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1579,"context_line":""},{"line_number":1580,"context_line":"    def test_connection_with_endpoint_from_catalog(self):"},{"line_number":1581,"context_line":"        self.store.configure()"},{"line_number":1582,"context_line":"        self.context.service_catalog \u003d ["},{"line_number":1583,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_e4ff48ff","line":1580,"in_reply_to":"1a6eadb0_8164c6e5","updated":"2016-12-13 18:18:03.000000000","message":"Done","commit_id":"9dbe040c2489b2876353e3cb4e16cc82ee6d348e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f7930df8883775a95d46dace1b12b787eda06e50","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1605,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"    def test_connenction_manager_with_endpoint(self):"},{"line_number":1608,"context_line":"        self.store.configure()"},{"line_number":1609,"context_line":"        self.context.service_catalog \u003d ["},{"line_number":1610,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_e1d3ba36","line":1607,"updated":"2016-12-13 18:03:50.000000000","message":"Please fix spelling of \u0027connenction\u0027 (since under current guidelines, we won\u0027t allow it to be fixed after this is merged).  Also, I think this test could have a more explanatory name.","commit_id":"9dbe040c2489b2876353e3cb4e16cc82ee6d348e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"db6206261fd3a1509efacb7b2952100bcba61a01","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"        self.assertEqual(\u00270123\u0027, connection.preauthtoken)"},{"line_number":1605,"context_line":"        self.assertEqual({}, connection.os_options)"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"    def test_connenction_manager_with_endpoint(self):"},{"line_number":1608,"context_line":"        self.store.configure()"},{"line_number":1609,"context_line":"        self.context.service_catalog \u003d ["},{"line_number":1610,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_240a2022","line":1607,"in_reply_to":"1a6eadb0_e1d3ba36","updated":"2016-12-13 18:18:03.000000000","message":"Done","commit_id":"9dbe040c2489b2876353e3cb4e16cc82ee6d348e"}]}
