)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"8a5063397e7697c072e68e25d394ecbf1c987af8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise exc when using multi-tenant and swift+config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When Swift multi-tenant store is used along with the"},{"line_number":10,"context_line":"scheme ``swift+config``, a reference to use swift objects"},{"line_number":11,"context_line":"is made resulting in the storage url for an accessible object"},{"line_number":12,"context_line":"being created from a swift auth_address. This behavior is suitable"},{"line_number":13,"context_line":"for single-tenant swift store and not multi-tenant store."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_b51d2964","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":57},"updated":"2016-10-20 17:16:28.000000000","message":"since the breakage isn\u0027t on all cases and sharing like ones, I think we don\u0027t need to rush to a backward incompat change here.\n\nrather let\u0027s start with a warning and deprecation message for this combination and mention that in the upcoming glance_store release using this combination won\u0027t start glance.","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"8a5063397e7697c072e68e25d394ecbf1c987af8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"introduced."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Partial-Bug: 1625075"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I8b5c31541d3c501ad7c2520b463f881599f4a28e"},{"line_number":28,"context_line":"Co-Authored-By: Hemanth Makkapati \u003chemanth.makkapati@rackspace.com\u003e"},{"line_number":29,"context_line":"Co-Authored-By: Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_220b9d2b","line":26,"updated":"2016-10-20 17:16:28.000000000","message":"this will have UpgradeImpact, thus include a release note.\n\nnot sure if we\u0027d have DocImpact but we do need the rst files updated in glance to reflect that such combination won\u0027t work for swift store.","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"5992de456b04a2a063b92d3b73245bb80441506e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"introduced."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Partial-Bug: 1625075"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I8b5c31541d3c501ad7c2520b463f881599f4a28e"},{"line_number":28,"context_line":"Co-Authored-By: Hemanth Makkapati \u003chemanth.makkapati@rackspace.com\u003e"},{"line_number":29,"context_line":"Co-Authored-By: Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_c2cb581d","line":26,"in_reply_to":"fa6399be_220b9d2b","updated":"2016-10-20 20:06:03.000000000","message":"+1","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"8f149501c8aa5f4fcf68800283bfcfdbc97c309c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"introduced."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Partial-Bug: 1625075"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I8b5c31541d3c501ad7c2520b463f881599f4a28e"},{"line_number":28,"context_line":"Co-Authored-By: Hemanth Makkapati \u003chemanth.makkapati@rackspace.com\u003e"},{"line_number":29,"context_line":"Co-Authored-By: Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_4363a0dc","line":26,"in_reply_to":"fa6399be_220b9d2b","updated":"2016-10-21 22:19:30.000000000","message":"Nikhil, can you please clarify if we need to edit this file: https://github.com/openstack/glance/blob/master/doc/source/configuring.rst#configuring-swift-configuration-file\nIt says that swift_store_config_file and default_swift_reference should not be set together.\nBut actually, checking if the file is not set is suffice.\nCan you confirm if we need to edit it?","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"6629406a7a7f79911d415692de8fab189ee478e7","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"def Store(conf):"},{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift+config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant and conf.glance_store.\\"},{"line_number":703,"context_line":"       default_store \u003d\u003d \u0027swift+config\u0027:"},{"line_number":704,"context_line":"        msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":705,"context_line":"                \"work with swift+config scheme.\")"},{"line_number":706,"context_line":"        raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_bf7d9fe9","line":703,"range":{"start_line":702,"start_character":54,"end_line":703,"end_character":38},"updated":"2016-10-20 19:55:26.000000000","message":"While this is definitely one of the ways to check whether or not \"swift+config\" is enabled, looks like an operator can set \"default_store\u003dswift\" and yet enable swift+config by setting the \"swift_store_config_file\" file. So, I think we should check whether that file is set too. \n\nYou can use this https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/swift/utils.py#L112-L115\n\nMaybe we should update the help texts of respective options but looks like there are multiple ways to enable swift+config. Another thing to note is, if you set swift+config as the scheme and don\u0027t set a swift-config file, it still emulates the swift+config behavior by populating the ref params using the glance creds.","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c5ed0541f68c67ca2f5626b364783c6ba764ba04","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"def Store(conf):"},{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift+config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant and conf.glance_store.\\"},{"line_number":703,"context_line":"       default_store \u003d\u003d \u0027swift+config\u0027:"},{"line_number":704,"context_line":"        msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":705,"context_line":"                \"work with swift+config scheme.\")"},{"line_number":706,"context_line":"        raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_ecf6018e","line":703,"range":{"start_line":702,"start_character":0,"end_line":703,"end_character":39},"updated":"2016-10-20 15:00:07.000000000","message":"nit:\nif (conf.glance_store.swift_store_multi_tenant and\n    conf.glance_store.default_store \u003d\u003d \u0027swift+config\u0027):","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ed9674055143a437e8bf9b928fc294e57cfda2bb","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"def Store(conf):"},{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift+config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant and conf.glance_store.\\"},{"line_number":703,"context_line":"       default_store \u003d\u003d \u0027swift+config\u0027:"},{"line_number":704,"context_line":"        msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":705,"context_line":"                \"work with swift+config scheme.\")"},{"line_number":706,"context_line":"        raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_49790dfc","line":703,"range":{"start_line":702,"start_character":54,"end_line":703,"end_character":38},"in_reply_to":"da6895a0_6d627dda","updated":"2016-10-21 15:04:13.000000000","message":"The default_swift_reference has a default value if I\u0027m not wrong. And, that is precisely the reason why swift+config will work even if you don\u0027t set the swift_store_config file, which is what I meant by emulating swift+config in my previous comment.\n\nBut, yes, I agree with pretty much what you said.","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"b6f4980097a72b916df4db88f159f77137610d55","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"def Store(conf):"},{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift+config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant and conf.glance_store.\\"},{"line_number":703,"context_line":"       default_store \u003d\u003d \u0027swift+config\u0027:"},{"line_number":704,"context_line":"        msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":705,"context_line":"                \"work with swift+config scheme.\")"},{"line_number":706,"context_line":"        raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_6d627dda","line":703,"range":{"start_line":702,"start_character":54,"end_line":703,"end_character":38},"in_reply_to":"da6895a0_bf7d9fe9","updated":"2016-10-20 20:17:00.000000000","message":"Thats right Hemanth. Just as you pointed out here and also looking at Stuart\u0027s tests in the comment here in this bug report: https://bugs.launchpad.net/swift/+bug/1511025, we have to make sure of 3 things here *if* multi-tenant is enabled:\n* swift+config is not set for ``default_store`` AND\n* swift_store_config_file is not set AND\n* default_swift_reference is also not set.","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"6629406a7a7f79911d415692de8fab189ee478e7","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"def Store(conf):"},{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift+config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant and conf.glance_store.\\"},{"line_number":703,"context_line":"       default_store \u003d\u003d \u0027swift+config\u0027:"},{"line_number":704,"context_line":"        msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":705,"context_line":"                \"work with swift+config scheme.\")"},{"line_number":706,"context_line":"        raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_9fa0dba7","line":703,"range":{"start_line":702,"start_character":0,"end_line":703,"end_character":39},"in_reply_to":"fa6399be_ecf6018e","updated":"2016-10-20 19:55:26.000000000","message":"+1 \nJust FYI: please see the second bullet at http://docs.openstack.org/developer/hacking/#general","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"6629406a7a7f79911d415692de8fab189ee478e7","unresolved":false,"context_lines":[{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift+config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant and conf.glance_store.\\"},{"line_number":703,"context_line":"       default_store \u003d\u003d \u0027swift+config\u0027:"},{"line_number":704,"context_line":"        msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":705,"context_line":"                \"work with swift+config scheme.\")"},{"line_number":706,"context_line":"        raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","},{"line_number":707,"context_line":"                                               reason\u003dmsg)"},{"line_number":708,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_ffec7791","line":705,"range":{"start_line":704,"start_character":16,"end_line":705,"end_character":48},"updated":"2016-10-20 19:55:26.000000000","message":"We should probably also mention what one should do after hitting this error. Maybe this is where we should link the documentation Brian was talking about in the other patch. Or just simply mention that both are mutually exclusive. \n\nI\u0027m afraid it still won\u0027t give the operator a clear picture though. Let\u0027s see what others think.","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"913bcaf7541661dafa47ffc11eeb345ed6d67900","unresolved":false,"context_lines":[{"line_number":700,"context_line":"def Store(conf):"},{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant:"},{"line_number":703,"context_line":"        if (conf.glance_store.default_store \u003d\u003d \u0027swift+config\u0027 and"},{"line_number":704,"context_line":"           sutils.is_multiple_swift_store_accounts_enabled):"},{"line_number":705,"context_line":"            msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":706,"context_line":"                    \"work with swift+config. The options \""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_1e7906fd","line":703,"range":{"start_line":703,"start_character":62,"end_line":703,"end_character":65},"updated":"2016-10-27 14:49:33.000000000","message":"This should be OR isn\u0027t it?","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"50b2b77ddc70a17d106482d07894abdae1cbdb6f","unresolved":false,"context_lines":[{"line_number":700,"context_line":"def Store(conf):"},{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant:"},{"line_number":703,"context_line":"        if (conf.glance_store.default_store \u003d\u003d \u0027swift+config\u0027 and"},{"line_number":704,"context_line":"           sutils.is_multiple_swift_store_accounts_enabled):"},{"line_number":705,"context_line":"            msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":706,"context_line":"                    \"work with swift+config. The options \""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_5e6d3e03","line":703,"range":{"start_line":703,"start_character":62,"end_line":703,"end_character":65},"in_reply_to":"ba5da102_1e7906fd","updated":"2016-10-27 14:55:33.000000000","message":"Yeah. It can be \u0027or\u0027 considering \"swift\" as the scheme might cause the swift ref to be used too. \nI think we should have the code handle the usage of default_swift_reference opt for single and multi tenant accordingly so the default ref is not picked up for multi. (this conditional check here would then just check for the presence of file alone)","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"7480020eaac39d30179ebdb84d03f2c739fe226b","unresolved":false,"context_lines":[{"line_number":700,"context_line":"def Store(conf):"},{"line_number":701,"context_line":"    # NOTE(dharinic): Multi-tenant store cannot work with swift config"},{"line_number":702,"context_line":"    if conf.glance_store.swift_store_multi_tenant:"},{"line_number":703,"context_line":"        if (conf.glance_store.default_store \u003d\u003d \u0027swift+config\u0027 and"},{"line_number":704,"context_line":"           sutils.is_multiple_swift_store_accounts_enabled):"},{"line_number":705,"context_line":"            msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":706,"context_line":"                    \"work with swift+config. The options \""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_5d13640d","line":703,"range":{"start_line":703,"start_character":62,"end_line":703,"end_character":65},"in_reply_to":"ba5da102_5e6d3e03","updated":"2016-10-28 18:31:55.000000000","message":"defult_swift_reference is pretty innocuous. Although it emaulates swift+config behavior in some cases, it doesn\u0027t really play a part in how the location looks eventually.","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ae6db0ed592f3ab30c7ac5c499910e81e6308be7","unresolved":false,"context_lines":[{"line_number":704,"context_line":"           sutils.is_multiple_swift_store_accounts_enabled):"},{"line_number":705,"context_line":"            msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":706,"context_line":"                    \"work with swift+config. The options \""},{"line_number":707,"context_line":"                    \"``swift_store_multi_tenant`` and \""},{"line_number":708,"context_line":"                    \"``swift_store_config_file`` are mutually exclusive. \""},{"line_number":709,"context_line":"                    \"If you inted to use multi-tenant swift store, please \""},{"line_number":710,"context_line":"                    \"make sure that you have not set a swift configuration \""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_4e147c43","line":707,"range":{"start_line":707,"start_character":21,"end_line":707,"end_character":23},"updated":"2016-10-24 19:48:21.000000000","message":"We primarily use `` in RST when highlighting a piece of text. Since the text here is intended to be shown to user, we don\u0027t have to use ``. You can use the regular single quotes instead.","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ae6db0ed592f3ab30c7ac5c499910e81e6308be7","unresolved":false,"context_lines":[{"line_number":704,"context_line":"           sutils.is_multiple_swift_store_accounts_enabled):"},{"line_number":705,"context_line":"            msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":706,"context_line":"                    \"work with swift+config. The options \""},{"line_number":707,"context_line":"                    \"``swift_store_multi_tenant`` and \""},{"line_number":708,"context_line":"                    \"``swift_store_config_file`` are mutually exclusive. \""},{"line_number":709,"context_line":"                    \"If you inted to use multi-tenant swift store, please \""},{"line_number":710,"context_line":"                    \"make sure that you have not set a swift configuration \""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_6e0f802e","line":707,"range":{"start_line":707,"start_character":47,"end_line":707,"end_character":49},"updated":"2016-10-24 19:48:21.000000000","message":"same","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ae6db0ed592f3ab30c7ac5c499910e81e6308be7","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":706,"context_line":"                    \"work with swift+config. The options \""},{"line_number":707,"context_line":"                    \"``swift_store_multi_tenant`` and \""},{"line_number":708,"context_line":"                    \"``swift_store_config_file`` are mutually exclusive. \""},{"line_number":709,"context_line":"                    \"If you inted to use multi-tenant swift store, please \""},{"line_number":710,"context_line":"                    \"make sure that you have not set a swift configuration \""},{"line_number":711,"context_line":"                    \"file with the ``swift_store_config_file`` option.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_8e1e9461","line":708,"range":{"start_line":708,"start_character":21,"end_line":708,"end_character":23},"updated":"2016-10-24 19:48:21.000000000","message":"same","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ae6db0ed592f3ab30c7ac5c499910e81e6308be7","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            msg \u003d _(\"Swift multi-tenant store cannot be configured to \""},{"line_number":706,"context_line":"                    \"work with swift+config. The options \""},{"line_number":707,"context_line":"                    \"``swift_store_multi_tenant`` and \""},{"line_number":708,"context_line":"                    \"``swift_store_config_file`` are mutually exclusive. \""},{"line_number":709,"context_line":"                    \"If you inted to use multi-tenant swift store, please \""},{"line_number":710,"context_line":"                    \"make sure that you have not set a swift configuration \""},{"line_number":711,"context_line":"                    \"file with the ``swift_store_config_file`` option.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_ce26ccb9","line":708,"range":{"start_line":708,"start_character":46,"end_line":708,"end_character":48},"updated":"2016-10-24 19:48:21.000000000","message":"same","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ae6db0ed592f3ab30c7ac5c499910e81e6308be7","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                    \"work with swift+config. The options \""},{"line_number":707,"context_line":"                    \"``swift_store_multi_tenant`` and \""},{"line_number":708,"context_line":"                    \"``swift_store_config_file`` are mutually exclusive. \""},{"line_number":709,"context_line":"                    \"If you inted to use multi-tenant swift store, please \""},{"line_number":710,"context_line":"                    \"make sure that you have not set a swift configuration \""},{"line_number":711,"context_line":"                    \"file with the ``swift_store_config_file`` option.\")"},{"line_number":712,"context_line":"            raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_3becec8e","line":709,"range":{"start_line":709,"start_character":28,"end_line":709,"end_character":33},"updated":"2016-10-24 19:48:21.000000000","message":"intend","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ae6db0ed592f3ab30c7ac5c499910e81e6308be7","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                    \"``swift_store_config_file`` are mutually exclusive. \""},{"line_number":709,"context_line":"                    \"If you inted to use multi-tenant swift store, please \""},{"line_number":710,"context_line":"                    \"make sure that you have not set a swift configuration \""},{"line_number":711,"context_line":"                    \"file with the ``swift_store_config_file`` option.\")"},{"line_number":712,"context_line":"            raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","},{"line_number":713,"context_line":"                                                   reason\u003dmsg)"},{"line_number":714,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_0e21a49f","line":711,"range":{"start_line":711,"start_character":35,"end_line":711,"end_character":37},"updated":"2016-10-24 19:48:21.000000000","message":"same","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ae6db0ed592f3ab30c7ac5c499910e81e6308be7","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                    \"``swift_store_config_file`` are mutually exclusive. \""},{"line_number":709,"context_line":"                    \"If you inted to use multi-tenant swift store, please \""},{"line_number":710,"context_line":"                    \"make sure that you have not set a swift configuration \""},{"line_number":711,"context_line":"                    \"file with the ``swift_store_config_file`` option.\")"},{"line_number":712,"context_line":"            raise exceptions.BadStoreConfiguration(store_name\u003d\"swift\","},{"line_number":713,"context_line":"                                                   reason\u003dmsg)"},{"line_number":714,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_4e3b9cd1","line":711,"range":{"start_line":711,"start_character":60,"end_line":711,"end_character":62},"updated":"2016-10-24 19:48:21.000000000","message":"same","commit_id":"bc2fd0d73c1f219a3897ef4b149e994da2c09dde"}],"glance_store/tests/unit/test_swift_store.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"6629406a7a7f79911d415692de8fab189ee478e7","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        Test that Glance does not start when multi-tenant is configured"},{"line_number":270,"context_line":"        with swift+config"},{"line_number":271,"context_line":"        \"\"\""},{"line_number":272,"context_line":"        self.config(default_store\u003d\u0027swift+config\u0027)"},{"line_number":273,"context_line":"        self.config(swift_store_multi_tenant\u003dTrue)"},{"line_number":274,"context_line":"        self.assertRaises(exceptions.BadStoreConfiguration,"},{"line_number":275,"context_line":"                          Store, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_4293c8a3","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":49},"updated":"2016-10-20 19:55:26.000000000","message":"same","commit_id":"c7966e3fc9317cf25e1109af4d8543d4cff0032c"}]}