)]}'
{"glance_store/tests/unit/test_store_base.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8753cb352038e30bdbd94f807d706fe97c7b401f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @mock.patch.object(store.driver, \u0027LOG\u0027)"},{"line_number":30,"context_line":"    def test_configure_does_not_raise_on_missing_driver_conf(self, mock_log):"},{"line_number":31,"context_line":"        self.config(stores\u003d[\u0027file\u0027], group\u003d\u0027glance_store\u0027)"},{"line_number":32,"context_line":"        self.config(filesystem_store_datadir\u003dNone, group\u003d\u0027glance_store\u0027)"},{"line_number":33,"context_line":"        for (__, store_instance) in backend._load_stores(self.conf):"},{"line_number":34,"context_line":"            store_instance.configure()"},{"line_number":35,"context_line":"            self.assertTrue(mock_log.warning.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_791689f2","line":32,"updated":"2017-01-20 09:08:34.000000000","message":"Maybe You should set also filesystem_store_datadirs to None (it\u0027s default value now but in case it will change someday it would be proof for it)","commit_id":"61a93a009bfe6b80e5d277d54b12b8287fdca1cd"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"25c15fab3e059d4c71dac9f044896ef043a6beaf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.config(filesystem_store_datadirs\u003dNone, group\u003d\u0027glance_store\u0027)"},{"line_number":34,"context_line":"        for (__, store_instance) in backend._load_stores(self.conf):"},{"line_number":35,"context_line":"            store_instance.configure()"},{"line_number":36,"context_line":"            self.assertTrue(mock_log.warning.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_57403607","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":52},"updated":"2017-01-24 00:54:12.000000000","message":"How about changing this to something like:\n``mock_log.warning.assert_called_once_with(\u003cthe warning message actually logged\u003e)\u0027\u0027?\nThis will help us make sure that we are dealing with what we exactly want.","commit_id":"e556cbab9ddc10a14880b318e3f619c6b75337cd"},{"author":{"_account_id":20570,"name":"Adam Kijak","email":"adam.kijak@corp.ovh.com","username":"adam.kijak"},"change_message_id":"c048367166ec4b222addb4e559afe8558f6057da","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.config(filesystem_store_datadirs\u003dNone, group\u003d\u0027glance_store\u0027)"},{"line_number":34,"context_line":"        for (__, store_instance) in backend._load_stores(self.conf):"},{"line_number":35,"context_line":"            store_instance.configure()"},{"line_number":36,"context_line":"            self.assertTrue(mock_log.warning.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_d3268d15","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":52},"in_reply_to":"5a3905b3_57403607","updated":"2017-01-26 15:04:35.000000000","message":"Done","commit_id":"e556cbab9ddc10a14880b318e3f619c6b75337cd"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"4b7498a24018d4ed69f702eaf7e444ab079f5207","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            store_instance.configure()"},{"line_number":36,"context_line":"            mock_log.warning.assert_called_once_with("},{"line_number":37,"context_line":"                \"Failed to configure store correctly: Store filesystem\""},{"line_number":38,"context_line":"                \" could not be configured correctly. Reason: Specify\""},{"line_number":39,"context_line":"                \" at least \u0027filesystem_store_datadir\u0027 or\""},{"line_number":40,"context_line":"                \" \u0027filesystem_store_datadirs\u0027 option Disabling add method.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_8a63d519","line":38,"range":{"start_line":38,"start_character":17,"end_line":38,"end_character":18},"updated":"2017-01-26 22:17:38.000000000","message":"Nit: Always have the space at the end of the line.","commit_id":"5ea7d275f97185d8e6d6c00c6ad0fa6baa1a1001"},{"author":{"_account_id":20570,"name":"Adam Kijak","email":"adam.kijak@corp.ovh.com","username":"adam.kijak"},"change_message_id":"656de29e390caf0f9bf7b5ce006e3ed5e36d46cf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            store_instance.configure()"},{"line_number":36,"context_line":"            mock_log.warning.assert_called_once_with("},{"line_number":37,"context_line":"                \"Failed to configure store correctly: Store filesystem\""},{"line_number":38,"context_line":"                \" could not be configured correctly. Reason: Specify\""},{"line_number":39,"context_line":"                \" at least \u0027filesystem_store_datadir\u0027 or\""},{"line_number":40,"context_line":"                \" \u0027filesystem_store_datadirs\u0027 option Disabling add method.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_f8aecb83","line":38,"range":{"start_line":38,"start_character":17,"end_line":38,"end_character":18},"in_reply_to":"3a461143_8a63d519","updated":"2017-03-02 14:02:55.000000000","message":"Fixed.","commit_id":"5ea7d275f97185d8e6d6c00c6ad0fa6baa1a1001"}]}
