)]}'
{"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"b60aff2d4b7a606915f579f8a8e22e02b5fdc46e","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        default_swift_reference \u003d ref_params.get(default_ref)"},{"line_number":1399,"context_line":"        if not default_swift_reference:"},{"line_number":1400,"context_line":"            reason \u003d _(\"default_swift_reference %s is \""},{"line_number":1401,"context_line":"                       \"required.\"), default_ref"},{"line_number":1402,"context_line":"            LOG.error(reason)"},{"line_number":1403,"context_line":"            raise exceptions.BadStoreConfiguration(message\u003dreason)"},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_92fde43c","side":"PARENT","line":1401,"updated":"2017-03-15 19:09:32.000000000","message":"isn\u0027t the right fix for this to perform late interpolation?\n\n  reason \u003d _(\"default_swift_reference %s is \"\n             \"required.\", default_ref)","commit_id":"d2689810932a37691a576fed031f48ee261f7b5e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e2c7d28c4989162e732afae721d0a20dc85eb66e","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        default_swift_reference \u003d ref_params.get(default_ref)"},{"line_number":1399,"context_line":"        if not default_swift_reference:"},{"line_number":1400,"context_line":"            reason \u003d _(\"default_swift_reference %s is \""},{"line_number":1401,"context_line":"                       \"required.\"), default_ref"},{"line_number":1402,"context_line":"            LOG.error(reason)"},{"line_number":1403,"context_line":"            raise exceptions.BadStoreConfiguration(message\u003dreason)"},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_5706d7ce","side":"PARENT","line":1401,"in_reply_to":"3a1ff146_5278ccc4","updated":"2017-03-16 15:22:35.000000000","message":"I merely followed other instances in this file.","commit_id":"d2689810932a37691a576fed031f48ee261f7b5e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"1bbfd874ab7c06fcccd0df4ce83c27540b540f1c","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        default_swift_reference \u003d ref_params.get(default_ref)"},{"line_number":1399,"context_line":"        if not default_swift_reference:"},{"line_number":1400,"context_line":"            reason \u003d _(\"default_swift_reference %s is \""},{"line_number":1401,"context_line":"                       \"required.\"), default_ref"},{"line_number":1402,"context_line":"            LOG.error(reason)"},{"line_number":1403,"context_line":"            raise exceptions.BadStoreConfiguration(message\u003dreason)"},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_7abe5ad5","side":"PARENT","line":1401,"in_reply_to":"3a1ff146_5706d7ce","updated":"2017-03-16 16:02:09.000000000","message":"Juan Antonio, I understand, but the more right way to do this would be like what Steve has commented. We would want to delay the string interpolation up to logging.Logger. For reference, please see [1], [2]\n\n[1] https://docs.python.org/2/howto/logging.html#logging-variable-data\n[2] https://docs.python.org/2/library/logging.html#logger-objects","commit_id":"d2689810932a37691a576fed031f48ee261f7b5e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"5f5ac9583670de1852e65bafd070bfa8ea092809","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        default_swift_reference \u003d ref_params.get(default_ref)"},{"line_number":1399,"context_line":"        if not default_swift_reference:"},{"line_number":1400,"context_line":"            reason \u003d _(\"default_swift_reference %s is \""},{"line_number":1401,"context_line":"                       \"required.\"), default_ref"},{"line_number":1402,"context_line":"            LOG.error(reason)"},{"line_number":1403,"context_line":"            raise exceptions.BadStoreConfiguration(message\u003dreason)"},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_5278ccc4","side":"PARENT","line":1401,"in_reply_to":"3a1ff146_92fde43c","updated":"2017-03-15 19:16:23.000000000","message":"Yeah, I think we need to delay string interpolation.","commit_id":"d2689810932a37691a576fed031f48ee261f7b5e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e2c7d28c4989162e732afae721d0a20dc85eb66e","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"            reason \u003d _(\"default_swift_reference %s is \""},{"line_number":1401,"context_line":"                       \"required.\"), default_ref"},{"line_number":1402,"context_line":"            LOG.error(reason)"},{"line_number":1403,"context_line":"            raise exceptions.BadStoreConfiguration(message\u003dreason)"},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"        auth_address \u003d default_swift_reference.get(\u0027auth_address\u0027)"},{"line_number":1406,"context_line":"        user \u003d default_swift_reference.get(\u0027user\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_d721e74e","side":"PARENT","line":1403,"updated":"2017-03-16 15:22:35.000000000","message":"that recommendation also won\u0027t as is since the message is set wrong here. which is the actual issue.","commit_id":"d2689810932a37691a576fed031f48ee261f7b5e"}]}