)]}'
{"glance_store/_drivers/cinder.py":[{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"1a9886a1e6c6302ec15367be99bb2a34531baf86","unresolved":false,"context_lines":[{"line_number":494,"context_line":"            volume.attach(None, None, attach_mode, host_name\u003dhost)"},{"line_number":495,"context_line":"            volume \u003d self._wait_volume_status(volume, \u0027attaching\u0027, \u0027in-use\u0027)"},{"line_number":496,"context_line":"            if (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":497,"context_line":"               not conn.do_local_attach):"},{"line_number":498,"context_line":"                yield device[\u0027path\u0027]"},{"line_number":499,"context_line":"            else:"},{"line_number":500,"context_line":"                with temporary_chown(device[\u0027path\u0027]), \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_104b37b0","line":497,"range":{"start_line":497,"start_character":19,"end_line":497,"end_character":39},"updated":"2017-03-27 19:28:28.000000000","message":"`do_local_attach` might not be always set, so should be `.get(\u0027do_local_attach\u0027)`.","commit_id":"5152e8834da6cb683a59717068a2780c778432b4"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"change_message_id":"9a650716fcbc2283a81b1ad739e35f4428f071e8","unresolved":false,"context_lines":[{"line_number":494,"context_line":"            volume.attach(None, None, attach_mode, host_name\u003dhost)"},{"line_number":495,"context_line":"            volume \u003d self._wait_volume_status(volume, \u0027attaching\u0027, \u0027in-use\u0027)"},{"line_number":496,"context_line":"            if (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":497,"context_line":"               not conn.do_local_attach):"},{"line_number":498,"context_line":"                yield device[\u0027path\u0027]"},{"line_number":499,"context_line":"            else:"},{"line_number":500,"context_line":"                with temporary_chown(device[\u0027path\u0027]), \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_99dc0ce5","line":497,"range":{"start_line":497,"start_character":19,"end_line":497,"end_character":39},"in_reply_to":"ffe62b97_104b37b0","updated":"2017-03-28 00:48:02.000000000","message":"do_local_attach is always set.\nos_brick/initiator/connectors/rbd.py\n--------------------------------\nclass RBDConnector(base.BaseLinuxConnector):\n    \"\"\"\"Connector class to attach/detach RBD volumes.\"\"\"\n\n    def __init__(self, root_helper, driver\u003dNone, use_multipath\u003dFalse,\n                 device_scan_attempts\u003dinitiator.DEVICE_SCAN_ATTEMPTS_DEFAULT,\n                 *args, **kwargs):\n\n        super(RBDConnector, self).__init__(root_helper, driver\u003ddriver,\n                                           device_scan_attempts\u003d\n                                           device_scan_attempts,\n                                           *args, **kwargs)\n        self.do_local_attach \u003d kwargs.get(\u0027do_local_attach\u0027, False)","commit_id":"5152e8834da6cb683a59717068a2780c778432b4"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"1a9886a1e6c6302ec15367be99bb2a34531baf86","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            volume \u003d self._wait_volume_status(volume, \u0027attaching\u0027, \u0027in-use\u0027)"},{"line_number":496,"context_line":"            if (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":497,"context_line":"               not conn.do_local_attach):"},{"line_number":498,"context_line":"                yield device[\u0027path\u0027]"},{"line_number":499,"context_line":"            else:"},{"line_number":500,"context_line":"                with temporary_chown(device[\u0027path\u0027]), \\"},{"line_number":501,"context_line":"                        open(device[\u0027path\u0027], mode) as f:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_10f9f74b","line":498,"range":{"start_line":498,"start_character":16,"end_line":498,"end_character":36},"updated":"2017-03-27 19:28:28.000000000","message":"I prefer to pass do_local_attach\u003dtrue on initialization of InitiatorConnector.\n\nFor long term solution, os-brick or cinderclient should provide utility to attach the device to the host.","commit_id":"5152e8834da6cb683a59717068a2780c778432b4"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"change_message_id":"9a650716fcbc2283a81b1ad739e35f4428f071e8","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            volume \u003d self._wait_volume_status(volume, \u0027attaching\u0027, \u0027in-use\u0027)"},{"line_number":496,"context_line":"            if (connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027rbd\u0027 and"},{"line_number":497,"context_line":"               not conn.do_local_attach):"},{"line_number":498,"context_line":"                yield device[\u0027path\u0027]"},{"line_number":499,"context_line":"            else:"},{"line_number":500,"context_line":"                with temporary_chown(device[\u0027path\u0027]), \\"},{"line_number":501,"context_line":"                        open(device[\u0027path\u0027], mode) as f:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_59e204a2","line":498,"range":{"start_line":498,"start_character":16,"end_line":498,"end_character":36},"in_reply_to":"ffe62b97_10f9f74b","updated":"2017-03-28 00:48:02.000000000","message":"ok,i will fix it in os_brick later.","commit_id":"5152e8834da6cb683a59717068a2780c778432b4"}]}
