)]}'
{"glance_store/location.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"50358700df2b12ad0fd45fbeabe4359fca9583d9","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            if uri.startswith(valid_schema):"},{"line_number":179,"context_line":"                break"},{"line_number":180,"context_line":"        else:"},{"line_number":181,"context_line":"            reason \u003d _(\"location URI must start with one of\""},{"line_number":182,"context_line":"                       \"the following schemas \u0027%s\u0027\") % str(valid_schemas)"},{"line_number":183,"context_line":"            LOG.info(reason)"},{"line_number":184,"context_line":"            raise exceptions.BadStoreUri(message\u003dreason)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_069364a5","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":73},"updated":"2018-04-26 13:51:00.000000000","message":"Since valid_schemas is a tuple of strings, this message is going to look a bit weird, something like:\n\n  start with one of following schemas \u0027(\u0027cinder://\u0027,)\u0027\n\nI suggest changing the string to\n\n    \"Location URI must start with one of \"\n    \"the following schemas: %s\") % \u0027, \u0027.join(valid_schemas)\n\n(Also notice capital L and the space after \u0027of\u0027.)","commit_id":"e5d1c0624f9fbadc0ad646b5b8fd114158238581"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"821214171867371125d24d1f20f45d42754f9c19","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        for valid_schema in valid_schemas:"},{"line_number":178,"context_line":"            if uri.startswith(valid_schema):"},{"line_number":179,"context_line":"                break"},{"line_number":180,"context_line":"        else:"},{"line_number":181,"context_line":"            reason \u003d _(\"Location URI must start with one of the following \""},{"line_number":182,"context_line":"                       \"schemas: %s\") % \u0027, \u0027.join(valid_schemas)"},{"line_number":183,"context_line":"            LOG.info(reason)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_819090ef","line":180,"range":{"start_line":179,"start_character":16,"end_line":180,"end_character":13},"updated":"2018-06-05 23:48:43.000000000","message":"we could just return instead of break and drop the else clause off all together","commit_id":"9eee56ec9c00d805e38ba0372299fdf676457518"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c036c9503a04da00a5437a182f00bf0ac20faf8c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        for valid_schema in valid_schemas:"},{"line_number":178,"context_line":"            if uri.startswith(valid_schema):"},{"line_number":179,"context_line":"                break"},{"line_number":180,"context_line":"        else:"},{"line_number":181,"context_line":"            reason \u003d _(\"Location URI must start with one of the following \""},{"line_number":182,"context_line":"                       \"schemas: %s\") % \u0027, \u0027.join(valid_schemas)"},{"line_number":183,"context_line":"            LOG.info(reason)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2615ffe5","line":180,"range":{"start_line":179,"start_character":16,"end_line":180,"end_character":13},"in_reply_to":"5f7c97a3_819090ef","updated":"2018-06-06 14:49:54.000000000","message":"Good point.","commit_id":"9eee56ec9c00d805e38ba0372299fdf676457518"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"c3d0cc4a89cda37fd31f3e93df8d97584c6771f4","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            if uri.startswith(valid_schema):"},{"line_number":179,"context_line":"                return"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        reason \u003d _(\"Location URI must start with one of the following \""},{"line_number":182,"context_line":"                   \"schemas: %s\") % \u0027, \u0027.join(valid_schemas)"},{"line_number":183,"context_line":"        LOG.info(reason)"},{"line_number":184,"context_line":"        raise exceptions.BadStoreUri(message\u003dreason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_0aff8b67","line":181,"range":{"start_line":181,"start_character":17,"end_line":181,"end_character":18},"updated":"2018-06-07 12:56:36.000000000","message":"If we end up using debug logging this should not be translated before logging.","commit_id":"26592e91f59504cdc7f54c78fff47b106b54746d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2b4c54405e3164c0059553b996f0f438914615e5","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            if uri.startswith(valid_schema):"},{"line_number":179,"context_line":"                return"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        reason \u003d _(\"Location URI must start with one of the following \""},{"line_number":182,"context_line":"                   \"schemas: %s\") % \u0027, \u0027.join(valid_schemas)"},{"line_number":183,"context_line":"        LOG.info(reason)"},{"line_number":184,"context_line":"        raise exceptions.BadStoreUri(message\u003dreason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b5983c75","line":181,"range":{"start_line":181,"start_character":17,"end_line":181,"end_character":18},"in_reply_to":"5f7c97a3_0aff8b67","updated":"2018-06-07 13:21:44.000000000","message":"We do still need the _() translation as it is right now since the `reason` variable is used for the exception message.","commit_id":"26592e91f59504cdc7f54c78fff47b106b54746d"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"c3d0cc4a89cda37fd31f3e93df8d97584c6771f4","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        reason \u003d _(\"Location URI must start with one of the following \""},{"line_number":182,"context_line":"                   \"schemas: %s\") % \u0027, \u0027.join(valid_schemas)"},{"line_number":183,"context_line":"        LOG.info(reason)"},{"line_number":184,"context_line":"        raise exceptions.BadStoreUri(message\u003dreason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_8ac4fb41","line":183,"range":{"start_line":183,"start_character":8,"end_line":183,"end_character":24},"updated":"2018-06-07 12:56:36.000000000","message":"Sorry noticed this only now!\n\nwe should not log error condition as info, either warn or debug would be appropriate here.","commit_id":"26592e91f59504cdc7f54c78fff47b106b54746d"}],"glance_store/tests/unit/test_location.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"821214171867371125d24d1f20f45d42754f9c19","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from glance_store.tests import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestHttpStore(base.StoreBaseTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(TestHttpStore, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_01b6c08b","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":19},"updated":"2018-06-05 23:48:43.000000000","message":"Not exactly testing http store.","commit_id":"9eee56ec9c00d805e38ba0372299fdf676457518"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c036c9503a04da00a5437a182f00bf0ac20faf8c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from glance_store.tests import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestHttpStore(base.StoreBaseTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(TestHttpStore, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_467cbb1f","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":19},"in_reply_to":"5f7c97a3_01b6c08b","updated":"2018-06-06 14:49:54.000000000","message":"I completely missed this!","commit_id":"9eee56ec9c00d805e38ba0372299fdf676457518"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9f88fdd9f67ab41fa5da3061bfc7e5d89448cffa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f1ceda59","line":1,"updated":"2018-06-06 21:23:25.000000000","message":"Foundation copyrights shouldn\u0027t be added to new files unless the code is written by an employee of the foundation. Copy/paste error?","commit_id":"0e181893e34871bdcc4ab063934cbedcf7716cbc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6ad67dc83bb2b217db7d3827db9299a3a274d699","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4071f2a7","line":1,"in_reply_to":"5f7c97a3_f1ceda59","updated":"2018-06-07 02:29:46.000000000","message":"I completely missed that.","commit_id":"0e181893e34871bdcc4ab063934cbedcf7716cbc"}]}