)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6c1cf33f3e886c20807775409f6397ff04f50adc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix html_last_updated_fmt in conf.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove duplicate html_last_updated_fmt in doc/source/conf.py."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ife99fbc14ef5c03a87428eaf5b3fa62aacda9450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_72f59556","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":16},"updated":"2018-05-29 12:12:10.000000000","message":"This is duplicated where?  Please explain the reason for this change.","commit_id":"48bc47fed3817f6b4b957e9b7153f233aa39757d"},{"author":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"change_message_id":"c16f008edaad07c5b6840aaffddafb746866cf6e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix html_last_updated_fmt in conf.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove duplicate html_last_updated_fmt in doc/source/conf.py."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ife99fbc14ef5c03a87428eaf5b3fa62aacda9450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d68ecbcf","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":16},"in_reply_to":"5f7c97a3_68a042f5","updated":"2018-05-30 07:39:40.000000000","message":"Follow https://docs.openstack.org/openstackdocstheme/latest\nwe need to remove html_last_updated_fmt.","commit_id":"48bc47fed3817f6b4b957e9b7153f233aa39757d"},{"author":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"change_message_id":"e607d827e6b86c2f3013bda41bb663a33d6e21af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix html_last_updated_fmt in conf.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove duplicate html_last_updated_fmt in doc/source/conf.py."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ife99fbc14ef5c03a87428eaf5b3fa62aacda9450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_9255d120","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":16},"in_reply_to":"5f7c97a3_72f59556","updated":"2018-05-29 12:28:52.000000000","message":"We define html_last_updated_fmt in 32 line, but redefine in 78 line, the second one cause the first one not take effect.","commit_id":"48bc47fed3817f6b4b957e9b7153f233aa39757d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f161d9dfa869e345921a4cc4dc9d4606a6ed5ad6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix html_last_updated_fmt in conf.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove duplicate html_last_updated_fmt in doc/source/conf.py."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ife99fbc14ef5c03a87428eaf5b3fa62aacda9450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_68a042f5","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":16},"in_reply_to":"5f7c97a3_9255d120","updated":"2018-05-29 13:28:09.000000000","message":"OK, but isn\u0027t that the point of the second one?  We set an initial value at line 32, and then try to get the timestamp and commit hash from git at line 78.  If we succeed, the value is changed, and if we fail, the value assigned at line 32 remains as the value of html_last_updated_fmt.  I don\u0027t see a reason to change this.","commit_id":"48bc47fed3817f6b4b957e9b7153f233aa39757d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b6e02bc06d98a951cb07aca7009bb905083e3e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix html_last_updated_fmt in conf.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove duplicate html_last_updated_fmt in doc/source/conf.py."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ife99fbc14ef5c03a87428eaf5b3fa62aacda9450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_6248e32d","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":16},"in_reply_to":"5f7c97a3_d68ecbcf","updated":"2018-06-05 13:04:21.000000000","message":"OK, so please revise your commit message to something like:\n\n  Update conf.py to align with openstackdocstheme\n\n  Revise the documentation configuration to reflect the latest guidelines at https://docs.openstack.org/openstackdocstheme/latest/\n\n(This makes it easier on the reviewers.  And I assume you have checked through the whole document?  Is html_last_updated_fmt the only thing that needs to be changed?)","commit_id":"48bc47fed3817f6b4b957e9b7153f233aa39757d"}]}
