)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"554c3cab49760806633b51d6541758f57d90a38a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eff4b68a_79039386","updated":"2022-08-09 16:40:18.000000000","message":"Quickly looking at this, I think the Connection object returned by Swift retries 5 times by default (see https://github.com/openstack/python-swiftclient/blob/61ce5ac8244206c5e469e24459e365a5b0767dd5/swiftclient/client.py#L1637) and this applies to put_object. I believe Brian is right, and that this patch is actually not needed.","commit_id":"3dc4db82fff4285a821add77055da4c1c342740a"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6e2cb1a280efc704960e5f26530abab2c77bcf96","unresolved":false,"context_lines":[{"line_number":981,"context_line":"                                                location.container,"},{"line_number":982,"context_line":"                                                chunk_name, reader,"},{"line_number":983,"context_line":"                                                content_length\u003dcontent_length)"},{"line_number":984,"context_line":"                                        last_exc_info \u003d None"},{"line_number":985,"context_line":"                                    except Exception:"},{"line_number":986,"context_line":"                                        last_exc_info \u003d sys.exc_info()"},{"line_number":987,"context_line":"                                        LOG.error("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_410f0539","line":984,"updated":"2018-06-27 20:25:03.000000000","message":"We want a break after a successful upload, surely?","commit_id":"d263c09972940b5180fcce807a86bb0b6d3463e0"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"6fe5c3474203223ea86930ddeaa0ce0dd7dd01c3","unresolved":false,"context_lines":[{"line_number":981,"context_line":"                                                location.container,"},{"line_number":982,"context_line":"                                                chunk_name, reader,"},{"line_number":983,"context_line":"                                                content_length\u003dcontent_length)"},{"line_number":984,"context_line":"                                        last_exc_info \u003d None"},{"line_number":985,"context_line":"                                    except Exception:"},{"line_number":986,"context_line":"                                        last_exc_info \u003d sys.exc_info()"},{"line_number":987,"context_line":"                                        LOG.error("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_59ffe701","line":984,"in_reply_to":"5f7c97a3_410f0539","updated":"2018-07-12 00:21:38.000000000","message":"Yes, thanks for catching that!","commit_id":"d263c09972940b5180fcce807a86bb0b6d3463e0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6e2cb1a280efc704960e5f26530abab2c77bcf96","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"                 others"},{"line_number":1178,"context_line":"        \"\"\""},{"line_number":1179,"context_line":"        # initialize a connection"},{"line_number":1180,"context_line":"        return swiftclient.Connection("},{"line_number":1181,"context_line":"            preauthurl\u003dstorage_url,"},{"line_number":1182,"context_line":"            preauthtoken\u003dauth_token,"},{"line_number":1183,"context_line":"            insecure\u003dself.insecure,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b445f946","line":1180,"updated":"2018-06-27 20:25:03.000000000","message":"swiftclient.Connection has a retries property with a pretty generous default [1] -- just how flakey do we expect this connection to be?\n\n[1] https://github.com/openstack/python-swiftclient/blob/3.5.0/swiftclient/client.py#L1548","commit_id":"d263c09972940b5180fcce807a86bb0b6d3463e0"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a63c46607145125c7588c310710f43b89692ca72","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"                 others"},{"line_number":1178,"context_line":"        \"\"\""},{"line_number":1179,"context_line":"        # initialize a connection"},{"line_number":1180,"context_line":"        return swiftclient.Connection("},{"line_number":1181,"context_line":"            preauthurl\u003dstorage_url,"},{"line_number":1182,"context_line":"            preauthtoken\u003dauth_token,"},{"line_number":1183,"context_line":"            insecure\u003dself.insecure,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_fc2261a6","line":1180,"in_reply_to":"5f7c97a3_b445f946","updated":"2018-07-12 00:23:11.000000000","message":"Ya, that\u0027s a good point; will see if we can investigate a little as to why the built-in retry isn\u0027t satisfactory.","commit_id":"d263c09972940b5180fcce807a86bb0b6d3463e0"}]}