)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fbc41d3b02a2f165bb10103672604191beaa8816","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"94083948_6feb88ff","updated":"2025-11-04 14:02:32.000000000","message":"As an action item to support this development I created a devstack-plugin-ceph patch: https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/966014 \n\nso you can pass `GLANCE_EC_ENABLE\u003dTrue` to local.conf to get that kind of configuration.","commit_id":"86d872bf7c5a0b62d355083887e9f693f92a740d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"10da2c866ae3549656737c2834fb32147abcfafe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea02dbeb_1d935683","updated":"2022-08-04 17:18:17.000000000","message":"Just rebasing so we can discuss this during the next review party.","commit_id":"86d872bf7c5a0b62d355083887e9f693f92a740d"}],"glance_store/_drivers/rbd.py":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d4511bd06f6cb0c3520df3cdf904de8ba0bd6dbc","unresolved":true,"context_lines":[{"line_number":457,"context_line":"                      features\u003dint(features), data_pool\u003ddata_pool)"},{"line_number":458,"context_line":"        return StoreLocation({"},{"line_number":459,"context_line":"            \u0027fsid\u0027: fsid,"},{"line_number":460,"context_line":"            \u0027pool\u0027: self.pool,"},{"line_number":461,"context_line":"            \u0027image\u0027: image_name,"},{"line_number":462,"context_line":"            \u0027snapshot\u0027: DEFAULT_SNAPNAME,"},{"line_number":463,"context_line":"        }, self.conf)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b881980_82611971","line":460,"updated":"2025-10-30 21:21:54.000000000","message":"@akekane@redhat.com @cyril@redhat.com from my tests partially dumped in [1] I think we do not need to have `data_pool` here because `self.pool` would point to the default `images` pool that is the `replicated` one. Within this pool we would store `metadata` for the EC use case, and it is sufficient to perform a future `Image` read operation because the `data_pool` info is stored within the metadata (you can see it with a `rbd info images/\u003cmy_ec_image\u003e`).\n\n[1] https://gist.github.com/fmount/70e74066de6885c07db6423b42ea2816","commit_id":"86d872bf7c5a0b62d355083887e9f693f92a740d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"8fa47413147e5090c1a626d5057661a542fcc6bc","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                      features\u003dint(features), data_pool\u003ddata_pool)"},{"line_number":458,"context_line":"        return StoreLocation({"},{"line_number":459,"context_line":"            \u0027fsid\u0027: fsid,"},{"line_number":460,"context_line":"            \u0027pool\u0027: self.pool,"},{"line_number":461,"context_line":"            \u0027image\u0027: image_name,"},{"line_number":462,"context_line":"            \u0027snapshot\u0027: DEFAULT_SNAPNAME,"},{"line_number":463,"context_line":"        }, self.conf)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c5438a9d_8aa20162","line":460,"in_reply_to":"47f8c9b3_8692706e","updated":"2026-04-21 19:21:45.000000000","message":"I think I have to re-align myself with the conversation first, because it has been too much time since that comment/test. Also, I think my comment wasn\u0027t intended to be on L460, but L463, and it was mostly a confirmation that storing self.pool is enough to resolve the data stored in `data_pool`.\n\n@cyril@redhat.com I\u0027m going to resolve this comment. Eventually, we can setup a test of this patch against https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/966014 to validate it.","commit_id":"86d872bf7c5a0b62d355083887e9f693f92a740d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6045141cbb1d26cffa96f7669018eaccae038800","unresolved":true,"context_lines":[{"line_number":457,"context_line":"                      features\u003dint(features), data_pool\u003ddata_pool)"},{"line_number":458,"context_line":"        return StoreLocation({"},{"line_number":459,"context_line":"            \u0027fsid\u0027: fsid,"},{"line_number":460,"context_line":"            \u0027pool\u0027: self.pool,"},{"line_number":461,"context_line":"            \u0027image\u0027: image_name,"},{"line_number":462,"context_line":"            \u0027snapshot\u0027: DEFAULT_SNAPNAME,"},{"line_number":463,"context_line":"        }, self.conf)"}],"source_content_type":"text/x-python","patch_set":2,"id":"47f8c9b3_8692706e","line":460,"in_reply_to":"9b881980_82611971","updated":"2026-04-21 15:41:46.000000000","message":"I am a bit confused. In your gist, you do pass data_pool\u003d... to create(). I\u0027m not sure what you are suggesting, care to share a diff?","commit_id":"86d872bf7c5a0b62d355083887e9f693f92a740d"}]}