)]}'
{"glance_store/_drivers/rbd.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2cb018ed6d32909412d56368166a6b1550de4af5","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                            image.create_snap(loc.snapshot)"},{"line_number":516,"context_line":"                            image.protect_snap(loc.snapshot)"},{"line_number":517,"context_line":"                except rbd.NoSpace:"},{"line_number":518,"context_line":"                    log_msg \u003d (_LE(\"Failed to store image %(img_name)s \""},{"line_number":519,"context_line":"                                   \"insufficient space available\") %"},{"line_number":520,"context_line":"                               {\u0027img_name\u0027: image_name})"},{"line_number":521,"context_line":"                    LOG.error(log_msg)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"                    # Delete image if one was created"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7174bdce","line":520,"range":{"start_line":518,"start_character":0,"end_line":520,"end_character":56},"updated":"2018-12-19 14:28:01.000000000","message":"This may have to be addressed in a followup patch, because I notice the same thing is done at line 533.  Is there are reason why we use the image name instead of the image_id?  \nWe have it available, and it\u0027s unambiguous while the name is not.","commit_id":"7377cf2638d36dbdbc91b3884e9d53a095364b5e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"202c6f0206c9d57a8620fd5d9dcb7d0a888e2afe","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                            image.create_snap(loc.snapshot)"},{"line_number":516,"context_line":"                            image.protect_snap(loc.snapshot)"},{"line_number":517,"context_line":"                except rbd.NoSpace:"},{"line_number":518,"context_line":"                    log_msg \u003d (_LE(\"Failed to store image %(img_name)s \""},{"line_number":519,"context_line":"                                   \"insufficient space available\") %"},{"line_number":520,"context_line":"                               {\u0027img_name\u0027: image_name})"},{"line_number":521,"context_line":"                    LOG.error(log_msg)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"                    # Delete image if one was created"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8c6cbf9e","line":520,"range":{"start_line":518,"start_character":0,"end_line":520,"end_character":56},"in_reply_to":"3f79a3b5_054df936","updated":"2018-12-20 22:57:57.000000000","message":"We discussed this at today\u0027s glance meeting.  The consensus was that we should be using the id here, so go ahead and change it on this patch so that we are merging a correct change.  Then file a bug about the rest of the file, saying that it should be using ID instead of name, and then you can put up a new patch that gets the rest.  Thanks!","commit_id":"7377cf2638d36dbdbc91b3884e9d53a095364b5e"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"8e6085ad05f328d4ab8e26e84d30f3352fe2fddb","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                            image.create_snap(loc.snapshot)"},{"line_number":516,"context_line":"                            image.protect_snap(loc.snapshot)"},{"line_number":517,"context_line":"                except rbd.NoSpace:"},{"line_number":518,"context_line":"                    log_msg \u003d (_LE(\"Failed to store image %(img_name)s \""},{"line_number":519,"context_line":"                                   \"insufficient space available\") %"},{"line_number":520,"context_line":"                               {\u0027img_name\u0027: image_name})"},{"line_number":521,"context_line":"                    LOG.error(log_msg)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"                    # Delete image if one was created"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_054df936","line":520,"range":{"start_line":518,"start_character":0,"end_line":520,"end_character":56},"in_reply_to":"3f79a3b5_7174bdce","updated":"2018-12-20 01:49:52.000000000","message":"@Rosmaita, thanks to point this out. The message is copied from line 533, no specific reason here.\n\nWe need a followup patch to reform the message, e.g. change the image name to image id, right? If so, I will do this followup patch.","commit_id":"7377cf2638d36dbdbc91b3884e9d53a095364b5e"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"a78092a6a87ab7b38956c3ae957ab764c3ac229c","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                            image.create_snap(loc.snapshot)"},{"line_number":516,"context_line":"                            image.protect_snap(loc.snapshot)"},{"line_number":517,"context_line":"                except rbd.NoSpace:"},{"line_number":518,"context_line":"                    log_msg \u003d (_LE(\"Failed to store image %(img_name)s \""},{"line_number":519,"context_line":"                                   \"insufficient space available\") %"},{"line_number":520,"context_line":"                               {\u0027img_name\u0027: image_name})"},{"line_number":521,"context_line":"                    LOG.error(log_msg)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"                    # Delete image if one was created"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5b62d7a9","line":520,"range":{"start_line":518,"start_character":0,"end_line":520,"end_character":56},"in_reply_to":"3f79a3b5_8c6cbf9e","updated":"2018-12-21 06:24:33.000000000","message":"@Rosmaita sorry, I was misled by the word image_name myself, in fact image_name is image_id here.\n\nsee line 467:\n467         image_name \u003d str(image_id)\n\nAnd this is the log I got previously:\n2018-12-11 15:51:06 ERROR glance_store._drivers.rbd None req-5acbf16b-95f1-460d-9a22-27976999f030 demo admin Failed to store image 8f4f645d-e310-465c-9d08-88c0f64f3126 insufficient space available: NoSpace: [errno 28] ...\n\nSo it seems this patch don\u0027t need to change and I just need to go ahead to replace the name from image_name to something like image_id in this file, in a separate patch, am I right?","commit_id":"7377cf2638d36dbdbc91b3884e9d53a095364b5e"}]}