)]}'
{"glance_store/multi_backend.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ea466ade08800bff1a4a6a4a16537d969c28b97a","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    driver_opts \u003d _list_driver_opts()"},{"line_number":154,"context_line":"    enabled_backends \u003d conf.enabled_backends"},{"line_number":155,"context_line":"    enabled_backends.update(RESERVED_STORES)"},{"line_number":156,"context_line":"    for backend in enabled_backends:"},{"line_number":157,"context_line":"        for opt_list in driver_opts:"},{"line_number":158,"context_line":"            if enabled_backends[backend] not in opt_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_c4806bc2","line":155,"updated":"2019-05-24 21:49:49.000000000","message":"Before we do this, I wonder if we should make sure that none of the enabled_backends begins with the prefix \u0027os_glance_\u0027, and if any one does, raise an exception for bad configuration?\n\nAt a minimum, we should include an upgrade check for this.  Jay has a patch up for a Cinder check for removed backend drivers, ours would be even simpler: https://review.opendev.org/#/c/649209/","commit_id":"ba54a6bf328df10072b4a1f7c6af3bce0d372fca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1be59dd7302069dd75982f2715cf3965774789d7","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    driver_opts \u003d _list_driver_opts()"},{"line_number":154,"context_line":"    enabled_backends \u003d conf.enabled_backends"},{"line_number":155,"context_line":"    enabled_backends.update(RESERVED_STORES)"},{"line_number":156,"context_line":"    for backend in enabled_backends:"},{"line_number":157,"context_line":"        for opt_list in driver_opts:"},{"line_number":158,"context_line":"            if enabled_backends[backend] not in opt_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_d196e14c","line":155,"in_reply_to":"bfb3d3c7_c4806bc2","updated":"2019-05-27 04:03:04.000000000","message":"IMO both these suggestions will be a part of glance and not store library. So I will make these changes in glance patch.","commit_id":"ba54a6bf328df10072b4a1f7c6af3bce0d372fca"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"71a70fa9c9af5a374f0ac586a07e0d69b891be15","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    enabled_backends \u003d CONF.enabled_backends"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    try:"},{"line_number":209,"context_line":"        if store_identifier.startswith(\u0027os_glance_\u0027):"},{"line_number":210,"context_line":"            scheme \u003d \u0027file\u0027"},{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            scheme \u003d enabled_backends[store_identifier]"},{"line_number":213,"context_line":"    except KeyError:"},{"line_number":214,"context_line":"        msg \u003d _(\"Store for identifier %s not found\") % store_identifier"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fb8cfa7_deb16ee3","line":211,"range":{"start_line":209,"start_character":0,"end_line":211,"end_character":13},"updated":"2019-06-04 21:39:17.000000000","message":"Instead of hard-coding this, how about having create_multi_stores or _load_multi_stores set a _RESERVED_STORES variable with the {\"name\":\"type\"} dict passed in as a kwarg, and then here you could do something like you did on PS10, where you appended the reserved stores to the local enabled_backends variable.","commit_id":"e793dee5fe219ee9095b0f2b52b3392ab51dff5d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"67e516f05b46b5fa2dd6f1b249e2696c47afcaf6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    enabled_backends \u003d CONF.enabled_backends"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    try:"},{"line_number":209,"context_line":"        if store_identifier.startswith(\u0027os_glance_\u0027):"},{"line_number":210,"context_line":"            scheme \u003d \u0027file\u0027"},{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            scheme \u003d enabled_backends[store_identifier]"},{"line_number":213,"context_line":"    except KeyError:"},{"line_number":214,"context_line":"        msg \u003d _(\"Store for identifier %s not found\") % store_identifier"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fb8cfa7_72faf342","line":211,"range":{"start_line":209,"start_character":0,"end_line":211,"end_character":13},"in_reply_to":"9fb8cfa7_deb16ee3","updated":"2019-06-05 03:06:53.000000000","message":"Done","commit_id":"e793dee5fe219ee9095b0f2b52b3392ab51dff5d"}],"glance_store/tests/unit/test_store_base.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31c3f1caa7e004d877c5efe059f5f4774fde81aa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.reserved_stores \u003d {"},{"line_number":58,"context_line":"            \u0027os_glance_staging_store\u0027: \u0027file\u0027"},{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.conf \u003d self._CONF"}],"source_content_type":"text/x-python","patch_set":14,"id":"9fb8cfa7_fe8c6580","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":36},"updated":"2019-06-05 12:49:23.000000000","message":"I\u0027d suggest naming this \u0027consuming_service_reserved_store\u0027 so we can be sure the \u0027os_glance_\u0027 stuff isn\u0027t hard coded somewhere.","commit_id":"6686bb9f9da3ee70f5c4d884c95905ef3b5082cb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"18fb5dd7f4f5518c064f8a3ccabe4c735994cb36","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.reserved_stores \u003d {"},{"line_number":58,"context_line":"            \u0027os_glance_staging_store\u0027: \u0027file\u0027"},{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.conf \u003d self._CONF"}],"source_content_type":"text/x-python","patch_set":14,"id":"9fb8cfa7_5eb6d1fc","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":36},"in_reply_to":"9fb8cfa7_fe8c6580","updated":"2019-06-05 13:10:13.000000000","message":"Done","commit_id":"6686bb9f9da3ee70f5c4d884c95905ef3b5082cb"}],"releasenotes/notes/rethinking-filesystem-access-5ab872fd0c0d27db.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ea466ade08800bff1a4a6a4a16537d969c28b97a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bfb3d3c7_ea5779c9","line":18,"updated":"2019-05-24 21:49:49.000000000","message":"This section needs to be rewritten, either here or on a follow up patch.  Probably needs to be split into \u0027features\u0027 and \u0027upgrades\u0027.\n\nIn \u0027features\u0027: mention that the tasks work directory, the image import staging area, and the glance image cache are being implemented as individual filesystem stores.  These are automatically configured by Glance and require no operator input (?? -- or do they?).  The goal is that in a future release, operators will be able to configure a store of their choice for each of these functions.  In Train, however, each *must* be a filesystem store.\n\nIn \u0027upgrades\u0027: mention the deprecation of image_cache_dir, tasks/work_dir, and node_staging_uri.  As a separate bullet point, say that the store name prefix \u0027os_glance_\u0027 is reserved by Glance for internal stores.  Glance will refuse to start if a store with this prefix is included in the enabled_backends (are we still calling it that?) option.","commit_id":"ba54a6bf328df10072b4a1f7c6af3bce0d372fca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1be59dd7302069dd75982f2715cf3965774789d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bfb3d3c7_f1ca054c","line":18,"in_reply_to":"bfb3d3c7_ea5779c9","updated":"2019-05-27 04:03:04.000000000","message":"\u003e this prefix is included in the enabled_backends (are we still\n \u003e calling it that?) option.\n\nYes we are still calling it enabled_backends only, the reason is we renamed it to enabled_stores then we need to rename the config option default_backend to default_store which is already present, used for single store configuration and currently marked for removal.","commit_id":"ba54a6bf328df10072b4a1f7c6af3bce0d372fca"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"732b734d154322c7041188f5ead9d23133ea4fcd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Configuration option ``work_dir`` used for tasks and``node_staging_uri``"},{"line_number":8,"context_line":"    used for new image import flow will now be reserved as individual"},{"line_number":9,"context_line":"    filesystem stores namely ``os_glance_tasks_store`` and"},{"line_number":10,"context_line":"    ``os_glance_cache_store``.  These are automatically configured by Glance"},{"line_number":11,"context_line":"    and require no operator input.  The goal is that in a future release,"},{"line_number":12,"context_line":"    operators will be able to configure a store of their choice for each of"},{"line_number":13,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":14,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_49b0f343","line":11,"range":{"start_line":10,"start_character":30,"end_line":11,"end_character":34},"updated":"2019-05-28 15:38:36.000000000","message":"this should not be correct. We still expect work_dir and node_staging_uri being set, no?","commit_id":"cf0b91e37150ad9c07046aca9f943bf80d52ad64"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c80fbabbb3b0e364d0f2537664eb843efdf2e64a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Configuration option ``work_dir`` used for tasks and``node_staging_uri``"},{"line_number":8,"context_line":"    used for new image import flow will now be reserved as individual"},{"line_number":9,"context_line":"    filesystem stores namely ``os_glance_tasks_store`` and"},{"line_number":10,"context_line":"    ``os_glance_cache_store``.  These are automatically configured by Glance"},{"line_number":11,"context_line":"    and require no operator input.  The goal is that in a future release,"},{"line_number":12,"context_line":"    operators will be able to configure a store of their choice for each of"},{"line_number":13,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":14,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_21a4aba5","line":11,"range":{"start_line":10,"start_character":30,"end_line":11,"end_character":34},"in_reply_to":"bfb3d3c7_49b0f343","updated":"2019-05-29 08:50:20.000000000","message":"Done","commit_id":"cf0b91e37150ad9c07046aca9f943bf80d52ad64"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"732b734d154322c7041188f5ead9d23133ea4fcd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":14,"context_line":"upgrade:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Configuration options work_dir and node_staging_uri will"},{"line_number":17,"context_line":"    be deprecated and removed during early U development cycle."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    * The store name prefix ``os_glance_*`` is reserved by Glance for internal"},{"line_number":20,"context_line":"      stores.  Glance will refuse to start if a store with this prefix is"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_69961796","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":63},"updated":"2019-05-28 15:38:36.000000000","message":"How are we Configuring these two default stores?\n\nAlso if this is the plan, this note needs to go into glance repo with the deprecation of said config options. Not in glance_store release notes as they are totally irrelevant.","commit_id":"cf0b91e37150ad9c07046aca9f943bf80d52ad64"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c80fbabbb3b0e364d0f2537664eb843efdf2e64a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":14,"context_line":"upgrade:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Configuration options work_dir and node_staging_uri will"},{"line_number":17,"context_line":"    be deprecated and removed during early U development cycle."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    * The store name prefix ``os_glance_*`` is reserved by Glance for internal"},{"line_number":20,"context_line":"      stores.  Glance will refuse to start if a store with this prefix is"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bfb3d3c7_819b1764","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":63},"in_reply_to":"bfb3d3c7_69961796","updated":"2019-05-29 08:50:20.000000000","message":"Removing it from here, already mentioned this in glance patch.","commit_id":"cf0b91e37150ad9c07046aca9f943bf80d52ad64"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9cfffa827557cb6ed53e0b31c7dd8f543ba13d3f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    This release adds support to reserve filesystem stores for staging"},{"line_number":4,"context_line":"    and tasks operations."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Configuration option ``work_dir`` used for tasks and``node_staging_uri``"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bfb3d3c7_92d4c321","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":25},"updated":"2019-05-29 08:46:43.000000000","message":"Sorry forgot to mention about this earlier, please do not include prelude (it did render somewhat weirdly with the milestone releases and made writing the final release renos absolute pain in the arse).","commit_id":"52f9e24f6454b48bf5986050ef79e40445ecdb17"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c80fbabbb3b0e364d0f2537664eb843efdf2e64a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    This release adds support to reserve filesystem stores for staging"},{"line_number":4,"context_line":"    and tasks operations."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Configuration option ``work_dir`` used for tasks and``node_staging_uri``"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bfb3d3c7_1296934d","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":25},"in_reply_to":"bfb3d3c7_92d4c321","updated":"2019-05-29 08:50:20.000000000","message":"Done","commit_id":"52f9e24f6454b48bf5986050ef79e40445ecdb17"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9cfffa827557cb6ed53e0b31c7dd8f543ba13d3f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Configuration option ``work_dir`` used for tasks and``node_staging_uri``"},{"line_number":8,"context_line":"    used for new image import flow will now be reserved as individual"},{"line_number":9,"context_line":"    filesystem stores namely ``os_glance_tasks_store`` and"},{"line_number":10,"context_line":"    ``os_glance_cache_store``.  The goal is that in a future release,"},{"line_number":11,"context_line":"    operators will be able to configure a store of their choice for each of"},{"line_number":12,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":13,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bfb3d3c7_1223f357","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":21},"updated":"2019-05-29 08:46:43.000000000","message":"staging","commit_id":"52f9e24f6454b48bf5986050ef79e40445ecdb17"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c80fbabbb3b0e364d0f2537664eb843efdf2e64a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Configuration option ``work_dir`` used for tasks and``node_staging_uri``"},{"line_number":8,"context_line":"    used for new image import flow will now be reserved as individual"},{"line_number":9,"context_line":"    filesystem stores namely ``os_glance_tasks_store`` and"},{"line_number":10,"context_line":"    ``os_glance_cache_store``.  The goal is that in a future release,"},{"line_number":11,"context_line":"    operators will be able to configure a store of their choice for each of"},{"line_number":12,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":13,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bfb3d3c7_3293975d","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":21},"in_reply_to":"bfb3d3c7_1223f357","updated":"2019-05-29 08:50:20.000000000","message":"Done","commit_id":"52f9e24f6454b48bf5986050ef79e40445ecdb17"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d07d1f1842f818b15d785fa1da069b9783d533bf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Operator needs to define \u0027os_glance_tasks_store\u0027 and"},{"line_number":13,"context_line":"    \u0027os_glance_staging_store\u0027 in glance-api.conf configuration"},{"line_number":14,"context_line":"    file as shown below."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_838bfbc0","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":28},"updated":"2019-05-30 15:35:36.000000000","message":"Do they need to, or will things still work correctly if they share the default filesystem_store_datadir?","commit_id":"d9e10ae4bc63d21b56fa0e8aa10ac01cd2c663b2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b7aba32e36d59a2fcbdddee53c3d4fb6002eb6c5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Operator needs to define \u0027os_glance_tasks_store\u0027 and"},{"line_number":13,"context_line":"    \u0027os_glance_staging_store\u0027 in glance-api.conf configuration"},{"line_number":14,"context_line":"    file as shown below."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_9f6eebfd","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":28},"in_reply_to":"bfb3d3c7_838bfbc0","updated":"2019-05-30 17:49:01.000000000","message":"Yes they need to define it explicitly because default path for filesystem will be same for all file stores.","commit_id":"d9e10ae4bc63d21b56fa0e8aa10ac01cd2c663b2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"71a70fa9c9af5a374f0ac586a07e0d69b891be15","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration option ``work_dir`` used for tasks and``node_staging_uri``"},{"line_number":5,"context_line":"    used for new image import flow will now be reserved as individual"},{"line_number":6,"context_line":"    filesystem stores namely ``os_glance_tasks_store`` and"},{"line_number":7,"context_line":"    ``os_glance_staging_store``.  The goal is that in a future release,"},{"line_number":8,"context_line":"    operators will be able to configure a store of their choice for each of"},{"line_number":9,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Operator needs to define \u0027os_glance_tasks_store\u0027 and"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_bef6fa8e","line":9,"range":{"start_line":4,"start_character":0,"end_line":9,"end_character":75},"updated":"2019-06-04 21:39:17.000000000","message":"I think the feature now is the optional reserved_stores kwarg, where the use case is to allow a mix of (1) operator-configured stores via the enabled_backends variable, and (2) stores that are reserved for use by a consuming service.","commit_id":"e793dee5fe219ee9095b0f2b52b3392ab51dff5d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"67e516f05b46b5fa2dd6f1b249e2696c47afcaf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration option ``work_dir`` used for tasks and``node_staging_uri``"},{"line_number":5,"context_line":"    used for new image import flow will now be reserved as individual"},{"line_number":6,"context_line":"    filesystem stores namely ``os_glance_tasks_store`` and"},{"line_number":7,"context_line":"    ``os_glance_staging_store``.  The goal is that in a future release,"},{"line_number":8,"context_line":"    operators will be able to configure a store of their choice for each of"},{"line_number":9,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Operator needs to define \u0027os_glance_tasks_store\u0027 and"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_52fd6f38","line":9,"range":{"start_line":4,"start_character":0,"end_line":9,"end_character":75},"in_reply_to":"9fb8cfa7_bef6fa8e","updated":"2019-06-05 03:06:53.000000000","message":"Done","commit_id":"e793dee5fe219ee9095b0f2b52b3392ab51dff5d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"71a70fa9c9af5a374f0ac586a07e0d69b891be15","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    ``os_glance_staging_store``.  The goal is that in a future release,"},{"line_number":8,"context_line":"    operators will be able to configure a store of their choice for each of"},{"line_number":9,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Operator needs to define \u0027os_glance_tasks_store\u0027 and"},{"line_number":13,"context_line":"    \u0027os_glance_staging_store\u0027 in glance-api.conf configuration"},{"line_number":14,"context_line":"    file as shown below."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    [os_glance_tasks_store]"},{"line_number":17,"context_line":"    filesystem_store_datadir \u003d /var/lib/glance/tasks_work_dir/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    [os_glance_staging_store]"},{"line_number":20,"context_line":"    filesystem_store_datadir \u003d /var/lib/glance/staging/"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_3ee20ad7","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":62},"updated":"2019-06-04 21:39:17.000000000","message":"This is something to go into the Glance upgrade notes, I don\u0027t think it\u0027s relevant to glance_store.","commit_id":"e793dee5fe219ee9095b0f2b52b3392ab51dff5d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"67e516f05b46b5fa2dd6f1b249e2696c47afcaf6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    ``os_glance_staging_store``.  The goal is that in a future release,"},{"line_number":8,"context_line":"    operators will be able to configure a store of their choice for each of"},{"line_number":9,"context_line":"    these functions.  In Train, however, each *must* be a filesystem store."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Operator needs to define \u0027os_glance_tasks_store\u0027 and"},{"line_number":13,"context_line":"    \u0027os_glance_staging_store\u0027 in glance-api.conf configuration"},{"line_number":14,"context_line":"    file as shown below."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    [os_glance_tasks_store]"},{"line_number":17,"context_line":"    filesystem_store_datadir \u003d /var/lib/glance/tasks_work_dir/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    [os_glance_staging_store]"},{"line_number":20,"context_line":"    filesystem_store_datadir \u003d /var/lib/glance/staging/"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_1295b7e4","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":62},"in_reply_to":"9fb8cfa7_3ee20ad7","updated":"2019-06-05 03:06:53.000000000","message":"Done","commit_id":"e793dee5fe219ee9095b0f2b52b3392ab51dff5d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dddc1c922013a00cd0e99f17d85042691defa8d0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added kwarg to configure reserved stores by consumable service. This"},{"line_number":5,"context_line":"    feature will allow a mix of operator-configured stores via"},{"line_number":6,"context_line":"    enabled_backends configuration option set in glance-api.conf file and"},{"line_number":7,"context_line":"    stores that are reserved for use by a consuming service."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_6314624f","line":6,"range":{"start_line":6,"start_character":49,"end_line":6,"end_character":64},"updated":"2019-06-05 12:35:41.000000000","message":"How about \"the [glance_store] section of the consuming service\u0027s configuration file\" ?","commit_id":"09b2aaf8fe21e012387260b3051ac4e063623026"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f1a623f1e4695b4353ed3048d78613cb9e421711","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added kwarg to configure reserved stores by consumable service. This"},{"line_number":5,"context_line":"    feature will allow a mix of operator-configured stores via"},{"line_number":6,"context_line":"    enabled_backends configuration option set in glance-api.conf file and"},{"line_number":7,"context_line":"    stores that are reserved for use by a consuming service."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_7e25d5aa","line":6,"range":{"start_line":6,"start_character":49,"end_line":6,"end_character":64},"in_reply_to":"9fb8cfa7_6314624f","updated":"2019-06-05 12:40:54.000000000","message":"Done","commit_id":"09b2aaf8fe21e012387260b3051ac4e063623026"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9ef7bb29b17829debb6ee60c7d28d02617197db1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added kwarg to configure reserved stores by consumable service. This"},{"line_number":5,"context_line":"    feature will allow a mix of operator-configured stores via"},{"line_number":6,"context_line":"    enabled_backends configuration option set in the [glance_store] section"},{"line_number":7,"context_line":"    of the consuming service\u0027s configuration file and stores that are"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_7e7395b2","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":58},"updated":"2019-06-05 12:42:36.000000000","message":"the consuming","commit_id":"6686bb9f9da3ee70f5c4d884c95905ef3b5082cb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"18fb5dd7f4f5518c064f8a3ccabe4c735994cb36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added kwarg to configure reserved stores by consumable service. This"},{"line_number":5,"context_line":"    feature will allow a mix of operator-configured stores via"},{"line_number":6,"context_line":"    enabled_backends configuration option set in the [glance_store] section"},{"line_number":7,"context_line":"    of the consuming service\u0027s configuration file and stores that are"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_3ecbdd72","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":58},"in_reply_to":"9fb8cfa7_7e7395b2","updated":"2019-06-05 13:10:13.000000000","message":"Done","commit_id":"6686bb9f9da3ee70f5c4d884c95905ef3b5082cb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9ef7bb29b17829debb6ee60c7d28d02617197db1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added kwarg to configure reserved stores by consumable service. This"},{"line_number":5,"context_line":"    feature will allow a mix of operator-configured stores via"},{"line_number":6,"context_line":"    enabled_backends configuration option set in the [glance_store] section"},{"line_number":7,"context_line":"    of the consuming service\u0027s configuration file and stores that are"},{"line_number":8,"context_line":"    reserved for use by a consuming service."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_be9eedb5","line":7,"range":{"start_line":7,"start_character":49,"end_line":7,"end_character":50},"updated":"2019-06-05 12:42:36.000000000","message":"I\u0027d suggest adding a comma here -- it\u0027s a long sentence and this will make it more readable.","commit_id":"6686bb9f9da3ee70f5c4d884c95905ef3b5082cb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"18fb5dd7f4f5518c064f8a3ccabe4c735994cb36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added kwarg to configure reserved stores by consumable service. This"},{"line_number":5,"context_line":"    feature will allow a mix of operator-configured stores via"},{"line_number":6,"context_line":"    enabled_backends configuration option set in the [glance_store] section"},{"line_number":7,"context_line":"    of the consuming service\u0027s configuration file and stores that are"},{"line_number":8,"context_line":"    reserved for use by a consuming service."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_5eab3188","line":7,"range":{"start_line":7,"start_character":49,"end_line":7,"end_character":50},"in_reply_to":"9fb8cfa7_be9eedb5","updated":"2019-06-05 13:10:13.000000000","message":"Done","commit_id":"6686bb9f9da3ee70f5c4d884c95905ef3b5082cb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e2a9b7b302e09e42b83f81ffc1356657f767b1f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added kwarg to configure reserved stores by the consuming service. This"},{"line_number":5,"context_line":"    feature will allow a mix of operator-configured stores via"},{"line_number":6,"context_line":"    enabled_backends configuration option set in the [glance_store] section"},{"line_number":7,"context_line":"    of the consuming service\u0027s configuration file, and stores that are"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_9edd2916","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":19},"updated":"2019-06-05 13:00:43.000000000","message":"should probably say what call this was added to?","commit_id":"194c673d1ccd044fc89f9eb95cf50b9b7339e46c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"18fb5dd7f4f5518c064f8a3ccabe4c735994cb36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added kwarg to configure reserved stores by the consuming service. This"},{"line_number":5,"context_line":"    feature will allow a mix of operator-configured stores via"},{"line_number":6,"context_line":"    enabled_backends configuration option set in the [glance_store] section"},{"line_number":7,"context_line":"    of the consuming service\u0027s configuration file, and stores that are"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_de4881cd","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":19},"in_reply_to":"9fb8cfa7_9edd2916","updated":"2019-06-05 13:10:13.000000000","message":"Done","commit_id":"194c673d1ccd044fc89f9eb95cf50b9b7339e46c"}]}