)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f6a695c17479de08136590469df02addde5e3f70","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The config options for file stores will be registered"},{"line_number":10,"context_line":"under correct group based on the dict \"reserved_stores\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Iaf338d29673e68a15d37fdda81add552e4175634"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I636e7f8b625056d1c7ee1503ced4dd7628384bfb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_f83b07c5","line":12,"updated":"2019-09-20 13:05:11.000000000","message":"Just a reminder - http://lists.openstack.org/pipermail/openstack-dev/2018-January/126535.html\n\n\n;)","commit_id":"384862af0c4f9c4e359f878796ed164cd2e84249"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"df6cb4fbd8d743c2e802a6472367034c60f979d2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The config options for file stores will be registered"},{"line_number":10,"context_line":"under correct group based on the dict \"reserved_stores\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Iaf338d29673e68a15d37fdda81add552e4175634"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I636e7f8b625056d1c7ee1503ced4dd7628384bfb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_f871c7df","line":12,"in_reply_to":"3fa7e38b_f83b07c5","updated":"2019-09-20 13:31:18.000000000","message":"cheers, will remove it from the next rev as it merged anyways","commit_id":"384862af0c4f9c4e359f878796ed164cd2e84249"}],"glance_store/multi_backend.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"362d116e84443501ece87dd5af3599738229abf5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    LOG.debug(\"Registering options for group %s\", _STORE_CFG_GROUP)"},{"line_number":126,"context_line":"    conf.register_opts(_STORE_OPTS, group\u003d_STORE_CFG_GROUP)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    enabled_backends \u003d copy.deepcopy(conf.enabled_backends)"},{"line_number":129,"context_line":"    if reserved_stores:"},{"line_number":130,"context_line":"        conf.enabled_backends.update(reserved_stores)"},{"line_number":131,"context_line":"        for key in reserved_stores.keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b8682f87","line":128,"range":{"start_line":128,"start_character":4,"end_line":128,"end_character":20},"updated":"2019-09-20 13:10:00.000000000","message":"I suggest naming this something else, like original_backends (or nonreserved_backends), it would make things clearer at line 151.","commit_id":"384862af0c4f9c4e359f878796ed164cd2e84249"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f6a695c17479de08136590469df02addde5e3f70","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                           default\u003d\u0027/var/lib/glance/{}\u0027.format(key),"},{"line_number":135,"context_line":"                           help\u003dFS_CONF_DATADIR_HELP.format(key)),"},{"line_number":136,"context_line":"                cfg.MultiStrOpt(\u0027filesystem_store_datadirs\u0027,"},{"line_number":137,"context_line":"                                help\u003d\"\"\"Not used\"\"\"),"},{"line_number":138,"context_line":"                cfg.StrOpt(\u0027filesystem_store_metadata_file\u0027,"},{"line_number":139,"context_line":"                           help\u003d\"\"\"Not used\"\"\"),"},{"line_number":140,"context_line":"                cfg.IntOpt(\u0027filesystem_store_file_perm\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3873dfb3","line":137,"range":{"start_line":137,"start_character":40,"end_line":137,"end_character":48},"updated":"2019-09-20 13:05:11.000000000","message":"Might be good to expand on this description to state why they are not used or what the future plan is for the config opt.","commit_id":"384862af0c4f9c4e359f878796ed164cd2e84249"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"df6cb4fbd8d743c2e802a6472367034c60f979d2","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                           default\u003d\u0027/var/lib/glance/{}\u0027.format(key),"},{"line_number":135,"context_line":"                           help\u003dFS_CONF_DATADIR_HELP.format(key)),"},{"line_number":136,"context_line":"                cfg.MultiStrOpt(\u0027filesystem_store_datadirs\u0027,"},{"line_number":137,"context_line":"                                help\u003d\"\"\"Not used\"\"\"),"},{"line_number":138,"context_line":"                cfg.StrOpt(\u0027filesystem_store_metadata_file\u0027,"},{"line_number":139,"context_line":"                           help\u003d\"\"\"Not used\"\"\"),"},{"line_number":140,"context_line":"                cfg.IntOpt(\u0027filesystem_store_file_perm\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_78095793","line":137,"range":{"start_line":137,"start_character":40,"end_line":137,"end_character":48},"in_reply_to":"3fa7e38b_3873dfb3","updated":"2019-09-20 13:31:18.000000000","message":"The plan is not to promote the usage in the non-imagestore use cases as these just doesn\u0027t make sense there.\n\nThis is more of a code comment and they only get registered to ensure that the driver doesn not barf when it gets loaded and it does try to access these options.\n\nThese 3 options won\u0027t show up in the example configs either.","commit_id":"384862af0c4f9c4e359f878796ed164cd2e84249"}]}