)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"29978fc8aad71192f6bc28b6b7878f70c7f26871","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the mount point for nfs volumes."},{"line_number":13,"context_line":"The default mount point for nfs volumes is /var/lib/glance/mnt."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/709389/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I10b5ea4943ad9388ce1962eae9204b905c8ff24a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1fa4df85_ca9e7eb7","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":50},"updated":"2020-02-27 14:48:50.000000000","message":"This is no longer needed.","commit_id":"1d87b021fd2d81926162489849110113fa7134e7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0631536459d61b9c2145a89dae68c9787a22be52","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the mount point for nfs volumes."},{"line_number":13,"context_line":"The default mount point for nfs volumes is /var/lib/glance/mnt."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/709389/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I10b5ea4943ad9388ce1962eae9204b905c8ff24a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1fa4df85_e8bfc2cd","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":50},"in_reply_to":"1fa4df85_ca9e7eb7","updated":"2020-02-27 16:47:42.000000000","message":"Done","commit_id":"1d87b021fd2d81926162489849110113fa7134e7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"de56d198ccf24902f3088e66e8559052c9a9ad58","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-27 16:45:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config for nfs mount point"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, glance_store mounts the cinder volume to /var/lib/cinder/mnt"},{"line_number":10,"context_line":"which causes permission issues for glance when accessing the volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_9a2647ce","line":7,"updated":"2020-03-04 05:16:07.000000000","message":"I would suggest, report a bug in launchpad and closes-bug tag here.","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e0d2dc340e8c487833e9991b6d8c4919cc0dc8d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-27 16:45:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config for nfs mount point"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, glance_store mounts the cinder volume to /var/lib/cinder/mnt"},{"line_number":10,"context_line":"which causes permission issues for glance when accessing the volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_89f02fff","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":30},"updated":"2020-03-05 10:57:58.000000000","message":"perhaps \"Cinder mounting needs\"","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3810d0dc7df33918e91087f976e86056899ec117","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-27 16:45:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config for nfs mount point"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, glance_store mounts the cinder volume to /var/lib/cinder/mnt"},{"line_number":10,"context_line":"which causes permission issues for glance when accessing the volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_e3fe5237","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":30},"in_reply_to":"1fa4df85_89f02fff","updated":"2020-03-11 09:03:32.000000000","message":"Done","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3810d0dc7df33918e91087f976e86056899ec117","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-27 16:45:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config for nfs mount point"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, glance_store mounts the cinder volume to /var/lib/cinder/mnt"},{"line_number":10,"context_line":"which causes permission issues for glance when accessing the volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_c301d63b","line":7,"in_reply_to":"1fa4df85_9a2647ce","updated":"2020-03-11 09:03:32.000000000","message":"Done","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e0d2dc340e8c487833e9991b6d8c4919cc0dc8d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config for nfs mount point"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, glance_store mounts the cinder volume to /var/lib/cinder/mnt"},{"line_number":10,"context_line":"which causes permission issues for glance when accessing the volume."},{"line_number":11,"context_line":"This patch adds a config option \u0027mount_point_base\u0027 by which we can"},{"line_number":12,"context_line":"provide the mount point for *fs volumes."},{"line_number":13,"context_line":"The different types of FS drivers will have separate directory for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_a9b88be4","line":10,"range":{"start_line":9,"start_character":12,"end_line":10,"end_character":68},"updated":"2020-03-05 10:57:58.000000000","message":"glance_store does not mount anything by default. All we really care about is fd to direct our i/o to.","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3810d0dc7df33918e91087f976e86056899ec117","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config for nfs mount point"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, glance_store mounts the cinder volume to /var/lib/cinder/mnt"},{"line_number":10,"context_line":"which causes permission issues for glance when accessing the volume."},{"line_number":11,"context_line":"This patch adds a config option \u0027mount_point_base\u0027 by which we can"},{"line_number":12,"context_line":"provide the mount point for *fs volumes."},{"line_number":13,"context_line":"The different types of FS drivers will have separate directory for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_a3f85a49","line":10,"range":{"start_line":9,"start_character":12,"end_line":10,"end_character":68},"in_reply_to":"1fa4df85_a9b88be4","updated":"2020-03-11 09:03:32.000000000","message":"Done","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e0d2dc340e8c487833e9991b6d8c4919cc0dc8d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":14,"context_line":"mounting their volumes,"},{"line_number":15,"context_line":"Eg: \u003cmount_point_base\u003e/nfs, \u003cmount_point_base\u003e/xyzfs etc."},{"line_number":16,"context_line":"The default mount point for *fs volumes is /var/lib/glance/."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I10b5ea4943ad9388ce1962eae9204b905c8ff24a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_29c49b5e","line":16,"range":{"start_line":16,"start_character":43,"end_line":16,"end_character":59},"updated":"2020-03-05 10:57:58.000000000","message":"We should point a sub directory under this patch rather than use the top level glance path for it.","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3810d0dc7df33918e91087f976e86056899ec117","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":14,"context_line":"mounting their volumes,"},{"line_number":15,"context_line":"Eg: \u003cmount_point_base\u003e/nfs, \u003cmount_point_base\u003e/xyzfs etc."},{"line_number":16,"context_line":"The default mount point for *fs volumes is /var/lib/glance/."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I10b5ea4943ad9388ce1962eae9204b905c8ff24a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_4393a601","line":16,"range":{"start_line":16,"start_character":43,"end_line":16,"end_character":59},"in_reply_to":"1fa4df85_29c49b5e","updated":"2020-03-11 09:03:32.000000000","message":"Done","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"89ab33c7abcbd97746b75072f266bfc805781a08","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":12,"context_line":"mounting their volumes,"},{"line_number":13,"context_line":"Eg: \u003cmount_point_base\u003e/nfs, \u003cmount_point_base\u003e/xyzfs etc."},{"line_number":14,"context_line":"The default mount point for *fs volumes is /var/lib/glance/*fs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1866966"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_6351480f","line":14,"range":{"start_line":14,"start_character":43,"end_line":14,"end_character":59},"updated":"2020-03-23 09:03:52.000000000","message":"this should be now /var/lib/glance/mnt/*fs","commit_id":"db29724156b8d55957b5412a1fe13c96dfb3a099"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"434a117ee5beca57459787a8b5ce0da39ef05589","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":12,"context_line":"mounting their volumes,"},{"line_number":13,"context_line":"Eg: \u003cmount_point_base\u003e/nfs, \u003cmount_point_base\u003e/xyzfs etc."},{"line_number":14,"context_line":"The default mount point for *fs volumes is /var/lib/glance/*fs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1866966"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_63d66852","line":14,"range":{"start_line":14,"start_character":43,"end_line":14,"end_character":59},"in_reply_to":"df33271e_436364dd","updated":"2020-03-23 09:15:18.000000000","message":"The usage only applies to nfs in this patch but the config option is defined for all *fs drivers.\nThis was all discussed and agreed upon in the glance meeting.","commit_id":"db29724156b8d55957b5412a1fe13c96dfb3a099"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"15910a21211fbcb454ec63ec9ef445439a811dbb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":12,"context_line":"mounting their volumes,"},{"line_number":13,"context_line":"Eg: \u003cmount_point_base\u003e/nfs, \u003cmount_point_base\u003e/xyzfs etc."},{"line_number":14,"context_line":"The default mount point for *fs volumes is /var/lib/glance/*fs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1866966"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_436364dd","line":14,"range":{"start_line":14,"start_character":43,"end_line":14,"end_character":59},"in_reply_to":"df33271e_6351480f","updated":"2020-03-23 09:06:22.000000000","message":"And while we are getting more picky... this change applies only to nfs, no other *fs stuff is happening in here.","commit_id":"db29724156b8d55957b5412a1fe13c96dfb3a099"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3103c33d3ae19a1fe11f5210f9f44ffa567efa2f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":12,"context_line":"mounting their volumes,"},{"line_number":13,"context_line":"Eg: \u003cmount_point_base\u003e/nfs, \u003cmount_point_base\u003e/xyzfs etc."},{"line_number":14,"context_line":"The default mount point for *fs volumes is /var/lib/glance/*fs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1866966"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_236aa07f","line":14,"range":{"start_line":14,"start_character":43,"end_line":14,"end_character":59},"in_reply_to":"df33271e_6351480f","updated":"2020-03-23 09:21:21.000000000","message":"Done","commit_id":"db29724156b8d55957b5412a1fe13c96dfb3a099"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7e30e1efa0428fc17a8f437000f8573618befafd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":12,"context_line":"mounting their volumes,"},{"line_number":13,"context_line":"Eg: \u003cmount_point_base\u003e/nfs, \u003cmount_point_base\u003e/xyzfs etc."},{"line_number":14,"context_line":"The default mount point for *fs volumes is /var/lib/glance/*fs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1866966"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_435404cb","line":14,"range":{"start_line":14,"start_character":43,"end_line":14,"end_character":59},"in_reply_to":"df33271e_63d66852","updated":"2020-03-23 09:17:13.000000000","message":"That makes sense, thanks. Only Abhishek\u0027s comment remains and we are good to go (I believe).","commit_id":"db29724156b8d55957b5412a1fe13c96dfb3a099"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b1c055355fe23c052bb3b8ccade4f78caf9cec54","unresolved":false,"context_lines":[{"line_number":10,"context_line":"provide the mount point for *fs volumes."},{"line_number":11,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":12,"context_line":"mounting their volumes,"},{"line_number":13,"context_line":"Eg: \u003cmount_point_base\u003e/mnt/nfs, \u003cmount_point_base\u003e/mnt/xyzfs etc."},{"line_number":14,"context_line":"The default mount point for *fs volumes is /var/lib/glance/mnt/*fs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1866966"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"df33271e_23ed80ef","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":55},"updated":"2020-03-23 09:27:58.000000000","message":"Since \u0027mnt\u0027 is in \u0027mount_point_base\u0027, this is now incorrect. PS9 was fine.","commit_id":"fe2e6da7c682a7992102ac4b467fa8d11cc6a29a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"675f6c6e5fd3278f46ee336c22d629e165abcb94","unresolved":false,"context_lines":[{"line_number":10,"context_line":"provide the mount point for *fs volumes."},{"line_number":11,"context_line":"The different types of FS drivers will have separate directory for"},{"line_number":12,"context_line":"mounting their volumes,"},{"line_number":13,"context_line":"Eg: \u003cmount_point_base\u003e/mnt/nfs, \u003cmount_point_base\u003e/mnt/xyzfs etc."},{"line_number":14,"context_line":"The default mount point for *fs volumes is /var/lib/glance/mnt/*fs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1866966"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"df33271e_c3aad483","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":55},"in_reply_to":"df33271e_23ed80ef","updated":"2020-03-23 09:32:15.000000000","message":"Don\u0027t know why i\u0027m doing these silly commit message mistakes but then again i was never good with commit messages.\nThanks!","commit_id":"fe2e6da7c682a7992102ac4b467fa8d11cc6a29a"}],"glance_store/_drivers/cinder.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7b827c3cf5e91389b043745037b21f580284bf39","unresolved":false,"context_lines":[{"line_number":50,"context_line":"CONF \u003d cfg.CONF"},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"CORE_OPTS \u003d ["},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":55,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":56,"context_line":"               help\u003d\"Top-level directory for maintaining glance\u0027s state\"), ]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"_CINDER_OPTS \u003d ["},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027cinder_catalog_info\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_fdaa67d0","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":76},"updated":"2020-02-24 05:30:08.000000000","message":"Where is this option getting registered??\nglance-store library has different mechanism of registering the options [1] than other libraries. They are initialized when glance service starts by reading the options list from the setup.cfg [2][3]. This option will never be registered unless you make changes there. Also after making change, install glance_store library in your local environment and then generate the sample config file using \u0027tox -e genconfig\u0027 and make sure whether this options make it in sample config or not.\n\n\n\n[1] https://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L402\n[2] https://github.com/openstack/glance_store/blob/master/glance_store/backend.py#L115\n[3] https://github.com/openstack/glance_store/blob/master/glance_store/multi_backend.py#L99","commit_id":"e81d372b14257754a0bc00c07d47e0d52145854f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"73cdb3233d2271c206071961cc3ae5f73db663fe","unresolved":false,"context_lines":[{"line_number":50,"context_line":"CONF \u003d cfg.CONF"},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"CORE_OPTS \u003d ["},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":55,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":56,"context_line":"               help\u003d\"Top-level directory for maintaining glance\u0027s state\"), ]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"_CINDER_OPTS \u003d ["},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027cinder_catalog_info\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_bd738f4d","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":76},"in_reply_to":"1fa4df85_7d32f7a9","updated":"2020-02-24 06:26:29.000000000","message":"1. Install glance_store with your patch in local environment\n2. Run glance\u0027s tox -e genconfig tool","commit_id":"e81d372b14257754a0bc00c07d47e0d52145854f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ad2140710cc37b215803eea994abda71b8d051b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"CONF \u003d cfg.CONF"},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"CORE_OPTS \u003d ["},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":55,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":56,"context_line":"               help\u003d\"Top-level directory for maintaining glance\u0027s state\"), ]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"_CINDER_OPTS \u003d ["},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027cinder_catalog_info\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_7d32f7a9","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":76},"in_reply_to":"1fa4df85_fdaa67d0","updated":"2020-02-24 06:20:41.000000000","message":"Done\nI couldn\u0027t find the genconfig option in glance_store\u0027s tox.ini\nalso IIUC it gets generated in glance-api.conf right? but I\u0027m not sure how","commit_id":"e81d372b14257754a0bc00c07d47e0d52145854f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc50af73dee67ff522cf6652bd3ff56e050677ba","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    * cinder_enforce_multipath"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"\"\"\"),"},{"line_number":341,"context_line":"    cfg.StrOpt(\u0027nfs_mount_base\u0027,"},{"line_number":342,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":343,"context_line":"               help\u003d\"\"\""},{"line_number":344,"context_line":"Directory where the NFS volume is mounted on the glance node."}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_1dcbc3a5","line":341,"updated":"2020-02-24 05:44:19.000000000","message":"also to make it similar like other config options please prefix it with cinder_,\n\ncinder_nfs_mount_base","commit_id":"e81d372b14257754a0bc00c07d47e0d52145854f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ad2140710cc37b215803eea994abda71b8d051b","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    * cinder_enforce_multipath"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"\"\"\"),"},{"line_number":341,"context_line":"    cfg.StrOpt(\u0027nfs_mount_base\u0027,"},{"line_number":342,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":343,"context_line":"               help\u003d\"\"\""},{"line_number":344,"context_line":"Directory where the NFS volume is mounted on the glance node."}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_9d9d7368","line":341,"in_reply_to":"1fa4df85_1dcbc3a5","updated":"2020-02-24 06:20:41.000000000","message":"Done","commit_id":"e81d372b14257754a0bc00c07d47e0d52145854f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"22c7b6eba5e9e8964e42b54f03fb473ca104a8b2","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Possible values:"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"* A string representing absolute path of mount point."},{"line_number":346,"context_line":"\"\"\"),"},{"line_number":347,"context_line":"]"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_dda1ab97","line":345,"range":{"start_line":345,"start_character":0,"end_line":345,"end_character":52},"updated":"2020-02-24 06:30:06.000000000","message":"nit: you can add here state_path as related option\n\nDo this change if another ps is required","commit_id":"1d87b021fd2d81926162489849110113fa7134e7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0631536459d61b9c2145a89dae68c9787a22be52","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Possible values:"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"* A string representing absolute path of mount point."},{"line_number":346,"context_line":"\"\"\"),"},{"line_number":347,"context_line":"]"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_48a3769f","line":345,"range":{"start_line":345,"start_character":0,"end_line":345,"end_character":52},"in_reply_to":"1fa4df85_dda1ab97","updated":"2020-02-27 16:47:42.000000000","message":"Done","commit_id":"1d87b021fd2d81926162489849110113fa7134e7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e0d2dc340e8c487833e9991b6d8c4919cc0dc8d","unresolved":false,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        try:"},{"line_number":568,"context_line":"            connection_info \u003d volume.initialize_connection(volume, properties)"},{"line_number":569,"context_line":"            if connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027nfs\u0027:"},{"line_number":570,"context_line":"                connection_info[\u0027mount_point_base\u0027] \u003d os.path.join("},{"line_number":571,"context_line":"                    mount_point_base, \u0027nfs\u0027)"},{"line_number":572,"context_line":"            conn \u003d connector.InitiatorConnector.factory("},{"line_number":573,"context_line":"                connection_info[\u0027driver_volume_type\u0027], root_helper,"},{"line_number":574,"context_line":"                conn\u003dconnection_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_e9be83b2","line":571,"range":{"start_line":569,"start_character":12,"end_line":571,"end_character":44},"updated":"2020-03-05 10:57:58.000000000","message":"Can we just get rid of the if statement and add it every time?","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3810d0dc7df33918e91087f976e86056899ec117","unresolved":false,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        try:"},{"line_number":568,"context_line":"            connection_info \u003d volume.initialize_connection(volume, properties)"},{"line_number":569,"context_line":"            if connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027nfs\u0027:"},{"line_number":570,"context_line":"                connection_info[\u0027mount_point_base\u0027] \u003d os.path.join("},{"line_number":571,"context_line":"                    mount_point_base, \u0027nfs\u0027)"},{"line_number":572,"context_line":"            conn \u003d connector.InitiatorConnector.factory("},{"line_number":573,"context_line":"                connection_info[\u0027driver_volume_type\u0027], root_helper,"},{"line_number":574,"context_line":"                conn\u003dconnection_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_03a92e8f","line":571,"range":{"start_line":569,"start_character":12,"end_line":571,"end_character":44},"in_reply_to":"1fa4df85_e9be83b2","updated":"2020-03-11 09:03:32.000000000","message":"the mounting is only required for cases of *fs drivers","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"be2f595000a7e45f2b105f1c52cc5055b5f60346","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"\"\"\"),"},{"line_number":336,"context_line":"    cfg.StrOpt(\u0027cinder_mount_point_base\u0027,"},{"line_number":337,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":338,"context_line":"               help\u003d\"\"\""},{"line_number":339,"context_line":"Directory where the NFS volume is mounted on the glance node."},{"line_number":340,"context_line":"The default is \u0027mnt\u0027 directory of the location where glance\u0027s Python module"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_58e4f3ac","line":337,"range":{"start_line":337,"start_character":24,"end_line":337,"end_character":39},"updated":"2020-03-23 08:39:25.000000000","message":"no \u0027mnt\u0027","commit_id":"533841ed1806c86b5dbacd4c441b2d9c00cdc931"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cdb5e537d01b2e575aec8fe59822b722d7d5d2a6","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"\"\"\"),"},{"line_number":336,"context_line":"    cfg.StrOpt(\u0027cinder_mount_point_base\u0027,"},{"line_number":337,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":338,"context_line":"               help\u003d\"\"\""},{"line_number":339,"context_line":"Directory where the NFS volume is mounted on the glance node."},{"line_number":340,"context_line":"The default is \u0027mnt\u0027 directory of the location where glance\u0027s Python module"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_632ca899","line":337,"range":{"start_line":337,"start_character":24,"end_line":337,"end_character":39},"in_reply_to":"df33271e_58e4f3ac","updated":"2020-03-23 09:01:27.000000000","message":"Seems logical. Done","commit_id":"533841ed1806c86b5dbacd4c441b2d9c00cdc931"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"be2f595000a7e45f2b105f1c52cc5055b5f60346","unresolved":false,"context_lines":[{"line_number":337,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":338,"context_line":"               help\u003d\"\"\""},{"line_number":339,"context_line":"Directory where the NFS volume is mounted on the glance node."},{"line_number":340,"context_line":"The default is \u0027mnt\u0027 directory of the location where glance\u0027s Python module"},{"line_number":341,"context_line":"is installed."},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Possible values:"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_18da6be8","line":341,"range":{"start_line":340,"start_character":0,"end_line":341,"end_character":13},"updated":"2020-03-23 08:39:25.000000000","message":"it doesn\u0027t sound right, right?","commit_id":"533841ed1806c86b5dbacd4c441b2d9c00cdc931"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cdb5e537d01b2e575aec8fe59822b722d7d5d2a6","unresolved":false,"context_lines":[{"line_number":337,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":338,"context_line":"               help\u003d\"\"\""},{"line_number":339,"context_line":"Directory where the NFS volume is mounted on the glance node."},{"line_number":340,"context_line":"The default is \u0027mnt\u0027 directory of the location where glance\u0027s Python module"},{"line_number":341,"context_line":"is installed."},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Possible values:"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_c32134a2","line":341,"range":{"start_line":340,"start_character":0,"end_line":341,"end_character":13},"in_reply_to":"df33271e_18da6be8","updated":"2020-03-23 09:01:27.000000000","message":"Done","commit_id":"533841ed1806c86b5dbacd4c441b2d9c00cdc931"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dbd6bbe5797cce01a499a0727b32992bdf207c52","unresolved":false,"context_lines":[{"line_number":337,"context_line":"               default\u003d\u0027/var/lib/glance/mnt\u0027,"},{"line_number":338,"context_line":"               help\u003d\"\"\""},{"line_number":339,"context_line":"Directory where the NFS volume is mounted on the glance node."},{"line_number":340,"context_line":"The default path is /var/lib/glance/mnt."},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"Possible values:"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_cd08e82d","line":340,"updated":"2020-03-27 13:46:47.000000000","message":"nit: you don\u0027t need to say what the default is, it will be indicated when the config file is generated.","commit_id":"0464e6f3e24060059476943e04f6f5379f1b66b0"}],"glance_store/backend.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"22c7b6eba5e9e8964e42b54f03fb473ca104a8b2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":111,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":112,"context_line":"               help\u003d\"Top-level directory for maintaining glance\u0027s state\"),"},{"line_number":113,"context_line":"]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"_STORE_CFG_GROUP \u003d \u0027glance_store\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_9dab3374","line":112,"updated":"2020-02-24 06:30:06.000000000","message":"ditto you can add here related option as cinder_nfs_mount_base","commit_id":"1d87b021fd2d81926162489849110113fa7134e7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0631536459d61b9c2145a89dae68c9787a22be52","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":111,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":112,"context_line":"               help\u003d\"Top-level directory for maintaining glance\u0027s state\"),"},{"line_number":113,"context_line":"]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"_STORE_CFG_GROUP \u003d \u0027glance_store\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_c88f6621","line":112,"in_reply_to":"1fa4df85_9dab3374","updated":"2020-02-27 16:47:42.000000000","message":"Done","commit_id":"1d87b021fd2d81926162489849110113fa7134e7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e0d2dc340e8c487833e9991b6d8c4919cc0dc8d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    * stores"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":111,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":112,"context_line":"               help\u003d\"\"\""},{"line_number":113,"context_line":"Top-level directory for maintaining glance\u0027s state"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Related Options:"},{"line_number":116,"context_line":"    * cinder_mount_point_base"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"\"\"\"),"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"_STORE_CFG_GROUP \u003d \u0027glance_store\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_897b4f79","line":118,"range":{"start_line":110,"start_character":0,"end_line":118,"end_character":5},"updated":"2020-03-05 10:57:58.000000000","message":"Why are we adding this in the first place as only thing it\u0027s used for is as default for cinder drivers mount base config option?","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3810d0dc7df33918e91087f976e86056899ec117","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    * stores"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":111,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":112,"context_line":"               help\u003d\"\"\""},{"line_number":113,"context_line":"Top-level directory for maintaining glance\u0027s state"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Related Options:"},{"line_number":116,"context_line":"    * cinder_mount_point_base"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"\"\"\"),"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"_STORE_CFG_GROUP \u003d \u0027glance_store\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_6317c2a5","line":118,"range":{"start_line":110,"start_character":0,"end_line":118,"end_character":5},"in_reply_to":"1fa4df85_897b4f79","updated":"2020-03-11 09:03:32.000000000","message":"I added it with reference to future work on the glance_store side, my approach was to use it for other fs driver config options at that time.\nthat\u0027s out of the picture for now but it can be useful for other purposes (as seen in other projects), do you still want me to remove this config option?","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"}],"glance_store/multi_backend.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"22c7b6eba5e9e8964e42b54f03fb473ca104a8b2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\"\"\")),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":57,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":58,"context_line":"               help\u003d\"Top-level directory for maintaining glance\u0027s state\"),"},{"line_number":59,"context_line":"]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"FS_CONF_DATADIR_HELP \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_fd9ee752","line":58,"updated":"2020-02-24 06:30:06.000000000","message":"ditto you can add here related option as cinder_nfs_mount_base","commit_id":"1d87b021fd2d81926162489849110113fa7134e7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0631536459d61b9c2145a89dae68c9787a22be52","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\"\"\")),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":57,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":58,"context_line":"               help\u003d\"Top-level directory for maintaining glance\u0027s state\"),"},{"line_number":59,"context_line":"]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"FS_CONF_DATADIR_HELP \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_88996e6f","line":58,"in_reply_to":"1fa4df85_fd9ee752","updated":"2020-02-27 16:47:42.000000000","message":"Done","commit_id":"1d87b021fd2d81926162489849110113fa7134e7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e0d2dc340e8c487833e9991b6d8c4919cc0dc8d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    * enabled_backends"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"\"\"\")),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":57,"context_line":"               default\u003d\u0027/var/lib/glance\u0027,"},{"line_number":58,"context_line":"               help\u003d\"\"\""},{"line_number":59,"context_line":"Top-level directory for maintaining glance\u0027s state"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Related Options:"},{"line_number":62,"context_line":"    * cinder_mount_point_base"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"FS_CONF_DATADIR_HELP \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_098f5f75","line":64,"range":{"start_line":56,"start_character":0,"end_line":64,"end_character":5},"updated":"2020-03-05 10:57:58.000000000","message":"ditto","commit_id":"c3604acb29f6d690fc45a5f97eb2647bf1cd3fcf"}]}