)]}'
{"glance_store/_drivers/cinder.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9b0e2263a1e59fc45b1f751a1db2bfaf12d7c942","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    from cinderclient import exceptions as cinder_exception"},{"line_number":40,"context_line":"    from cinderclient.v3 import client as cinderclient"},{"line_number":41,"context_line":"    from os_brick.initiator import connector"},{"line_number":42,"context_line":"    from oslo_privsep import priv_context"},{"line_number":43,"context_line":"except ImportError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5cd7b0ee","line":40,"range":{"start_line":40,"start_character":23,"end_line":40,"end_character":24},"updated":"2020-03-24 12:15:00.000000000","message":"Big +1!","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f2345e73e96e8b39f95f0eb9d8f7506786357fac","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        if self.backend_group:"},{"line_number":375,"context_line":"            self._set_url_prefix()"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_root_helper(self, backend\u003dNone):"},{"line_number":378,"context_line":"        if backend:"},{"line_number":379,"context_line":"            rootwrap \u003d getattr(CONF, backend).rootwrap_config"},{"line_number":380,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_2a9eb5b7","line":377,"range":{"start_line":377,"start_character":24,"end_line":377,"end_character":42},"updated":"2020-03-26 03:45:37.000000000","message":"As you are moving this under driver class,\neither make this method static or else remove this keyword argument and use self.backend_group instead.","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"caf3f1f2091294d63159e4a7e77f1d9b5adb2a3f","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        if self.backend_group:"},{"line_number":375,"context_line":"            self._set_url_prefix()"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_root_helper(self, backend\u003dNone):"},{"line_number":378,"context_line":"        if backend:"},{"line_number":379,"context_line":"            rootwrap \u003d getattr(CONF, backend).rootwrap_config"},{"line_number":380,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5b702ddd","line":377,"range":{"start_line":377,"start_character":24,"end_line":377,"end_character":42},"in_reply_to":"df33271e_2a9eb5b7","updated":"2020-03-26 10:28:41.000000000","message":"Done","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f2345e73e96e8b39f95f0eb9d8f7506786357fac","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        return \u0027sudo glance-rootwrap %s\u0027 % rootwrap"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def is_user_overriden(self, conf, backend\u003dNone):"},{"line_number":386,"context_line":"        if backend:"},{"line_number":387,"context_line":"            store_conf \u003d getattr(conf, backend)"},{"line_number":388,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_8aa54107","line":385,"range":{"start_line":385,"start_character":7,"end_line":385,"end_character":50},"updated":"2020-03-26 03:45:37.000000000","message":"ditto\nyou can remove conf argument and use self.conf as well","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"caf3f1f2091294d63159e4a7e77f1d9b5adb2a3f","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        return \u0027sudo glance-rootwrap %s\u0027 % rootwrap"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def is_user_overriden(self, conf, backend\u003dNone):"},{"line_number":386,"context_line":"        if backend:"},{"line_number":387,"context_line":"            store_conf \u003d getattr(conf, backend)"},{"line_number":388,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_7b6d3103","line":385,"range":{"start_line":385,"start_character":7,"end_line":385,"end_character":50},"in_reply_to":"df33271e_8aa54107","updated":"2020-03-26 10:28:41.000000000","message":"Done","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f2345e73e96e8b39f95f0eb9d8f7506786357fac","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                    for key in [\u0027user_name\u0027, \u0027password\u0027,"},{"line_number":393,"context_line":"                                \u0027project_name\u0027, \u0027auth_address\u0027]])"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def get_cinderclient(self, conf, context\u003dNone, backend\u003dNone):"},{"line_number":396,"context_line":"        if backend:"},{"line_number":397,"context_line":"            glance_store \u003d getattr(conf, backend)"},{"line_number":398,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_caae29e6","line":395,"range":{"start_line":395,"start_character":8,"end_line":395,"end_character":65},"updated":"2020-03-26 03:45:37.000000000","message":"ditto","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"caf3f1f2091294d63159e4a7e77f1d9b5adb2a3f","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                    for key in [\u0027user_name\u0027, \u0027password\u0027,"},{"line_number":393,"context_line":"                                \u0027project_name\u0027, \u0027auth_address\u0027]])"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def get_cinderclient(self, conf, context\u003dNone, backend\u003dNone):"},{"line_number":396,"context_line":"        if backend:"},{"line_number":397,"context_line":"            glance_store \u003d getattr(conf, backend)"},{"line_number":398,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_1b66a52a","line":395,"range":{"start_line":395,"start_character":8,"end_line":395,"end_character":65},"in_reply_to":"df33271e_caae29e6","updated":"2020-03-26 10:28:41.000000000","message":"Done","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f2345e73e96e8b39f95f0eb9d8f7506786357fac","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        return c"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @contextlib.contextmanager"},{"line_number":449,"context_line":"    def temporary_chown(self, path, backend\u003dNone):"},{"line_number":450,"context_line":"        owner_uid \u003d os.getuid()"},{"line_number":451,"context_line":"        orig_uid \u003d os.stat(path).st_uid"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_aaa925de","line":449,"range":{"start_line":449,"start_character":36,"end_line":449,"end_character":48},"updated":"2020-03-26 03:45:37.000000000","message":"ditto","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"caf3f1f2091294d63159e4a7e77f1d9b5adb2a3f","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        return c"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @contextlib.contextmanager"},{"line_number":449,"context_line":"    def temporary_chown(self, path, backend\u003dNone):"},{"line_number":450,"context_line":"        owner_uid \u003d os.getuid()"},{"line_number":451,"context_line":"        orig_uid \u003d os.stat(path).st_uid"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_3b63a91c","line":449,"range":{"start_line":449,"start_character":36,"end_line":449,"end_character":48},"in_reply_to":"df33271e_aaa925de","updated":"2020-03-26 10:28:41.000000000","message":"Done","commit_id":"db6cc5dee729333bb2d3647031552b15175a20ac"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"31c697b18274af09b820c8eecdb87f424c10cc9e","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_root_helper(self):"},{"line_number":378,"context_line":"        if self.backend_group:"},{"line_number":379,"context_line":"            rootwrap \u003d getattr(CONF, self.backend_group).rootwrap_config"},{"line_number":380,"context_line":"        else:"},{"line_number":381,"context_line":"            rootwrap \u003d CONF.glance_store.rootwrap_config"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_0f180dd1","line":379,"range":{"start_line":379,"start_character":31,"end_line":379,"end_character":35},"updated":"2020-03-27 04:15:22.000000000","message":"nit: if new PS needs then please change this to self.conf to be identical with following methods.","commit_id":"4da861ae07106504f89a084ad190e8276847eb3a"}]}