)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"74ca1f13acd2b288a96ea045c5ce414326a6cdae","unresolved":false,"context_lines":[{"line_number":17,"context_line":"that store is configured. If the dependencies (cinderclient for example)"},{"line_number":18,"context_line":"fails to install, the import will be None and needs to be handled."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"3) Change default volume type to be consistent with cinder :"},{"line_number":21,"context_line":"This change doesn\u0027t do much functionally as the None volume type is"},{"line_number":22,"context_line":"already handled in c-api layer but to be consistent with cinder,"},{"line_number":23,"context_line":"using __DEFAULT__ type is preferred."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Partially Implements: blueprint improve+cinder+store"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_067511fa","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":36},"updated":"2020-08-10 17:38:46.000000000","message":"Where exactly does this happen?  I only saw __DEFAULT__ in a log message; as far as I can tell by the code, the cinder_volume_type config option can still be None.","commit_id":"cbdf7a21cab6ac6327eb20c51b94677c1331b4c0"}],"glance_store/_drivers/cinder.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f247eed1a0f48c92da1618fb46c954ade1266d8b","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        if self.backend_group:"},{"line_number":392,"context_line":"            self.rootwrap \u003d getattr("},{"line_number":393,"context_line":"                self.conf, self.backend_group).rootwrap_config"},{"line_number":394,"context_line":"            self.store_conf \u003d getattr(self.conf, self.backend_group)"},{"line_number":395,"context_line":"            self.glance_store \u003d getattr(self.conf, self.backend_group)"},{"line_number":396,"context_line":"            self.timeout \u003d getattr("},{"line_number":397,"context_line":"                self.conf, self.backend_group).cinder_state_transition_timeout"},{"line_number":398,"context_line":"            self.use_multipath \u003d getattr("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_17e7ae14","line":395,"range":{"start_line":394,"start_character":12,"end_line":395,"end_character":70},"updated":"2020-05-13 06:19:49.000000000","message":"can we get rid of either one of this?\nsame comment for line #408","commit_id":"fb11d3def6a5acaa6b7f5f7826d5dfdad00c8d16"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f86c9ea4c8b99704667b67f2d8eeff0e209756f","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        if self.backend_group:"},{"line_number":392,"context_line":"            self.rootwrap \u003d getattr("},{"line_number":393,"context_line":"                self.conf, self.backend_group).rootwrap_config"},{"line_number":394,"context_line":"            self.store_conf \u003d getattr(self.conf, self.backend_group)"},{"line_number":395,"context_line":"            self.glance_store \u003d getattr(self.conf, self.backend_group)"},{"line_number":396,"context_line":"            self.timeout \u003d getattr("},{"line_number":397,"context_line":"                self.conf, self.backend_group).cinder_state_transition_timeout"},{"line_number":398,"context_line":"            self.use_multipath \u003d getattr("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_ecb6acfa","line":395,"range":{"start_line":394,"start_character":12,"end_line":395,"end_character":70},"in_reply_to":"ff570b3c_17e7ae14","updated":"2020-05-13 07:44:34.000000000","message":"Done","commit_id":"fb11d3def6a5acaa6b7f5f7826d5dfdad00c8d16"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f247eed1a0f48c92da1618fb46c954ade1266d8b","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.mount \u003d importlib.import_module(\u0027glance_store.common.fs_mount\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def configure(self, re_raise_bsc\u003dFalse):"},{"line_number":391,"context_line":"        if self.backend_group:"},{"line_number":392,"context_line":"            self.rootwrap \u003d getattr("},{"line_number":393,"context_line":"                self.conf, self.backend_group).rootwrap_config"},{"line_number":394,"context_line":"            self.store_conf \u003d getattr(self.conf, self.backend_group)"},{"line_number":395,"context_line":"            self.glance_store \u003d getattr(self.conf, self.backend_group)"},{"line_number":396,"context_line":"            self.timeout \u003d getattr("},{"line_number":397,"context_line":"                self.conf, self.backend_group).cinder_state_transition_timeout"},{"line_number":398,"context_line":"            self.use_multipath \u003d getattr("},{"line_number":399,"context_line":"                self.conf, self.backend_group).cinder_use_multipath"},{"line_number":400,"context_line":"            self.enforce_multipath \u003d getattr("},{"line_number":401,"context_line":"                self.conf, self.backend_group).cinder_enforce_multipath"},{"line_number":402,"context_line":"            self.mount_point_base \u003d getattr("},{"line_number":403,"context_line":"                self.conf, self.backend_group).cinder_mount_point_base"},{"line_number":404,"context_line":"            self.volume_type \u003d getattr("},{"line_number":405,"context_line":"                self.conf, self.backend_group).cinder_volume_type"},{"line_number":406,"context_line":"        else:"},{"line_number":407,"context_line":"            self.rootwrap \u003d self.conf.glance_store.rootwrap_config"},{"line_number":408,"context_line":"            self.store_conf \u003d self.conf.glance_store"},{"line_number":409,"context_line":"            self.glance_store \u003d self.conf.glance_store"},{"line_number":410,"context_line":"            self.timeout \u003d ("},{"line_number":411,"context_line":"                self.conf.glance_store.cinder_state_transition_timeout)"},{"line_number":412,"context_line":"            self.use_multipath \u003d self.conf.glance_store.cinder_use_multipath"},{"line_number":413,"context_line":"            self.enforce_multipath \u003d ("},{"line_number":414,"context_line":"                self.conf.glance_store.cinder_enforce_multipath)"},{"line_number":415,"context_line":"            self.mount_point_base \u003d ("},{"line_number":416,"context_line":"                self.conf.glance_store.cinder_mount_point_base)"},{"line_number":417,"context_line":"            self.volume_type \u003d self.conf.glance_store.cinder_volume_type"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        self.username \u003d self.glance_store.cinder_store_user_name"},{"line_number":420,"context_line":"        self.password \u003d self.glance_store.cinder_store_password"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_1795ee40","line":417,"range":{"start_line":391,"start_character":8,"end_line":417,"end_character":72},"updated":"2020-05-13 06:19:49.000000000","message":"Also can we do this similar what you have done at line #419\n\nif self.backend_group:\n    self.store_conf \u003d getattr(self.conf, self.backend_group)\n    self.glance_store \u003d getattr(self.conf, self.backend_group)\nelse:\n    self.store_conf \u003d self.conf.glance_store\n    self.glance_store \u003d self.conf.glance_store\n\nself.rootwrap \u003dself.glance_store.rootwrap_config\nself.timeout \u003d self.glance_store.cinder_state_transition_timeout\nself.use_multipath \u003d self.glance_store.cinder_use_multipath\nself.enforce_multipath \u003d self.glance_store.cinder_enforce_multipath\nself.mount_point_base \u003d self.glance_store.cinder_mount_point_base\nself.volume_type \u003d self.glance_store.cinder_volume_type\n\nself.username \u003d self.glance_store.cinder_store_user_name\nself.password \u003d self.glance_store.cinder_store_password\nself.project \u003d self.glance_store.cinder_store_project_name\nself.url \u003d self.glance_store.cinder_store_auth_address","commit_id":"fb11d3def6a5acaa6b7f5f7826d5dfdad00c8d16"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f86c9ea4c8b99704667b67f2d8eeff0e209756f","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.mount \u003d importlib.import_module(\u0027glance_store.common.fs_mount\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def configure(self, re_raise_bsc\u003dFalse):"},{"line_number":391,"context_line":"        if self.backend_group:"},{"line_number":392,"context_line":"            self.rootwrap \u003d getattr("},{"line_number":393,"context_line":"                self.conf, self.backend_group).rootwrap_config"},{"line_number":394,"context_line":"            self.store_conf \u003d getattr(self.conf, self.backend_group)"},{"line_number":395,"context_line":"            self.glance_store \u003d getattr(self.conf, self.backend_group)"},{"line_number":396,"context_line":"            self.timeout \u003d getattr("},{"line_number":397,"context_line":"                self.conf, self.backend_group).cinder_state_transition_timeout"},{"line_number":398,"context_line":"            self.use_multipath \u003d getattr("},{"line_number":399,"context_line":"                self.conf, self.backend_group).cinder_use_multipath"},{"line_number":400,"context_line":"            self.enforce_multipath \u003d getattr("},{"line_number":401,"context_line":"                self.conf, self.backend_group).cinder_enforce_multipath"},{"line_number":402,"context_line":"            self.mount_point_base \u003d getattr("},{"line_number":403,"context_line":"                self.conf, self.backend_group).cinder_mount_point_base"},{"line_number":404,"context_line":"            self.volume_type \u003d getattr("},{"line_number":405,"context_line":"                self.conf, self.backend_group).cinder_volume_type"},{"line_number":406,"context_line":"        else:"},{"line_number":407,"context_line":"            self.rootwrap \u003d self.conf.glance_store.rootwrap_config"},{"line_number":408,"context_line":"            self.store_conf \u003d self.conf.glance_store"},{"line_number":409,"context_line":"            self.glance_store \u003d self.conf.glance_store"},{"line_number":410,"context_line":"            self.timeout \u003d ("},{"line_number":411,"context_line":"                self.conf.glance_store.cinder_state_transition_timeout)"},{"line_number":412,"context_line":"            self.use_multipath \u003d self.conf.glance_store.cinder_use_multipath"},{"line_number":413,"context_line":"            self.enforce_multipath \u003d ("},{"line_number":414,"context_line":"                self.conf.glance_store.cinder_enforce_multipath)"},{"line_number":415,"context_line":"            self.mount_point_base \u003d ("},{"line_number":416,"context_line":"                self.conf.glance_store.cinder_mount_point_base)"},{"line_number":417,"context_line":"            self.volume_type \u003d self.conf.glance_store.cinder_volume_type"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        self.username \u003d self.glance_store.cinder_store_user_name"},{"line_number":420,"context_line":"        self.password \u003d self.glance_store.cinder_store_password"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_2cd0a41f","line":417,"range":{"start_line":391,"start_character":8,"end_line":417,"end_character":72},"in_reply_to":"ff570b3c_1795ee40","updated":"2020-05-13 07:44:34.000000000","message":"Done","commit_id":"fb11d3def6a5acaa6b7f5f7826d5dfdad00c8d16"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a59e3d3dcaa56506c8e9faceec36de98eb7b5ad0","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        # before we use them in the fs_mount file"},{"line_number":388,"context_line":"        self.mount \u003d importlib.import_module(\u0027glance_store.common.fs_mount\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def configure(self, re_raise_bsc\u003dFalse):"},{"line_number":391,"context_line":"        if self.backend_group:"},{"line_number":392,"context_line":"            self.glance_store \u003d getattr(self.conf, self.backend_group)"},{"line_number":393,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_86a92191","line":390,"range":{"start_line":390,"start_character":22,"end_line":390,"end_character":42},"updated":"2020-08-10 17:32:42.000000000","message":"It looks to me from the driver definition that you should be overriding configure_add() not configure(), especially since you\u0027re not calling super() here, you\u0027re not honoring this re_raise_bsc protocol, and you\u0027re not calling self.update_capabilities(). Is there some reason not to?","commit_id":"cbdf7a21cab6ac6327eb20c51b94677c1331b4c0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5c912ab301196685763ee7a2e4620488663710ab","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        # before we use them in the fs_mount file"},{"line_number":388,"context_line":"        self.mount \u003d importlib.import_module(\u0027glance_store.common.fs_mount\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def configure(self, re_raise_bsc\u003dFalse):"},{"line_number":391,"context_line":"        if self.backend_group:"},{"line_number":392,"context_line":"            self.glance_store \u003d getattr(self.conf, self.backend_group)"},{"line_number":393,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a65c254b","line":390,"range":{"start_line":390,"start_character":22,"end_line":390,"end_character":42},"in_reply_to":"9f560f44_86a92191","updated":"2020-08-10 17:52:20.000000000","message":"you can either use configure or configure_add method depending on the need. confgiure_add is mostly used to disable add/delete methods on the store instance if store validation fails.\n\nNone of the driver has implemented update_capabilities method, we have one decorator op top of eah drivers add,delete,get method to check capabilities.","commit_id":"cbdf7a21cab6ac6327eb20c51b94677c1331b4c0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a59e3d3dcaa56506c8e9faceec36de98eb7b5ad0","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.mount \u003d importlib.import_module(\u0027glance_store.common.fs_mount\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def configure(self, re_raise_bsc\u003dFalse):"},{"line_number":391,"context_line":"        if self.backend_group:"},{"line_number":392,"context_line":"            self.glance_store \u003d getattr(self.conf, self.backend_group)"},{"line_number":393,"context_line":"        else:"},{"line_number":394,"context_line":"            self.glance_store \u003d self.conf.glance_store"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        self.rootwrap \u003d self.glance_store.rootwrap_config"},{"line_number":397,"context_line":"        self.timeout \u003d self.glance_store.cinder_state_transition_timeout"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_669a0d62","line":394,"range":{"start_line":391,"start_character":0,"end_line":394,"end_character":54},"updated":"2020-08-10 17:32:42.000000000","message":"Is this tested somewhere? I\u0027m sure it\u0027s hard to spot because it depends on the parent class\u0027s init...","commit_id":"cbdf7a21cab6ac6327eb20c51b94677c1331b4c0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"74ca1f13acd2b288a96ea045c5ce414326a6cdae","unresolved":false,"context_lines":[{"line_number":761,"context_line":"                    \u0027image_size\u0027: str(image_size),"},{"line_number":762,"context_line":"                    \u0027image_owner\u0027: owner}"},{"line_number":763,"context_line":"        LOG.debug(\u0027Creating a new volume: image_size\u003d%d size_gb\u003d%d type\u003d%s\u0027,"},{"line_number":764,"context_line":"                  image_size, size_gb, self.volume_type or \u0027__DEFAULT__\u0027)"},{"line_number":765,"context_line":"        if image_size \u003d\u003d 0:"},{"line_number":766,"context_line":"            LOG.info(_LI(\"Since image size is zero, we will be doing \""},{"line_number":767,"context_line":"                         \"resize-before-write for each GB which \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8633e161","line":764,"range":{"start_line":764,"start_character":39,"end_line":764,"end_character":72},"updated":"2020-08-10 17:38:46.000000000","message":"This isn\u0027t correct -- if self.volume_type is None, what you\u0027ll get is whatever default_volume_type is configured on the cinder side, which isn\u0027t necessarily __DEFAULT__.  I suggest replacing with \u0027\u003cthe default volume type configured in cinder\u003e\u0027","commit_id":"cbdf7a21cab6ac6327eb20c51b94677c1331b4c0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5c912ab301196685763ee7a2e4620488663710ab","unresolved":false,"context_lines":[{"line_number":761,"context_line":"                    \u0027image_size\u0027: str(image_size),"},{"line_number":762,"context_line":"                    \u0027image_owner\u0027: owner}"},{"line_number":763,"context_line":"        LOG.debug(\u0027Creating a new volume: image_size\u003d%d size_gb\u003d%d type\u003d%s\u0027,"},{"line_number":764,"context_line":"                  image_size, size_gb, self.volume_type or \u0027__DEFAULT__\u0027)"},{"line_number":765,"context_line":"        if image_size \u003d\u003d 0:"},{"line_number":766,"context_line":"            LOG.info(_LI(\"Since image size is zero, we will be doing \""},{"line_number":767,"context_line":"                         \"resize-before-write for each GB which \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_86e8017c","line":764,"range":{"start_line":764,"start_character":39,"end_line":764,"end_character":72},"in_reply_to":"9f560f44_8633e161","updated":"2020-08-10 17:52:20.000000000","message":"For that purpose, we need to query cinder and get it from there","commit_id":"cbdf7a21cab6ac6327eb20c51b94677c1331b4c0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c7939078d7efc39f1a35c827ce75d4ae06f58b8c","unresolved":false,"context_lines":[{"line_number":761,"context_line":"                    \u0027image_size\u0027: str(image_size),"},{"line_number":762,"context_line":"                    \u0027image_owner\u0027: owner}"},{"line_number":763,"context_line":"        LOG.debug(\u0027Creating a new volume: image_size\u003d%d size_gb\u003d%d type\u003d%s\u0027,"},{"line_number":764,"context_line":"                  image_size, size_gb, self.volume_type or \u0027__DEFAULT__\u0027)"},{"line_number":765,"context_line":"        if image_size \u003d\u003d 0:"},{"line_number":766,"context_line":"            LOG.info(_LI(\"Since image size is zero, we will be doing \""},{"line_number":767,"context_line":"                         \"resize-before-write for each GB which \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_89a3f2ff","line":764,"range":{"start_line":764,"start_character":39,"end_line":764,"end_character":72},"in_reply_to":"9f560f44_86e8017c","updated":"2020-08-10 18:01:07.000000000","message":"No need to query cinder ... I mean replace it with a literal string saying that type\u003dwhatever the default type in cinder is.","commit_id":"cbdf7a21cab6ac6327eb20c51b94677c1331b4c0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"068ae9f6401e3857286522f4289f7dede8d02517","unresolved":false,"context_lines":[{"line_number":761,"context_line":"                    \u0027image_size\u0027: str(image_size),"},{"line_number":762,"context_line":"                    \u0027image_owner\u0027: owner}"},{"line_number":763,"context_line":"        LOG.debug(\u0027Creating a new volume: image_size\u003d%d size_gb\u003d%d type\u003d%s\u0027,"},{"line_number":764,"context_line":"                  image_size, size_gb, self.volume_type or \u0027__DEFAULT__\u0027)"},{"line_number":765,"context_line":"        if image_size \u003d\u003d 0:"},{"line_number":766,"context_line":"            LOG.info(_LI(\"Since image size is zero, we will be doing \""},{"line_number":767,"context_line":"                         \"resize-before-write for each GB which \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c9996ac4","line":764,"range":{"start_line":764,"start_character":39,"end_line":764,"end_character":72},"in_reply_to":"9f560f44_89a3f2ff","updated":"2020-08-10 18:03:35.000000000","message":"oops, this is log message, I over looked it ::D\n\nMakes sense then.","commit_id":"cbdf7a21cab6ac6327eb20c51b94677c1331b4c0"}]}